GitLab

It is safer to use the C++11 foreach operator to iterate over this
vector. On Windows gfx::ScreenWin gets the the display count from a
different place from the display list.

BUG=427931

Review URL: https://codereview.chromium.org/689223002

Cr-Commit-Position: refs/heads/master@{#302416}

To make the dialog more accessible, auto-focus the first button in the
dialog when it opens so focus is already on an element inside the
dialog. This behaviour is more consistent with existing dialogs in
Chrome, and helps users using screen-readers and similar with navigating
the dialog after it opens.

BUG=425311

Review URL: https://codereview.chromium.org/689833004

Cr-Commit-Position: refs/heads/master@{#302415}

For example, after uploading this CL, I just ran:

./try.py mac.bisect.blink_perf.cfg linux.perf_test.tab_switching.cfg. I expect it should only start two try jobs.

If you run ./try.py (with no arguments), it prints usage help and a "too few arguments" message.

BUG=415890

Review URL: https://codereview.chromium.org/687733003

Cr-Commit-Position: refs/heads/master@{#302414}

Revert of Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions (patchset #2 id:20001 of https://codereview.chromium.org/688633004/)

Reason for revert:
caused crashers. see bug 429576

Original issue's description:
> Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions
>
> Currently, PasswordAutofillAgent (in renderer) prepares password autofill suggestions for PasswordAutofillManager (in browser) and sends them via IPC.
>
> But the manager has the data to generate the suggestions itself, so this CL makes it derive the suggestions from that data instead of hauling it through IPC.
>
> This CL also adds one more test case to the PasswordAutofillManager unittest, to compensate for the coverage lost in the PasswordAutofillAgent browsertest by moving some logic out of the agent to the manager.
>
> BUG=400186, 377422, 118601
>
> Committed: https://crrev.com/86cc798cc2947dd88aa73505d716f93538dffa5b
> Cr-Commit-Position: refs/heads/master@{#302245}

TBR=gcasto@chromium.org,tsepez@chromium.org,jww@chromium.org,vabr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400186, 377422, 118601

Review URL: https://codereview.chromium.org/695233002

Cr-Commit-Position: refs/heads/master@{#302413}

BUG=420746

Review URL: https://codereview.chromium.org/633233002

Cr-Commit-Position: refs/heads/master@{#302412}

The network cache is not safe for usage by multiple processes at the same
time like when sky tests are running many mojo_shell instances in parallel.
To work around this we store the cache in memory. In the future we should
consider file system partitioning for mojo services.

This CL originally reviewed and landed in the Mojo repo in
https://codereview.chromium.org/679403002/. Re-landing in the Chromium repo
because this code is canonically developed here.

TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/697883003

Cr-Commit-Position: refs/heads/master@{#302411}

Add sashab@ to the OWNERS file in the views/apps/app_info_dialog
directory.

Review URL: https://codereview.chromium.org/276293002

Cr-Commit-Position: refs/heads/master@{#302410}

BUG=397019, 390086

Review URL: https://codereview.chromium.org/686333002

Cr-Commit-Position: refs/heads/master@{#302409}

BUG=426679

Review URL: https://codereview.chromium.org/675133002

Cr-Commit-Position: refs/heads/master@{#302408}

Adds hi-res assets.
Adds new error asset.
Removes audio history step.
Updates audio history 'learn more' link.

BUG=390086

Review URL: https://codereview.chromium.org/695703002

Cr-Commit-Position: refs/heads/master@{#302407}

Based on formatting a few java files in base/ and comparing before/after.

BUG=429372
NOTRY=true

Review URL: https://codereview.chromium.org/697893002

Cr-Commit-Position: refs/heads/master@{#302406}

Added alt-text and focusability to the revoke buttons in the App Info
dialog so they can be navigated to with the keyboard. This allows
permissions to be revoked for apps for users who are navigating with a
screen reader or only using the keyboard.

BUG=425311

Review URL: https://codereview.chromium.org/689863002

Cr-Commit-Position: refs/heads/master@{#302405}

BUG=428557
TEST=None

Review URL: https://codereview.chromium.org/697863002

Cr-Commit-Position: refs/heads/master@{#302404}

Blink's actual implementation preserves keyIdentifier='Enter'
when Enter is pressed. To make sure that the test framework
behaves like the actual implementation, this CL makes sure that
keyIdentifier is set to 'Enter' when the Enter key is simulated.

BUG=423270

Review URL: https://codereview.chromium.org/649343002

Cr-Commit-Position: refs/heads/master@{#302403}

Revert of Clean up the page state saving mechanism. (patchset #2 id:20001 of https://codereview.chromium.org/689163002/)

Reason for revert:
This is a likely candidate for having broken lots of layout tests...

Original issue's description:
> Clean up the page state saving mechanism.
>
> BUG=416184
> TEST=as in bug
>
> Committed: https://crrev.com/133fac58dfe9ac1d2b0071ce107825adaad67cc7
> Cr-Commit-Position: refs/heads/master@{#302372}

TBR=creis@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=416184

Review URL: https://codereview.chromium.org/694963003

Cr-Commit-Position: refs/heads/master@{#302402}

BUG=423019

Review URL: https://codereview.chromium.org/691183002

Cr-Commit-Position: refs/heads/master@{#302401}

Blink roll 2842c5f8ea181eb3415ae3b124b873eb4355e6e2: c51b33ed3d9bc7d1ccc45231a5d48432a2be6740 (svn 184758:184775)

TBR=morrita

Review URL: https://codereview.chromium.org/699533002

Cr-Commit-Position: refs/heads/master@{#302400}

Cr-Commit-Position: refs/heads/master@{#302399}

These objects don't have the same lifetime and we were using raw pointers to them  in a few places, which could lead to use-after-free.

BUG=429477
TBR=perkj@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/698803002

Cr-Commit-Position: refs/heads/master@{#302398}

Disable WebViewInteractiveTest.NewWindow_OpenInNewTab on OS_MACOSX, until the problem to miss keyup event with command key is fixed

BUG=425859
R=avi@chromium.org
R=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/692113002

Cr-Commit-Position: refs/heads/master@{#302397}

Cr-Commit-Position: refs/heads/master@{#302396}

This addresses the issue of getStats blocking the UI thread for excessive amounts of time and also opens the door for us to do other heavy-lifters such as setRemoteDescription and setLocalDescription asynchronously.

This CL builds on several others that have landed this week (see bug for details), but here are the key changes:

- PeerConnectionDependencyFactory has a separate signaling thread instead of using the UI thread.
- Classes that join WebRTC and Blink objects need to be aware of the signaling thread being different.  This means that callbacks will come in on the signaling thread from webrtc and need to be sent to the UI thread for javascript callbacks.

BUG=369796

Review URL: https://codereview.chromium.org/675013005

Cr-Commit-Position: refs/heads/master@{#302395}

Currently our code assumes that high res tiling comes before the low
res tiling (for eviction iterators). However, that doesn't seem to be
the case in all situations. Rather that just fixing the problem (if
it is a problem), this patch makes the eviction code be able to proceed
without crashing. In these situations the eviction order of tilings
won't be ideal, but would still visit all tilings.

BUG=429397, 429201
R=danakj, reveman

Review URL: https://codereview.chromium.org/694143002

Cr-Commit-Position: refs/heads/master@{#302394}

This patch adds more eviction cache invalidations in order to avoid
use after free scenarios. This problem will be fixed by faster eviction
since we won't need the cache, but until that is in place, this is
a necessary fix.

BUG=429201
R=danakj, reveman

Review URL: https://codereview.chromium.org/687573003

Cr-Commit-Position: refs/heads/master@{#302393}

This patch removes the initial binding when the renderer commits a
navigation, rather than after a fixed delay from starting the renderer.

We have to wait until the first commit before relying on the  visibility
signal, because a renderer for the foreground tab is considered
background until it commits.

BUG=421041

Review URL: https://codereview.chromium.org/673573003

Cr-Commit-Position: refs/heads/master@{#302392}

Revert of Hold the Pepper proxy lock for all Pepper GL calls. (patchset #3 id:40001 of https://codereview.chromium.org/692683003/)

Reason for revert:
causing huge crashes in canary. bug=429446

Original issue's description:
> Hold the Pepper proxy lock for all Pepper GL calls.
>
> BUG=418651
>
> Committed: https://crrev.com/057f7a69dd40c93550b375b4287dba70d719316a
> Cr-Commit-Position: refs/heads/master@{#302303}

TBR=dmichael@chromium.org,dmichael@google.com,penghuang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418651

Review URL: https://codereview.chromium.org/698463006

Cr-Commit-Position: refs/heads/master@{#302391}

For example, vendor, renderer, driver version, etc.This
way a developer can gather data on what platforms the app
fails to run. This needs changes on both blink and chromium.

Below steps are followed to implement this

1. Add basic headers in blink.
2. Add the necessary apis in chromium.
3. Start using this in WebglRenderingContxt.cpp.

This patch represents step-2 in this process.

BUG=412440

Review URL: https://codereview.chromium.org/645613002

Cr-Commit-Position: refs/heads/master@{#302390}

BUG=429300

Review URL: https://codereview.chromium.org/695993003

Cr-Commit-Position: refs/heads/master@{#302389}

Revert of Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #1 id:1 of https://codereview.chromium.org/684253003/)

Reason for revert:
Ah, reverted the wrong CL.

Original issue's description:
> Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/)
>
> Reason for revert:
> Should turn on logging in telemetry_gpu_tests in general.
>
> Original issue's description:
> > Add logs to debug a flakiness on GPU Mac bots.
> >
> > This is temporary and will be removed after we pin down the issue.
> >
> > BUG=424024
> > TEST=
> > R=kbr@chromium.org
> > TBR=dgozman@chromium.org
> > NOTRY=true
> >
> > Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0
> > Cr-Commit-Position: refs/heads/master@{#302371}
>
> TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=424024
>
> Committed: https://crrev.com/ec506e7f57922e5a068d76128f020877bc7986cb
> Cr-Commit-Position: refs/heads/master@{#302387}

TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/698783002

Cr-Commit-Position: refs/heads/master@{#302388}

Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/)

Reason for revert:
Should turn on logging in telemetry_gpu_tests in general.

Original issue's description:
> Add logs to debug a flakiness on GPU Mac bots.
>
> This is temporary and will be removed after we pin down the issue.
>
> BUG=424024
> TEST=
> R=kbr@chromium.org
> TBR=dgozman@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0
> Cr-Commit-Position: refs/heads/master@{#302371}

TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/684253003

Cr-Commit-Position: refs/heads/master@{#302387}

NOTRY=true
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/695873003

Cr-Commit-Position: refs/heads/master@{#302386}

This is unnecessary as image ids are not reused. CreateImage will
fail if generation of image ids wraparound as negative ids are
considered an error.

R=piman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/689253002

Cr-Commit-Position: refs/heads/master@{#302385}

Cr-Commit-Position: refs/heads/master@{#302384}

BUG=

Review URL: https://codereview.chromium.org/694763003

Cr-Commit-Position: refs/heads/master@{#302383}

Only one should be set, so update functions to reflect this. In the rare
case both are set, always-on takes precedence.

BUG=397019

Review URL: https://codereview.chromium.org/685053002

Cr-Commit-Position: refs/heads/master@{#302382}

VC++ hits internal compiler errors on a source file in each of yasm and
libexif. This halts the build and prevents full analysis. Therefore this
change disables /analyze for those two projects, to increase total
coverage.

Also fix a typo in libexif's README.chromium

BUG=427616

Review URL: https://codereview.chromium.org/657883003

Cr-Commit-Position: refs/heads/master@{#302381}

Cr-Commit-Position: refs/heads/master@{#302380}

Chrome add "X-Chrome-UMA-Enabled" (and sometimes "X-Client-Data") headers while accessing Google servers if UMA is enabled.
This header is added before sending the request to the ServiceWorker.
So the request which is passed to the ServiceWorker contains this header.

If event.request.mode is 'cors' and event.request.headers has "x-chrome-uma-enabled", fetch(event.request) send a CORS preflight request.
This preflight request contains "Access-Control-Request-Headers: x-chrome-uma-enabled" header.
But the response from the Google server doesn't contain "Access-Control-Allow-Headers: x-chrome-uma-enabled" header.
So this fetch fails.

To avoid this problem this patch removes these headers before sending the request to the ServiceWorker.

This patch introduces ServiceWorkerContext::AddExcludedHeadersForFetchEvent() method and changes DevToolsNetworkTransactionFactory to call this method.

BUG=425649

Review URL: https://codereview.chromium.org/666973003

Cr-Commit-Position: refs/heads/master@{#302379}

This change renames MediaIndicatorView to MediaIndicatorButton, and then
merges-in the new functionality to support tab muting by clicking on the
indicator.  This is the "Cocoa port" of a previous change that added
this feature to the views UI: http://codereview.chromium.org/591963002

See change description in link above for details.

Also, this change resolves a long-standing bug where navigating back
into a NTP would leave the audio indicator turned on even though the NTP
does not emit sound.

BUG=360372, 344229
TEST=With --enable-tab-audio-muting, user can click audio indicator to toggle tab muting, or use the tab context menu to toggle muting of one or more selected tabs.

Review URL: https://codereview.chromium.org/688523002

Cr-Commit-Position: refs/heads/master@{#302378}

BUG=421291

Review URL: https://codereview.chromium.org/692523004

Cr-Commit-Position: refs/heads/master@{#302377}