- 09 Oct, 2020 40 commits
-
-
Yuwei Huang authored
This CL attempts to make the official build bot upload remoting debug symbols, so that we can use them to decipher stack traces coming from an official build remoting Linux host. Bug: 1136663 Change-Id: I5669140b3b63399d521644de3b8524def6092560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462547Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#815701}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8ce5f5261ab7..84bd221ed748 2020-10-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-09 morg@google.com Add grunt-arc-r board to PFQ (experimental) 2020-10-08 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ibc3f777315de0f38adab46737f90dee6eb12ebc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815700}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Ic61630a22fda8a25377fbe2c9dd9818c1c5ec72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458849Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815699}
-
Alison Maher authored
Currently, we wait to layout fragmented OOF elements until they've reached the fragmentation context root. In the case of nested fragmentation, we need to wait until that fragmentation context root has finished layout to ensure that the containing block has also finished layout. This change delays layout of fragmented OOF elements until we've reached a fragmentation context root that is not itself fragmented. This results in OOF elements being added as children to the outermost fragmentainer that it is found in rather than the innermost. We will need to bubble up some extra information about the innermost fragmentainer in order to properly position the OOF elements. This will be done in a follow-up CL. Bug: 1079031 Change-Id: Ia2d5ed3af2a99f5c091d1cd9c399cc34bc580038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462048 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815698}
-
Aaron Krajeski authored
Has become a straightforward revert of this commit. https://chromium-review.googlesource.com/c/chromium/src/+/2216591 For as yet unknown reasons, not using CopySubTexture can cause rapid flickering between pixellated and non-pixellated rendering. Considering this is negatively effecting many users right now, it may be worth pushing this change through as a quick fix. Bug: 1134799 Change-Id: Ia25b312f3755063b1fdeaa39be5057b7654b7548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450842Reviewed-by:
Jonah Chin <jochin@microsoft.com> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#815697}
-
Wez authored
Enable test packages to be made wholly or partially hermetic through use of "fuchsia.test" facets in their package manifests. - Remove the unused //build/fuchsia/exe_runner.py script. - Rename run_package.py to run_test_package.py, and similarly for the methods and types it publishes. - Update the RunTestPackage() API to support launching the component using the 'run_test_component' command, rather than 'run', if requested. Bug: 1038786, 1132032 Change-Id: I42aaf996324542a2d6c6d6d93ea8bd1d0a878730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997698 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#815696}
-
Scott Violet authored
BUG=none TEST=test only change Change-Id: I704dc578dabef22c991ffa1873f7951f3e7dd08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462389 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815695}
-
Yuki Shiino authored
Relaxes a restriction of use_allocator != "partition" a little so that we can specify use_allocator = "partition" for testing purposes. Note that use_allocator never be "partition" unless we explicitly specify it, so there is no change on all bots (until we will actually ship it). Bug: 1121427 Change-Id: Ib06997385f864f1ba097edb46eeed3a215105911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463088Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#815694}
-
Keren Zhu authored
Bug: 1130078 Change-Id: Ic5253a9024038fe204076c2c5ab744b1e5275f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462099 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#815693}
-
Becca Hughes authored
This flag is turned on because originally Kaleidoscope + NTP modules were launching at the same time. Now NTP modules is launching earlier which means we need to turn this flag off. BUG=1136904 Change-Id: Ie20a8650f9621dfa85803a397d55a0873f54496d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463330 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815692}
-
Alex Gough authored
Bug: 1130762 Change-Id: I0c003e2f5d17dbea3653f47508a4e47eff7cf61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458906Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#815691}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I808b5a1ee49e56e51e21961d3e7d1a4b937a1c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458867Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815690}
-
Yulun Wu authored
This addresses changes from: https://chromium-review.googlesource.com/c/chromium/src/+/2417653 Note that SearchIcon and Assistant buttons are different colors in classic UI. Bug: 1134800 Change-Id: I409bc4bde13331766dc8aa8c54dfeda082c653d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462044Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5291cbadc02e..b2ff69f856d9 2020-10-09 jmadill@chromium.org Suppress Mac/GL test failures with standalone runner. 2020-10-09 gbiv@chromium.org fix an instance of bugprone-unused-return-value If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1134714 Tbr: timvp@google.com Change-Id: I7cbefc64c5d6e377a6255df0a1a3a3177e93e5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815688}
-
Yulun Wu authored
This addresses a change in this CL https://chromium-review.googlesource.com/c/chromium/src/+/2382222 Bug: 1134854 Change-Id: I3970a260b534dabed6dd8bbba849812f5edfaddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462053Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815687}
-
Yulun Wu authored
This CL addresses changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2417241 Bug: 1134800 Change-Id: I9ce7301dcdfe9940a10f3920e2901a051ff0f0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462556Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815686}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I9802951e5f8d4d77d0c0ae2a3f69134f93b548df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459427Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815685}
-
Mohamed Adel authored
Moving it to where the bridges are stored as NotificationImageRetainer will be used in the NPB Mac UNNotification, making it not unique to windows builds only. Bug: 1136930 Change-Id: I496f9295d18665a27d39f8d0aced293a1f076a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460903 Auto-Submit: Mohamed Adel <adelm@google.com> Commit-Queue: Mohamed Adel <adelm@google.com> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#815684}
-
Roberto Moura authored
Bug: 1127604 Change-Id: I48460b30fc37119e31f595359e31803d13475f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461736Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#815683}
-
minch authored
Check the spec in the crbug. Bug: 1128755 Change-Id: I91cf16ee49317deea14556d04ff9c933f3a6556c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462354Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#815682}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. In this case, everything (including the definition for this function) spelled this `has_complete_suggestion`, so go with that. Bug: 1136209 Change-Id: I41b6f21a9b675e9e5817e2b563293c91c95a462a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459110 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815681}
-
Clark DuVall authored
This reverts commit 022292aa. Reason for revert: Breaking clank builds: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/230952 Original change's description: > Split out minimal target for PaymentDetailsUpdateService > > We are investigated using isolated splits for Chrome, and splitting > //chrome code into a DFM. Due to b/169196314, all service classes must > be present in the base module. See go/isolated-splits-clank for more > details. > > This change creates a new minimal target for PaymentDetailsUpdateService > which the base module will depend on. > > Bug: 1126301 > Change-Id: Ib4396073bbc4254c0400bccec1f4acac3ba88ad8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459508 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815649} TBR=agrieve@chromium.org,danyao@chromium.org,maxlg@chromium.org,cduvall@chromium.org Change-Id: I8eea37376fcbd13b78774cf4c4fb2480c309d150 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463803Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815680}
-
Ramin Halavati authored
Updates a few chrome/browser/ui/views/* classes for compatibility with ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ie4f8e4aaf1f981ba6575fe8cc38b62a009289626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461375 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#815679}
-
Henrique Ferreiro authored
Animated cursor assets were not being loaded because GetCursorDataFor was used for all cursors, instead of using GetAnimatedCursorDataFor when the cursor was animated. With this CL, both set of cursors are merged so they can be retrieved with a single call. To ease these changes, ImageCursor, which was a very thin layer over CursorLoader, was merged into the latter. This change has the benefit of unifying the cursor loading code path of Ash with the one of the other Aura platforms and changing Ash on Linux to use the Chromium assets instead of the platform cursors, as when running on Chrome OS devices. The only behavior change with respect to ImageCursors is that the cached cursors will be removed on display changes, instead of reloaded. Bug: 1135515 Change-Id: Iedf84290bf3792c3ce06cfad0be1b5c0e2d96946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440760 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815678}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I3af15a8ff257a242396a8cc58ba8c0b1df74c934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459387Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815677}
-
Alice Wang authored
This CL dismisses the account picker bottom sheet when the bottom sheet controller is null. Bug: 1136799 Change-Id: I9814c10f6becb07c3e95ab93f0d81b69af936853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463307 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#815676}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09f602317f2b..b3c2e9be46bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC flackr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1114729 Tbr: flackr@google.com Change-Id: Ic51bdf7fffe793afd40e6d26f30755c04c95dd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463258Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815675}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/58919b4db13b..723d5437e6a0 2020-10-09 bmeurer@chromium.org Improve scope information for language plugins. 2020-10-09 alexrudenko@chromium.org Enable TypeScript for LocationsSettingsTab.js 2020-10-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-09 aerotwist@chromium.org TypeScriptify RadioSetting.js 2020-10-09 sigurds@chromium.org Prepare console/ConsoleView.js for TypeScript.. 2020-10-09 sigurds@chromium.org [ts] Type-check console/ConsoleViewport.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143,chromium:1136484 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4781d7efd5f74fef565ef0b58508c2a0283fb5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463390Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815674}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I6c89922f34472a5e06fb88b68ecbf5996de37c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459051Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815673}
-
Regan Hsu authored
The NotoficationAccessSetupOperation::Status enums were out of sync by 1, because the multidevice_notification_access_setup_dialog.js enums include a NOT_STARTED state to accommodate the initial dialog state. This CL fixes that. Bug: 1106937 Change-Id: I3d27cac52adb20cd5775a238355f2aaa9aae722c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462608Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815672}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I63ccd3a15d31ab2633b874193fe26c24628bff81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460891Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815671}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602212356-910f3b9c14ad8fb9eb002bc49aff02d2bc68cf6f.profdata to chrome-win64-master-1602244639-9ed9777b412f549b6770ee430e4768c83e1e2c1e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icf450c9bdc47183118a87513368db4a54c93327e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462504Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815670}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I4f96c26c813abcb8e6825c0dfe2b1d4fa3f2653a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463227Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815669}
-
Ian Kilpatrick authored
This patch uses WritingModeDirection for: - NGBoxStrut::ConvertToPhysical - NGPhysicalBoxStrut::ConvertToLogical - NGFragment - NGBoxFragment There should be no behaviour change. Bug: 1091797 Change-Id: I5b6a99f12707c7b92d5e7fc4f1dc4c977ee68007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456849 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815668}
-
Justin Cohen authored
Preload appears to trigger an edge-case crash in WebKit when a restore is triggered and cancelled before it can complete. This isn't specific to preload, but is very easy to trigger in preload. As a speculative fix, if a preload is in restore, don't destroy it until after restore is complete. This logic should really belong in WebState itself, so any attempt to destroy a WebState during restore will trigger this logic. Even better, this edge case crash should be fixed in WebKit: https://bugs.webkit.org/show_bug.cgi?id=217440. The crash in WebKit appears to be related to IPC throttling. Session restore can create a large number of IPC calls, which can then be throttled. It seems if the WKWebView is destroyed with this backlog of IPC calls, sometimes WebKit crashes. See crbug.com/1032928 for an explanation for how to trigger this crash. Note the timer should only be called if for some reason session restoration fails to complete -- thus preventing a WebState leak. Bug: 1032928 Change-Id: I217918437d5cdc6f610f3331634791699dd678ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461571Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815667}
-
Mike Jackson authored
DesktopPWAsWithoutExtensions has shipped. Cleaning up the code to remove the variation to support Bookmark apps Bug: 1065748 Change-Id: Ifd9c276bf2466b02de4eac3e8ffadfae33b1c995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462343 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815666}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I9ba052ae97bfc618224f84271de28f8f4c81443c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459269Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815665}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ia6b83a737c7507b1ff260f7ef76ebc426c35b7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462643Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815664}
-
Ken Rockot authored
This allows interfaces to be tagged with a UUID within mojom files. The UUID is propagated to a base::Token constant nested within the generated interface class for C++ bindings. This allows consumers to establish stable runtime identifiers for interfaces that can persist independently from other interface details, including the superficial name of the definition. Bug: 1136652 Change-Id: Ib69bc116015606e029a02a663a578e08b0755e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462378Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#815663}
-
Zentaro Kavanagh authored
- Currently empty element - Will later add the test section of a diagnostics card such as button to run tests and a routine-result-list to show results. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I64597f5f89c478f74a7900d46b415948d3c1d27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461636 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#815662}
-