GitLab

Frame detach and frame close don't really have any relationship. Update
the naming and comments to make this clear.

BUG=472140

Review-Url: https://codereview.chromium.org/2379293002
Cr-Commit-Position: refs/heads/master@{#422865}

Group nav (paragraph nav) is bound to Search+Ctrl+up/down. Define groups as loosely as possible and don't sync so nav remains as high up as possible for role/predicate matches to occur.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=643840

Review-Url: https://codereview.chromium.org/2380073005
Cr-Commit-Position: refs/heads/master@{#422864}

clang-format wraps long lines, so java_cpp_enum.py should also
handle multi-line enum entries.

Also changed the HeaderParser to ignore empty comments.

BUG=652018

Review-Url: https://codereview.chromium.org/2396533002
Cr-Commit-Position: refs/heads/master@{#422863}

Use the taskId rather to determine if finish() should be called
on Preferences. Previously, if a user navigated in Preferences,
sResumedInstance got set to the sub-Preference and the main
Preference got finished. Since they belong to the same task, this
shouldn't happen.

BUG=652572

Review-Url: https://codereview.chromium.org/2386213004
Cr-Commit-Position: refs/heads/master@{#422862}

Committed: https://crrev.com/f34c072397b99c313e79cd10a77f5ca397154399
Review-Url: https://codereview.chromium.org/2365893002
Cr-Original-Commit-Position: refs/heads/master@{#422655}
Cr-Commit-Position: refs/heads/master@{#422861}

A recent CL introduced some new GN dependencies that broke internal Cast
variants:
  https://codereview.chromium.org/2354633002

Correct the dependencies here. Also put stronger asserts in x11 targets.

BUG=

Review-Url: https://codereview.chromium.org/2371583002
Cr-Commit-Position: refs/heads/master@{#422860}

This allows UsbDeviceHandleUsbfs to be used from any thread that
instantiates a FileDescriptorWatcher (not just threads that run
a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.

BUG=645114

Review-Url: https://codereview.chromium.org/2391633002
Cr-Commit-Position: refs/heads/master@{#422859}

There's no change in behaviour. Now that we setPaginationStrut() on the row,
we don't need to call paginationStrutForRow() outside of layout anymore.

BUG=642814
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2389913002
Cr-Commit-Position: refs/heads/master@{#422858}

Change the pattern of delegation to chrome to use mojom::SystemTrayClient.
This is more consistent with how we want to handle ash delegates going
forward. It eliminates a couple layers of indirection.

* Add wrapper methods to SystemTrayController in ash
* Remove Show* methods from SystemTrayDelegate in ash
* Delete SystemTrayCommon in chrome, move code to SystemTrayClient

Also delete unused tray_display.cc, left over from another cleanup CL
https://codereview.chromium.org/2217713002

BUG=647412
TEST=existing browser_tests, manually verifying system tray help and
settings buttons open web UI in chrome

Review-Url: https://codereview.chromium.org/2395523002
Cr-Commit-Position: refs/heads/master@{#422857}

With this CL, WaitableEventWatcher uses SequencedTaskRunnerHandle
instead of MessageLoop::current() to post back to the sequence that
called StartWatching().

Also, WaitableEventWatcher no longer registers itself as a destruction
observer of the MessageLoop from which StartWatching() is called. If
the watched WaitableEvent is signaled after the MessageLoop is
destroyed, the task posted by WaitableEventWatcher to the
SequencedTaskRunner will simply not run (no crash).

MessageLoop::current() and destruction observer do not work with
TaskScheduler.

BUG=650318

Review-Url: https://codereview.chromium.org/2368423002
Cr-Commit-Position: refs/heads/master@{#422856}

Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page.
Adds mojom files for Bluetooth service definition and internals page handler.
Adds basic Bluetooth device retrieval using starter Bluetooth service
implementation for logging on web front end.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=651282

Committed: https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9
Review-Url: https://codereview.chromium.org/2357383002
Cr-Original-Commit-Position: refs/heads/master@{#422570}
Cr-Commit-Position: refs/heads/master@{#422855}

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2382943002
Cr-Commit-Position: refs/heads/master@{#422854}

BUG=640268

Review-Url: https://codereview.chromium.org/2385383002
Cr-Commit-Position: refs/heads/master@{#422853}

BUG=None

Review-Url: https://codereview.chromium.org/2391993002
Cr-Commit-Position: refs/heads/master@{#422852}

BUG=

Review-Url: https://codereview.chromium.org/2389063002
Cr-Commit-Position: refs/heads/master@{#422851}

This CL adds code to update row view in the chooser when mouse button
is down and moves over rows.

BUG=645693

Review-Url: https://codereview.chromium.org/2382373002
Cr-Commit-Position: refs/heads/master@{#422850}

This includes defining a new NetLog event (SAFE_BROWSING_PING), which begins
when a ping is queued up, and ends when the result callback is fired. Covers
both the SafeBrowsingHit and ThreatDetails pings.

BUG=648323

Review-Url: https://codereview.chromium.org/2361963002
Cr-Commit-Position: refs/heads/master@{#422849}

We are already disabling GPU acceleration to avoid readbacks caused
by calls to getImageData. This change applies the same principle
to canvas-to-canvas drawImage calls in order to avoid probable
future readbacks.

BUG=652126, 651517, 650116, 642539, 640144

Review-Url: https://codereview.chromium.org/2388293002
Cr-Commit-Position: refs/heads/master@{#422848}

This CL was created programmatically by:

thakis@thakis:~/src/chrome/src$ cat pre.txt
 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
thakis@thakis:~/src/chrome/src$ cat post.txt
 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE
 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
 * DAMAGE.
thakis@thakis:~/src/chrome/src$ cat replace.py
import sys

pre = open('pre.txt').read()
post = open('post.txt').read()

for f in sys.argv[1:]:
  t = open(f).read()
  t = t.replace(pre, post)
  open(f, 'w').write(t)
thakis@thakis:~/src/chrome/src$ git grep -l "* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS \`\`AS IS'' AND AN" | xargs ./replace.py

BUG=563793

Review-Url: https://codereview.chromium.org/2395513002
Cr-Commit-Position: refs/heads/master@{#422847}

This avoids having to copy the data between std::vector<char> and IOBuffer within the implementation of WebSocketChannel.

As a follow-up, I plan to see about eliminating a similar copy at the Mojo bindings layer in content/browser/websockets/.

Review-Url: https://codereview.chromium.org/2267233002
Cr-Commit-Position: refs/heads/master@{#422846}

to avoid a race with rendering callback (https://cs.chromium.org/chromium/src/media/audio/pulse/pulse_output.cc?sq=package:chromium&rcl=1475536681&l=148)

BUG=285242

Review-Url: https://codereview.chromium.org/2394483002
Cr-Commit-Position: refs/heads/master@{#422845}

This also rewrites some comments for clarity or brevity.

BUG=563793
TEST=none

Review-Url: https://codereview.chromium.org/2385993002
Cr-Commit-Position: refs/heads/master@{#422844}

BUG=609122

Review-Url: https://codereview.chromium.org/2392003002
Cr-Commit-Position: refs/heads/master@{#422843}

This also makes some minor modifications (small rewrites for grammar, etc.).

BUG=563793
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2391943002
Cr-Commit-Position: refs/heads/master@{#422842}

Morally reverts https://codereview.chromium.org/294653002.

BUG=345874

Review-Url: https://codereview.chromium.org/2387903002
Cr-Commit-Position: refs/heads/master@{#422841}

Tasks associated with transactions are terminated when a dispatcher
host's connection goes away, but queued connection open/delete
requests are not associated with transactions, meaning attempting to
send the results will fail. To avoid this, check to see if the
dispatcher is still connected when a request gets to the head of the
queue.

BUG=650635
R=cmumford@chromium.org

Review-Url: https://codereview.chromium.org/2386683003
Cr-Commit-Position: refs/heads/master@{#422840}

fast/borders/border-radius-with-box-shadow.html requires a trivial
rebaseline after

https://chromium.googlesource.com/skia.git/+/a3b45d4f7db953472df4f11ab1595964b65175f9

BUG=630695
TBR=bsalomon@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2393553002
Cr-Commit-Position: refs/heads/master@{#422839}

Currently, DevTools file watcher reports both added and changed paths
as "changed" and doesn't report removed paths.

This patch improves DevTools file watcher so that it starts reporting
changed, added and removed paths.

BUG=none
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2384343002
Cr-Commit-Position: refs/heads/master@{#422838}

https://chromium.googlesource.com/angle/angle.git/+log/886de36..4c65524

BUG=chromium:651493,651101,chromium:618464

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2393613002
Cr-Commit-Position: refs/heads/master@{#422837}

Reverted by:
https://codereview.chromium.org/2369683002/

Reason for reland:
I've reworked it so that:
1. The list of pak files to extract are not set on start-up, but rather lazy initialized
2. This is done by putting the list of locale assets right in base's BuildConfig.java
3. Downstream parts have been upstreams so that this won't require a 2-sided patch

Language pak files were moved to res/raw when split apks was being implemented.
Moving them to assets with a java constant keeping track of pak file locations
will improve lookup time and save some space (no more xml files and
resources.arsc).

Other notables:
- .pak filenames no longer mangled. No more .lpak. no more hyphens to _s
- Ensures that monochrome doesn't extract files by extracting only when
files are compressed.

BUG=529604

Review-Url: https://codereview.chromium.org/2371843002
Cr-Commit-Position: refs/heads/master@{#422836}

This allows ProcessOutputWatcher to be used from any thread that
instantiates a FileDescriptorWatcher (not just threads that run
a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.

BUG=645114

Review-Url: https://codereview.chromium.org/2384293002
Cr-Commit-Position: refs/heads/master@{#422835}

The API already has dependency on permission:imageWritePrivate.

BUG=650707
TEST=Manual.

Review-Url: https://codereview.chromium.org/2387543002
Cr-Commit-Position: refs/heads/master@{#422834}

BUG=176897

Review-Url: https://codereview.chromium.org/2386313003
Cr-Commit-Position: refs/heads/master@{#422833}

This CL adds getter/setter for colour temperature for
Android implementation.  JS API uses Kelvin grades,
whereas the platform uses names, so a mapping of
sorts is introduced.

BUG=650675
TEST= by hand using the JS ImageCapture API.

Review-Url: https://codereview.chromium.org/2385833002
Cr-Commit-Position: refs/heads/master@{#422832}

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
  5. No menu items for non-existing Arc app.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=652741
BUG=b/30646620

Review-Url: https://codereview.chromium.org/2393453002
Cr-Commit-Position: refs/heads/master@{#422831}

Review-Url: https://codereview.chromium.org/2374213003
Cr-Commit-Position: refs/heads/master@{#422830}

Like https://codereview.chromium.org/2390853002/ but for bindings, public.

BUG=563793
TBR=dcheng

Review-Url: https://codereview.chromium.org/2391793003
Cr-Commit-Position: refs/heads/master@{#422829}

Remove an unused include and fix a return value. Small things I noticed
during other cleanup work.

BUG=none

Review-Url: https://codereview.chromium.org/2391023002
Cr-Commit-Position: refs/heads/master@{#422828}

Force Listview to update in onResume() to synchronize with any change of
location access permission of search engines.

BUG=652204

Review-Url: https://codereview.chromium.org/2390113002
Cr-Commit-Position: refs/heads/master@{#422827}

This time the header lookup uses the first include.

BUG=

Review-Url: https://codereview.chromium.org/2388973002
Cr-Commit-Position: refs/heads/master@{#422826}