- 14 Nov, 2020 10 commits
-
-
Patrick Noland authored
This puts LocationBarCoordinator in charge of constructing and destroying UrlBarCoordinator, StatusCoordinator, and AutocompleteCoordinator. This allows us to wire a few more dependencies into constructors instead of via setters. The coordinators are still passed to LocationBarLayout for it to use via a new initialize() method that consolidates a few different setter methods on LocationBarLayout. initialize() helps avoid bugs that could arise when calling these setters out of order. There is an additional change to LocationBarLayoutTest that fixes a DCHECK when running tests on a debug build. Bug: 1146057, 1146062 Change-Id: Ie6c7e871d6cb0eb4bbffff0ab3ed275968d84e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495969 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827494}
-
Peter Boström authored
Fixes missing offset for non-zero bounds.x() for the icon area in TabIcon::MaybePaintFavicon. Bug: 1147408 Change-Id: I309c5074ee82c8a4ecc3cd14243c329088fb06a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538207 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#827493}
-
adoneria authored
1. Disable component build for mac builders on CI and try. 2. Enable use of goma for mac and win builders on CI. 3. Enable component build for win builders on try. Bug: 1148920 Change-Id: I690834b4b80812569bff2d8206b775cf05966f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538161Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#827492}
-
Sorin Jianu authored
The IDL file is split in three parts: public, internal, and legacy definitions. This is a fairly straightforward change, which consists of suffixing the path to the typelib in the executable file with a //<index> where the index matches one of the there source IDLs above. Further work is needed to properly generate the GUIDs depending on the which IDL the GUIDs belong to. Some of the GUIDs must depend on branding, and some of the GUIDs must depend on branding and version. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2527822 after the following fixes: diff --git a/chrome/updater/test/test_app/update_client_win.cc b/chrome/updater/test/test_app/update_client_win.cc index 13ffa873ce6c..71c8e4c090c6 100644 --- a/chrome/updater/test/test_app/update_client_win.cc +++ b/chrome/updater/test/test_app/update_client_win.cc @@ -28,11 +28,12 @@ #include "chrome/updater/update_service.h" namespace updater { + namespace { HRESULT CreateUpdaterInterface(Microsoft::WRL::ComPtr<IUpdater>* updater) { Microsoft::WRL::ComPtr<IUnknown> server; - HRESULT hr = ::CoCreateInstance(__uuidof(UpdaterClass), nullptr, + HRESULT hr = ::CoCreateInstance(__uuidof(UpdaterClass)], nullptr, CLSCTX_LOCAL_SERVER, IID_PPV_ARGS(&server)); if (FAILED(hr)) { diff --git a/chrome/updater/test/test_app/update_client_win.h b/chrome/updater/test/test_app/update_client_win.h index 25e16c53cc09..e5496ec47828 100644 --- a/chrome/updater/test/test_app/update_client_win.h +++ b/chrome/updater/test/test_app/update_client_win.h @@ -10,7 +10,7 @@ #include <windows.h> #include <wrl/client.h> -struct IUpdater; +class IUpdater; namespace base { class SingleThreadTaskRunner; Bug: 1140562 Change-Id: Ibce69536e2816ab089f8851191af052ff7616565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538267Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827491}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e61ccc59a240..fd5c198347e1 2020-11-13 chanli@chromium.org [resultdb] Update rdb version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147548 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia7f7a6de01e7448b1c489c0697c9a2d5791d457d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827490}
-
Robert Ogden authored
We expect that this duration will either be pretty short, in the case of loadshedding origins, or very long in the case of origins trying to use a 503 response to opt out of prefetches. Since the loadshedding case is not interesting from a product prespective, this histogram is scoped out to a week to catch the latter. Bug: 1146210 Change-Id: Ibeb1488206edbca7c8999a05def7e22d833772a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538133Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#827489}
-
Aleks Totic authored
Few more unit test fixes. Bug: 958381 Change-Id: I902fe45de917b06322e886b02c2b6fe495d08421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536254 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#827488}
-
Adam Ettenberger authored
Items in single selection containers that have accessibility focus should get the selected state. Code to mirror focus to selection exists, but the selected state must be refreshed. Replacing AXLayoutObject::SelectionShouldFollowFocus with a helper method in ax_role_properties, ui::IsSelectRequiredOrImplicit and including Role::kTreeItem [1] since the ARIA spec lists aria-selected as a required state. Adding AXObject::IsSelectedFromFocusSupported (see AXLayoutObject impl) which provides a mostly conclusive answer for whether an element can support this behavior. During this investigation, I found there was a portion of the spec that was not implemented, so I created a crbug [2] for that. "If any DOM element in the widget is explicitly marked as selected, the user agent MUST NOT convey implicit selection for the widget." Also created a crbug [3] for followup to consider including more selectable roles for this behavior. Currently only roles that require or have an implicit value for aria-selected allow this behavior. It may be desirable to include roles columnheader, rowheader, gridcell and row, but felt that would be out of scope for this CL. [1]: https://www.w3.org/TR/wai-aria-1.1/#treeitem [2]: https://crbug.com/1143451 (Not allowed with explicit selection) [3]: https://crbug.com/1143483 (Consider allowing more roles) AX-Relnotes:Notify the aria-selected state changed for items that have their selected state follow focus, and enable this behavior for role=treeitem elements inside single-selection containers. Bug: 1141579 Change-Id: Idce80a91f41df859775eed59a922ac7c923d9f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493000 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#827487}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/56523dff6983..da1f66c8cee1 2020-11-13 enga@chromium.org Update DepthBiasTests to use WGSL 2020-11-13 enga@chromium.org Update CullingTests to use WGSL 2020-11-13 enga@chromium.org Update ComputeIndirectTests to use WGSL 2020-11-13 enga@chromium.org Update CompressedTextureFormatTests to use WGSL 2020-11-13 enga@chromium.org Update ColorStateTests to use WGSL 2020-11-13 enga@chromium.org Update ClipSpaceTests to use WGSL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I69a38afae88fc367ea614a7575e07962f9ca7a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537142Reviewed-by:
-
Robin Lewis authored
Bug: 1148979 Change-Id: I971194186baef5f8a2b82ef8a826f491116a102e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538353 Commit-Queue: Robin Lewis <wrlewis@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#827485}
-
- 13 Nov, 2020 30 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I70d41037f2dfac71976d0156f19d16edb900e0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537102Reviewed-by:
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I37686da165a4ef9d352e39c25f875e80ee2da77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537934Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827483}
-
Gabriel Charette authored
This was missed in the original implementation because on Windows the pump always processes a native event before DoWork() and hence always kicks off the "ThreadController active" trace event prior to DoWork(). On platforms that don't do this, the tasks nested backwards (and the ends were out of order which messed up the trace layout). Also cover DidRunTask() now to cover microtasks and added extra brackets to make it extra clear what the scope of "things we do to run the task" are. R=altimin@chromium.org Bug: 899897, 1074019 Change-Id: I67a01853365e173ed924513592191d6098a4f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536998 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827482}
-
Aaron Colwell authored
Removing an unnecessary call to IsDefaultSiteInstance() in RenderFrameHostManager. The condition the call was in expects RequiresDedicatedProcess() to return true on the SiteInstance which won't happen on a default SiteInstance. - Removed IsDefaultSiteInstance() call from RFHM. - Added a test that explicitly verifies that a default SiteInstance returns fals for RequiresDedicatedProcess() to help prove the call was not needed and ensure that we don't accidentally change this behavior. - Converted DCHECK in set_process_reuse_policy() to a check to make sure we don't accidentally allow reuse to be set on production builds. Bug: 1085275 Change-Id: I628df05fe1b2eb27031f8bec087913867717e9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538251 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#827481}
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making GPU a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.gpu getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: I8621639935b014eb4905804f432327729619c3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537775 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#827480}
-
Rakib Hasan authored
This reverts commit 902c49d1. Reason for revert: Builders do not allow using a floating references. We need to start pinning tags to chromium/src again in order to run skew tests. The error can be seen here, https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863706392115604464/+/steps/test_pre_run/0/steps/s__trigger__weblayer_instrumentation_test_versions_apk_M88_Client_Tests/0/stdout?format=raw Original change's description: > weblayer, skew tests: Add M88 skew tests > > This skew test will updated daily by uploading new CIPD packages > for each tag created in the M88 branch. The m88 reference will point > to the most recent package uploaded. > > Bug: 1147459, 1147455, 1099017, 1041619 > Change-Id: Ib9ae51d2a7379d478cbab68a334c7d2488bf0e8a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538152 > Auto-Submit: Rakib Hasan <rmhasan@google.com> > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827411} TBR=sky@chromium.org,rmhasan@google.com Change-Id: I17d5abc780eeba571c4d92793db46ed88ab61d66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147459 Bug: 1147455 Bug: 1099017 Bug: 1041619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537186Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#827479}
-
David Bertoni authored
This test is no longer flaky on asan or tsan bots, but is very flaky on Mac and Windows, so this CL re-enables the test on the asan/tsan bots and disables it on Mac and Windows. Bug: 377702, 1148894 Change-Id: Ia0065e4636bf813d98bca6cda1ead3edc7ae4684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535035Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#827478}
-
Alexander Cooper authored
Currently we've rolled our own helper method "ContainsFeature"; however, this essentially duplicates base::Contains (which is slightly shorter). Remove this helper method and use base::Contains instead. Change-Id: Icc4d92190536bbd7203474305bf891e48e4cb7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537786 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#827477}
-
James Cook authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. I added a couple TODOs for lacros work items that need followup and deleted an unused include. Bug: 1052397 Change-Id: I726fc10295074dbc9cff4501b0d67ea2b4f7de54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536798Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#827476}
-
Mingjing Zhang authored
This CL implements the stale-frame metrics that measure the undesirably prolonged presentation time due to frame dropping. The metrics are reported under the Graphics.Smoothness.Stale.* (staleness of each frame) and Graphics.Smoothness.MaxStale.* (maximum staleness per interaction). Bug: 1092949 Change-Id: Id2e3d616bfa4362fd8f4b6db4fedb23290d6cba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490385Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827475}
-
Lukasz Anforowicz authored
This CL changes AwContents.loadUrl(LoadUrlParams), so that URLs passing through WebView APIs are fixed - partially restoring the behavior prior to r818969. Before r818969 (which landed in 88.0.4298.0), the URL passed to WebView.loadUrl (and postUrl, loadData, loadDataWithBaseURL) would get fixed via url_formatter::FixupURL when the //content layer was processing the navigation (e.g. from within WillHandleBrowserAboutURL or BrowserURLHandlerImpl::FixupURLBeforeRewrite - both of these callsites have been removed in r818969). Such rewrite is not happening after r818969 - this is an accidental breaking change. In https://crbug.com/1145717 we have some evidence that some apps have actually depended on fixing the URLs, although the evidence is not particularily strong and doesn't include the specific URLs that were getting fixed. Unlike before r818969, *all* URLs are fixed, *prior* to starting the navigation via the //content APIs - this introduces some small differences in behavior (e.g. javascript:42 would not be rewritten before this r818969, but would be rewritten to http://javascript:42/ after the current CL), but these differences are small and the risk seems acceptable (e.g. javascript:42+42 would not be rewritten). Bug: 1145717 Change-Id: I04f5ee54b3ee841cf54d0256e0eeca2e2f984e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528804Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#827474}
-
Gordon Seto authored
Rename sim-detect-page to setup-loading-page and update UI to be used for both psim and esim flows. Bug: 1093185 Change-Id: Iaf8934a3423c1ce21d6115bc9ea28c9d972738b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535231 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827473}
-
Karandeep Bhatia authored
This is in preparation of splitting RulesetSource class into a RulesetSource base class and a FileBackedRulesetSource derived class. This will be useful for implementing session scoped rules which are not file backed. BUG=1043200 Change-Id: Ia099b9f180408d4b3518c4f80d41ec312d5f740f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495875 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
This CL improves the error messages for array parse failures in generated code. BUG=1113513 Change-Id: Ic1edfab5e005f363b8670b1f798a241673b856ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520799Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827471}
-
Peter Boström authored
Replaces remaining CalculatePreferredSize() overrides that are used to unconditionally set a specific fixed width. Bug: 1128500 Change-Id: I93abc6b85be7fa956e65608819806aaac23d8d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538131Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#827470}
-
Scott Little authored
This reverts commit 34bf7349. Reason for revert: Failing SingleRulesetTest.SessionRules unit_tests on multiple platforms: https://ci.chromium.org/p/chromium/builders/ci/win-asan/15627 https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/17985 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110233 Original change's description: > DNR: Add initial implementation for [get/update]SessionRules. > > The session rules are not indexed and evaluated yet. This will be done > in a follow-up. > > Skipping presubmit since this seems to be hitting crbug.com/956368. > > BUG=1043200 > Doc=https://docs.google.com/document/d/1_I6jHA_jCa0UbR2QVUZsBApt_GqEuMz7qnpQdt1LEv0/edit?usp=sharing (Internal only) > > No-Presubmit: True > Change-Id: Id15783af14ff1f4a88900680d29d71d07794b4e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495511 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827418} TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org,kelvinjiang@chromium.org Change-Id: Ibdd5c17fb41abc19809fb9fe7224c1ecdd30c1ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537185Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827469}
-
Frank Liberato authored
Previously, ImageReaderGLOwner created a ScopedJavaSurface that did not call Surface.release() upon destruction. Unfortunately, this meant that nobody called release(). This was never noticed because we also leaked the Surface object, so it was never finalized => no helpful diagnostics. After https://chromium-review.googlesource.com/c/chromium/src/+/2453270 the leak was fixed, but now the lack of release() caused strict- mode violations. This change switches ImageReader's ScopedJavaSurface to call release properly. It's safe because CodecSurfaceBundle makes sure that the surface outlives the MediaCodec instance that's using it. This change also reverts https://chromium-review.googlesource.com/c/chromium/src/+/2527563 which replaced the leak-the-surface behavior intentionally, as part of the investigation. Bug: 1146071 Change-Id: Ib8187530299ba7790e30e630250cc2a7fd4eebf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537782Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#827468}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33eec64159df..07569638a739 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sclittle@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1115463,chromium:1119406,chromium:1147179 Tbr: sclittle@google.com,adithyas@google.com Change-Id: I047fca48aab5d00503ef3edfddfe3872908f9b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537031Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827467}
-
David Maunder authored
This reverts commit 56334b9e. Reason for revert: causing a bot to crash see crbug.com/1148972 Original change's description: > Add CriticlaPersistedTabData to fieldtrial_testing_config > > This was determined to be necessary in cl/342061697 > > Bug: 1148823 > Change-Id: I125e177fa057e6aebd92a0750559e4a68940c312 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537699 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: David Maunder <davidjm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827346} TBR=mpearson@chromium.org,davidjm@chromium.org Change-Id: I7238b95d7e0577f6d5797fe500a3031d5e7f5960 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537003Reviewed-by:
David Maunder <davidjm@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#827466}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Idc00f2369a9496d35ac7e3f775b1ded9dd2703a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537000Reviewed-by:
-
Ted Meyer authored
playerIDs were getting added to dead players, then removed from the player map - when it came time to delete players, the dead players tried to be removed again. Looks like CF was running without DCHECK enabled, so it never hit the check for iter != players_.end(). Bug: 1148757 Change-Id: I13486c59ec362b023ddbf93462d359bec7707512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537789Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827464}
-
Daniel Cheng authored
This was only needed for testing, but tests can start a test server and have all names resolve to 127.0.0.1. In this case, a little additional work is also required due to the HTTPS requirement. Bug: 819406 Change-Id: I07af6e568a53e1eda54e5d553d05001b2a12a213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536071Reviewed-by:
Elad Alon <eladalon@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827463}
-
Scott Little authored
This reverts commit 28c8eb1a. Reason for revert: This CL seems to have caused SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest to become flaky. Sorry for reverting such a big CL, but please fix and reland. See: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4495 https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4494 https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4491 https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4475 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21297 Original change's description: > Convert FrameHostMsg_SynchronizeVisualProperties to RemoteFrameHost message > > This CL migrates FrameHostMsg_SynchronizeVisualProperties IPC message > to RemoteFrameHost Mojo interface. To do that, this CL moves > FrameVisualProperties struct from //content to //blink. Then, this CL > introduces SetSynchronizeVisualProperties function in WebRemoteFrame > class in order to make RenderFrameProxy::SynchronizeVisualProperties > call SynchronizeVisualProperties in blink. > > Bug: 1093956 > Change-Id: I38088e71df5d1d7743c6ec1826b17301b6bc57b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376766 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827199} TBR=kinuko@chromium.org,haraken@chromium.org,dtapuska@chromium.org,gyuyoung@igalia.com Change-Id: If0cea40964f6f7d417e9aceb9d8505bac2d7764a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1093956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535812Reviewed-by:
-
Adam Langley authored
If one unchecks the checkbox in the QR-scanning dialog, the phone is no longer linked to the desktop. BUG=1002262 Change-Id: I9c6d97637ba5361b6d1f24f4d270f172d7e15363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527888Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#827461}
-
Findit authored
This reverts commit 3846b220. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 827420 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM4NDZiMjIwMzIxYTRlYTM3MWJiNmE0NGUzYTEyN2NmNjllZTUyNDEM Sample Failed Build: https://ci.chromium.org/b/8863709088659159040 Sample Failed Step: compile Original change's description: > Split the updater IDL file. > > The IDL file is split in three parts: public, internal, and legacy > definitions. > > This is a fairly straightforward change, which consists of suffixing > the path to the typelib in the executable file with a //<index> where > the index matches one of the there source IDLs above. > > Further work is needed to properly generate the GUIDs depending on > the which IDL the GUIDs belong to. Some of the GUIDs must depend on > branding, and some of the GUIDs must depend on branding and version. > > > Bug: 1140562 > Change-Id: I6030977d3961ff24bbc8bc33392415d59884feec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527822 > Reviewed-by: S. Ganesh <ganesh@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827420} Change-Id: I3821d3b2bb496016035c7192a1d3c3c7eb672e63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537122 Cr-Commit-Position: refs/heads/master@{#827460}
-
Zhaoyang Li authored
A potential fix landed for the flaky "Connection aborted" issue in iOS (See bug). Enable ResultDB on some fyi builders to verify the fix: * ios-simulator-multi-window * ios14-beta-simulator * ios14-sdk-simulator These builders are not monitored or already have failing suites. Bug: 1136998 Change-Id: I30577514f365c676c9e5d22143bc08b104499ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536932Reviewed-by:
-
Takumi Fujimoto authored
Most of the failures to stop a DIAL session is because the session no longer exists. So we query for the app's current status, and if it's not running, we remove the corresponding route. Bug: 1141714, b/158693455 Change-Id: I71e9770d1188861c37bce996fedf30461a0f9bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492918 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827458}
-
Dmitry Gozman authored
When the browser is controlled remotely over the pipe, and the pipe is disconnected, there is no way left to control the browser. Every pipe client tries to kill the browser at that point. Instead, we can just shutdown normally, leaving no core dumps. Change-Id: Ib03a727930b00f48a6869c12c66c86072d45b5b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536354 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Joe Downing authored
This change updated the 'Upgrade' logic in the CRD host WXS file so that it no longer blocks downgrades. I've run through several upgrade and downgrade scenarios and it looks like everything gets cleaned up and re-registered correctly with this change. I looked into a few options to constrain the version window where downgrades are allowed. I think the most promising would be to add a wxs param which takes a 'max_downgrade' var based on the 'chrome_version_full' + max version skew and use that for blocking downgrades. I'm not convinced this is necessary though since we don't have any version checking for our MacOS package and we haven't had any issues related to downgrading when using Keystone. Bug: 1148967 Change-Id: I4b36541ff901eb10f4c26c7652654f43f77762c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538202 Commit-Queue: Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#827456}
-
Brandon Jones authored
Ideally this conversion should happen in the XR service and off the JS thread, but that's an optimization that can happen later. The actual conversion may need some tweaking in the future, for things like better tone mapping, but for the time being this gives a usable result. Bug: 1147569 Change-Id: I0407eee6e4c8337bd376bd43ca0f32987a471055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535915 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#827455}
-
