- 16 Sep, 2020 40 commits
-
-
Dominique Fauteux-Chapleau authored
This should not change deep scanning behaviour with Connectors. Bug: 1103390 Change-Id: I7a92943edb690010495c8014d51b493e110301bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412633Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#807517}
-
edchin authored
https://crrev.com/c/2312556 is a refactor that introduced a DCHECK failure regarding (mouse) pointer support. The signin confirmation button can either have an opaque background (i.e., "Add Account" or "Yes, I'm in!") or a transparent background (i.e., "More") when scrolling is needed to reach the bottom of the screen. This CL changes the style provider to one that handles both opaque and transparent buttons. Bug: 1127293 Change-Id: I9e27f012d79885324b32ba918bd4f3f48a59d235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413172 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#807516}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 86-4240.27-1600081136-benchmark-86.0.4240.36-r1 to 86-4240.27-1600081136-benchmark-86.0.4240.38-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idbb062c864a4e3301eefc4967e4e430ef3c649f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807515}
-
Xiaohan Wang authored
Add cros and arm/arm64 to be future proof. Bug: 1111381 Change-Id: If6310e006710c2857d6c9be1297796374dcb3f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411344 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#807514}
-
Xiaohan Wang authored
When Widevine CDM host verification signing failed due to no signing cert, the build process will fail by default. However, developers making local builds typically don't have those certs. This CL introduces `ignore_missing_widevine_signing_cert` gn arg so the error caused by missing Widevine signing cert could be ignored. By default, `ignore_missing_widevine_signing_cert` is set to false on official bots (is_official_build=true) to catch real failures. Developers needing to set `is_official_build` can manually set this gn arg to be true to suppress the error. Bug: 1127616 Change-Id: I41a43e922399497c75f1f967219d41d1566d90dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412933 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#807513}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I0f59c9d6812ca93e2d7b5d100d7857467b685f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414193 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#807512}
-
Demetrios Papadopoulos authored
Without this attribute, screen readers don't announce whether a tab is currently selected. Bug: 1123470 Change-Id: Ie88959bf1cd4fc68003fffa62fbebe57877b899f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410496 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#807511}
-
Xiaohan Wang authored
Bug: 1128458 Change-Id: I0a08be5ccb2e245134b12f264b90ccd2376cd2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413207 Commit-Queue: John Rummell <jrummell@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#807510}
-
Carlos Frias authored
This CL enables obtaining a finer control for OS hooks supported by OSIntegrationManager::InstallOsHooks(). Currently, there is no option for file handlers and file_handler_manager_->EnableAndRegisterOsFileHandlers() is being called every time InstallOsHooks() is executed. This CL adds the bitset OsHookType to InstallOsHooksOptions struct to allow controlling which OS Hooks to install, including file handlers. bool add_to_application_menu now becomes os_hooks[OsHookType::kShortcuts]. bool run_on_os_login now becomes os_hooks[OsHookType::kRunOnOsLogin]. Bug: 1087219 Change-Id: Ib370c394235efe66fca23267928184b9841c76ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373229 Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#807509}
-
danakj authored
The code has moved, so update the includes. R=avi@chromium.org Bug: 1091083 Change-Id: Ib618539c1215d137cb1f109ee6109fe2e9b63fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413560Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807508}
-
Yuke Liao authored
This CL runs lacros_chrome_browsertests on CI/CQ to prevent regressions. Bug: 1120582 Change-Id: I2350852341b1be0319e06350e3412ad43c771868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411845Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#807507}
-
David Bertoni authored
This CL adds more tests to be run as Service Worker-based extensions. Bug: 1093066 Change-Id: Ib984bb47dfc16c1e7c5bca8838a5c6e71d0c9671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405552 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807506}
-
Jonathan Ross authored
This reverts commit 0e23bba9. Reason for revert: crbug.com/1128983 Causing linux-lacros-rel to fail compile almost 25% of the time. Making it tough to land changes Original change's description: > Use mojom::V8CacheOptions instead of blink::V8CacheOptions > > Now we can use mojom::V8CacheOptiosn directly in Blink. So, > this CL replaces all uses of blink::V8CacheOptions, then > remove it. > > Change-Id: I636e0259d0b7da692bf693c3ec13f99dba9cd410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409665 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#807427} TBR=kinuko@chromium.org,haraken@chromium.org,gyuyoung@igalia.com Change-Id: I0387c6f09f0a3bcb06fa6f62ce5ef53cb82e6860 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414671Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#807505}
-
Markus Handell authored
VideoCaptureDeviceAVFoundation was requesting UYVY if a MJPEG mode was selected by media::FindBestCaptureFormat() to fix cases of no video samples from the camera in case of a specific model. While this workaround works for most known cameras and modes, it leads to the following problems: 1. Sluggish video for 4K MJPEG output for BRIO. 2. It presents a power disadvantage compared to requesting MJPEG directly and decompressing with libyuv. This change fixes this by requesting MJPEG directly unless the known problematic camera is selected, in which case it requests UYVY. Bug: 1116241, 1124884, 1035077 Change-Id: Iab5fc2944ce1b891f956fce4be32eccf280c7349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412732 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#807504}
-
John Abd-El-Malek authored
The initial navigation might not be completing, so expliclity wait for that. Bug: 1128528 Change-Id: Ida24e814b9910315d05698f2ef15cfd6e48e7b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412838 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807503}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b87e7b7d3b0b..f5ee7c40c31b 2020-09-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-16 jacktfranklin@chromium.org Migrate Heap snapshot test for detached iframe. 2020-09-16 changhaohan@chromium.org Add UMA for Grid overlays opened source 2020-09-16 jacktfranklin@chromium.org Add npm run auto-debug-unittest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1110817 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I384664de4aa3ed46050b7afe0eaf99cc5ff27140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807502}
-
Anne Lim authored
This is a reland of b0398ace Original change's description: > [Autofill] Update Sync Bridge to save instrument_id > > Please see bug for design doc. > > Bug: 1121806 > Change-Id: I9c67bc3487a64eb1b07b4d0334a63081f85c66fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404947 > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Anne Lim <annelim@google.com> > Cr-Commit-Position: refs/heads/master@{#806731} Bug: 1121806 Change-Id: Ic0c1303e8284a9c00b49b4e54121ec86c8a37645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412887Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#807501}
-
Liquan (Max) Gu authored
Change: * In PRImpl#initAndValidate(), refactors the mSpec parsing block to unwind the UI logic and the business logic. This way, mPaymentUIsManager.updateDetailsOnPaymentRequestUI() have a chance to be combined into onPaymentRequestParamsInitiated(). * Do the same unwinding for other cases in the code Bug: 1102522 Change-Id: I6939e934a554a2a252f1f0cb71208c245a738486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405617 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#807500}
-
David Black authored
Previously we watched the backing file for each holding space item in order to determine when to remove a stale holding space item. Now, we'll instead watch the parent directory of the backing file so that a file system watch can be reused across multiple holding space items. Bug: 1122418 Change-Id: I2b18f51c06dba36027c9c8b1562803f756980b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410978Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#807499}
-
Dominique Fauteux-Chapleau authored
This is done by storing the response in the DownloadItem user data. Bug: 1128046 Change-Id: I8c9711e428d94208a4965bfce400a2a36ef71a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410587Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#807498}
-
James Cook authored
Previously the crostini window tracking code was identifying lacros as an "unmatched" crostini app. Correctly setting the shelf ID fixes several issues: * No more penguin icon for lacros windows * Lacros icon shows correct active/running indicator * Lacros context menu has list of open windows when there is more than one window open Also change the Lacros BrowserManager to wait a little longer before starting the browser during session restore. This ensures that the shelf (ChromeLauncherController and objects it owns) are created before the first lacros-chrome browser window. There will probably be more shelf fixes required, but this is a start. Bug: 1115263 Test: added to browser_tests Change-Id: I323c7d9b213affba4de59130380585d769de19e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411607 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807497}
-
rbpotter authored
Two up mode is implemented in the plugin but not the ink controller, and triggering it causes a crash if the plugin is not on the page. Also fixing the following case: 1. Rotate PDF. Annotation is disabled. 2. Set 2 page view. 3. Rotate PDF back to upright. Currently, annotation is re-enabled, despite still being in 2 page view. After this CL, annotation remains disabled, until two page view is turned off. Bug: 1048812 Change-Id: I26c0cb43645c82905e1fe5b53398332573d8a774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411284Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#807496}
-
rbpotter authored
Bug: 1128583 Change-Id: Id7e714eb94b2ff08a346d4d0166d97e93654265d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412139Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#807495}
-
mhasank authored
The UMA is sent in session manager daemon when starting ARC fails and we create backup of ARC bug report. BUG=b:168630900 TEST=deploy to dut, opt in to arc, ensure suffix shows up in chrome://histograms Change-Id: Iab49253ab966ff98c73a2da573bcc73dd1289cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412780Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#807494}
-
Hazem Ashmawy authored
Add tests for crash collection consent error message. This also handles a silent bug where calling assertNoUnverifiedIntents in the teardown of a skipped test, will cause a crash, by checking that the activity is launched. Fixed: 1106315 Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*" Change-Id: Ie0252d898f848f69dee90a6f526691dfab495289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411943 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#807493}
-
David Grogan authored
* Don't make all tables in row flexboxes go through the min-width:auto path, which was added in https://chromium-review.googlesource.com/c/chromium/src/+/2392444 * Always make flex item's min/max widths encompass table's min intrinsic size, even if the table has a definite min-width. No behavior change intended. Change-Id: I92456b5c4e20272887066593d166809e6b98ab54 Bug: 1123100,1128262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410596Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807492}
-
Matt Jones authored
This patch ensures that the bottom sheet is not currently suppressed prior to showing content. This patch also ensures that higher-priority content replaces existing content when suppressed. Bug: 1114584 Change-Id: I99f5ed696e269012908bc68f9968c09ae7ee818b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401855 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#807491}
-
Andrew Grieve authored
This reverts commit 90feb41b. Reason for revert: Broke disassembling with ndk for apks Original change's description: > SuperSize: Fix console's Disassemble not using stored toolchain > > Just something that came up when I was trying to use it. > > Bug: 999351 > Change-Id: I31c7c6a3b0ae6baaa7205b59cf1e6fff1bb2a517 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412369 > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807185} TBR=huangs@chromium.org,agrieve@chromium.org Change-Id: I13c23a145096865627c080910b4901ebff293901 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414648Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#807490}
-
Gayane Petrosyan authored
Add prefix and suffix to text fragment selector when only exact text selector is not enough. Gradually add words from available prefix and suffix range until unique match is found. Bug: 1102382 Change-Id: I377deca1315b3f2ea781a2dce37d04bb5a57dd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374369 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#807489}
-
Erik Staab authored
This is a reland of 11c26e5e Original change's description: > Change the mac builder default to be either 10.13 or 10.15. > > Once the hosts are all upgraded to 10.15 we will remove the 10.13 option. > > Bug: 1121185 > Change-Id: I3177749f79ddd16b9d725693f21e79ebd752c22c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412757 > Commit-Queue: Erik Staab <estaab@chromium.org> > Auto-Submit: Erik Staab <estaab@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807218} Bug: 1121185 Change-Id: I0b4e69122fc7b80165ca2abbd2542c24ba88d0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413529 Auto-Submit: Erik Staab <estaab@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#807488}
-
Guillaume Jenkins authored
When opening multiple URLs via Siri Shortcuts while the tab switcher was opened and empty, only the first 3 URLs were successfully opened. The cause is as follows: - URL 1 opens and causes the tab switcher to dismiss asynchronously, but callback 1 is still run immediately - Callback 1 causes URL 2 to start opening, but it must wait for the dismiss animation to finish, so callback 2 is stored in the BVC properties - Callback 2 eventually runs, and does two things: 1) open URL 3 2) append callback 3 to the BVC tab opening callbacks - Immediately after callback 2 finishes running, the BVC clears its callback property, erasing callback 3 that was just set by callback 2 - URL 3 is opened by callback 2, but callback 3 is never run because by the time the BVC tries to invoke the tab opening callback, it was already set to nil after running callback 2 The simplest fix I found is to simply clear the callback property before running the callback (the callback is stored to a local var before clearing the property). That way, callbacks can append new tab opening callbacks without fear of them being erased. Bug: 1124291 Change-Id: Ib3684f4ce93136c28bb55711b4a5742510082302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405897Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#807487}
-
kylechar authored
Change ColorTransformPixelTest so that they run with Vulkan. Also merge together the list of color spaces to be tested for GLRenderer and SkiaRenderer. The only thing that doesn't work with SkiaRenderer is piecewise HDR transfer functions, so add a check and early return in the test body if using SkiaRenderer and the color space has a piecewise HDR transfer function. Also make sure VideoRendererPixelHiLoTest doesn't run if GL tests are turned off. The test only works with GL but it was still being run when BUILDFLAG(ENABLE_GL_BACKEND_TESTS) was false. Bug: 1117587 Change-Id: If24ec29ab36d7c20e93f5140786639fb99385ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411700Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#807486}
-
Mohamed Amir Yosef authored
This is analogous to PasswordForm::in_store and reflects in which store those credentials are stored. Bug: 1119286 Change-Id: I18084d1af45f427346f0df4282a2505a1748c139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407900 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#807485}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/08574aeb4454..fa54364cea0b 2020-09-16 jonaso@webrtc.org Update STUN attributes with latest IANA registrations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifa06912fbe794806fb81d78fe15c331f1ace5e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807484}
-
danakj authored
The code has moved, so update the includes. R=avi@chromium.org Bug: 1091083 Change-Id: I2c9a5c20b78756fc0b460a85f00d8560f1883979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412947 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807483}
-
Scott Violet authored
Couple of comments about 'overflow:clip': . Per spec it does not create a new formatting context. . Implementation will create a PaintLayer, but it won't create a scrollable area. . Can not be scrolled. This adds IsScrollContainer to ComputedStyle and LayoutObject. The name 'scroll container' comes from https://www.w3.org/TR/css-overflow-3/#scroll-container . As 'overflow: visible' may be set along one axis, and 'overflow: clip' another, this renames IsOverflowVisible() to IsOverflowVisibleAlongBothAxes() to make it clear it applies to both axes. BUG=1087667 TEST=this is mostly a rename, so no direct tests. Once OverflowClip is enabled, there are layout tests exercising this. Change-Id: I5a4647a19e31c7ad212929bb9e408708fd61d441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402303Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807482}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38f0f40310d6..d1382ae74fac 2020-09-16 primiano@google.com Merge "iorap API: fix thread race when initializing the consumer library" 2020-09-16 treehugger-gerrit@google.com Merge "Roll trace processor" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3e6e58bed619a859b1cbc81fd370599ee7a209e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807481}
-
Scott Violet authored
This makes all methods of Tab/Browser throw an exception if used after the Tab/Browser has been destroyed. Hopefully this will make it easier to identify bad usage rather than NPEs slightly deeper in the stack. BUG=none TEST=none Change-Id: Id42839c5aca2061f811b5ec07aefd1e0f187d55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412550 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807480}
-
Dan Harrington authored
* > autotest ... base/strings/strcat.cc will now run tests for base/strings/strcat_unittest.cc * > autotest ... strcat no longer complains "strcat" is ambiguous, since strcat_unittest.cc is the only matching test file. * Fixed rare case where caching could use the wrong target. Change-Id: Id028b8d5477687bef02b6cd94688f74839d08964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407857Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#807479}
-
Josh Nohle authored
If contacts are removed from the allowlist, only the selected-contacts visibility private certificates need to be recreated. If the contact list changes, only the all-contacts visibility private certificates need to be recreated. (Ideally, we would only recreate all-contacts visibility private certificates if contacts are removed from the contact list, but we do not have this information.) These revocations need to occur so that unauthorized contacts do not have access to valid certificates. Previously, all private certificates were being recreated in both scenarios, which is safe but overkill. Fixed: b/168022980, 1123134 Change-Id: I9263e02f2cca72c5b350368d42596c5f2d5655e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412890 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#807478}
-