- 03 Jul, 2018 40 commits
-
-
Matthew Cary authored
This will be used for orderfile generation benchmarks. More precisely, they are thin wrappers around the system health benchmarks that make it more convenient to run orderfile generation. Bug: 843561 Change-Id: I5d3a2288d4f4a2f74004ef90f3cec0e4b44c7198 Reviewed-on: https://chromium-review.googlesource.com/1124161Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#572181}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ce3f7b384d77..c56c2429b0f6 git log ce3f7b384d77..c56c2429b0f6 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 hjd@google.com perfetto-ui: Plumb trace_processor to javascript 2018-07-03 hjd@google.com perfetto-ui: Add deferred Created with: gclient setdep -r src/third_party/perfetto@c56c2429b0f6 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I991045dc1e2a17250481a273b50bcd7a53d86b8a Reviewed-on: https://chromium-review.googlesource.com/1124379 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572180}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cbfa46069e2b..c61a0380486a git log cbfa46069e2b..c61a0380486a --date=short --no-merges --format='%ad %ae %s' 2018-07-03 nednguyen@google.com Revert "Only output the total histogram format if there is at least a single page that succeed" Created with: gclient setdep -r src/third_party/catapult@c61a0380486a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:859073 TBR=sullivan@chromium.org Change-Id: Iaa7a6b9160b2e0235e160f8014e48b85bc4e2a82 Reviewed-on: https://chromium-review.googlesource.com/1123945Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572179}
-
Hiroki Nakagawa authored
As a cleanup, this CL removes ResourceFetcher::AddWarningConsoleMessage() and instead implements ResourceFetcher::GetUrlsOfUnusedPreloads(). Before this CL, AddWarningConsoleMessage() printed warnings in the console via an implementation of FetchContext because ResourceFetcher is in platform/ and cannot access ConsoleMessage etc. To simplify layering around that, this CL makes ResourceFetcher return URLs of unused preloads and a caller (i.e., LocalDOMWindow) in core/ print warnings with the URLs. Bug: 845285 Change-Id: I241c9567ba79df0ec24f8817cf6045456e44b75b Reviewed-on: https://chromium-review.googlesource.com/1124137Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#572178}
-
Vadym Doroshenko authored
Now NewPasswordFormManager waits for server predictions for 500 ms before filling (kMaxFillingDelayForServerPerdictions const). But this const was taken arbitrary. This UMA measure time of receiving credentials from the password store and server predictions in order to understand which delay would be right. Bug: 831123 Change-Id: I42ee476fc949dca63fc7978b94998a20a1ac5e69 Reviewed-on: https://chromium-review.googlesource.com/1120253 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572177}
-
Guido Urdaneta authored
This fixes a bug where removing a device did not result in stopping all its associated streams. A unit test for this requires a minor refactoring to remove the MediaStreamManager dependency from MediaDevicesManager, and will be provided in a follow-up CL. This CL is deliberately simple in order to make merging easier. Bug: 856658 Change-Id: I84ef2856195cc7650bb08992d2095f8f853e9ea9 Reviewed-on: https://chromium-review.googlesource.com/1124323Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#572176}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0ea751539e3a..a8eb1e619eb9 git log 0ea751539e3a..a8eb1e619eb9 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 oprypin@webrtc.org roll_deps: Accept any prefix (like 'git_revision:'), not only 'version:' for CIPD 2018-07-03 ishankhot@fb.com Make ReceiveSendsFromThread use Dispatch 2018-07-03 sprang@webrtc.org Add sprang@ as owner of simulcast.cc/h 2018-07-03 buildbot@webrtc.org Roll chromium_revision a1981d69..f6935ecd (571936:572058) 2018-07-02 emircan@webrtc.org Add VP9 profile negotiation to SDP Created with: gclient setdep -r src/third_party/webrtc@a8eb1e619eb9 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:858978,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifef1fa58091510e43a491c29a74d787c9667284e Reviewed-on: https://chromium-review.googlesource.com/1124419Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572175}
-
Bence Béky authored
ResourceLoader is not used by network service, therefore Net.HttpResponseInfo.ConnectionInfo.MainFrame and Net.HttpResponseInfo.ConnectionInfo.SubResource histograms will not be recorded after network service launches. This CL obsoletes these two histograms, and a follow-up CL will add new histograms in the network service code path. Bug: 859546 Change-Id: I37e190c1ef060642c08f95314ce52428542a5a2d Reviewed-on: https://chromium-review.googlesource.com/1122712Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This reverts commit 6bdafce4. Reason for revert: This CL is breaking the child ordering of tabs creating with Long Press on a link -> Open in a New Tab. They are now opened after the last page opened with ToolsMenu -> Open New Tab. See crbug.com/859508 Original change's description: > Pass current tab as opener when opening new tab > > Pass the current tab as the opener when opening a new tab. > This allow selection the previous current tab when the > tab is closed via "pull-to-close" action or via the new > "close" action in the UI refresh. > > The current tab is passed when tab is opened via ([*] > denotes that this behaviour is added by this CL): > - open tab in background > - "New Tab" menu action [*] > - captive portal detection [*] > - search by image [*] > > Bug: 661988 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Iecf41a8c0b3cfe465b3ff95a1061c97739b4ed79 > Reviewed-on: https://chromium-review.googlesource.com/1068680 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561427} TBR=marq@chromium.org,sdefresne@chromium.org,eugenebut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 661988, 859508 Change-Id: I14e6f2350bad216381224aaf3319018e1c1ffdf1 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1124279Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#572173}
-
Marc Treib authored
This replaces SyncService::QuerySyncStatusSummaryString (which didn't really make a whole lot of sense in the first place) and SyncService::GetEngineInitializationStateString (which is now simply a subset of the new State). Bug: 839834 Change-Id: I9e3d9785a9bbafe5b8a7397b4a7c6c97acf9adf9 Reviewed-on: https://chromium-review.googlesource.com/1118223 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#572172}
-
Alexander Semashko authored
This is a prerequisite for switching WindowedNotificationObserver to use base::RunLoop instead of deprecated MessageLoopRunner. There were two nested waits for the same notification which does not make sense and does not work as is with the upcoming change. This CL was split out from https://crrev.com/c/982612 and uploaded by git cl split. R=jochen@chromium.org Bug: 668707 Change-Id: I217e5ea431d4a58b15ed1eef51a912142124c8b8 Reviewed-on: https://chromium-review.googlesource.com/1120488Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#572171}
-
Marc Treib authored
This adds tests FullStartupSequenceFirstTime and FullStartupSequenceNthTime, based on the new SyncService::State enum. To be able to properly test the full flow, this also introduces a MockSyncEngine (previous tests use a Fake, which bypasses some steps). Bug: 839834 Change-Id: I145becf840f476d73815526b8abd43a9bfa159b8 Reviewed-on: https://chromium-review.googlesource.com/1118383 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Kent Tamura authored
web_url_request.h is used in 3,600+ compilation units, and this CL reduces its estimated pre-processed size from 2.82MB to 0.31MB. Bug: 242216 Change-Id: I60209d15fd6faac4a2bab5696ef307a1b90d6b10 Reviewed-on: https://chromium-review.googlesource.com/1124254Reviewed-by:
-
Kent Tamura authored
resource_client.h is used in 1,600+ compilation units, and this CL reduces its estimated pre-processed size from 4.04MB to 1.73MB. Bug: 242216 Change-Id: Iae174451fe424d9765b0ada17c0fef8e9190839c Reviewed-on: https://chromium-review.googlesource.com/1124269Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#572168}
-
Kent Tamura authored
https://html.spec.whatwg.org/multipage/dom.html#html-element-constructors > 7. Let prototype be Get(NewTarget, "prototype"). Rethrow any exceptions. As the specification says, we should rethrow. Removing a v8::TryCatch instance in V8HTMLConstructor::HtmlConstructor() works as "rethrow". Bug: 854887 Change-Id: I6b2d6ae829453270fe4437a87e65528525c64990 Reviewed-on: https://chromium-review.googlesource.com/1124129Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#572167}
-
Ramin Halavati authored
Debug data is added to traffic_annotation_auditor_test to search for win-annotator-rel FYI bot bug. Bug: 844014 Change-Id: Ie0a8b34cb725b02fad08fbdc4e0918d373b9e1a7 TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1123832Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#572166}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7ce703ef..91a410dd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I009c94e1e7cd6df185ec31651dd7b550546cebfe Reviewed-on: https://chromium-review.googlesource.com/1124110Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572165}
-
Yoshifumi Inoue authored
This patch introduces a new test case for Element#innerText to verify that result has a collapsed whitespace due by soft line break. In the test case, the layout object associated to space character between <span> elements, doesn't have neither InlineTextBox and NGPhysicalTextFragment. Thus, Element#innerText implementation should detect this and handle it. Bug: 651764 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia25d06a2a3fe993f2e966188b81f9e9c1d0fe982 Reviewed-on: https://chromium-review.googlesource.com/1124264Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572164}
-
Olga Sharonova authored
This reverts commit c0d56727. Reason for revert: Win tests are still broken :( https://uberchromegw.corp.google.com/i/chromium.webrtc/builders/Win7%20Tester/builds/43887/steps/browser_tests Original change's description: > Fix fake audio setup in WebRTC audio perf tests. > > Change them to set up switches::kUseFileForFakeAudioCapture in > SetUpCommandLine(), so that it can be propagated to the audio process. > > Bug: 850936 > Change-Id: Ia6cccc01d2b5fa7545abe8cb1554d72c33146566 > Reviewed-on: https://chromium-review.googlesource.com/1122857 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572142} TBR=hbos@chromium.org,olka@chromium.org Change-Id: I0a9dffe2824ac3fff218193fabe5caa39cb2a5cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850936 Reviewed-on: https://chromium-review.googlesource.com/1124359Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#572163}
-
Javier Fernandez authored
We defined two LayoutBox elements list to identify grid items that need to perform a pre-layout: orthogonal and baseline items. We were creating these lists as part of the PlaceItemsOnGrid logic. This design has 2 main problems that lead to bug 855844, and likely many other: * The PlaceItemsOnGrid function is not executed completely if the grid is not dirty. * There might be items in the list that should not be there due to style changes; also, some should have been added for the same reason. The simplest and safest approach is to avoid such lists and identify the items needing pre-layout during the first steps of the grid's layout logic. Since style changes affecting either the writing-mode or the Self Alignment properties of a grid item will force a re-layout of the grid it belongs to, we can be sure that all the grid items will perform the pre-layout, if they needed to. Bug: 855844 Change-Id: I396524b0fc6a4816bcb7962997f129a325c04934 Reviewed-on: https://chromium-review.googlesource.com/1122623 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#572162}
-
Sylvain Defresne authored
This reverts commit 330fc4a1. Reason for revert: speculative revert to fix views_unittests (https://bugs.chromium.org/p/chromium/issues/detail?id=859829). Original change's description: > Make all MacViews windows potentially draggable. > > This fixes the PiP window not being draggable on Mac. > > Bug: 849983 > Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75 > Reviewed-on: https://chromium-review.googlesource.com/1121145 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572038} TBR=avi@chromium.org,sdy@chromium.org Change-Id: Ic1e718a03d272c2c1b4646ead018ad776d03fd18 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849983,859829 Reviewed-on: https://chromium-review.googlesource.com/1124299 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
jdoerrie authored
This change modifies base::win::Vector to use ComPtrs in the backing storage for types derived from IUnknown. Bug: 821766 Change-Id: Ib531a3e3c15e8cae1ec94de3f11b36d01b7a5acf Reviewed-on: https://chromium-review.googlesource.com/1120337 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#572160}
-
Dominik Röttsches authored
We tripped over this when adding Unicode 11 emoji. There is no need to introduce an additional obstacle for characters that the OS or our Emoji fallback code might already know about but our ICU might not have been updated yet. Bug: 850336 Change-Id: I0748ac5b755a2d8c3b92be9c9e21cf96ed75be16 Reviewed-on: https://chromium-review.googlesource.com/1122407 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572159}
-
Alexander Timin authored
Enable the feature by default and remove waterfall config. R=skyostil@chromium.org,rkaplow@chromium.org TBR=kenrb@chromium.org BUG=806271 Change-Id: I20627952407b2cb7926060b5d36d3ef5fa2db60e Reviewed-on: https://chromium-review.googlesource.com/1102505Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572158}
-
Kurt Horimoto authored
This CL creates ReadingListCoordinator, which uses UITableViews and replaces the old UICollectionView-based implementation. Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I59acbe85cb389c69462bb72ddb7858acb1249c55 Reviewed-on: https://chromium-review.googlesource.com/1104941 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#572157}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37774c911e68..d7425b58df89 git log 37774c911e68..d7425b58df89 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-07-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a72f400c5ff3..92da844eb754 (1 commits) Created with: gclient setdep -r src/third_party/skia@d7425b58df89 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I02bdfffe800af4d31a8cad450a8478410422c299 Reviewed-on: https://chromium-review.googlesource.com/1123946Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572156}
-
Mihai Sardarescu authored
This CL adds a unit tests for the unified consent service. The current tests only covers the non-personalized services. It should be enhanced to also include the sync-related part once teh unified consent starts managing the sync state. This CL also makes the following changes: * replaces the dependencies of the service on profile_sync_service with a dependency on the more generic sync_service * enabled Url-keyed anonymized data collection when unified consent is enabled. Bug: 823809 Change-Id: I2ab27429272ecccfbd254ffc4100234ce95623df Reviewed-on: https://chromium-review.googlesource.com/1122858 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#572155}
-
Gyuyoung Kim authored
As StagingbufferPool and ResourcePool, SoftwareImageDecodeCache has been only supporting the MemoryCoordinator. However, it is not enabled by default. So it would be good if we support the memory pressure handler until the MemoryCoordinator is enabled by default. Especially, it will help low-end devices to reduce memory usage under the out-of-memory situation. Bug: 856527 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0aace1839b9d0e056f1a2db18f5d9e652c742c5f Reviewed-on: https://chromium-review.googlesource.com/1122016Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#572154}
-
Makoto Shimazu authored
Previously SWNavigationLoader::Cancel() didn't clear |binding_| and it didn't delete itself. This CL is to close the binding explicitly and fixes the leak. Bug: 859415 Change-Id: I99a79f2f0cc21802bdd36d507c4c8692955cc3d9 Reviewed-on: https://chromium-review.googlesource.com/1122065 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#572153}
-
Mihai Sardarescu authored
Sync model type TYPED_URLS can be enabled only if the user has encryption, while HISTORY_DELETE_DIRECTIVES cannot be enabled then. So in order to check whether the user is sending history to google in a readable way, HISTORY_DELETE_DIRECTIVES is the better one. This CL changes the URL-keyed anonymized data collection helper to use HISTORY_DELETE_DIRECTIVES. Bug: 823809 Change-Id: Ideb0a6129750f7e0e122e82a0c932aa6acd7bdc6 Reviewed-on: https://chromium-review.googlesource.com/1122118Reviewed-by:
-
Lei Zhang authored
Change-Id: I09581a1f8459e5dcfd15815780531acd339e8130 Reviewed-on: https://chromium-review.googlesource.com/1123891Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572151}
-
Wang Qing authored
This CL fixes the build error with the following message: ../../base/allocator/partition_allocator/partition_alloc_unittest.cc: In member function ‘virtual void base::internal::PartitionAllocTest_PurgeDiscardable_Test::TestBody()’: ../../base/allocator/partition_allocator/partition_alloc_unittest.cc:1905:42: error: ‘PartitionAllocGeneric’ was not declared in this scope char* ptr1 = reinterpret_cast<char*>(PartitionAllocGeneric( ^~~~~~~~~~~~~~~~~~~~~ ../../base/allocator/partition_allocator/partition_alloc_unittest.cc:1905:42: note: suggested alternative: ‘PartitionAllocatorGeneric’ char* ptr1 = reinterpret_cast<char*>(PartitionAllocGeneric( ^~~~~~~~~~~~~~~~~~~~~ PartitionAllocatorGeneric ../../base/allocator/partition_allocator/partition_alloc_unittest.cc:1909:5: error: ‘PartitionFreeGeneric’ was not declared in this scope PartitionFreeGeneric(generic_allocator.root(), ptr1); Bug= 859785 R= haraken@chromium.org Change-Id: I6e06534ba78fa7a3742ec3585502d60943374b1a Reviewed-on: https://chromium-review.googlesource.com/1123931Reviewed-by: -
Zhuoyu Qian authored
Follow the spec[1], negative values are not allowed. We should reject the negative values of background-size during parsing. [1]: https://drafts.csswg.org/css-backgrounds/#background-size Bug: 825549 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ib260bafa421249aed471ff801c8b49a4b97aba1e Reviewed-on: https://chromium-review.googlesource.com/989529Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#572149}
-
Fergal Daly authored
The previous implementation gave the document the ability to forward a part from sub-component of a component but only the component author should be able to do that. Bug: 859446, 805271 Change-Id: I37dc9399646a2db677c350546cbb1cfad7ee2d39 Reviewed-on: https://chromium-review.googlesource.com/1122136Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#572148}
-
Gauthier Ambard authored
The -openerOfTab: method of the TabModel wasn't used. This CL removes it. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I79d219e52798a47da582d373b0b8e277e263a11e Reviewed-on: https://chromium-review.googlesource.com/1122631Reviewed-by:
-
Paul Irish authored
Bug:851311 Change-Id: Ia13bc1f082b69f37ee8ca65ac467cea166c11a2b Reviewed-on: https://chromium-review.googlesource.com/1120951 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#572146}
-
Anders Hartvoll Ruud authored
R=eae@chromium.org Bug: 851490 Change-Id: I0090986f81763d3c84f1245d5340286f9a3a1dff Reviewed-on: https://chromium-review.googlesource.com/1121463Reviewed-by:
-
Christian Dullweber authored
Session Storage is currently not properly tested by BrowsingDataRemoverBrowserTest because it is not supported by the SiteDataCounter and the CookieTreeModel. This Cl adds an integration test for its web-visible behavior. Bug: 843995 Change-Id: I3eac6903995e4b4773bbcc08bc3f551001a4cdbb Reviewed-on: https://chromium-review.googlesource.com/1113306 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#572144}
-
Daniel Bratell authored
There are two g_previews_factory now which causes issues with some jumbo builds. This renames one of them g_previews_service_factory. Change-Id: I05d4ab366239888e80fb32f782ac4e4880a8609f Reviewed-on: https://chromium-review.googlesource.com/1122131Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#572143}
-
Olga Sharonova authored
Change them to set up switches::kUseFileForFakeAudioCapture in SetUpCommandLine(), so that it can be propagated to the audio process. Bug: 850936 Change-Id: Ia6cccc01d2b5fa7545abe8cb1554d72c33146566 Reviewed-on: https://chromium-review.googlesource.com/1122857Reviewed-by:
-
