- 01 Dec, 2020 40 commits
-
-
Gavin Williams authored
When cancel scan request fails, a toast with error message will pop up, the scan will continue, and the scan progress page will keep showing. Bug: 1059779 Change-Id: I9ba3a7a29837f55e8b166224949be1d403e3661c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559496 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#832156}
-
Brian Sheedy authored
Increases the timeout for GPU info collection on Mac Debug builds, as tests are flakily hitting the 5 second default timeout. Bug: 1153667 Change-Id: Ica5608d53d6c65a9a0af9c6ec69829346a348b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566695 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#832155}
-
John Abd-El-Malek authored
Bug: 1147533 Change-Id: If7d3cf96c9f101663e6fdb960378565639b88121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558959 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#832154}
-
Elly Fong-Jones authored
Currently the field is only labelled by its placeholder text, which is not read by all screenreaders. This change gives it an explicit accessible label instead. Bug: 1083307 Change-Id: I7b79de41576c9a9c4caf33ef54a5009329d3d0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538531Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#832153}
-
Aleks Totic authored
Adds flag to enable TablesNG to Chrome. Off by default. Plan is for tables to be feature complete by Dec 4th. This is the first public step towards TablesNG release. Bug: 958381 Change-Id: Idce9980395cbfc860fa4fd5834e56db9bc7cdfc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566251 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#832152}
-
Thomas Guilbert authored
This CL [1] used video.requestVideoFrameCallback() to deflake tests. crbug.com/1084265 fixed flakiness issues when capturing video frames at the end of a test. The combination of the two means that some tests that are marked as flaky could potentially be re-enabled. This CL enables theses tests, and also updates video-zoom-contols.html to use video.rVFC. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2208866 Bug: 636239, 988248, 1082837 Change-Id: I2c1fc2d481ba95fac7232f0050386eac9c13726c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556443 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#832151}
-
Kunihiko Sakamoto authored
Bug: 862003 Change-Id: Ic430f97ac38987aa3bc9f3bf9c4e4c4468898dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560364Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#832150}
-
Fergal Daly authored
In Frame::Swap, don't clear provisional_frame_ until after calling DetachDocument, this leads to calling the unload handler and then calling Frame::Detach (from HTMLFrameOwnerElement::DisconnectContentFrame). We need provisional_frame_ to be populated when we reach https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/frame/frame.cc;l=143;drc=c5b0c68b26eadd812ec19d88327e3dbf5a4c6477 After moving that, this fixes several places where the frame has been deleted and the code was not expecting it. Bug: 1148793 Change-Id: I21db092ad30561e4705dcd54203407a342d8cfa7 Fixed: 1148793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551883Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832149}
-
Alan Cutter authored
This CL adds metrics for how often preinstalled web apps migrate and remove an existing app install. This data is useful to monitor rollouts of default web apps that are replacing old Chrome apps to ensure the migration is happening as expected. Bug: 809304, 1058265 Change-Id: Ie9edb4a1cf89e84d7e56a20bad028dd8ea1aeb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561999 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#832148}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/146912bb62b7..5537c0394234 2020-11-30 bikineev@chromium.org PCScan: Add metrics for PCScan. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:11297512 Tbr: wenbinzhang@google.com Change-Id: I6c6a6a176648c3068c511ac58f9e664f17e0e145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832147}
-
Ken Rockot authored
This ensures that dangling AsyncDomStorageDatabase references are properly cleaned up when the database is freed during LocalStorageImpl shutdown, preventing UAFs in potentially already-scheduled tasks which would otherwise attempt to use those references. Fixed: 1152800 Change-Id: Ic98a00d4605aed61f3dee4a2cb9b0c14f3ebf868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565711 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#832146}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/236d4f36e63d..d96af00c9286 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xialinyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131897 Tbr: xialinyan@google.com Change-Id: I3e14a5e150bfc3b1fe0f8af1aa1fb0696912435f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566491Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832145}
-
Jeffrey Kardatzke authored
BUG=b:153111783,chromium:1141237 TEST=With flag, clear HEVC can be played back, fails otherwise Change-Id: I0549d81600ad33d257d72c2b03b3079b098afb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566291 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#832144}
-
Nancy Wang authored
When using Alt + Tab to switch between the app windows, there is no icon for Crostini app windows. This CL adds |CrostiniAppWindow| to load icons for Crostini app window widgets to show Crostini app icons on windows when switch with Alt + Tab. BUG=1116251 Change-Id: I2e2b4669c56151c800b3580c10198992fd9ca8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563381 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#832143}
-
Chris Harrelson authored
A previous CL (*) already did this up to the first observation. Now we enforce it for all times content skips and unskips. The rationale for this change is that content-visibility is a UA-controlled best practice, and it is mostly up to the UA to avoid layout shifts when using this feature. Note that there will still be layout shifts reported for elements adjacent to (but not descendants of) content-visibility:auto elements if the content-visibility:auto element resizes and causes a shift. The change in this CL applies only to the content-visibility:auto element itself. Bug: 1151526 Change-Id: Ie3aed71b2f2500ea799c7bf77dbdd28e60a9175a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566270Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#832142}
-
Shrek Shao authored
Add readPixels validation for RGBA / UNSIGNED_SHORT combination. This is only valid with EXT_texture_norm16 extension enabled. Bug: 1152259 Change-Id: I0e10b7d29f3b362c4054500270bbad87dcde599f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559797 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
-
Akihiro Ota authored
There was a recent regression in the search the menus behavior where search results were not being read aloud to the user; however, the issue no longer reproduces as of 89.0.4342.0. To catch possible regressions in the future, this change adds speech expectations to the existing search the menus test. Bug: 1151102 Change-Id: I201b8b12dfbf2025f42ced93ade5ac4c63c5c1a3 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565737Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#832140}
-
Mustafa Emre Acer authored
Bug: 1153761 Change-Id: I0ccd25212c03c0b62609205f3f92fb965cbb2e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566732Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#832139}
-
Jinsuk Kim authored
In preparation of 100% stable rollout, this CL turns on the feature by default, and deletes the field trial configuration. Bug: 1128629, 1006111 Change-Id: I03b8af9c5a3bbcb2b5ff20b567c86366e3122217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561910 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832138}
-
Meilin Wang authored
Bug:1150634 Change-Id: Ia9ac840f9d8eccf75ddb40d2dd55007e2e4a53ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556444Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#832137}
-
Joe DeBlasio authored
This reverts commit a6c2104c. It also adds iOS to the list of impacted platforms. Reason for revert: crbug.com/1152130 Original change's description: > [Lookalikes] Enable target embedding by default on ToT. > > Bug: 1076617 > Change-Id: I5d818d4db60fad9e4cdc8e862d82a5bff6372560 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505583 > Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> > Commit-Queue: Steven Holte <holte@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821978} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1076617 Change-Id: I43c31dc635ae879aa3ad3a326ea48cf49751f735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555466 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#832136}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f37338cdaa21..42433abb9596 2020-11-30 primiano@google.com Cleanup for Windows standalone support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Change-Id: If45d2cca32d624a563965b05b16091e8b5e3cca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566871Reviewed-by:
-
Yuki Yamada authored
This is a follow-up for https://crrev.com/c/2222362. Add configs for the new analyzer to enable it on Gerrit. Bug: 1058341 Change-Id: I0a3284bc0031be782002d87ec7350bf17eb4e906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560519Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#832134}
-
Henrique Ferreiro authored
Leftover from cleanups from the related bug. Bug: 688943 Change-Id: I32e81561ffc0834874203f1e1c16443d6156924e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563542 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Koji Ishii authored
New expectations were created due to renames of tests at: https://github.com/web-platform-tests/wpt/pull/26588 This patch removes old expectations. TBR=tkent@chromium.org Bug: 1151800 Change-Id: I772fecea73d0987bda9d85e52ae390c0736ddd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567070Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#832132}
-
Pedro Tôrres authored
Previously only "org.h5l.kcm" was allowed, but user reports indicate needing to access the "com.apple.GSSCred" service as well. R=kerrnel@chromium.org, rsesek@chromium.org Bug: 1134449 Change-Id: I4c61c82f448de8409c5e5cf3878451a4d69e1264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560804Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#832131}
-
Ken Rockot authored
There are three WebUIs defined in Content which use Mojo: - gpu - process-internals - conversion-internals These are adapted here to use newer Mojo JS modules. Bug: 1004256 Change-Id: If766eb81599d9311b79076011a8ac1d08f343927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555806Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#832130}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/619ae0038825..3f564fc76ea8 2020-11-30 jmadill@chromium.org EGL: Generate entry points. 2020-11-30 paulthomson@google.com Capture/Replay: track swapWithDamage 2020-11-30 jmadill@chromium.org Rename FromGL to PackParam. 2020-11-30 jmadill@chromium.org EGL: Generalize the entry point enum. 2020-11-30 jmadill@chromium.org Vulkan: Use XFB queries with the XFB extension. 2020-11-30 syoussefi@chromium.org Fix ordering of stages in gl::ShaderType If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I04ee7198176350554faa969c042ef13b4df166dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566210 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Michael Crouse authored
This change decouples detecting the language of text from the model inference of CLD3. This will enable the TFLite-based model to rely on the same detection utilities that are not model specific. Bug: 1151409 Change-Id: I7780a9a66efe8b0f1cdf765cfc838a4e98954f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560662 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832128}
-
Kelvin Jiang authored
aria-hidden=true is set on the toast when it's hidden, and removed right before the toast is shown. Tested manually for chrome://extensions on Mac using VoiceOver Bug: 1084193 Change-Id: I5f11f5beec4facb52a6ab41fc34bc8b2a9d33651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559733Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#832127}
-
Rakina Zata Amni authored
Currently we have is_overriding_user_agent in DidCommitProvisionalLoadParams to indicate if user-agent override is used when loading a document. This information can be known entirely in the browser side by checking the NavigationRequest's is_overriding_user_agent for cross-document navigations, and reusing the last value for same-document navigations - this CL adds is_overriding_user_agent_ to RenderFrameHostImpl for this purpose. This CL also adds DCHECK_EQs for is_overriding_user_agent calculated in the browser vs the value sent by the renderer, and DumpWithoutCrashing for this param is added in https://crrev.com/c/2557877. See DidCommitProvisionalLoadParams removal doc: https://docs.google.com/document/d/18FeFEnfH_hTeGH7b_qkIto8pGtxdU54msnPlWo-qldA/edit Bug: 1131832 Change-Id: I569f5454c2efcac58c5e31470ae08f41b060717f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398000 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b589fd27351..4c6f57a23e63 2020-11-30 tdenniston@google.com [svg] Use new code path for rest of presentation attrs 2020-11-30 bsalomon@google.com Remove GrRenderTargetContextPriv and GrSurfaceContextPriv 2020-11-30 reed@google.com move SkMipmapBuilder to private If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I6eb02db08d9b1182a6414bf4ad849dbb520ee159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566650Reviewed-by:
-
Thomas Guilbert authored
This CL updates video-layer-crash.html to use video.requestVideoFrameCallback() and guarantee that a frame is outputed before ending the test. Bug: 1082868 Change-Id: I7d75319a50f1f5eae07d3644e148c6cdf8558c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560879 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Lijin Shen authored
1. Remove fixed height 2. A padding on top & bottom 3. A max width on title and primary button to make it wrap text correctly A demo: https://hsv.googleplex.com/4791153801035776 Bug: 1152524 Change-Id: Ie8072005affac41a9be7abd2c1a06ff419808ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565384Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
-
Reid Kleckner authored
R=dcheng@chromium.org, mlippautz@chromium.org Change-Id: I52a8377e4811edb4f6f32dbb1749b3dfd03a4467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561108Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#832122}
-
Nina Satragno authored
Improve handling conversion between a byte and a CtapDeviceResponseCode: * Fix undefined behaviour from static_cast'ing a byte before verifying it's in the CtapDeviceResponseCode enum. * Log the byte we actually received when we get an error, instead of converting the response code back into a byte. This way, we log codes we don't know about and save me some emabarrassment when reporting bugs to authenticator vendors. * Convert the list of codes into a shiny new constexpr flat_set. Now we don't have to manually increase the array size to avoid the compiler yelling at us. * Add some missing CTAP codes. * Add a logging for bad GetInfo responses. Fixed: 1148479 Change-Id: Ic8966f4c881d4a6c7872ed8dc6cbf1a5fd05377a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562973 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#832121}
-
Andres Medina authored
A previous fix attempted to remove some warnings. Some source_sets were not using the private_config needed to build. Adding the private_config. Bug: 1152807 Test: CQ Change-Id: I8f8f4a74affd161e7a39a99e43a8060d8421b4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566371 Auto-Submit: Andres Medina <medinaandres@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#832120}
-
Changwan Ryu authored
Integrate the core logic into AwContents for Android P and above. Note that we are now using DisplayMode to check the fullscreen status. Adding basic instrumentation tests require some plumbing into test activity and its rule since we need to hide action bar *before* setting the content view. Bug: 1094366 Change-Id: I7296038f894861f68c57c025caa6a70ea9b69ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299461Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#832119}
-
Ken MacKay authored
Never queue audio data, and limit to only one copy of other messages. In particular, if a loopback receiver stopped receiving messages, the mixer's send queue (for the audio data) could grow without bound, leading to OOM. Merge-With: eureka-internal/492543 Bug: internal b/165017599 Test: on device Change-Id: Ib66c9f00fd4f451e8bba66e6586f9023cd1bc668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555726Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#832118}
-
Zhaoyang Li authored
git grep -l '12b5035g' | xargs sed -i '' -e 's/12b5035g/12b5044c/g' Bug: 1148325 Change-Id: Ifa509da0edd67c3666bf09345c8793d63274338f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566736Reviewed-by:
-
