- 16 Apr, 2018 37 commits
-
-
Friedrich Horschig authored
Right now, clicking the X button in the search will close it. To start a new search, you have to open a new search. That experience isn't very discoverable, so UX developed an improved workflow - details in the bug. The new flow needs these changes: - the X button _only_ clears the query text field now - the X button is _only_ available when a query was entered - closing the search happens only via the "navigate up" button in the action bar. - the three-dots overflow menu is hidden while a search is active (already the case on small screens - now large screens do the same) Tests cover all of these cases. Bug: 821755 Change-Id: Ieb2e16c096750d66874aa4c4999759629332491b Reviewed-on: https://chromium-review.googlesource.com/966070Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550955}
-
jdoerrie authored
This change fixes a subtle bug in TestCallbackReceiver, renames StatusCallbackReceiver to ValueCallbackReceiver and adds usages where appropriate. Bug: 785955, 799044 Change-Id: Iac686ec59c48e33d75155e67d615a6bdb4c042a0 Reviewed-on: https://chromium-review.googlesource.com/1009744 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550954}
-
Gauthier Ambard authored
This CL fixes the navigation using the popup menu. The navigation was crashing because the command protocol is only implemented by the legacy class. Bug: 833120 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I31268facd31c035a4bb0ff72d6d235f9789a8d14 Reviewed-on: https://chromium-review.googlesource.com/1013977Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#550953}
-
Marc Treib authored
Bug: 825190 Change-Id: I166418dc7691b572abdee1f337c938528142efca Reviewed-on: https://chromium-review.googlesource.com/1007236 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#550952}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1f02393d. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15649 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: Ifee54a7711ff1d23672c801c7fbd8ca5894ea642 Reviewed-on: https://chromium-review.googlesource.com/1013742 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#550951}
-
Joone Hur authored
When the build flag enable_native_notifications = false, a build error happens. This CL adds ENABLE_NATIVE_NOTIFICATIONS guard to fix this problem. Bug: None Change-Id: I2ab67b9f41898404eb3096f25c6dbd9ac31b7255 Reviewed-on: https://chromium-review.googlesource.com/1012728Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#550950}
-
Matt Falkenhagen authored
The strings just get converted to URLs. Simpler to just use URLs directly. More cleanup for the linked bug in preparation for more unit tests. Bug: 830288 Change-Id: Ie467b841ee8c07a2bf22c26d4151c1711943f69f Reviewed-on: https://chromium-review.googlesource.com/1013022Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550949}
-
Alan Cutter authored
This CL cleans up the LocationBar interface. LocationBar::ShowPageInfoDialog() was only ever used with the LocationBarView implementation of LocationBar and can be removed from the higher level interface. There are no behavioural changes in this CL. Bug: 828278 Change-Id: Ied8af6849f16bda72bb89c7f5fcffdfd599adcbe Reviewed-on: https://chromium-review.googlesource.com/1011884 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550948}
-
Hiroki Nakagawa authored
This test was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/985334 Bug: 825740 Change-Id: I5c732d2aa828ccecbe1f39ea79f168ee798521bb TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1013818 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Philipp Hancke authored
and remove the class from any past ones. Re-land of https://chromium-review.googlesource.com/c/chromium/src/+/615500 (with JS error fixed) BUG=678292 Change-Id: Icedc03ed30e2f4c0d36341db371ef3d12a679a94 Reviewed-on: https://chromium-review.googlesource.com/986139Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#550946}
-
Fergal Daly authored
Looks like there is no way to set the title explicitly, it just comes from the first section name. Change-Id: Ie7b451aeb212576df09f1e2da77b9f5e1141dc9d Reviewed-on: https://chromium-review.googlesource.com/1013667Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550945}
-
Blake O'Hare authored
This reverts commit 4204e85d. Reason for revert: Multiple people are noticing the following fatal error on startup. It's preventing Chrome OS from starting (noticed on an Eve and a Cyan). Testing with and without this change indicates that this CL is the cause: [5643:5757:0416/141408.095095:ERROR:bus.cc(551)] Failed to get the ownership of org.chromium.UrlHandlerService: Connection ":1.102" is not allowed to own the service "org.chromium.UrlHandlerService" due to security policies in the configuration file [5643:5643:0416/141408.181175:FATAL:cros_dbus_service.cc(77)] Failed to own: org.chromium.UrlHandlerService Original change's description: > Add ash D-Bus framework & service for opening URLs with Chrome > > This adds a small D-Bus service framework to ash and then adds an > initial service that has one call "OpenUrl" which will then > open a new tab in Chrome with that URL. This is intended to be used by > Chrome OS clients that want to open a URL with Chrome; initial usage > will be from VMs. > > Bug: 822496 > Bug: 831333 > Test: Verified with dbus-send that links open properly > Change-Id: I648af624817cd387f30aba751c7f465e0dcc60e0 > Reviewed-on: https://chromium-review.googlesource.com/998081 > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550900} TBR=derat@chromium.org,xiyuan@chromium.org,hashimoto@chromium.org,stevenjb@chromium.org,sky@chromium.org,jorgelo@chromium.org,benwells@chromium.org,mnissler@chromium.org,dominickn@chromium.org,jkardatzke@google.com,mkwst@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822496, 831333 Change-Id: Ie7ea0e469116c7b1968cf929c378d9bceaeb9e1d Reviewed-on: https://chromium-review.googlesource.com/1013799Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550944}
-
Luciano Pacheco authored
This fixes a "ghost" focus, where the tab puts the focus on the content panel/div and there isn't any visual clue about it. I tested screen reader/Chromevox and it wasn't reading anything when content panel/div was focused, also it doesn't seem necessary for any keyboard event handling, so it seems safe to remove and not have focus on this element. Bug: 779044 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0453792d1aa33918773f982944fc7358bece8587 Reviewed-on: https://chromium-review.googlesource.com/1004889Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#550943}
-
https://pdfium.googlesource.com/pdfium.git/+log/b71d24c1affe..d5624a47bcaa $ git log b71d24c1a..d5624a47b --date=short --no-merges --format='%ad %ae %s' 2018-04-16 stackexploit Fix UAF in CFGAS_FontMgr::FindFont Created with: roll-dep src/third_party/pdfium BUG=chromium:832589 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia438998e67a9a01581120da381761354ad454962 Reviewed-on: https://chromium-review.googlesource.com/1012725 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550942}
-
Matt Falkenhagen authored
These will be useful for planned unit tests for SharedWorkerHost which will be in its own test file. Also: * Add missing EXPECT_TRUE for some Check*() calls, which return a bool. * Remove calls to deprecated RunAllPendingInMessageLoop(). * Change some CHECK to DCHECK and rm unneeded includes. Bug: 830288 Change-Id: I3f7ed117fdde4d859047f6e95b5080119857daec Reviewed-on: https://chromium-review.googlesource.com/1013817 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This is a remaining task from https://chromium-review.googlesource.com/c/chromium/src/+/1009448 We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: Iefa7d73db427177eab41481a396be7aa42fbf230 Reviewed-on: https://chromium-review.googlesource.com/1012042Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550940}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: Ib390ab3a726e1a825aa81d0c76e972f455c31ca4 Reviewed-on: https://chromium-review.googlesource.com/1013499 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL fixes undesirably large insets on the hosted app menu button that get set when command line flags "--top-chrome-md=material-touch-optimized --enable-features=SecondaryUiMd" are used on chromeOS causing the menu icon to get cropped. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=334387&signed_aid=zaosvDPanfssI1aE7ljaww==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=334388&signed_aid=sVoIaJthm75DLZgxqr06fA==&inline=1 Bug: 831968 Change-Id: I20bcc33aef41a0e0872170e7751502936c63ded4 Reviewed-on: https://chromium-review.googlesource.com/1011922 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#550938}
-
Noel Gordon authored
One part of solving the issue at hand was to examine the call order of the browser test setup routines. Moreover setup routines should prefer CHECK (fail fast with a stack trace). SetUpCommandLine happens just after SetUp: move them together, and put them in call-order. SetUpOnMainThread happens just before StartTest, so move them together similarly. SetUpOnMainThread needs a Profile to work at all. Add CHECK (to make that need somewhat clearer), and prefer CHECK in this routine body in general (it's a setup routine). StartTest is called right after SetUpOnMainThread: every test resource needed for testing is (or should be) ready at that time. Add LOG(INFO) here to show when StartTest is called, relative all other LOG tracing, since any test-related output that appears before this point indicates that "things have gone horribly wrong". Bug: 831074 Change-Id: I725413ad53592cb430ecf669e7ad2c50fdddead4 Reviewed-on: https://chromium-review.googlesource.com/1013838 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550937}
-
yoshiki iguchi authored
Bug: none Test: none Change-Id: I82e9024750d40c520f8ff468454dc4a9b001b027 Reviewed-on: https://chromium-review.googlesource.com/1004976Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550936}
-
Patti authored
This patch removes the 1px outline on LocationBarView and switches to using a views::FocusRing in touch mode. See screenshots - https://drive.google.com/file/d/1g4O_mh4oPb8PJIAb7pjDq0rK32KIUUvP/view?usp=sharing Bug: 801583, 829574 Change-Id: I6498ff15d3b1be6a03cab92e9aae8971b54c358e Reviewed-on: https://chromium-review.googlesource.com/1002716 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550935}
-
https://chromium.googlesource.com/catapult.git/+log/f718fb12b8cf..ac39bc379194 $ git log f718fb12b..ac39bc379 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 dtu [pinpoint] Add `isolate_server` argument. 2018-04-11 dtu [pinpoint] Add `swarming_server` argument. 2018-04-10 dtu [pinpoint] Include error message in bug comment. Created with: roll-dep src/third_party/catapult BUG=chromium:822008,chromium:822008 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I0203fc0ce59468f36ac6f5ef29258985aa74d47c Reviewed-on: https://chromium-review.googlesource.com/1013232Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550934}
-
Blake O'Hare authored
When dragging the keyboard to a new display, the keyboard should appear in the part of the display closest to where the keyboard was on the previous display. This is implemented by containing the bounds of the keyboard in global coordinates using the bounds of the new display. Change-Id: Ie650529fd6bb66da2108b47e8aafab43ddd43856 Reviewed-on: https://chromium-review.googlesource.com/1011484 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#550933}
-
Noel Gordon authored
The integration test extensions send messages to the system under test and also to the browser test harness (messages head in both directions no matter how you depict the test system). Add commentary to sendTestMessage to state where (or to whom) messages are sent to. Explain the expected message format, add code to throw if callers don't use that format (throw breaks browser tests). Bug: 831074 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia8085b3ebd28b7b001e7a5bfae4d883cdbd5660e Reviewed-on: https://chromium-review.googlesource.com/1013359Reviewed-by:
-
Jiaquan He authored
This is a reland of de013df9 It was reverted in d35f7c61 for breaking Linux ChromiumOS MSan Tests. The reason is StringOrdinal passed over mojo can be empty, and deserializing will fail for the data view with empty data. Crash logs: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F6545%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FCrashRestoreComplexTest.RestoreSessionForThreeUsers%2F0 Original change's description: > Reland "app_list: merge AppListViewDelegate into AppListClientImpl in Chrome." > > This is a reland of db8976b8 > > Original change's description: > > app_list: merge AppListViewDelegate into AppListClientImpl in Chrome. > > > > This commit does a few things: > > > > - merges the Chrome AppListViewDelegate into AppListClientImpl; > > - cleans up unused references; > > - updates methods to proper accesses. > > > > Ownership of major classes: > > > > - Each user has its own AppListSyncableService, and it holds its own > > AppListModelUpdater, ModelBuilders, etc. > > - There's only one AppListClientImpl in ChromeBrowserMainExtraPartsAsh > > shared by all users, and it holds Search classes, a mojo pointer to > > the AppListControllerImpl in Ash, etc. > > - There's only one singleton AppListServiceImpl shared by all users, > and > > it holds AppListControllerDelegateImpl. > > > > Their lifecycles: > > > > - Among these classes, AppListClientImpl is the first to be initiated, > in > > PreProfileInit. It binds to AppListController in Ash, and then tells > > AppListServiceImpl two pointers (AppListController*, > AppListClientImpl*). > > - When AppListServiceImpl receives the two pointers, it should have > been > > initiated as a singleton. > > - The AppListClientImpl is associated with the current active user > profile > > when it's accessed from AppListServiceImpl. > > > > Bug: 733662 > > Change-Id: Iac6de011185bf88c4b3c575871b69bd7a67c340b > > Reviewed-on: https://chromium-review.googlesource.com/974660 > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Jiaquan He <hejq@google.com> > > Cr-Commit-Position: refs/heads/master@{#546247} > > Bug: 733662 > Change-Id: Ia779e0ec795a9457dc7214f38b528c2dab688b90 > Reviewed-on: https://chromium-review.googlesource.com/991232 > Commit-Queue: Jiaquan He <hejq@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547956} Bug: 733662 Change-Id: Idf1d0aee42eecda00aa2200554df533b4eaa717e Reviewed-on: https://chromium-review.googlesource.com/996054 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550931}
-
Sasha Morrissey authored
Change the ChromeOS Audio Player to no longer use panels, but behave as a regular app. Panels are now deprecated. See the bug for more details. Bug: 800990 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia081ac12da133a31ca89719b501b373152a0441c Reviewed-on: https://chromium-review.googlesource.com/1011863Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#550930}
-
Robert Ma authored
1. Some expectations can be consolidated (some tryjobs did not finish during the original imports, and expectations were added in later imports). 2. Filed a separate issue for wpt/accelerometer/Accelerometer.https.html TBR=cbiesinger Bug: 833215, 833093 Change-Id: If23c7188c0c74e525e362f8fd39dccc1c5f11aab Reviewed-on: https://chromium-review.googlesource.com/1013739Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#550929}
-
Yoshifumi Inoue authored
This patch changes "table-delete-00[123].html" to utilize |selection_test()| for ease of maintenance. Bug: 679977 Change-Id: Ia7eafc1acac5f6764c2358b87e00304873d0bb9f Reviewed-on: https://chromium-review.googlesource.com/1009502Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550928}
-
Patti authored
The omnibox drop-down/pop-up should be 4dips larger than the LocationBarView in touch mode. Also make sure each omnibox result entry's height matches this. Bug: 829951, 801583 Change-Id: Ib0e811c057ee4908e620d2761b1b85e6f1253618 Reviewed-on: https://chromium-review.googlesource.com/1005650 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550927}
-
Dominick Ng authored
This CL allows installed desktop PWAs on Chrome OS to appear as an option in the intent picker. If the user chooses to open the current URL in the PWA, the current web contents will be reparented to the app container. Following UI review guidance, the persistence toggle is disabled for desktop PWAs as the underlying system does not yet support persisting the user's choice. The checkbox is re-enabled if an ARC app is selected. The Arc.IntentHelper* UMA histograms are deprecated in favour of new, app-platform generic histograms, and will be removed in an upcoming milestone. BUG=824598 Change-Id: I292ffc8cca9212483f0c0e1359610d3d0c40c633 Reviewed-on: https://chromium-review.googlesource.com/991495 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#550926}
-
Koji Ishii authored
This patch rebaselines image and/or text failures after the list marker change in CL:994915. The CL prevents list markers overlapping with previous content by including the list marker height into the list item. While it is slightly differnet from what Blink does, I think this is reasonably close to rebaseline, given the behavior is not well- defined and Gecko behaves differently. We may revisit this if this difference turned out to be more significant than I think. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 725277 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I773bc19ca2d27c96266d15d75b8f20de12952b30 Reviewed-on: https://chromium-review.googlesource.com/1013674 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#550925}
-
Kent Tamura authored
Use //third_party/pywebsocket instead. * tools/remove_stale_pyc_files.py We should walk in bottom-up order in order to remove nested directories containing only *.pyc. Change-Id: I7adff11285218025ab80f4f8e1a8fc9d039c4385 Reviewed-on: https://chromium-review.googlesource.com/1004567Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#550924}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f9aceec4. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15635 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I513f54d1c15546c1b538f49560b442db0fa54f87 Reviewed-on: https://chromium-review.googlesource.com/1012540 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Changwan Ryu authored
We purge trace events directly as the kernel debug messages in trace_event_android.cc, but that method does not allow tracing events to be written *after* the event occurrence. This CL introduces ScopedSysTraceEvent as an alternative to EarlyTraceEvent, and we use Android's Trace.beginSection() and Trace.endSection() to record trace events, and adds trace events for startup tasks. Note that we are adding it only for WebView because 1) It only works for API level >= 18. 2) We enable systrace for WebView startup perf tests anyways, presumably in order to understand the surrounding context better. BUG=817644 Change-Id: Ib4db5ac649d5b54aabedbaccc3e589e4ee9511dd Reviewed-on: https://chromium-review.googlesource.com/1008907 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550922}
-
Tatsuhisa Yamaguchi authored
The feature was disabled on MTP volumes because older implementaiton didn't work on MTP volumes (crbug/486397). The packing function of Zip Archiver works on MTP volumes. Bug: 831525 Test: Manually tested by zipping file on a connected MTP device. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I61830c5853e7290295ed01f4cfe439f68dfb2480 Reviewed-on: https://chromium-review.googlesource.com/1006741Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550921}
-
Koji Ishii authored
Following bot results are included. 4777 4794 4795 25 lines were removed and 7 lines were deflaked by consecutive results since 4741. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib4d7282210cc8fe0052af86548b8a8373a6f714e Reviewed-on: https://chromium-review.googlesource.com/1012045 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Avi Drissman authored
BUG=775534 NOTRY=true TBR=steimel@chromium.org Change-Id: I9005481e06d66bdd3ca4a123337f4a6da598a342 Reviewed-on: https://chromium-review.googlesource.com/1013717Reviewed-by:
-
- 15 Apr, 2018 3 commits
-
-
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I25e98088935100e51500cd60ac8d6b53ed0a648a Reviewed-on: https://chromium-review.googlesource.com/1013223Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550918}
-
David Black authored
Bug: b:77866848 Change-Id: I6462c7159233f26838fbef66328cd49af8f887af Reviewed-on: https://chromium-review.googlesource.com/1005565 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#550917}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ce767403. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15632 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I92dfe2b3d99adc3731281027b82c086e5c195b2d Reviewed-on: https://chromium-review.googlesource.com/1013601 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
