GitLab

VkSubmitInfo::pWaitDstStageMask must be must be a valid pointer
to an array of waitSemaphoreCount valid combinations of
VkPipelineStageFlagBits values.

Bug: None
Change-Id: I23fe8210f724cbb11c48e6dcab7e6452fe0cab3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630540Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663773}

Remove aura::Env from WMHelperCastShell:
Upstream has removed aura::Env from the WMHelper interface, this CL
removes it from the CastShell specialization as well.

NoGnCheck views_delegate:
The header include and dep in the BUILD.gn file are both guarded
correctly, but gncheck still thinks the include is illegal. Don't
gncheck the include.

Bug: b/133174544
Test: Chromecast build
Change-Id: Id5de601311c8285416172cb1e97b74957f341fd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628999Reviewed-by: Sergey Volk <servolk@chromium.org>
Auto-Submit: Fergus Simpson <afergs@chromium.org>
Commit-Queue: Fergus Simpson <afergs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663772}

* Emit ATK focus and object:state-changed:focused events in response
  to ax::mojom::Event::kActiveDescendantChanged
* Add ATK_STATE_FOCUSED to the state set of the active descendant
* Update tests to reflect new events and states

Bug: 959857
Change-Id: Idb97671e1c4f65aa293e1e4e7dbd5a9ecf47fb2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631404Reviewed-by: Martin Robinson <mrobinson@igalia.com>
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/master@{#663771}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=benmason@chromium.org

Change-Id: I49ef7868dfc7aedf4ad44ecf26dd9ef5884fdb91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632552Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663770}

https://android.googlesource.com/platform/external/perfetto.git/+log/6925d000325a..5ca8b4622a59


git log 6925d000325a..5ca8b4622a59 --date=short --no-merges --format='%ad %ae %s'
2019-05-28 eseckler@google.com Merge "public: Only build on platforms with IPC support for now"
2019-05-28 ilkos@google.com Merge "Allow final metrics result to be empty"
2019-05-28 lalitm@google.com Merge "metrics: fix crash when metric name not found"
2019-05-28 lalitm@google.com Merge "metrics: add tests for protobuilder functions"
2019-05-28 lalitm@google.com Merge "trace_processor: add support for text proto out and interactive metrics"
2019-05-28 treehugger-gerrit@google.com Merge "Fix chrome build"
2019-05-28 lalitm@google.com Merge "trace_processor: add support for proto and sql metric from shell"
2019-05-28 lalitm@google.com bazel: remove support for generate descriptors
2019-05-28 lalitm@google.com Merge "metrics: add support for extension fields in descriptors"
2019-05-28 lalitm@google.com Merge "metrics: add support for non-message repeated fields"
2019-05-28 khokhlov@google.com Merge changes Ie6400c7f,Ia8ac1a7f
2019-05-28 lalitm@google.com Merge "traceconv: bump shas"
2019-05-28 lalitm@google.com Merge "protos: add descriptor set build import"
2019-05-28 hjd@google.com Merge "Add zlib to buildtools"
2019-05-28 lalitm@google.com perfetto: ensure that ftrace descriptor is only built in standalone
2019-05-24 lalitm@google.com trace_processor: expose metric registration and proto extension fns
2019-05-24 lalitm@google.com metrics: introduce properly namespace metric file paths
2019-05-24 lalitm@google.com trace_processor: metrics: register built-in metrics upfront
2019-05-23 primiano@google.com Merge "Perfetto Client API (4): Add initial integration test"
2019-05-23 treehugger-gerrit@google.com Merge "TracingMutexImpl: Fix DestroyTracingSession()"
2019-05-23 treehugger-gerrit@google.com Merge "Add gen_amalgamated to gen_all"
2019-05-23 ilkos@google.com Merge "Simplify error and data loss stats"
2019-05-23 treehugger-gerrit@google.com Merge "Trace processor: add trace_metadata table"
2019-05-23 lalitm@google.com metrics: add proper support for repeated fields
2019-05-23 lalitm@google.com trace_processor: improve helper proto design
2019-05-23 ilkos@google.com Add statistics as a proto
2019-05-23 lalitm@google.com metrics: refactor metrics code into proper builder class
2019-05-23 ilkos@google.com Merge "Add count of spawned processes and other minor improvements"
2019-05-23 lalitm@google.com Merge "loadtool: fix loadtool sleeping longer than intended"
2019-05-23 primiano@google.com Merge "Remove gen_amalgamated from gen_all"
2019-05-23 eseckler@google.com service: Let producers choose whether to enable SMB scraping
2019-05-22 lalitm@google.com Merge "perfetto: refine proto descriptor support"
2019-05-22 lalitm@google.com Merge "metrics: add typechecking to metric result protos"
2019-05-22 treehugger-gerrit@google.com Merge "Extract common code from our various build generators into a library"
2019-05-22 lalitm@google.com Merge "trace_processor: fix overflow of window size"
2019-05-22 skyostil@google.com Unify include statements for protobuf
2019-05-22 ilkos@google.com Merge "Filter out failed launches"
2019-05-22 primiano@google.com Fix autoroller, remove extra ../ in GN file
2019-05-22 skyostil@google.com Merge "Add retired instruction count field for legacy events"
2019-05-22 lalitm@google.com Merge "traceconv: add comment about catapult"
2019-05-22 lalitm@google.com trace_processor: fix debug dcheck
2019-05-22 lalitm@google.com Merge "trace_processor: fix typo"
2019-05-21 primiano@google.com Perfetto Client API (3): Tracing muxer implementation
2019-05-21 primiano@google.com Perfetto Client API (2): public interfaces and backend implementation
2019-05-21 primiano@google.com Perfetto Client API (1): initial refactorings


Created with:
  gclient setdep -r src/third_party/perfetto@5ca8b4622a59

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:129747127,chromium:129747127,chromium:129747127,chromium:129747127,chromium:129747127,chromium:b/133324726,chromium:133268735,chromium:132678367,chromium:132678367,chromium:132678367
TBR=perfetto-bugs@google.com

Change-Id: I411cb3737e9f4b32f7f933ca9bbb05a4c29bc5f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631735Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663769}

Disable some unit tests in NavigationURLLoaderTest and ResourceDispatcherHostTest and fix one test in the former when network service is enabled.

Fix NavigationURLLoaderTest.RequestFailedCertErrorFatal to work with network service. The other tests that are disabled in NavigationURLLoaderTest depend on net:: test objects that are an implementation detail of the old path, to ensure that the request is cancelled correctly when the navigation or context goes away. It's not clear how much value these tests actually provide, and this is a bit hard to test in a unit test with network service, so I'm disabling them for now.

ResourceDispatcherHostTest.ForbiddenDownload is disabled because it's a regression test for a ResourceDispatcherHost bug.

Bug: 966633
Change-Id: If979805546875ca616a1c54ff559d9f40498038a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631768
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663768}

This updates from revision
0e2a405f597a3c1be456d704b42bdd5e0d4954bb (2019-02-21)

to revision
c3a44bfc61dcf0feb1cc0e37a95fb281799d43c6 (2019-05-24)

Bug: 951494
Change-Id: Iaa722617a8c48a4b22daa1d872508871608debc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615741
Auto-Submit: Martijn Croonen <martijnc@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663767}

The accessibility of the TableView isn't great. This CL improves it
by increase the contrast of the sublabels.
It also use a shared constant for the font of the sub labels in case
we need to modify it in the future.

Bug: 960264
Change-Id: I962f66082c459ccf9999848e510670d9e12dca11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627364Reviewed-by: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663766}

https://chromium.googlesource.com/angle/angle.git/+log/1b6aded661de..46fe0e4be950


git log 1b6aded661de..46fe0e4be950 --date=short --no-merges --format='%ad %ae %s'
2019-05-28 jonahr@google.com Cleanup Features headers.
2019-05-28 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for 2D array textures


Created with:
  gclient setdep -r src/third_party/angle@46fe0e4be950

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@google.com

Change-Id: Ie2e264678d91f7f859c1bffb9d4c5f2225892523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631575Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663765}

This allows it to show dialogs and work as required.

BUG=948882
TEST=as in bug

Change-Id: Ifc339187093e571f8f6062cfa4a9d3130a357e02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631873
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663764}

There's a P0 escape from the locked mode currently in M75 which is just days
away from stable.  This is a very quick and simple fix that addresses the
problem for now and it will be backmerged immediately to M75.

Bug: 957950
Change-Id: I2c39c04d4bc0219c000977928b538c60619a6bf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632251
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663763}

Opaque origins (such as about:blank and data: URLs) inherit the security
and privileges of their creator origins, which are tracked in precursor
tuples. ScriptContext::GetEffectiveDocumentURL() attempts to determine
the precursor origin of an opaque URL today by traversing the creation
chain and looking for the first non-about:blank opener or parent.
However, this is not always strictly correct for all opaque origins;
for instance, the precursor tuple of a data: frame may not be that of
its immediate parent in the case of nested iframes.

Update ScriptContext::GetEffectiveDocumentURL() to use
Origin::GetTupleOrPrecursorTupleIfOpaque(), which correctly tracks this.
Note that we still have to do the opener/parent traversal case because
content script matching needs to have the full URL (including path), and
not just the scheme, host, and port tuple.

To balance these, we simply return the document URL (which is
potentially opaque) in the case of a mismatch between opener/parent
traversal and the precursor tuple. This should be an exceptionally
rare case in practice.

Updating this method to use the precursor tuple is a prerequisite for
adding support for data:-URL content script injection.

----- Reland Notes -----
The original patch didn't account for a parent being null in the
iteration of the frame tree, which could cause issues in edge cases
(that are not terribly uncommon). The reland adds a graceful return in
those cases, and adds a regression test.

Bug: 55084
Change-Id: Ib46d67dddc3fe0b769e30abe383534e5c490c912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621196
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663762}

This CL enables all viz_unittests that pass with Vulkan.

Bug: 961373
Change-Id: Ie0d0c590d58a930bf5e005dc233240203d76e773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625015
Commit-Queue: Saman Sami <samans@chromium.org>
Auto-Submit: Saman Sami <samans@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663761}

This patch stops propagation of setting NeedsCollectInlines
at atomic inlines.

Usually atomic inlines that have children are LayoutBlockFlow,
but LayoutSVGRoot is one example that are not LayoutBlockFlow.

This patch also clarifies the distinction when a parent of
object needs to collect from when the object itself needs to
collect.

Bug: 966699
Change-Id: I260824f3e8e211f842aa7990c6d504a3c72549b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631016
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663760}

This patch adds CHECKs to `LazyLineBreakIterator::
NextBreakablePosition` before reading from a raw pointer.

This is a speculative fix. It is likely that there's a case
where `NGLineBreaker` over runs `NGInlineItem::EndOffset()`,
but we have not be able to find a locally reproducing case
yet. The case in issue 967167 has a broken surrogate pair at
the end, but it's still not enough to reproduce.

Bug: 967167, 967439
Change-Id: I64973e8e7e41b5089147b0383178af6217b4db47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630141
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663759}

In WebDriver spec, we assume that the actions with the same id and type
are the same, we should give the pointer actions of different source
types a different id.

Bug: 606367
Change-Id: I1d8f6a08ee8d98c4afd281f077e23067ad915ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626960Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663758}

This CL moves //ios/web/web_state/error_translation_util* into
//ios/web/web_view:util.

Bug: 942244,956511
Change-Id: Iee866e5f371e203720dfa3e128f848272ef78f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630160Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663757}

Change-Id: I54c4f60513076030258b1b6b3a6a6e681f353578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632300
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663756}

This is a reland of 7e329171

Original change's description:
> Log SCROLLBAR LatencyInfo's for main thread injected scrolls
>
> Note: based on crrev.com/1595296
>
> When scroll gestures are injected during the handling of an input on
> the main thread, we want to dispatch the scroll gesture with the
> LatencyInfo information from the original input event, but with a
> different type. This allows the end to end latency metrics to be
> computed correctly and classified separately as a specific type of
> scroll (not just, e.g. as mouse latency).
>
> Bug: 954007
> Change-Id: I725eaa46f21883aff08ab209d73dc5d0398a85db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603342
> Commit-Queue: Daniel Libby <dlibby@microsoft.com>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#659630}

TBR=tdresser@chromium.org, bokan@chromium.org

Bug: 954007
Change-Id: I70f2c0e445c872bf357469f64f1d8104c1da62f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628955
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#663755}

https://skia.googlesource.com/skia.git/+log/cf49b6472020..176b214f91bc


git log cf49b6472020..176b214f91bc --date=short --no-merges --format='%ad %ae %s'
2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@176b214f91bc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@google.com

Change-Id: Ia53e61f4d36b75bd62e2e8a0fcef38ea0a7b34d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631573Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663754}

Extending the histogram for another 6 months as the feature this is tracking
is in public beta currently, and not fully launched yet.

Bug: 967501
Change-Id: I6e66d4c9feabfa1a8d2883d33f17fedb2dbff6c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631381Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663753}

Touchless doesn't support snackbars so use toasts instead.

Bug: 959333
Change-Id: I14fcea19a53e6d3d7e7bfee6542ff71775dbed03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626884Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663752}

After clang r360674, each .obj file embeds the path to the profile library
as a dependent lib. No intended behavior change.

Change-Id: Ie892fccdb8aaefc2545db56fb3274dc6f0992a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630986Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663751}

https://swiftshader.googlesource.com/SwiftShader.git/+log/71c012b1b956..51e9e5659a55


git log 71c012b1b956..51e9e5659a55 --date=short --no-merges --format='%ad %ae %s'
2019-05-28 capn@google.com Implement Y′CbCr conversion
2019-05-28 capn@google.com Fix single-plane views of YCbCr formats
2019-05-28 capn@google.com Refactor writing texture level descriptor info
2019-05-28 capn@google.com Take the plane/aspect into account when copying/blitting
2019-05-28 capn@google.com Implement VkSamplerYcbcrConversion object
2019-05-28 capn@google.com Claim support for YCbCr 3- and 2-plane 420 format
2019-05-28 capn@google.com Allow additional info to be passed to object's Create functions
2019-05-28 capn@google.com Add 8-bit YCbCr 420 format info
2019-05-28 capn@google.com Refactor obtaining format aspect info
2019-05-28 capn@google.com Implement OpImageGather
2019-05-28 capn@google.com Refactor texel names
2019-05-28 capn@google.com Fix taking the sampling instruction type into account


Created with:
  gclient setdep -r src/third_party/swiftshader@51e9e5659a55

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/116336664,chromium:b/132437008,chromium:b/132437008,chromium:b/129523279,chromium:b/129523279,chromium:b/129523279
TBR=swiftshader-team+autoroll@google.com

Change-Id: I93e2f4c68994dfd5097f61ccfb3a85c0b7157f7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632416Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663750}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b42d4c7a..68951d2c

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5f552b17b8bfb7b0df5fec77e4428c2c51e51322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631733Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663749}

Also added a note about a known issue that can cause build failures.

Bug: 967618
Change-Id: Iebf4df4a15453e525653ee2052f61e84c0e169f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632299
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663748}

When the DSE is Google, omnibox should use the bundled icon instead
of the google favicon.

Bug: 966389
Change-Id: I95d683a7bf1c3f460ec2d73ccd39d1b8fa305fcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631697
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663747}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c66b67119b9..15902f4c7d5d


Created with:
  gclient setdep -r src-internal@15902f4c7d5d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com

Change-Id: I1094223b1dadbd3cb23e06b5c2a4a2ac4c6ed0a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632417Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663746}

Bug: 961158, 960421
Change-Id: I584060d95247b66e38fd6dfb765356ebf193664b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603684
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663745}

Extending the histogram for another 6 months as the bug this was introduced for
isn't fully fixed yet.

Additionally, transferring ownership of the metric as both original owners
switched to different projects.

Bug: 960033
Change-Id: I732fceae598371ef6efffd6adb07ff748c21c529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631407Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663744}

Devices that had /data/local/tmp/ command-line flags file need to read
from SharedPreferences from attachBaseContext(). This was causing all
tests to fail when this file is present.

Also improves failure message somewhat.

Bug: 441859
Change-Id: Ifdf8f8f4117690ef6c739189d53f361dbe9b5626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631716
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663743}

In Unified Plan, iceConnectionState is calculated in the blink layer.
In edge cases, there are differences between this state and the one
calculated in third_party/webrtc. This CL makes sure the same state is
exposed in chrome://webrtc-internals/ as the one exposed in JavaScript.
For debugging purposes, this CL also exposes the old ("legacy")
implementation of the iceConnectionState. This is not observable in
JavaScript, but it will help us debug issues such as
https://crbug.com/966798.

Bug: 967451
Change-Id: I5793b648e7c98cfd0c0f3301b648dad00ba69823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632190Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663742}

Adds histograms for page impressions and actions identical to Android's.

Bug: 957688
Change-Id: I5985cca226c0ec15cdd67ed4dcf99a73a8876e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628031Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663741}

Since commit 4874fdef ("[blinkpy] Stop rebaselining on Android bots"),
android_blink_rel is no longer part of the rebaselining bots used by
wpt-importer.

However, 'android' is still part of Port.CONFIGURATION_SPECIFIER_MACROS,
which is passed as |specifier_macros| to simplify_specifiers(). And since
Android is no longer covered by trybots, |versions| in that function ends up
an empty set, which by definition means all its elements are in
|specifiers|.

In practice, this means that a test such as
external/wpt/preload/onload-event.html, which was failing on some Mac bots,
would cause simplify_specifiers() to return something like ['Android',
'Mac10.10'] and we would try to add repeated lines to TestExpectations that
look like

     crbug.com/626703 [ Android ] foo [ Failure Timeout ]
     crbug.com/626703 [ Mac10.13 ] foo [ Failure Timeout ]
     crbug.com/626703 [ Android ] foo [ Failure Timeout ]
     crbug.com/626703 [ Mac10.12 ] foo [ Failure Timeout ]

which fails our presubmit checks as expected.

Fix it by not taking empty sets into consideration when looping. This
unblocks WPT imports again.

Bug: 567947
Change-Id: Ia471cad213192fa23425d5e8eecf47457605f9ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631663
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663740}

This adds a feature flag to ensure that additional Crostini session
status enterprise reporting is still disabled even when the policy for
Crostini reporting is enabled (which is used for existing reporting).

Test: compile
Bug: 844468
Change-Id: Id9f25dc344cb804679312d6488964de23de9610b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631654
Auto-Submit: Alex Oldemeier <aoldemeier@chromium.org>
Reviewed-by: Olya Kalitova <okalitova@chromium.org>
Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663739}

From the field trial (see
https://bugs.chromium.org/p/chromium/issues/detail?id=758566#c71 for details),
ordered prefetch improves startup performance significantly on low-end devices,
and regresses it on high-end ones.
As a consequence, enable only on low-memory.

From the field trial, this is time to commit for cold starts:
- Devices with >=2GB of RAM: Regression of 110ms (5.44%) at the median, 175ms
  (2.96%) @95th percentile
- Devices with <=1.2GB of RAM: Improvement of 135ms (2.71%) at the median, 650ms
  (4.34%) at the 95th percentile

Also removes the command-line switch and the synthetic field trial setting. As
such, this is partially a revert of
https://chromium-review.googlesource.com/c/chromium/src/+/1270936.

Bug: 758566
Change-Id: I3a95f97bd5c9eda7840a107fa22b7d016a4a08c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631380Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663738}

There is no point sending DeferredImages to cc until the PaintWorklet
has been properly registered; it just requires cc to have null-checking
logic. Instead, this CL adds support for off-thread PaintWorklet to
CSSPaintImageGenerator::IsImageGeneratorReady and uses it to defer
creating DeferredImages.

Bug: 965632
Change-Id: I351bf85ee0eec1df4ac401de2c78a4e99a38ea03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622868Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663737}

In the event of an account removal or token update, Chrome OS Account
Manager sometimes revokes old tokens before informing its observers
about the update. Sometimes this causes certain Chrome services to
mark the current newly minted token as invalid and in other cases, it
causes unnecessary error notifications.

Fix this by making old token revocation as the last step of a token
update and notify Account Manager's observers before revoking the old
token.

Bug: 952570
Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*"
Change-Id: Idaf222417eecfd88cae77a7471cb9ee03b8c85b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631666
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663736}

This cl adds EVENT_COULD_NOT_SHOW to JourneyLogger::events_ and records
the bit vector when payment sheet is not shown. This is because we still
want to know value of other bits like EVENT_CAN_MAKE_PAYMENT_[TRUE|FALSE]
or EVENT_REQUEST_METHOD_[BASIC_CARD|GOOGLE|OTHER].

Without this change on Desktop NotShown cases were recorded as aborted
with JourneyLogger::ABORT_REASON_MOJO_CONNECTION_ERROR error, while on
Android not recorded at all.

Bug: 966150
Change-Id: Ifddfb68622b2d8eb67b8b687077836e863868ea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626013Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663735}

Currently, when the top suggestion is a suggestion from history
(with URL), we show the favicon for that page in the popup. If
the favicon doesn't exist, then the omnibox will use a fallback when
it can't load the favicon, but the fallback will be the history icon,
the icon for the suggestion, instead of the globe.

Fixed: When omnibox suggestion is a history type, then the icon is
fallback to the globe in this case.

Bug: 966347
Change-Id: I9c8210b55c6818facf4034abbd20be3386da46ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625996
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#663734}