- 06 Dec, 2019 40 commits
-
-
Omar Morsi authored
This CL adds an option for generating test certificates with custom subject alternative name (SAN). This is important e.g. for testing of SAN matching in isolation. Bug: 1030652 Test: Metadata of generated certificates has not changed (inspected manually). Change-Id: I95c5003b46e4a78fb176c4d330571e22fc2b5f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949797 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#722422}
-
Oriol Brufau authored
In r720875 I changed the pseudo type of the style used for markers with 'content: normal' from kPseudoIdNone to kPseudoIdMarker. This had the side effect that they started to propagate style to its children, producing a 90.6%-99.9% performance regression in the flexbox_with_list_item test. This patch prevents that style propagationg for normal markers, fixing the perf regression. Markers with 'content' different than 'normal' are still propagated since it's necessary in that case. Bug: 1030884, 457718 Change-Id: Ia8341b605366ebdfd117cf569d030b38862348dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953723Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#722421}
-
Oriol Brufau authored
The spec has added 'white-space' to the list of properties that apply to ::marker pseudo-elements. Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo BUG=457718 TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html Change-Id: Iaf05bb568d0127b2aae4219715bb8839620101a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954384Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Pavol Marko authored
It was only enabled recently and has been consistently failing across multiple bots. TBR=dcheng@chromium.org, etienneb@chromium.org, erikchen@chromium.org Bug: 843467 Test: browser_tests --gtest_filter=*MemlogBrowserTest* Change-Id: Iee8db1833b3e58013b5522d02dd6ca8b9ab579ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954006Reviewed-by:
-
Olivier Robin authored
With slim navigation, the navigation manager items are only restored when the tab is displayed. Before that point, use the session_storage to sync the tab. Bug: 1024750 Change-Id: Ie22d46065f28d172980175e3d8468712579a8ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943241Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722418}
-
Navid Zolghadr authored
This makes moving ComputedStyle to Oilpan in these classes that are referencing it in the future easier. Firstly it replaces a const & reference of ComputedStyle in BoxInfo with a cached value needed in that class. Secondly it makes a local FloatObject class public so that it can be stored in a HeapVector and have WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS on it and later have a trace function for its CompuetedStyle reference. Bug: 1030176 Change-Id: Iff63d1fb385bbb5ac85fc5445caf7dfd775352ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946051Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722417}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69d1054db47b..af5f9020e38b Created with: gclient setdep -r src-internal@af5f9020e38b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie02c7b5bdfbb2109ffde20dbe9cfa6045efe4d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955237Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722416}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Id933fc47dbc7a9b3efcf939b0ac3cf3b93d0b259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952568 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#722415}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7d04c75b577b..51a024f7d973 git log 7d04c75b577b..51a024f7d973 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 dberris@chromium.org Remove unnecessary assertion Created with: gclient setdep -r src/third_party/catapult@51a024f7d973 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1031431 Tbr: oysteine@google.com Change-Id: I99b0ebc2b07e9fa9eb8feacd03cd55b5debe032f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722414}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=bartfab@chromium.org Bug: 1023677 Change-Id: I945eb1ac77ffaf199afffb799717444515d427af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926923 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#722413}
-
Alexander Timin authored
Restarting bfcached navigations (e.g. when we evict after the document was restored) is potentially problematic - add trace events to ensure that the problems are easy to diagnose. R=alexmos@chromium.org Change-Id: Ia1a888889e52d9e9a0aaec7119833a851060d234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930151 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722412}
-
Miyoung Shin authored
This CL cleans up WebContentsObserver inheritance from classes that had only overridden OnInterfaceRequestFromFrame but removed during the conversion to BrowserInterfaceBroker. Bug: 1030327 Change-Id: If38d1f96779bd7badd47712b059b7b05939f8c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950263Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#722411}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1256d9bcac50..1fce3f8e55a5 git log 1256d9bcac50..1fce3f8e55a5 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 yvesg@webrtc.org Remove custom constructors for AudioProcessing::Config. Created with: gclient setdep -r src/third_party/webrtc@1fce3f8e55a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibee7f9e82474b9ca9a885de6132e22b63e537bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955235Reviewed-by:
-
Ramin Halavati authored
Google Docs Offline extension has some web-accessible resources that can be requested by websites, as a measure of browsing in incognito mode. This CL adds UKM metrics to measure the usage of these resources by docs and other websites. Note that the imports are double counted since they are counted once in preload and once in actual load. Privacy review doc: https://docs.google.com/document/d/1be0us3OZjXfr4bfj5NUxKfuXDy6ESu_ClcrfeyyfVZI/ Bug: 588766 Change-Id: Ib2cfafa53207ad6406b971c8fcb85091345b0726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901035 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#722409}
-
Kuo Jen Wei authored
Bug: b/141518780 Change-Id: I3b92965cf0da978e9a8820e86c236a752e565a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954995 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Umut Baris Oztunc authored
This removes the calls to the base::FilePath copy constructor which is called explicitly while passing arguments to the FileSystemWatcher constructor inside CreateAndStartFileSystemWatcher function. Bug: 1030575 Test: Manually tested. Change-Id: If5ae4da8904f8beeb3c9e4eb38a988a146290793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949833Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Umut Barış Öztunç <umutoztunc@google.com> Cr-Commit-Position: refs/heads/master@{#722407}
-
Kenichi Ishibashi authored
This isn't used. Bug: N/A Change-Id: Icf6f869a04b17bd2656ca05797092427fcb8657e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955244 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#722406}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/828b56268225..7d04c75b577b git log 828b56268225..7d04c75b577b --date=short --first-parent --format='%ad %ae %s' 2019-12-06 dberris@chromium.org Fix typo (input_ref -> inputs_ref) 2019-12-06 dberris@chromium.org Set the default empty lists in serialisation Created with: gclient setdep -r src/third_party/catapult@7d04c75b577b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1031421,chromium:1031426 Tbr: oysteine@google.com Change-Id: I107a386972a4b9cbf143a079aac2fc885f93ad0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955229Reviewed-by:
-
sangwoo authored
Interpose views::AnimationDelegateViews using gfx::AnimationDelegateNotifier, which helps to adapt align animation to the Compositor's frame. There's no intended behavior change. Bug: 824026 Change-Id: I2cb9a06e89b9627a933a83c5d44eac19a3792c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953240Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#722404}
-
Roman Sorokin authored
Added CHECK in the ScreenLocker Bug: 1024555 Change-Id: I4cf76bff08b6911a914be20619767f5c4ad1a72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939709Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722403}
-
Maksim Sisov authored
Instead of attaching already attached buffer once again, it's just enough to provide damage and commit the surface. Also, the test was extended. Original change's description: > ozone/wayland: Complete submission of a buffer submitted more than once > > This CL fixes a corner use case that was caught by one of the users > of Ozone/Wayland. > > The problem appeared when the Chromium compositor sent a next frame into > the same buffer that had just been submitted and a OnSubmission callback > had been sent to the viz process located WaylandBufferManager. This > happened only when the remote inspector was attached and the screencast > was enabled. > > In this case, Wayland compositor will not send an OnRelease callback > and we should not wait for that. Instead, we must complete the > submission immediately and set the |WaylandBuffer::released| > member to be false. Once another buffer is committed, Wayland compositor > will release the previous buffer. > > Bug: 1029777 > Change-Id: Ib74c16f41f128298998bc9699f8d9ded3697cd43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946479 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720878} TEST: WaylandBufferManagerTest.SubmitSameBufferMultipleTimes Bug: 1029777 Change-Id: If429fa5626e6276a72bb0ed97385cb26c01ab591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951018 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#722402}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8715dde6ef9ad44a822efa8e53851924d2f9caee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955227Reviewed-by:
-
Kuo Jen Wei authored
Add new window operations passing between background and foreground window. Foreground and background will bind corresponding operations and call methods across background and foreground. Bug: b/141518806 Test: tast run <DUT> 'camera.CCAUI*' Change-Id: I45801659712af6bc6f439e67c2ae37ad8ab6805d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935634Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#722400}
-
Victor Costan authored
Bug: 729800 Change-Id: If8fd518bc53254d330a08349dcd8ea93731a52d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1103666 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#722399}
-
Findit authored
This reverts commit e8d24f73. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 722373 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U4ZDI0ZjczN2UyOWYzZmJhM2U0NjU0ZWExZGMxMjU5ZTEzNzMwNTgM Sample Failed Build: https://ci.chromium.org/b/8894850112495909312 Sample Failed Step: browser_tests Original change's description: > Reland "Move Audio Service off Service Manager" > > This is a reland of a4d27f51 > > The reland moves the TestingApi binder support into a component > library to avoid duplicate definitions that resulted in browser > test failures in component builds. > > Original change's description: > > Move Audio Service off Service Manager > > > > All the details around if/when a service instance is started and whether > > it's in- or out-of-process have been centralized into the implementation > > of a single GetAudioService() helper in Content. > > > > A few other helpers are added to ease the transition off the Service > > Manager, though they aren't necessarily ideal APIs. For example, > > client library APIs which once took a Service Manager Connector may now > > take a RepeatingCallback to bind a specific type of interface. > > > > In addition to GetAudioService(), Content provides helpers for > > AudioSystem construction and StreamFactory binding from any sequence. > > > > Because all timeout/lifetime management logic is now generically > > supported within Mojo and Content and requires no service implementation > > details to get right (and because unit tests launching service processes > > is no longer supported outside of Content), all Audio Service test > > coverage relevant to lifetime management is deemed superfluous and has > > been removed. > > > > Bug: 977637 > > Change-Id: I4c59948eafce2322547bf2b0479961e095b3edee > > Tbr: oshima@chromium.org > > Tbr: guidou@chromium.org > > Tbr: vollick@chromium.org > > Tbr: xiaohuic@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941280 > > Commit-Queue: Ken Rockot <rockot@google.com> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#721832} > > Bug: 977637 > Change-Id: I183e79042c99458f2abf9423d8f9bbefedf5b374 > No-Presubmit: true > Tbr: oshima@chromium.org > Tbr: guidou@chromium.org > Tbr: vollick@chromium.org > Tbr: xiaohuic@chromium.org > Tbr: avi@chromium.org > Tbr: rsesek@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952601 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#722373} Change-Id: I39c5079ef87d681d2854314e82195ec203498929 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954771 Cr-Commit-Position: refs/heads/master@{#722398}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a4c2ff39bec..69d1054db47b Created with: gclient setdep -r src-internal@69d1054db47b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I80a703d8218dadff3687bd0cf90dd81b7d72b715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955305Reviewed-by:
-
Steve Anton authored
Append uses memcpy which is much faster than calling push_back in a loop. Bug: None Change-Id: I7d9027663f9e1d20a8a2b65cce64678ca1354491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954451 Auto-Submit: Steve Anton <steveanton@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#722396}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f128c3d0c5a2..828b56268225 git log f128c3d0c5a2..828b56268225 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 dberris@chromium.org Set a default empty list when looking for changes Created with: gclient setdep -r src/third_party/catapult@828b56268225 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1031421 Tbr: oysteine@google.com Change-Id: I649eb55d6f7987853b4fb89efa0df4c3f1bac45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955070Reviewed-by:
-
Adam Rice authored
It is unused. Change-Id: Ic2bfae2a1fb906fc54107cf830803681460d259f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954815Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#722394}
-
Dominic Farolino authored
The CL crrev.com/c/1683494 fixes the issue that this stale TODO references, and removed the expectation file. Since the TODO was accidentally left behind, this CL removes it. R=falken@chromium.org Bug: N/A Change-Id: I1cec7b0fa056acfbf397c833cf49b1b41f0af038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954455Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#722393}
-
Jeevan Shikaram authored
This CL removes background color of the uninstall button in app management. Bug: 1031411 Change-Id: If1ea8983c98dac603d3c6ff09b558044c9ffbd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953241Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#722392}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/447ab8a42a5b..f128c3d0c5a2 git log 447ab8a42a5b..f128c3d0c5a2 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 dberris@chromium.org Use configuration-provided values Created with: gclient setdep -r src/third_party/catapult@f128c3d0c5a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1031405 Tbr: oysteine@google.com Change-Id: I5a7d3e07ee3efb76943b3dec80f1e926d91e7b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954277Reviewed-by:
-
nancy authored
BUG=1011235 Change-Id: Iecc5a8b598d3933aed90d0da1c31fe3c882ca73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951274 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#722390}
-
nancy authored
Family Link checks whether we need to show the pause dialog, so add a parameter to PauseData structure. So the current checking in AppService can be removed. For Web apps, call Family Links interface to pause/resume apps. BUG=1011235 Change-Id: I6fc76e4e4a02798d3825eb6e4d2734407a702ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952549 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Danan S authored
The LOG(FATAL) here was frequently causing a crash when entering overview mode. Bug: 990282 Change-Id: Ib1a5dd50a0a04bf15d106b233a3e726c3db761ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954225Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#722388}
-
Navid Zolghadr authored
This CL moves NodeRenderingData to Oilpan and also removes NodeRareDataBase. NodeRareDataBase is never created directly and it was not an Oilpan object. But its only child (i.e. NodeRareData) was on heap. Hence this CL moves the reference of NodeRenderingData to NodeRareData and removes NodeRareDataBase. https://docs.google.com/document/d/1AJ1XCtiYbaw64KhPX_a_TiNDOqeYV-MO30I1C-8VzPk/edit?pli=1#heading=h.3qsfdd8uwwk3 Bug: 1030176 Change-Id: Iefeb9a0544aa781f060d38c35729a24c9b2c6450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948365Reviewed-by:
-
Christopher Lam authored
This CL removes --cr-slider-ripple-opacity in favor of specifying opacity in --cr-slider-ripple-color. This makes ripple color easier to reason about and allows a clear, single point of ripple color override. TBR=lucmult@chromium.org Bug: 10292245 Change-Id: I5b8ad44a42dea1d953e6b104c0ad5380416f439d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941448Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b2ab7ff465a7..176b9884fdee git log b2ab7ff465a7..176b9884fdee --date=short --first-parent --format='%ad %ae %s' 2019-12-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@176b9884fdee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I152a0e3865cc7eeb5c0fddac47c021f52ed33510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955068Reviewed-by:
-
Aran Gilman authored
Bug: 1027612 Change-Id: Ia1837c29aa0532f72f2493b6c84459e5d1b988a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931139 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#722384}
-
Gyuyoung Kim authored
This CL removes unnecessary Create() factory functions in //third_party/blink/renderer/modules/lock as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory function, - Lock::Create Bug: 939691 Change-Id: I3d4c564474bdc97c7267be343a2b2340a71857c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952566 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#722383}
-
