GitLab

- TileService not support incognito profile.

Bug: 1110285
Change-Id: Ief1c8025b74ec5df94c5e811d213a6679fd6069c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324938Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792500}

Bug: 1100034
Change-Id: Id91fef164ce560cdecc777c35c100dd42d16685a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322288Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Jongmok Kim <jongmok.kim@navercorp.com>
Cr-Commit-Position: refs/heads/master@{#792499}

This patch migrates tests away from deprecated APIs and adopts
TestingProfile::Builder for tests in
/chrome/browser/engagement.

Rationale: creating or overriding keyed services after the profile has
been created is problematic and known to cause hard-to-debug test
flakiness, because it bypasses BrowserContextDependencyManager and often
leading to use-after-free.

This CL was uploaded by git cl split.

R=calamity@chromium.org

Bug: 1106699
Change-Id: Ia256324372fffe91b7dd7bda603faea66fbbb666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316361
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792498}

Bug: 1110344

Change-Id: I93448f79508b3de35b1067ea3a6080b42ed0a860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316886Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Harkiran Bolaria <hbolaria@google.com>
Cr-Commit-Position: refs/heads/master@{#792497}

Testing Speedometer formula and internals and new behaviors in
progress panel.

The setUpPage method of files_xf_elements_unittest.js changed to setUp
as it is not called per test case and causes conflict between tests.

Bug: 953308
Change-Id: I24c88e63cdcec99f73a5233e18d2d91dbac8d2fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317128
Commit-Queue: Omid Tourzan <oto@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792496}

Using wpt-import in Chromium 2a54cee2.
With Chromium commits locally applied on WPT:
3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/cookie-store
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=lpz@google.com

No-Export: true
Change-Id: I717e4cae93bb0f53d7616d461e7b6ba0c6d5b7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324948Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792495}

There's a plan to stop exposing stream_map() to subclasses.

Change-Id: I402615195daee34b4d26868fb191158117e9ae5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324443
Auto-Submit: Renjie Tang <renjietang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792494}

Android's TimePickerDialog behaves differently on older Android
versions.

This CL adds a class DownloadTimePickerDialog, which overrides
Android API to fix the compatibility issue. Now we always reset the
positive and negative button listeners in show() function override.

Also applies styles to date picker and time picker.

Bug: 1107611
Change-Id: I9fa6b5b17f145b0f592beae2d0a06b3f06fc8a1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320969
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792493}

This is a reland of b9f1aa01
The CL was previously reverted due to a flaky check on whether a process
is still alive or not, which is fixed in this CL by adding a
RenderFrameDeletedObserver and waiting until the process is actually
deleted before checking. See fix:
https://chromium-review.googlesource.com/c/chromium/src/+/2323086/1..2/content/browser/frame_host/render_frame_host_manager_browsertest.cc
Original change's description:
> Reuse process on history navigations between same-site cross-BI pages
>
> See crbug.com/1096135 for context. When doing same-site navigations, we
> might do a proactive BrowsingInstance swap, but we will reuse the
> renderer process whenever we can. On history navigations between pages
> that are same-site but have different BrowsingInstances (not only on
> cases that are caused by proactive BI swap), we should try to reuse the
> renderer process.
>
> Bug: 1096135
> Change-Id: I58f72bedecbbf94e4e05218bb9c15970a502d8a9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282553
> Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#792195}

Bug: 1096135, 1110281
Change-Id: I2c1ad20a73ad194980dfb2ab4caef29d2e1113d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323086Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792492}

This is a prerequisite to implement lazy loading for Polymer 3.

Bug: 1045266
Change-Id: I92c428cd2c18d6f4096ee5fbdd26ae77efb831ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321954Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792491}

This is a reland of f4723a7e

Original change's description:
> Convert from base::Bind and base::Callback to Once/Repeating in media
> 
> This CL converts base::Callback (and corresponding calls to base::Bind)
> to either base::OnceCallback or base::RepeatingCallback in
> chrome/browser/media. In general a base::OnceCallback is preferred since
> that's a stronger API guarantee, so that's been done where safe.
> 
> Bug: 1007635
> Change-Id: Ie3113c61db1ae43ce2e31c262f023d714f42dfc0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321003
> Commit-Queue: Will Cassella <cassew@google.com>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#792380}

Bug: 1007635
Change-Id: Idf5e4e9b24bf8e09f0d81cc9b822c267c479f9f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324409Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#792490}

Bug: None
Change-Id: Ida7a9e313069a8a7dc5844ab1e5f65a1c4a466d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325230Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792489}

This CL make Request constructor follow
https://fetch.spec.whatwg.org/#dom-request:
"38. If inputBody is body and input is disturbed or locked, then throw a
TypeError."

This CL also refactors the constructor around body extracting following
the last spec.

Bug: 1105704
Change-Id: Ie2ba890828e2091dbc0c55fa7120fb7ec37ebc13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309369Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792488}

This reverts commit 474b44df.

Reason for revert: Whoops. Reverting due to the prod freeze.

Original change's description:
> Reland "PRESUBMIT.py: Replace checkteamtags with DIR_METADATA checks."
> 
> This is a reland of e6d6e338
> 
> CheckDirMetadataFormat returns a list of input_api.Command objects,
> which are not derived from output_api.PresubmitResult.
> 
> Fixed by running it using input_api.RunTests.
> 
> Original change's description:
> > PRESUBMIT.py: Replace checkteamtags with DIR_METADATA checks.
> >
> > checkteamtags is no longer necessary.
> > - Add a check to validate DIR_METADATA files.
> >   This obviates the need fo checkteamtags, as `dirmd` validates metadata in
> >   OWNERS files, and we no longer need to enforce a unique team email for all
> >   (component, OS) pair.
> > - Add a check to enforce that OWNERS files contain no metadata if a
> >   DIR_METADATA file is present in the same directory.
> >
> > Bug: 1102997
> > Change-Id: I661f7a1958824e7d20642d65534c2502d1a050e2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317838
> > Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#791884}
> 
> Bug: 1102997
> Change-Id: Iff7d2569ee4e9a5a66773dba47e2de8e3c8f9b82
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321550
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#792486}

TBR=dpranke@google.com,nodir@chromium.org,ehmaldonado@chromium.org

Change-Id: I6641555670408ef276296b927a9b8f925e5335a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1102997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324556Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#792487}

This is a reland of e6d6e338

CheckDirMetadataFormat returns a list of input_api.Command objects,
which are not derived from output_api.PresubmitResult.

Fixed by running it using input_api.RunTests.

Original change's description:
> PRESUBMIT.py: Replace checkteamtags with DIR_METADATA checks.
>
> checkteamtags is no longer necessary.
> - Add a check to validate DIR_METADATA files.
>   This obviates the need fo checkteamtags, as `dirmd` validates metadata in
>   OWNERS files, and we no longer need to enforce a unique team email for all
>   (component, OS) pair.
> - Add a check to enforce that OWNERS files contain no metadata if a
>   DIR_METADATA file is present in the same directory.
>
> Bug: 1102997
> Change-Id: I661f7a1958824e7d20642d65534c2502d1a050e2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317838
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#791884}

Bug: 1102997
Change-Id: Iff7d2569ee4e9a5a66773dba47e2de8e3c8f9b82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321550
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792486}

Serialized operations include paddding in the returned
|serialized_size|, but this padding isn't initialized, so stale values
from the last serialization may be present in the padding region,
resulting in the same operation yielding different digests at different
times.

Clearing out the serialization buffer prior to serialization clears out
this padding.

Bug: 973801
Change-Id: I8b4a744c17b6d396bf86db549969532431c31327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245886
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792485}

 - Adds a new Context Menu with a "Copy" action (only on URL Bookmarks,
   not folders yet),
 - Wraps the old implementation with a feature flag check,
 - Adds metrics for the new context menu and its action.
   - After chatting with a member of the metrics team, I learned that
     usage of histogram macros is discouraged and, rather, histogram
     functions should be used instead (reduces compiled code bloat, and
     unnecessary caching and validation). So, in this CL, I also changed
     usage of Macros to functions (two of them).

Bug: 1093302
Change-Id: Ic74f7fbce55943454d18dbbbfa863062267b731b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311140
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792484}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I1a241b512f8be95deec34fea4411e19cb46758b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325069Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792483}

Change:
* Move ShouldShowContactSection into PaymentUIsManager.

Bug: 1102522

Change-Id: I5a9b7c0369cf27cef4a8c0de1c26e6a9428ebb05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317506
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792482}

The SBClientPhishing feature is under active development again, and
these metrics are all useful for top-level performance monitoring.

Fixed: 1109956, 1095038
Change-Id: I01281a6e7e144d1e74601450c042f1a3bf60a20f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319345Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792481}

This reverts commit 68ee6d9b.

Reason for revert: Causes mac test failures: see crbug.com/1110528

Original change's description:
> [webui] Stop & clear lottie animations
> 
> Stop and clear lottie animations when changing the animation-url. This
> prevents a visual glitch where the previous animation might show for a
> few frames while the new one loads.
> 
> Fixed: 1104241
> Change-Id: Id2015c8a374180eda33a8fd870611f224cae4e31
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317814
> Commit-Queue: Nina Satragno <nsatragno@chromium.org>
> Auto-Submit: Nina Satragno <nsatragno@chromium.org>
> Reviewed-by: dpapad <dpapad@chromium.org>
> Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#792421}

TBR=dpapad@chromium.org,nsatragno@chromium.org,malaykeshav@chromium.org

Change-Id: I22a420f2c48068c2e002558181e9153a156744d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1110528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325290Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792480}

TBR=bling-team@google.com

Change-Id: I81dc3c83390d89778f8106c872c37e51fd551448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324167Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792479}

Switches the painting code in pdf/ to use the new abstract Graphics API,
instead of using pp::Graphics2D directly. This eliminates direct
dependencies on Pepper in the painting code.

Bug: 1099020
Change-Id: Ib848d6824fa0cedd5737d56ceae9927754348cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321706Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792478}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: If3103c8588d58cba3b5ada80a87dddcdbf726582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324941Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792477}

Prevents crashes on CTS

Bug: 1069302
Change-Id: I227ac25237e2eac51d9c6131e81552f1cbb48a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324168
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792476}

Note this doesn't implement the validation that minBufferBindingSize
must be undefined for incompatible binding types (since that hasn't been
done for any of the other fields yet either).

Also slightly reorder things to match the upstream spec (which groups
optional fields by what binding type they're used for).

Minimally tested locally against upstream
webgpu:api,validation,createBindGroupLayout:bindingTypeSpecific_optional_members:*
but we need to fix a lot more things in those tests including a crash
and the binding type rules mentioned above.

Bug: 1069302
Change-Id: I64b4ac41297539c066b7f22ff9b6766462138c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324723Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792475}

We have quite a few cases where some internal methods "synthesize"
user activation notification triggers, as if they were real user
interactions.  After UAv2 shipped in M72, these calls /should/ be
unnecessary, see the bug.  However the compat implication is not clear.

This CL is part of a sequence that would hook up histograms to each
type of triggers.  If a synthetic trigger turns out to be ineffective,
we would blindly remove them.  We will then investigate the remaining
ones one-by-one.

This CL covers all browser-side changes except any interface changes to
UpdateUserActivationState() methods.

Bug: 1103249
Change-Id: Ie5117836ff1aba0b65a3058a35190cd4fb12c32f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281303Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792474}

This is a wrapper of ServiceWorkerStorage::GetAllRegistrations().

Bug: 1055677
Change-Id: I3c4155348c34f247b396d9312bb8b31ace7ffc42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319929Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792473}

BitmapCache and GlobalDiscardableReferencePool both move to
//components/browser_ui/util

Bug: 1016938
Change-Id: Ie9d52db4ba4081326b9f5ce07eb6f7d30376694e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321511Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792472}

DragDropDelegate implementations, such as WebContents, require that the
DragLeave event is fired before DragFinished when the DnD session ends
with no actual data transfer (cancelled), e.g: the drop happens on top
of a widget that does not accept the data being dragged. Otherwise, it
might lead to issues like crbug.com/1109324, where the whole web
contents view becomes unresponsive. This patch fixes it by making sure
OnDragLeave() is called just before OnDragFinished() when the session
ends with a cancellation.

R=tonikitoo@igalia.com

Test: ozone_unittests --gtest_filter='*DragControllerTest.StartAndCancel*'
Bug: 1109324
Change-Id: Idcbdb93ef0187847e2e779f3e4ac568bc594b90d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318511Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#792471}

The disabled tests cover the effect of a WebContents' visibility on
its auto-reload behavior.

It turns out that visibility of WebContents within content_shell
behaves somewhat unexpectedly -- at least on Mac -- resulting
in the WebContents non-deterministically becoming visible during a
navigation, despite being explicitly hidden by test logic prior to
the navigation.

In order to avoid the resulting flakiness, this rearranges the test
logic so that forced visibility changes are imposed *after*
the relevant navigation rather than before it.

Fixed: 1110259
Change-Id: I38ab9d22a225018a8c5a1762cac15af45bf846e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324163Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#792470}

Bug: 1108637
Change-Id: I763b2fb13d03c85f716cdeeba70a5b16b96623fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318830Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Auto-Submit: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792469}

The test was not added with the fix of bug because there were problems
with Mac and Windows.

R=kainino@chromium.org

Bug: chromium:1104580
Change-Id: Iafca0c9471f37d2897fd2b8fde1aae3c8c1fb38b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320274
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792468}

Also enables qrcode_generator_bubble_unittest for ChromeOS;
it was stuck in a no-{Android,CrOS} block.

Bug: 1110446
Change-Id: Iba92df1293d979a10a66c7e90e1f0eb0651888a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324807Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792467}

https://chromium.googlesource.com/angle/angle.git/+log/44bb4d7abee6..07cdf4214314

2020-07-28 tobine@google.com Vulkan: Add new validation skips
2020-07-28 nguyenmh@google.com Remove context id serialization

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: tobine@google.com
Change-Id: I50661f1e37c340e48b3684ad1ccde09d6681cbfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792466}

PrintParams should be of type base::DictionaryValue

Bug: chromedriver:3481
Change-Id: I4dae87d6e1a88585d592a1be85b757ff01d8d869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324668
Auto-Submit: Shengfa Lin <shengfa@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792465}

Move Point from viewport.js to constants.js and re-use in
open_pdf_params_parser.js and gesture_detector.js.

Bug: None
Change-Id: I743e6653055dc760f3f63472ffa7a4e8f2ee6bda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322170
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792464}

This code should do nothing if error_html is null. This moves
the check earlier.

BUG=none
TEST=none

Change-Id: I568c5ece3c2e1aca23e91480918ce1a35a07fa55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324654
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792463}

No-Tree-Checks: true
No-Try: true
Ignore-CQ-Freeze: true
Bug: 1109999
Change-Id: I4474c8088d567a85873ccc79f8eb41a25e484447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325192Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/master@{#792462}

ARM Mac bots have 'arm64' cpu dimension.
https://chromium-swarm-dev.appspot.com/bot?id=build201-a9

Adding Ignore-CQ-Freeze because this isn't for production.

Ignore-CQ-Freeze: true
Bug: 1103470
Change-Id: I3d3713909994a88224aec6c9eaf48e9d0890d2ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320714
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/master@{#792461}