- 24 Feb, 2018 27 commits
-
-
Weidong Guo authored
Changes: 1. Remove |scroll_ignore_timer_| 2. Observe scroll animation start and end in both AppListView and AppsGridView. 3. Ignore scroll events when the scroll animation is running. Bug: 759179 Change-Id: I44388cf7c89a35b587a99dcacd92aa01a182fc78 Reviewed-on: https://chromium-review.googlesource.com/932010 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#538978}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f9648b5c7cf8..f438ff743a4b $ git log f9648b5c7..f438ff743 --date=short --no-merges --format='%ad %ae %s' 2018-02-23 shenghuazhang [cipd] Match version to vars value supporting in gclient.py Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I531fb97610d7351f63c66fb2052493ac573dd35a Reviewed-on: https://chromium-review.googlesource.com/935750Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538977}
-
Nate Fischer authored
No change to logic, this just adds UMA metrics. Following up to http://crrev/c/933290, this is to log user opt-in preference. This adds "SafeBrowsing.WebView.UserOptIn" to track potential spikes/changes in user opt-outs. Bug: 713724 Test: check that metric is logged under chrome://histograms/SafeBrowsing Change-Id: Ieb32dc07d930705e5348fbe66d03b267b5562d7b Reviewed-on: https://chromium-review.googlesource.com/935483 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#538976}
-
John Budorick authored
Now following bit.ly/chromium-build-naming TBR=martiniss@chromium.org Bug: 812533 Change-Id: I923f3cefe256bbfb427e76ef0552e44e468167dd Reviewed-on: https://chromium-review.googlesource.com/935661Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#538975}
-
https://skia.googlesource.com/skia.git/+log/1022f743758b..54f9da58aad3 $ git log 1022f7437..54f9da58a --date=short --no-merges --format='%ad %ae %s' 2018-02-23 angle-skia-autoroll Roll skia/third_party/externals/angle2/ e41df6556..a4ef843fe (2 commits) 2018-02-23 benjaminwagner Switch Win10 NUC5i7RYH and NUCD34010WYKH bots to new Windows image. 2018-02-23 halcanary SkQP/Doc: new APKs again 2018-02-23 egdaniel Fixes to alignment issues with regards to mapped vulkan memory. 2018-02-23 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 569770ec9..4cbf9f959 (1 commit) 2018-02-22 herb SkScalerContext - make some fields private. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ie1b8be74413f96909325d257ac840c6f9ebe5ee1 Reviewed-on: https://chromium-review.googlesource.com/935756Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538974}
-
Andrii Shyshkalov authored
Also touch new cq.cfg to make it different from old one. TBR=nodir@chromium.org No-True: true No-Presubmit: true Bug: 815072 Change-Id: Ic6ed3e0a7afbece7fa4d4b95fb5c3f8c4023ae63 Reviewed-on: https://chromium-review.googlesource.com/936201Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#538973}
-
Andrii Shyshkalov authored
TBR=nodir@chromium.org No-Try: True No-Presubmit: True Bug: 815072 Change-Id: I653d89f47cd424540c2d4bea3730f8d1d4f37075 Reviewed-on: https://chromium-review.googlesource.com/936184Reviewed-by:
-
Ryan Daum authored
After dispatching the OnSideSwipeBegin, now checks to see if the event was consumed. If so, aborts propagation of the event so it is not used subsequently for scroll or drag type gestures. Bug: b/73738898 Test: Manual Change-Id: I301caa88b0455c4f405ca9c2fc19a39e03e1535d Reviewed-on: https://chromium-review.googlesource.com/932445Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#538971}
-
Istiaque Ahmed authored
CVJ::OnHashesReady seems to be missing lock while accessing member variable. Add lock to the method. OnHashesReady also calls BytesRead which already had lock. Turn that method to private BytesReadImpl, remove lock from it, and provide lock to the publicly callable version (new BytesRead). This CL also protects CVJ::time_spent_. Bug: 814966 Test: Internal change only. See bug for running unit_tests. Change-Id: I632dccf2ee921d1c84392b44c3ab8e0ca52dde3e Reviewed-on: https://chromium-review.googlesource.com/933245Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#538970}
-
Achuith Bhandarkar authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c1049d910642..92e338611b65 $ git log c1049d910..92e338611 --date=short --no-merges --format='%ad %ae %s' 2018-02-22 shapiroc Add missing unibuild CTS/GTS support 2018-02-14 shapiroc Add support for yaml in cbuildbot 2018-02-21 rahulchaudhry generic_stages: revert 'temporarily ignore all target prebuilts'. 2018-02-22 manojgupta cbuildbot: Fix unit tests tarball naming. 2018-02-22 vpalatin cros tryjob: Add --profile option 2018-02-22 achuith [cros_vm]: Use SDK version instead of LKGM for cache. 2018-02-22 achuith [cros_chrome_sdk]: Also catch GSCommandError. 2018-02-22 davidriley auto_updater: Move AwaitReboot logic to separate call. 2018-02-22 laszio afdo: update profile location and naming convention for CWP 2018-02-21 akeshet completion_stages: delete the concept of sanity_check_slaves 2018-02-21 akeshet chromeos_config: remove wolf-tot-paladin 2018-02-08 ayatane Move sysmon to vpython 2018-02-21 rahulchaudhry generic_stages: temporarily ignore all target prebuilts. 2018-02-23 ihf Reland "pre-cq: replace lumpy with zako, change kevin to arcnext." 2018-02-23 norvez Revert "pre-cq: replace lumpy with zako, change kevin to arcnext." 2018-02-22 dgarrett chromeos_config: Make kevin-arcnext internal. 2018-02-21 dgarrett branch-util-tryjob: Use gs://chromeos-throw-away-bucket/. Created with: roll-dep src/third_party/chromite Bug: 762650,815325 Change-Id: Iaf90c53e6069730c1d1519d2b64bdda8d6d06754 Reviewed-on: https://chromium-review.googlesource.com/935784Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#538969}
-
Xianzhu Wang authored
In the current layer squashing algorithm, all squashed layers under a squashing layer have a common clip ancestor which is the squashing layer's ClippingContainer() which doesn't include control clips. For SPv175, when we set layer state of a squashing layer, we should use the clip state of the ClippingContainer to skip any control clips on the squashing layer's object that should not apply on squashed layers. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/compositing/CompositingLayerAssigner.cpp?rcl=5909b5622777f87eb25763ccd8ff349413422742&l=165 TBR= # for enabling a temporarily disabled test Bug: 813221 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie395f025935028f29b2f5de25674698227550b93 Reviewed-on: https://chromium-review.googlesource.com/927001 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538968}
-
Bill Orr authored
Oculus wants submitted textures to be in SRGB format. WebGL is rendering linear color space, so we need to convert. Bug: 812408 Change-Id: I25fc2ca95a62ec95ef7773c17ad2001910a845e5 Reviewed-on: https://chromium-review.googlesource.com/935494Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538967}
-
dpapad authored
settings-toggle-button, and cr-toggle need to be migrated from 'click' to 'tap' at the same time, otherwise calling stopPropagation() has no effect. Bug: 815069 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I44015ff3e5a0a94c6625bc9cfad9ce0e88e43c11 Reviewed-on: https://chromium-review.googlesource.com/935152Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#538966}
-
Lei Zhang authored
This reverts commit 4bd85181. Reason for revert: Depends on r538891, which got reverted. So this needs to be reverted as well to make the tree green. Original change's description: > [CrOS Tether] Trigger a host scan after device is unlocked. > > When combined with > https://chromium-review.googlesource.com/c/chromium/src/+/929867, this > CL will cause a notification to appear when unlocking a device if a > Tether host is nearby and the device is not connected to the Internet. > > Bug: 813838, 672263 > Change-Id: I9c0cd3b047c46dacba0f3acc84d03e2f0abf452c > Reviewed-on: https://chromium-review.googlesource.com/935476 > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Commit-Queue: Ryan Hansberry <hansberry@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538931} TBR=khorimoto@chromium.org,hansberry@chromium.org Change-Id: I2a150fc3072d09f42b114b8c2f118c65af6da833 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 813838, 672263 Reviewed-on: https://chromium-review.googlesource.com/936061Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#538965}
-
Reilly Grant authored
- WindowOpenApiTest.RemoveLockedFullscreenFromWindow - WindowOpenApiTest.RemoveLockedFullscreenFromWindowWithoutPermission Bug: 815379 Change-Id: I702f508d0944b1c9e35cc926d0689a52acdb7dbe Reviewed-on: https://chromium-review.googlesource.com/936004Reviewed-by:
-
John Abd-El-Malek authored
Don't send new subresource loader factories to the renderer for failed commits when the network service is disabled. This was an unintended change in r524876. Bug: 814913 Change-Id: I60c45cc44a9295902fba553e0ddac704b6ac895a Reviewed-on: https://chromium-review.googlesource.com/935368Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#538963}
-
Wez authored
We are introducing a cross-platform version of cronet_unittests, initially for Linux, Mac and Fuchsia, so having the special Android- specific test binary with the same name makes it impossible to set up the GN isolate mapping correctly. Bug: 808075 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I104259ab0ab9f3533600665555d67946bb39fcfc Reviewed-on: https://chromium-review.googlesource.com/933591Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#538962}
-
Reilly Grant authored
This reverts commit e20f89c8. Reason for revert: HostScannerImplTest.TestNotificationDisplaysMultipleTimesWhenUnlocked in chromeos_components_unittests is failing on multiple builders Original change's description: > [CrOS Tether] Change the behavior of "available hotspot" notifications. > > Previously, such hotspots could only be displayed once per use login > to ensure that we do not spam the user. However, user feedback indicates > that users expect to see the notification each time they unlock their > devices again. This change makes it possible for the notification to be > displayed multiple times per user login, as long as the user has locked > their device in between each time. > > Bug: 813838, 672263 > Change-Id: Ib1c400b0b9c335e7c42193edfad5a324a2f05be7 > Reviewed-on: https://chromium-review.googlesource.com/929867 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538891} TBR=achuith@chromium.org,khorimoto@chromium.org,hansberry@chromium.org Change-Id: Ibdb1d6a79706cc1cff2a6b513aea8cbc2dca5bb7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 813838, 672263 Reviewed-on: https://chromium-review.googlesource.com/935901Reviewed-by:
-
Khushal authored
The original change[1], did not flip this bit. Oops. [1] https://chromium-review.googlesource.com/c/chromium/src/+/918122 R=piman@chromium.org BUG: 776216 Change-Id: Ib47b542134aac46b2fd04d6647d9cc42d83a06c7 Reviewed-on: https://chromium-review.googlesource.com/934975Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#538960}
-
Lei Zhang authored
Before r526819, the utility process performing the PDF to EMF conversion disconnects itself. Its ServiceUtilityProcessHost notices the disconnection and deletes itself. With r526819, the utility process no longer disconnects itself, and waits forever for its host to tear down the connection. Meet this new expectation and tear down the connection from the host side. BUG=814984 Change-Id: I505673a82eb4748898819c6664802238738443bb Reviewed-on: https://chromium-review.googlesource.com/935631Reviewed-by:
-
Lei Zhang authored
Change-Id: Iace17c672f5fb92a6073831f9da55c2cf400b518 Reviewed-on: https://chromium-review.googlesource.com/935496Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#538958}
-
danakj authored
When a renderer or other viz client shuts down, the CompositorFrameSink may not have been notified about all the SharedBitmapIds being deleted. In that case the shared memory would stay in the display compositor's ServerSharedBitmapManager forever, leaking that memory space. So have each CompositorFrameSink implementation remember what SharedBitmapIds it has told the display compositor about, and remove them all when the implementation is destroyed. R=kylechar@chromium.org NOTRY=true Bug: 730660 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia1aff6f9035b4713ece787f49ceb1d6c0f839c15 Reviewed-on: https://chromium-review.googlesource.com/929989 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#538957}
-
Andrii Shyshkalov authored
Only documentation and global/refs.cfg file are new here. Configs are pure copy-pasta. No-Try: True Bug: 815072 Change-Id: I7863b95323b2ba6a05d1d56f60e9b67808fa36b8 Reviewed-on: https://chromium-review.googlesource.com/935582 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#538956}
-
Tarun Bansal authored
Add more checks to the test to aid in debugging on the bots. Note that the test passes on the local machine. Bug: 813599 Change-Id: Ie9617b5604bdabe76bc41ed7bf7d42a0a63aeaba Reviewed-on: https://chromium-review.googlesource.com/935302Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#538955}
-
https://pdfium.googlesource.com/pdfium.git/+log/3760afa05acd..26820b474343 $ git log 3760afa05..26820b474 --date=short --no-merges --format='%ad %ae %s' 2018-02-23 rharrison Setup testing XFA using .in files Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0998bcc30ab92c4fe47f6d87e17c7041a21da753 Reviewed-on: https://chromium-review.googlesource.com/935500 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538954}
-
Peter Kasting authored
This changes the form of DoNothing() from a simple no-arg function to a class that produces callbacks via templated operator(). This allows callers to replace base::Bind(&base::DoNothing) with base::DoNothing() for a small boilerplate reduction; more importantly, it allows using DoNothing() to replace existing no-op functions/lambdas that took more than zero args, and thus had to be manually declared. This removes dozens of such functions and around 600 LOC total. In a few places, DoNothing() can't be used directly, and this change also adds explicit callback-generating Once<>() and Repeatedly<>() members that will produce a callback with a specific signature. BUG=811554 TEST=none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I37f87b35c6c079a6a8c03ff18ec3a54e1237f126 Reviewed-on: https://chromium-review.googlesource.com/903416 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#538953}
-
Yuichiro Hanada authored
This CL fixes the issue when connecting an external keyboard that has a Caps-Lock key. The issue happening when mapping Search key to Caps-Lock key on the internal keyboard will be addressed later. Bug: 747823 Test: Manual. Confirm that Caps-Lock + Q generates @ and Caps-Lock is not enabled after that. Change-Id: I96c378d85ca85ce0d78bbc1ebd57bd44fb5f1a5f Reviewed-on: https://chromium-review.googlesource.com/933667Reviewed-by:Dan Erat <derat@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#538952}
-
- 23 Feb, 2018 13 commits
-
-
Sergey Ulanov authored
Enabling layout tests on Fuchsia bots. Only smoke tests are currently enabled. For most tests output matches Linux. Added new expectations for the cases when the results are different from Linux (in such cases they often match Android). Bug: 778467 Change-Id: Id26f7de9ec397cca46a83fae9937f7c3f6d6ce60 Reviewed-on: https://chromium-review.googlesource.com/917188 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Jia authored
base::Time could go backwards, while TimeTicks does not increment when system is suspended. In this cl, we implement a BootClock that only increases and does not stand still when system is suspended. Bug: 802942 Change-Id: Id5127758ecf8c443c936b8e62f8ef6ae07cb1735 Reviewed-on: https://chromium-review.googlesource.com/928044Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
-
Matt Mueller authored
Change-Id: Ic44c20f5dcb25ab86b90ad2df75b8a91dfa253b1 Reviewed-on: https://chromium-review.googlesource.com/933704 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#538949}
-
Emircan Uysaler authored
This CL moves GMBVFP usage inside WebMediaPlayerMS. Since MediaStream no longer passes frames through main thread, earlier blocker for the bugs have been resolved. Uploading to GMBs in the WebMediaPlayerMS section where we pass on IO thread makes more sense as we can track hidden or backgrounded state there. Bug: 653200 Change-Id: I95a9ca1cfa52d94e9001b4a499cc3ab71c2c71a3 Reviewed-on: https://chromium-review.googlesource.com/927707Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#538948}
-
Nico Weber authored
https://chromium-review.googlesource.com/c/chromium/src/+/933862 added chromium_linux_clang_and_gl_gtests to the UBSanVptr Linux bot, while the ToT bot only runs chromium_linux_clang_gtests -- and gl_unittests doesn't run under ubsan yet (see blockers of crbug.com/815183). So switch UBSanVptr Linux to chromium_linux_clang_gtests instead. Many of the tests that were run on UBSanVptr Linux do pass, so run those on ToTLinuxUBSanVptr too. Namely, aura_unittests, capture_unittests, chromedriver_unittests, components_browsertests, compositor_unittests, dbus_unittests, events_unittests, gin_unittests, media_unittests, mojo_common_unittests, mojo_unittests, nacl_loader_unittests, ui_touch_selection_unittests, and wm_unittests now run on the ToT bot. Generally check that if a test is disabled on ToTLinuxUBSanVptr it's disabled for UBSanVptr Linux too (notably, interactive_ui_tests no longer runs on the non-tot bot, which also doesn't pass. But services_unittests now does run, like on the tot bot). Bug: 814099, 815183 Change-Id: Icef0bd597f740774351a112df1d2c891ee371d24 Reviewed-on: https://chromium-review.googlesource.com/934424Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538947}
-
Cherie Shi authored
as there is no reports indicating any connection closed with visitor nulled. Bug: 546668 Change-Id: I21522e3786d3e9fabd2e2786ddc8929227bcd5ab Reviewed-on: https://chromium-review.googlesource.com/935300Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#538946}
-
John Williams authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9b006ee2b566712ac2f62f8c0599054176f9bafc Reviewed-on: https://chromium-review.googlesource.com/917307Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#538945}
-
Reilly Grant authored
This reverts commit c70d2d70. Reason for revert: <INSERT REASONING HERE> Original change's description: > Clean up chrome_switches.{h,cc} and move to lib "non_code_constants" > > This CL consists of the following changes: > 1) Remove function PowerOverlayEnabled() which is not used. > 2) Remove function ExtensionsDisabled() which is not used. > 3) Move ExtensionsDisabled(base::CommandLine) to chrome_extensions_browser_client.cc, > which is the only call site. > 4) Move chrome_switches.{h,cc} to lib "non_code_constants", as they don't contain any > functions now. > > After this change, including "chrome_switches.h" (and "chrome_constants.h") > only requires a dependence on lib "non_code_constants", rather than lib > "constants" which is overkill. > > This applies to notification_helper which only includes "chrome_switches.h" > and "chrome_constants.h" under chrome/common. > > Bug: 734095 > Change-Id: I3be5ffff70e9f594989c2058dca0ef109eabf085 > Reviewed-on: https://chromium-review.googlesource.com/930368 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Xi Cheng <chengx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538941} TBR=sky@chromium.org,chengx@chromium.org Change-Id: If9a6c26836432e7b857ec350abc9370fac810f7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734095 Reviewed-on: https://chromium-review.googlesource.com/935758Reviewed-by:
-
rbpotter authored
This function is used outside of cloud print (in webui/print_preview) and will be needed by the print backend service in future. Split from https://crrev.com/c/902668 Bug: 809738 Change-Id: I00a668db965e1b179dd87ee19b2d6e37faeba44b Reviewed-on: https://chromium-review.googlesource.com/912274 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Peter Boström authored
Changing "Edit..." to "Advanced" caused layout problems, so moving to the shorter "More..." as "Edit..." conflicts with the "Edit bookmarks" title of the dialog. Bug: chromium:812362, chromium:814668 Change-Id: Id11a7c463c20c5a6508c863882a6f0be8d9f2b8d Reviewed-on: https://chromium-review.googlesource.com/935626Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#538942}
-
Xi Cheng authored
This CL consists of the following changes: 1) Remove function PowerOverlayEnabled() which is not used. 2) Remove function ExtensionsDisabled() which is not used. 3) Move ExtensionsDisabled(base::CommandLine) to chrome_extensions_browser_client.cc, which is the only call site. 4) Move chrome_switches.{h,cc} to lib "non_code_constants", as they don't contain any functions now. After this change, including "chrome_switches.h" (and "chrome_constants.h") only requires a dependence on lib "non_code_constants", rather than lib "constants" which is overkill. This applies to notification_helper which only includes "chrome_switches.h" and "chrome_constants.h" under chrome/common. Bug: 734095 Change-Id: I3be5ffff70e9f594989c2058dca0ef109eabf085 Reviewed-on: https://chromium-review.googlesource.com/930368Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#538941}
-
Becky Zhou authored
+ Change the globe icon for both modern and non-modern + Change padding to vertically align the close icon to the menu icon Bug: 812924 Change-Id: I60312acf2ea561c92bdd2779c1540b65c8f4695f Reviewed-on: https://chromium-review.googlesource.com/927691Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#538940}
-
Jian Li authored
When a saved page is opened from Android Downloads or 3rd party app, we need to query the Offline Pages DB based on the size and digest of the MHTML content in order to find out if there is a trusted offline page assoicated with it. Bug: 758690 Change-Id: I732a9a41e367310231436c5701377d38516849a6 Reviewed-on: https://chromium-review.googlesource.com/932744 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#538939}
-
