- 18 Oct, 2018 40 commits
-
-
Michael Spang authored
This is a pure interface so it can inline the dtor and doesn't need to hide the ctor. Bug: none Test: compile Change-Id: Idbf3cd3ca8397b3c0883f5e7759151ff9d29ab55 Reviewed-on: https://chromium-review.googlesource.com/c/1283476 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#600970}
-
Koji Ishii authored
When marking the first line box dirty, this patch checks if the line box exists. Normally NGBlockLayoutAlgorithm suppresses box fragment if no line boxes exist. However, NGColumnLayoutAlgorithm may generate box fragments for column boxes. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie5697a524cd6fc1067fc4c03466e88fa8d5da68b Reviewed-on: https://chromium-review.googlesource.com/c/1288769Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#600969}
-
Michael Spang authored
Input device node names always start with exactly "event". Bug: none Test: compile Change-Id: I7e332f16901fa979eff7b1553ae6439a0806b9fd Reviewed-on: https://chromium-review.googlesource.com/c/1287103 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#600968}
-
Tarun Bansal authored
In local testing, there are two separate reasons for flakes: (i) Histogram tester does not return correct values even though the relevant code has already logged the histogram values correctly. (ii) The via header value is set too late by the unittest. The first problem is sort of solved by waiting for the histogram to populate. The second problem is solved by setting the via header value in the test constructor. Bug: 760294 Change-Id: I9ae23e4b704f6eaa51fd9c37f76491008c6cb1c6 Reviewed-on: https://chromium-review.googlesource.com/c/1289689Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#600967}
-
Ahmed Fakhry authored
Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. R=sky@chromium.org BUG=857331, 896514 TEST=Added a new browser test. Reviewed-on: https://chromium-review.googlesource.com/c/1284289Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600408} Change-Id: I388bc5056f956bea2edffc7127dcab533824e56b Reviewed-on: https://chromium-review.googlesource.com/c/1287510 Cr-Commit-Position: refs/heads/master@{#600966}
-
Donn Denman authored
Adds a context menu item to take a "Sneak peek" at a link using the overlay panel. This provides an ephemeral tab to view a linked page (once fully implemented. Currently the menu item has no effect when selected.) See go/ephemeral for a detailed design. BUG=894619 Change-Id: I3856e1524d37f82d065d9f8322cebda972d269a0 Reviewed-on: https://chromium-review.googlesource.com/c/1286097 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#600965}
-
Tommy Nyquist authored
This CL updates the UI to show a badge icon in the app menu icon whenever the user is running Chrome on a currently unsupported Android version. This badge in the app menu is only displayed once, until the user taps the app menu icon. If the user does in fact get a new version, the badge state is reset, and will be shown again. The current behavior for out of date users stays the same as before (once per cold start). In addition, a new menu item is displayed at the top of the menu that explains that Chrome is unable to update. Nothing happens when you tap the menu item in the case of an unsupported OS version. The new menu item and the new warning message in About Chrome will always be displayed when the user is in this state, regardless of whether the app menu has already been tapped (which removes the badge). This CL also updates the UI in Settings - About Chrome to show a new message and a warning icon when the user is running Chrome on an unsupported version of the Android OS. By default, Jelly Bean is considered unsupported after this CL, but this can be overridden from the variations framework. It is possible to use command line flags or chrome://flags for testing the different states, though that does not impact the About Chrome screen. Binary-Size: This CL adds new assets and the minimal code required. Bug: 847940 Change-Id: I0d8653c8ac93f80241c70283effe2105e20af190 Reviewed-on: https://chromium-review.googlesource.com/c/1289470Reviewed-by:
-
Yuwei Huang authored
We release the reference to _client when ClientConnectionViewController opens up the HostViewController. When the connection is dropped, the ClientConnectionViewController pops out without transferring the ownership of _client to ClientConnectionVC, so user now cannot send feedback by tapping "report this". There is no retain cycle between RemotingClient and ClientConnectionVC or HostVC so it is fine to make ClientConnectionVC keep the reference to _client after the HostVC is showing. Verified that no RemotingClient persists in any scenarios after the connection ends. Bug: 888277 Change-Id: I25940441327f5bf1a77eeb072d6fc45fc991e02f Reviewed-on: https://chromium-review.googlesource.com/c/1287438Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#600963}
-
khmel@chromium.org authored
Some user feedbacks are overflown this message. This happens after adding "arc.apps.default" prefs. "default" appeared in arc.apps listing. Fix to check if this is valid crx id as it done in different places of this file. TEST=Manually BUG=b/117566030 Change-Id: I79384e58ab31593f571b2ce4542dfbfbc3d2447f Reviewed-on: https://chromium-review.googlesource.com/c/1289992Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600962}
-
iOS Autoroller authored
TBR=smut Change-Id: Ib94e90e40c763771517461fe61d38f2af74b27d2 Reviewed-on: https://chromium-review.googlesource.com/c/1289750Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#600961}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If391adaae4e4970a0d4edd6df913a470c094a43b Reviewed-on: https://chromium-review.googlesource.com/c/1289658Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600960}
-
Morten Stenshorne authored
In the collapsed table borders model, all borders (from the table itself, table sections, table columns, table rows and table cells) are painted in the background-and-borders phase of the table. We need special code to prevent the background of a self-painting-layer table-cell from overlapping with the borders that have already been painted. Similar code exists for legacy in TableCellPainter. Bug: 869878 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I190dd6a152e751f6b30409104fb466ca46bb9024 Reviewed-on: https://chromium-review.googlesource.com/c/1289890 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f94579d3c84c..91031585f0fd git log f94579d3c84c..91031585f0fd --date=short --no-merges --format='%ad %ae %s' 2018-10-18 yshaul@google.com chromeos_config: Remove _no_unittest_boards from chromeos_config 2018-10-18 dgarrett@google.com Reland "chromeos_config: Move all CQ slaves to swarming." Created with: gclient setdep -r src/third_party/chromite@91031585f0fd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic8968fe22aa0517ff345553664fbbca932b74534 Reviewed-on: https://chromium-review.googlesource.com/c/1289653Reviewed-by:
-
Sunil Kumar authored
Test : Cast CQ / Manual Bug: internal b/117938330 Change-Id: I96e4ec912548e08f2030213b12d6064b66f98d68 Reviewed-on: https://chromium-review.googlesource.com/c/1288857Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Sunil Kumar <skx@chromium.org> Cr-Commit-Position: refs/heads/master@{#600957}
-
Ethan Xu authored
This CL fixes a java.lang.StringIndexOutOfBoundsException in HostBrowserLauncherParams#createWebShareTargetUriString() when the WebAPK receives the following share intent: Intent intent = new Intent(Intent.ACTION_SEND); intent.setTyle("text/plain"); BUG=None TEST=HostBrowserLauncherParamsTest.* Change-Id: If14cafcb43ed3f7668a7165e071674027713316d Reviewed-on: https://chromium-review.googlesource.com/c/1285069 Commit-Queue: Ethan Xu <xuethan@google.com> Reviewed-by:Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#600956}
-
Jun Mukai authored
The previous one was reverted due to failures on ASAN/LSAN bot (see crrev.com/600462). Those failures are fixed by crrev.com/600889 so this simply relands the same config. BUG=883523 TEST=none TBR=sky@chromium.org Change-Id: I0d4ee97bf3a446bcae359e7c5bf9125e48a4405a Reviewed-on: https://chromium-review.googlesource.com/c/1289680 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#600955}
-
Xiaocheng Hu authored
CreatePositionWithAffinityForBoxAfterAdjustingOffsetForBiDi() expects an |offset| in range from 0 to box length. However, a call site in LayoutText::PositionForPoint() incorrectly adds |box->Start()| to it, causing out of range offsets. This patch fixes it. Haven't found any incorrect behavior in wild due to this bug, but it's an obvious bug so let's still fix it... Change-Id: Id7deb528b18aa4c36d0a18bb564ede3dcc138110 Reviewed-on: https://chromium-review.googlesource.com/c/1289684 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Patrick Monette authored
The current implementation uses a combination of SHBrowseForFolder, GetOpenFileName and GetSaveFileName, which are deprecated. The IFileDialog, on the other hand, is the currently supported API to display a file dialog on Windows. Bug: 73098,884075 Change-Id: Ifbab2dae5046bf9e38b866d9ae99dbccc1fa9bbe Reviewed-on: https://chromium-review.googlesource.com/c/1252914Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#600953}
-
Michael Spang authored
Bug: none Test: none Change-Id: I8ec80e17c394d68bfb4bdbd4813f58054dee5615 Reviewed-on: https://chromium-review.googlesource.com/c/1284853 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
dpapad authored
There is a race condition between when Polymer calls observers and when it updates a two-way bound variable in the parent element. Bypass the isuse by using the observers parameter instead. Bug: 896509 Change-Id: I63b13c858b62214d7973af641f67c659de9ea674 Reviewed-on: https://chromium-review.googlesource.com/c/1289410Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600951}
-
Rouslan Solomakhin authored
Before this patch, Android Oreo and newer blacked-out the status bar, so the time and battery icon, for example, were not visible during payment. This patch sets the payment dialogs status bar icon color to be either white or black, depending on the status bar background color. These changes apply to Android Oreo and newer only. After this patch, the status bar icons are always visible during payment. Bug: 890183 Change-Id: Ia478ec9461b05bd4cb2993fd11b301a9ec0f4704 Reviewed-on: https://chromium-review.googlesource.com/c/1286744 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#600950}
-
Joe Downing authored
There are several bugs tracking falky tests on this buildbot and this suite is yet another which has mutliple tests timing out w/ no discernable cause. Marking experimental so sheriffs do not need to retriage/snooze this issue each time the flake occurs. Bug: 876615, 840369 Change-Id: I9c8bd562a32ef352322f27a93a58c45dd091d91e Reviewed-on: https://chromium-review.googlesource.com/c/1289574Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#600949}
-
Scott Violet authored
This reverts commit 297fdf47. Reason for revert: Causes failures single process mash interactive ui tests. Original change's description: > adds ability to track when keyevent processed asynchronously > > This adds the ability to register a callback on a KeyEvent that is called > when async processing completes. This is important for content as key events > may be handed to the renderer, which means the event is asynchronously > processed. > > BUG=891489 > TEST=none > > Change-Id: Ifaad1b88b0256ea2c69128663c24b1803e7f7321 > Reviewed-on: https://chromium-review.googlesource.com/c/1262405 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600910} TBR=sadrul@chromium.org,sky@chromium.org Change-Id: I0dd537e67aff1ffbc59a89afc0707db0db4ccc3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891489 Reviewed-on: https://chromium-review.googlesource.com/c/1289993Reviewed-by:
-
David Black authored
Assistant UI is hidden when tapping outside of the widget. We should also check if the user is interacting with the virtual keyboard to avoid closing Assistant UI while the user is typing. Bug: b:117833352 Change-Id: I95437c4bd495321cf41c8add6d4ab283b771a442 Reviewed-on: https://chromium-review.googlesource.com/c/1287262Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#600947}
-
Andrew Grieve authored
Change-Id: Ic7bed4a8c89a7df4591af9d1eb79b843dcc8a98a Reviewed-on: https://chromium-review.googlesource.com/c/1288958Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600946}
-
Christian Biesinger authored
And also mark Child as WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS Change-Id: I6ba20fa19e13c9dfafda35b0825392cb28aa97f1 Reviewed-on: https://chromium-review.googlesource.com/c/1289700 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ec8dc1f8ab8..fff636607ed5 Created with: gclient setdep -r src-internal@fff636607ed5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie0ef46c62ca9b2768d7e23de7eb14a73f7bdae95 Reviewed-on: https://chromium-review.googlesource.com/c/1289651Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600944}
-
Clark DuVall authored
Bot failing again, this time from http://crrev.com/c/1270096 which added some new tests. TBR=jam@chromium.org Bug: 893572 Change-Id: I9cda2cf50cec142ddd22ffc665113e10404ca43f Reviewed-on: https://chromium-review.googlesource.com/c/1289951Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600943}
-
Tarun Bansal authored
Bug: 891458 Change-Id: I144a1eb2c528b0e02f45a7b000628c07b1ba78c3 Reviewed-on: https://chromium-review.googlesource.com/c/1287893Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#600942}
-
Scott Violet authored
This reverts commit c2433fd3. Reason for revert: Reverting as this seems to have caused test failures. See https://00e9e64bac17b1a1e709c8fd95db1163ae475ac6cb06a35508-apidata.googleusercontent.com/download/storage/v1/b/chromeos-autotest-results/o/249805514-chromeos-test%2Fchromeos4-row2-rack3-host13%2Fdebug%2Fchrome.20181018.142111.20626.dmp.txt?qk=AD5uMEsH944iWjB3hVfYpYveYY42yDmeSmaloi4T8m-qV5_5eEJmNDeb1lBby-lFFErlO5nO1QKigTyOqGM--MbgBRyVWOh1G71dEW0D1U8URRam461zfRh3yO4CsZ2gD4-F8rUcI3wlwDLIK8uiM6GgpljDlz8j_dUpxUZnjB2zzPDuXcRSW8njM3dEtsGnFkK3pRpRA7Ml_CYfC2efi41kv9cagTfZjme31xasl2qHrhH9U7_8AabIZzRQJXbZsVMQHfTsrQG5PCrLMgtuZrQojX9bx9CLqXYQbU6enBSR-GSCE76QhbU731YVfickBBA-cMEzWoN9IlysucYQxKe7nL4HELnqhP_RdPKbpyvHueQRFNeQG2wIs4Eko02vXqFc3isaXPzSUD35IH8nbxXtJeS4-heV7Tl3y3dwyJKJx6Ef4jKJzLx8iruvVEpvzDqEwswVlNrWjBDVScq9-mwhnQPiarhrKKxIzamGmyskBv9PzHlkvRntO-b2Me_j5R2SAxR7NVAdVbwdN05a9Ud_csUqpoUcg3c9GBYauKH3U9H5jmNwR927PHu0dtiiPJ31FgxPpG7s-VM9bNEiKBVJak3i1ZiANmHaDabPy34Efz2yhinKtx8ujApPjbTKVyYBdKNSBNKdhHG2Pl9eiDOL56tA7s52FiQ4mxwP85z1wvyzWHXn4G7ruHbKGmYU39zcmeiQ15fCQQmoDLr7VB_NRn7evWi0yvtB7GnLF6wHnP8NwHPDqcWfWc88S3rIPpHDyzoCL2TQ_IMKj4PCelPbcVKVPBOJzsMIYe8wZgM-P402yNyH4f0MX-4wQjHSVn3ueMJ3gTZA-sbNALo-qRz9jWqAkMOSWina_265HMh9hBQ3RwVN0BLts8F3M_REF9rtA_F2UZwy for one example. Original change's description: > Add Enable methods to keyboard_controller.mojom > > The CL: > * Introduces keyboard.mojom.KeyboardEnableState, an enum used to track > the various states that control whether the virtual keyboard should > be enabled. Some states enable the keyboard, others disable it. > * Moves ownership of the states and the state machine to determine when > the keyboard should be enabled to KeyboardController. > * Adds mojo interfaces to set and clear states, get the current enabled > state, and explicitly reload the keyboard. > > Note: All mojo API calls to change an enable state will also enable or > disable the keyboard accordingly. This is consistent with existing > logic where these calls are made so should not change any behavior. > > Note: Not all calls to keyboard_util.cc helpers have been replaced, > including a few in src/chrome, only places where no additional > re-factoring is required were changed. > > Bug: 843332 > Change-Id: I64aad28f0c630ce5d37cab0e5ccfe40013078356 > Reviewed-on: https://chromium-review.googlesource.com/c/1275132 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600798} TBR=jamescook@chromium.org,stevenjb@chromium.org,tsepez@chromium.org,shend@chromium.org Change-Id: I6eabcf4bee1bfc53506a1cca8a2ba0d0e6aa14d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/c/1289954Reviewed-by:
-
John Abd-El-Malek authored
Manual repro steps: 1) start linux_chromeos's chrome with: --user-data-dir=/tmp/chrome --login-manager 2) login and close chrome 3) in "/tmp/chrome/Local State", replace OAuthTokenStatus's value from 4 to 3 4) start chrome again with same command line parameters and sign-in 5) the outgoing network request should have a Cookie header Bug: 896862 Change-Id: I79b96ba071c3485578223a1a16ef6a48350c760f Reviewed-on: https://chromium-review.googlesource.com/c/1289674 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1cb0e3a86df8..798a713685a9 git log 1cb0e3a86df8..798a713685a9 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 mtklein@google.com re-enable effect deserialization for flutter 2018-10-18 brianosman@google.com Add bitmap-as-shader case to P3 GM 2018-10-18 egdaniel@google.com Add function support for vulkan ycbcr conversion. 2018-10-18 herb@google.com Blacklist dftext 2018-10-18 brianosman@google.com Return texture color space when converting raster images to proxies 2018-10-18 fmalita@chromium.org Trim SkPictureShader's key Created with: gclient setdep -r src/third_party/skia@798a713685a9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I7d4a14d7d6a23ebe666fd0ad594c89bf547fe211 Reviewed-on: https://chromium-review.googlesource.com/c/1289652Reviewed-by:
-
Fabrice de Gans-Riberi authored
This CL adds tests for the fuchsia.oldhttp service Chromium implementation. These tests ensure the service is capable of sending URL requests, receiving a response and/or an error code as expected. The service implementation files have been moved around under a single directory for consistency. Bug: 874155 Change-Id: Iae843adc62db054a17125cea10b17771c127b801 Reviewed-on: https://chromium-review.googlesource.com/c/1239627Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#600938}
-
David Bokan authored
The touch action filter currently relies on checking the GestureScrollBegin event for whether we need to filter or not. It assumes a pinch-zoom will cause a GSB with a pointer_count == 2 and so pinch-zoom is filtered in that way, since we always bracket GesturePinch events between a GSB and a GestureScrollEnd. However, this breaks down for double-tap-drag zoom (i.e. double tap but hold and drag the second tap to zoom). In this case, the pointer_count is 1 so we don't filter it. In this CL, we remove the bracketing of pinch gestures in the double-tap-drag zoom case and allow activating the filter at GesturePinchBegin. We must now track in the TouchActionFilter whether we've seen a GestureScrollBegin so that we know whether to apply and remove the filtering at GesturePinchBegin/GesturePinchEnd. Bug: 865090 Change-Id: I25e426f6f48dbf0ebcecfbddee5e2d8cbcc40504 Reviewed-on: https://chromium-review.googlesource.com/c/1279236 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#600937}
-
Andrey Kosyakov authored
Bug: 838291 Change-Id: I591d86d2ca3a12c3975f84d0159c5fd55badc8a7 Reviewed-on: https://chromium-review.googlesource.com/c/1285753 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600936}
-
sczs authored
- InfobarCoordinator now owns the InfobarContainerView. - Creates a consumer protocol to communicate between InfobarContainerIOS and InfobarContainerView. Paving the way for a mediator. - Deletes cr_transitionWithView in favor of the stock method since InfobarContainerView was the last class using it Bug: 892376 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5ed216e48096bf59ec485460dc42dab250177e01 Reviewed-on: https://chromium-review.googlesource.com/c/1287315 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600935}
-
Doug Arnett authored
This is a step toward supporting Slow Page Triggering as may be indicated in the optmization guide hints. A follow-on CL will use this surfaced ECT threshold. Bug: 895581 Change-Id: Ic8cca4c03eb1700223a83980e9376e7612197290 Reviewed-on: https://chromium-review.googlesource.com/c/1289150Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d59bf5f..67ed0448 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3731b3722b8658e21d01dcba98c1bd01e5b6f72f Reviewed-on: https://chromium-review.googlesource.com/c/1289570Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600933}
-
wutao authored
This cl adds a11y heading to query log in the AssistantQueryView. Bug: b/113734499 Test: tested on EVE Change-Id: I5dcca50ef2b6a28e050b3dc462437c60036c56d7 Reviewed-on: https://chromium-review.googlesource.com/c/1285051 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
-
Sahel Sharify authored
This is a reland of f24f12dd This cl is using RenderFrameDeletedObserver to avoid crbug.com/889002 which is the cause of the crashes in flakiness dashboard: https://chromium-swarm.appspot.com/task?id=409ddad025e7a610&refresh=10&show_raw=1 Original change's description: > Added Fling Bubbling browsertests. > > The tests were initially landed in the following cl: > https://chromium-review.googlesource.com/c/chromium/src/+/1278963 > > The logic of the cl is re-landed in a separate cl(r599781) to give it > more time to bake. This cl re-lands the browser tests after applying > the following changes: > > 1- Addressed renaming nit. > 2- Used MainThreadFrameObserver to make sure that compositor is synced > after scrolling on main thread. > > Bug: 894703 > Change-Id: I25d6dbf7f216bbedecb6673d6c2819dcd1d82d55 > Reviewed-on: https://chromium-review.googlesource.com/c/1286875 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600509} Bug: 894703 Change-Id: I07b802b807c93beb684378e2fe18357fabf3ecbe Reviewed-on: https://chromium-review.googlesource.com/c/1289515Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600931}
-
