- 26 Jul, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If3be2ddc9846b35888b5ac6174ff0eb9fe4ca9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319260Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791653}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0ffac8f25150..3b2cd31c7400 2020-07-26 capn@google.com Update Vulkan headers to version 1.2.148 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4b8220aad62a2b2e8c889f6e78fa37cb00836bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319257Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791652}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0af0cc63711d..ed1310e11068 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Icfae6b93353be9239f1dc2aedfb0eae2bf12cc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319256Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791651}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595548091-fbf1089422fe94cc098aa428bb435f8d7f2c1e43.profdata to chrome-win64-master-1595743199-2ae9238defd87beaa44a6caba317a80f7d0a5f76.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I40625c8a60ae644000a5854500410a9359decfbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791650}
-
Chris Harrelson authored
This fixes a typo in the original patch that missed a negation of IsLayoutView. See diff with patchset 1: https://chromium-review.googlesource.com/c/chromium/src/+/2319409/1..3 Tests: paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html (on high-DPI) Bug: 1100711 Change-Id: I54f4e05494ee2fda4dafac74a92b67a8bc756c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319409 Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791649}
-
Yuki Shiino authored
Change-Id: I5e2f56fcad692d0a1b8c5cfaaeb7cdf824377c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313616 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#791648}
-
Aya ElAttar authored
Changed ClipboardDataEndpoint to support virtual machines, like Crostini, PluginVM, ARC++ as potential sources or destinations of the clipboard data. Bug: 1103217 Change-Id: I3ff721a8fbc685adfb5779b1edb579da4062ff24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315030 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791647}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4eaf6d79edfa..0ffac8f25150 2020-07-26 capn@google.com Refactor native instruction intrinsics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2515aab4ab065557300760d403ae60ad7024f89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791646}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/ui. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 1106699 Change-Id: Id83d2e9bb3cb147da6363981cd7ac20a6daa956a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316207 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#791645}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595743199-22efd79a8f382cf756210a15cbf2b66a618fb4f9.profdata to chrome-mac-master-1595762871-f57a18dae0d23eb5476a17afe73c8569c909d4b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4361c7a0307867d7b3afd5c965f10ff229ade979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319254Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791644}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/257412e085dc..0af0cc63711d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Id872e624b022d7a3ffad35b8157d4f77a04c089f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319548Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791643}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74b3eb7a..374acd70 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I245af2fc69b8dc279b080a689c386512794f9af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318929Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791642}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b6b2984f40d..257412e085dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I27630f759753f7fad482b42a3284f82a7261f9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319530Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791641}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15292955fea1..392da6ba3027 2020-07-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I8ba7324050c31dffaac6244f1548f81cbf975f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791640}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibc03e36080ee24048ed47704f23095da334388a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791639}
-
Lei Zhang authored
As explained by jdoerrie@ here: https://crrev.com/c/2253564/4/base/pickle.cc Change-Id: Ie36ac8f031d261819a9e9226f7226be1b6247898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315418 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791638}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cba20b21bdac..8b6b2984f40d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Id029875c2cd8fedffe891adb92f9574801b479a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319457Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791637}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595699927-ce7b3c1cfa4d0f0111933ec52963fcbdda760fdb.profdata to chrome-mac-master-1595743199-22efd79a8f382cf756210a15cbf2b66a618fb4f9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1840bd1c25a02956cb8076e5a4ab2651e71ee95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319458Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791636}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4ceefeb36e0e..e490afec61da 2020-07-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9735912fda1e9b4c57ec5d27f828a8cfd9065cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319451Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791635}
-
Anupam Snigdha authored
Text service framework(TSF) on Windows platform already triggers a focus call to the top level HWND that should receive keyboard focus. This happens in |TSFBridgeImpl::OnTextInputTypeChanged| and |TSFBridgeImpl::UpdateAssociateFocus| where the thread input manager sets focus on the HWND by calling |SetFocus| and |AssociateFocus| respectively. |RenderWidgetHostViewEventHandler::SetKeyboardFocus| explicitly calls |::SetFocus| on the HWND that leads to side-effects when narrator is active as it intermittently switches focus to the legacy HWND that results in VK dismissal and also puts the state machine of the VK in a weird state. Calling |::SetFocus| also has perf implications as TSF listens to this API call and does a reentrant call to Chromium to fetch document states. I tested both hardware and virtual keyboard with this change and I don't see any obvious issues. Removing this call also fixed the accessibility issue where the VK was getting dismissed after first keystroke. Bug: 1106556 Change-Id: If8146d2b97a36799a8ade1c514fb238c67e76b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314980Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#791634}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie2f41726c302e5755445d3fab6418f06d4cd3eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791633}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61f247378358..cba20b21bdac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I053fbc0940d7567aa93c379d992188b12d1ba19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319449Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791632}
-
Xing Liu authored
This CL fixes a bug that download may disappear on Android Q after they are completed. We query and cache the display names from media store only when there are more than 0 in progress downloads. So the cache might be empty and we use the cache for completed download as well, which result in missing display name and download history db recorded being removed. Also directly check Android version in c++. The current code loads Q API when loading Java static methods in DownloadCollectionBridge, which triggers disk read violation on Android P. Bug: 1106286 Change-Id: I2338a665a2147154ffd20df447fe74b84a8c8738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314299 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#791631}
-
Xing Liu authored
When selecting download later in the download later dialog, checkbox is now disabled, and the positive button text is changed to "Next". Bug: 1107620 Change-Id: Idf08c8675b81b6eb67affbe0ebd231ded621fbf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316447Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791630}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I83906a3a9ec1c6e3dbc186834ed411533b037651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319407Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791629}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e873f801..74b3eb7a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0c237add66b0395b96522e9038ec4ef784daa91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319290Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791628}
-
Alexander Alekseev authored
This Cl moves show_aggregated_damage from RendererSettings to DebugRendererSettings (thus making it dynamic) and adds checkbox for it in Ash HUD settings. Bug: 1106855 Change-Id: Id42dcd54476eac3d4b2c4339f4e6c7b4c38709f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315437Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#791627}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic929607ff75ba1106f989a7a1e621731baf79ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791626}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/668b0530e130..60cbf70944cf 2020-07-25 titovartem@webrtc.org Remove deprecated ctor from DefaultVideoQualityAnalyzer 2020-07-25 titovartem@google.com Add time controller conformance test and fix conformance bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2304e5bb9f8864da720bffdb65a0333d91556563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791625}
-
Chris Harrelson authored
Previously, DragImageForSelection forced lifecycles twice; the second time was due to the call to ClippedSelection. Change-Id: I4bca2f5cdb9fefffc6a54d1233d315d721bb0539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317769Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791624}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibf43654e520b28b60586401cfd4857f095a1c2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318546Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791623}
-
Kalvin Lee authored
This change modifies several call sites in printing code to avoid constructing base::StringPiece instances from nullptr. Bug: 1102941 Fixes: 1102941 Test: autoninja ... chrome printing_unittests Test: ./printing_unittests Change-Id: If5797f6d41a03c9cfdf9eb5d40f063159a9193e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313978 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#791622}
-
Chris Sharp authored
Bug: 1108908 Change-Id: Ia74d7c3f9e7151f365a1a5d0ce4f45d54312f672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315838Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#791621}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595678123-cab8caa4f93e8afba47417bd0b38f6939852da88.profdata to chrome-mac-master-1595699927-ce7b3c1cfa4d0f0111933ec52963fcbdda760fdb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Id5e5843f939335dd5a3a1c661989fc974e8d5332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791620}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96de0520b550..61f247378358 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419 Tbr: Change-Id: I30351b591976696652cb7ac75e61d6c1e5fcb474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318968Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791619}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Id069238f74018916bd8065b93ecb44d5d2ef9ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319350Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791618}
-
Sadrul Habib Chowdhury authored
Add behdadb@ and jonross@ as the owners for rendering benchmark. BUG=none R=vmiura@chromium.org Change-Id: I6d37c552857146c16bc844bd3f452d6c13f6574b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316328 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#791617}
-
Ian Kilpatrick authored
In order to correctly layout a flexbox, and run the flex algorithm, we need to have the correct scrollbar state. Previously we'd perform a "pre-layout" in order to get the correct state. This caused a performance issue on a site which was performing double layouts on a subtree which was flipping between scrollbar state. This changes FlexNG perform a relayout of the flexbox, if any flex children have changed their scrollbar state from when they were initially measured. Bug: 1063575 Change-Id: I84149ad564961349a69ff134429a0e4b4fb038dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314997 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791616}
-
Brian Geffon authored
This CL introduces the userspace swap policy as described in go/userspace-swap. The policy is only concerned with the "when" of userspace swap and not the actual userspace swap implementation itself. The swapping part will be handled in a later CL which will contain the "mechanism" part of userspace swapping. This CL uses information about renderers to determine if they are eligible to be swapped and if so it will trigger the userspace swap process to the mechanism. BUG=chromium:1067833 Change-Id: I9a1f635c96401701f4c1cad44ba403582f2af828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295926 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#791615}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3b3914d7. With Chromium commits locally applied on WPT: 9c2ef271 "[COOP report] Add support for report-only" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bajones@chromium.org: external/wpt/gamepad binji@chromium.org: external/wpt/wasm domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kozyatinskiy@chromium.org: external/wpt/console NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ie709385657bcecae35029914cb0f50d01d57d14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319287Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791614}
-