- 15 Oct, 2019 40 commits
-
-
Hiroki Nakagawa authored
This test is flaky on multiple platforms. See the following link for details. https://bugs.chromium.org/p/chromium/issues/detail?id=923627#c10 Bug: 923627 Change-Id: I89f94f1cdbca08251bcbf03a55679124beb6bca7 Tbr: mcnee@chromium.org, tdresser@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861434 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#705821}
-
Koji Ishii authored
This patch removes |out_floats_for_min_max| from |NGLineBreaker|. The caller instead computes the list of unpositioned floats from |NGLineInfo::Results()|. This change is needed for fixes for crbug.com/10118167 and crbug.com/1001000, but does not fix them. Fixes some cases of |ComputeContentSize()| DCHECK failures in crbug.com/976304, but maybe not all. |out_floats_for_min_max| was originally added in r619070 (crrev.com/c/1365984) to keep track of unpositioned floats. But today, |NGLineInfo::Results()| has all unpositioned floats. Furthermore, changing rewind logic for crbug.com/10118167 caused several tests to fail because we don't adjust |out_floats_for_min_max| when we rewind. This patch avoids mismatch of the two lists by unifying them. blink_perf.layout looks neutral: https://pinpoint-dot-chromeperf.appspot.com/job/108a2986c20000 Current assumption is that looping items isn't too expensive, but we could add a flag to |NGLineInfo| if this loop turned out to be more expensive in some cases. Bug: 976304, 10118167, 1001000 Change-Id: I4a5cb98f5dc6d331a699991390d7bd97ce51cd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857844 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#705820}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f056de19cad1..d0b7b0ccae01 Created with: gclient setdep -r src-internal@d0b7b0ccae01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I51cb9eae8053ab2e1e363dd4ac04e7c4559b548f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860285Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705819}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I9d5ed8edec28f5d0da934d625d2a5b2aa086836b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859908Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705818}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/40e1e14c..517b740d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I64b40b7b168e9f8068b84c6d0fbf199748c8c190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860781Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705817}
-
Gary Kacmarcik authored
We need to update the permissions check dialog to handle the new Screen Recording permission added in Mac OX 10.15. Bug: 1012826 Change-Id: I3d062a76b44267746091a9b21163edefb4d312de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860278Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#705816}
-
chrome://test/dpapad authored
Also bring back |extraLibraries| override in welcome_browsertest.js (along with a new explanatory comment), which was removed in a previous CL. Bug: None Change-Id: Ib3ed274af8519bbc541eeb435c6cc37abfa3611f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860149 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#705815}
-
Yue Zhang authored
This CL adds a check in TabGridDialogMediator to skip saving title when group no longer exists, i.e. the group becomes a single tab or the last tab in group is closed. Also, some unit tests are added for this check. Bug: 1013973 Change-Id: Id6cab4bec07ffbdbbe2daf12fe792d281fcb84af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860394 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705814}
-
Dan Beam authored
Conjoins omnibox's transparency UI and the NTP realbox's removal UI on omnibox::kOmniboxSuggestionTransparencyOptions. Note: this leaves the keyboard shortcut (Shift+Delete) intentionally enabled, as this is what Omnibox does. R=mahmadi@chromium.org Bug: 1002689 Change-Id: Iffdbd7a94567fce3352c0b7611229f9ddb4846b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861275Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#705813}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2527379a1c2..88b8e3962362 git log e2527379a1c2..88b8e3962362 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 mmortensen@google.com Update unit test so that it works inside and outside the SDK. 2019-10-15 saklein@chromium.org binhost controller: Cleanup parallel postsubmit binhost. 2019-10-15 cjmcdonald@chromium.org Remove bug link for new parallel_emerge Created with: gclient setdep -r src/third_party/chromite@88b8e3962362 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I29f4ffc8ba099840b459a2cb0a20d51191cc778a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860283Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705812}
-
Meredith Lane authored
Enabled by default in stable for awhile now, so safe to remove. BUG=860016 Change-Id: I2deea943849ce11a3db2a98e85df6c6aee5d38cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850689Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#705811}
-
Dan Beam authored
Pressing unmodified Delete is currently throwing. R=mahmadi@chromium.org Fixed: 1013833 Change-Id: Ia895d0977595562e8ea636a063a88bd663a0ebad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861113 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts XRRuntimePtr and mojo::Binding<XRRuntime> in chrome and device to the new Mojo type, and use pending_remote<XRRuntime> in isolated_xr_service.mojom. Bug: 955171 Change-Id: I663f37d58678d7175a9ce15a4d5244c7a142ceda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847707Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#705809}
-
Miyoung Shin authored
This CL converts TCPServerSocket{Ptr, Request} in chrome, components, content, extensions and services to the new Mojo type, and uses pending_receiver<T> in network_context.mojom and tcp_socket.mojom and pending_remote<T> in viz_main.mojom. Bug: 955171 Change-Id: I5c2fb8e46d35d57a3358c92d132053f71377161b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851884 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Bill Budge <bbudge@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#705808}
-
Asanka Herath authored
Currently the HttpAuthHandlerNegotiate::Factory() is responsible for determining the maximum token size on Windows. This is done prior to constructing the HttpNegotiateAuthSystem. Conceptually the maximum token length is a property of the Negotiate auth "system" (really should be called "mechanism"). Someone constructing this should not have to know the token size. That's the kind of thing that this abstraction layer is supposed to enapsulate. Moreover, the "NegotiateLibrary" (i.e. the platform interface) currently needs to be understood at both above and below the HttpNegotiateAuthSystem abstraction layer. In addition, to being an abstraction violation, having the library be known above the HttpNegotiateAuthSystem layer means that the functionality of the library needs to be accessible outside the HttpNegotiateAuthSystem. In order for us to cleanly cleave out privileged token operations out of the network process, we need to make sure such functionality is neatly tucked away on one side of a single abstraction. This is issue 991265. Furthermore, having library access scattered outside HttpNegotiateAuthSystem makes it difficult to move time consuming SSPI operations into a separate thread. This is issue 711186. To address these issues this CL moves the token size determination into HttpNegotiateAuthSystem. Things still aren't quite there yet, but it's a step in the right direction. This change results in a behavior change. Currently the availability of the Negotiate authentication mechanism is determined when constructing the first HttpAuthHandlerNegotiate. With this change, the decision moves to GenerateAuthToken(). Fortunately for us Chromium is not supported on any Windows platform which doesn't have the Negotiate authentication package. Hence there should not be any observable behavior change. Bug: 991265, 711186 Change-Id: I9a30db15c6332a1304bc29112a0c26105a35282f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814621Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705807}
-
Maggie Cai authored
This CL adds PWA implementation for |LaunchAppWithIntent|. BUG=853604 Change-Id: I6257f8d473d1368f0e769b1cca332cc72808bf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851628 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705806}
-
Maggie Cai authored
Add Intent URL launch source for web apps. BUG=853604 Change-Id: I226c941c9ea2a96be6fed9d4b0598862a750e15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855541Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Maggie Cai authored
The intent picker for all desktop platforms is launched in M77, so extend the expiry milestone to M80. BUG=None Change-Id: I6f5c057237273b3415866d3d959e50f1dd571c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858027Reviewed-by:
Melissa Zhang <melzhang@google.com> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#705804}
-
Chris Harrelson authored
Change-Id: Ie3e6f0bb185ed5e2ba8a25bd22e4c537306a1880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860485 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705803}
-
James Darpinian authored
Uses the new DisableExtension functionality from https://chromium-review.googlesource.com/c/angle/angle/+/1838418 to prevent ARB_texture_rectangle from being exposed to WebGL shaders. Bug: angleproject:3770 Change-Id: I106785757235f3f1748d74ddf25dac9384caa281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842223Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#705802}
-
Wei Wang authored
In this patch, ServiceWorkerProviderHost::PreCreateFor* functions are renamed due to the face that all provider hosts are precreated after OnProviderCreated is removed. Bug: 932318 Change-Id: I6b7c87c03fac687d4108d09fa95d5fb13ffa69d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856928 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#705801}
-
Yannic Bonenberger authored
This reverts commit 6216be03. Reason for revert: Causes crashes in Canary: https://crbug.com/1014075 Original change's description: > [ServiceWorker] Stop resurrecting uninstalled workers > > Previously, service workers were resurrected when they were updated > or when the same script was registered while the service worker was > still alive. Now, registering a service worker will always create a > new instance, regardless of whether there already is a running > instance or not. > > Chrome status: > https://chromestatus.com/feature/5646687634718720 > > Intent to Implement and Ship: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/r176Lvgxfys/4W4IGM4uAgAJ > > Bug: 971571,988582 > Change-Id: Id7748377af107099d7c10fb2e455f30f7423e5f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768759 > Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705159} TBR=falken@chromium.org,kinuko@chromium.org,yannic.bonenberger@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 971571, 988582, 1014075 Change-Id: I070b328a33db63ac3dba128d43d026c86aec1498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860029 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e7b5c5e99289..acf66fdd4e87 git log e7b5c5e99289..acf66fdd4e87 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 jdarpinian@chromium.org Fix registry_xml.py dependency Created with: gclient setdep -r src/third_party/angle@acf66fdd4e87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: I8cf38bff09e90b9b5ad50b0d54d99e7ac1b2f084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860282Reviewed-by:
-
Hiroki Nakagawa authored
This crashes on Linux CFI bot. See https://crbug.com/1014343 for details. Bug: 1012167, 1014343 Change-Id: I3cb444e26225146d2d1540c4320a524aef951c4f Tbr: tangltom@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861314Reviewed-by:
-
Eric Karl authored
Adds the following for de-jelly: - About:flags entry for enabling the experimental feature. - Support for reading "enable_de_jelly_for_chrome" system var. - A finch kill-switch in case we need to disable this codepath. Bug: 995965 Change-Id: Idbe24a8b3062f7d3dfc36b3f814c37e9f9b6129a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859585 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#705797}
-
Rakina Zata Amni authored
The MaxFrameCount UMA records the maximum number of frames in a page, and is triggered by RenderFrameDeleted. Since RenderFrameDeleted is not called on a bfcached frame when we navigate away from it (but will be called when it is evicted from the bfcache/the tab is closed/etc), the |max_frame_count_| is already overwritten and should not be recorded. Bug: 1010870 Change-Id: I669e91aec29af74d3b9e154356b034b50aeaf75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855543 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705796}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e18484723e86..f056de19cad1 Created with: gclient setdep -r src-internal@f056de19cad1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8700202c647b62e93b05a1b93434482fd41c7fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860280Reviewed-by:
-
Miyoung Shin authored
This CL converts ResolveHostClient{Ptr, Request} in chrome, components, content, extensions and services to the new Mojo type, and uses pending_remote<ResolveHostClient> in host_resolver.mojom and network_context.mojom. Bug: 955171 Change-Id: Idc0b8a474e884d7d8fef0cf3bcd668c0dfd201b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860024 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705794}
-
Miyoung Shin authored
This CL converts HostResolver{Ptr, Request} in chrome, extensions and services to the new Mojo type, and uses pending_receiver<HostResolver> in network_context.mojom. Bug: 955171 Change-Id: I99b384615a73b2fdd6fa49ff284aa7962c7ebd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859778Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/61d564ff3b00..e2527379a1c2 git log 61d564ff3b00..e2527379a1c2 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 saklein@chromium.org sysroot_lib: Stop adding deprecated chrome binhost. 2019-10-14 saklein@chromium.org goma_util: Bypass path_util.ToChrootPath calls. Created with: gclient setdep -r src/third_party/chromite@e2527379a1c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I34cae77489b6e71f476179cc243620e1b802b09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860408Reviewed-by:
-
Miyoung Shin authored
This CL converts TCPConnectedSocket{Ptr, Request} in chrome, components, content, extensions and services to the new Mojo type, and uses pending_receiver<T> in network_context.mojom and pending_remote<T>, pending_receiver<T> in tcp_socket.mojom. Bug: 955171 Change-Id: I397ec01420af1c4d6d33061ce814809a36a69bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851366Reviewed-by:mark a. foltz <mfoltz@chromium.org> Reviewed-by:
-
Dominick Ng authored
BUG=1012164 TBR=jbroman@chromium.org Change-Id: I58df8af772f651520a321c67f90f96f945f721dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855620 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705790}
-
Austin Tankiang authored
The new feature is working fine and enabled by default, so the flag is unneeded now. Bug: 1013999 Change-Id: If7a82d3f01b386ce8cd0a5c2d56271e1aa704bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858023Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#705789}
-
Andrew Xu authored
Due to my previous CL (crrev.com/c/1849096), |first_tappable_index_| and |last_tappable_index_| are calculated in the wrong way. This CL fixes such an issue. Bug: 1013811 Change-Id: I2723070b8a0ecfef31e82433148d1df84937e23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857043 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#705788}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a6ff36bd..40e1e14c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75655db73db5a68babb0343897028255fd293d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860778Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d7aaf46aeb4..858cf233ef71 git log 7d7aaf46aeb4..858cf233ef71 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 csmartdalton@google.com Call setNeedsStencil() when clearing stencil Created with: gclient setdep -r src/third_party/skia@858cf233ef71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:10083125 Change-Id: I78a9947a4ed6983cad567c46b19cf37da91032bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860405Reviewed-by:
-
Daniel Libby authored
From code inspection and running the referenced test, there is no querying of composition state under FrameSelection::UpdateAppearance. Remove the comment and DisableCompositingQueryAsserts Bug: 1007989 Change-Id: Ibbd66413bc1cdbe897e474b5fd55d515e8822368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856849Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705785}
-
minch authored
Update the drag distance for max drag progress. Ripple radius and affordance transform should also be updated at the same time. Relationships: drag_distance drag_progress ripple radius transform 0 0 0 0 (80 + 20) 1 32 100 (240 + 20) 2.6 40 116 See recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiM3JsNE4tdkNxR1VnemZESHdkbm1pVU03T1Jv/view?usp=sharing Bug: 1002733 Change-Id: I98a877d41bced755d144f3583d688ca21fae4c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856870 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#705784}
-
Eric Willigers authored
Update WebAppMetrics histograms when the kDesktopPWAsWithoutExtensions feature is enabled, and a web app launches. Not yet updating: histograms indicating if an app was installed by the user. Bug: 918986 Change-Id: I66b356776b7de5d6c6156517777b92e56dbd92a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846625 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#705783}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2b47014e. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 0583f458 "Fetch Metadata: split up `document` destination." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I99cb790d016d082b82bd807f95ef5cf6bd4c38a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860777Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705782}
-
