- 27 Jul, 2020 40 commits
-
-
Jit Yao Yap authored
This CL adds kRemote to AppService's AppType enum to represent Remote Apps. Bug: 1101208 Change-Id: I406ada51944643e070f39e03a7e18152975d907c DD: go/cros-remote-apps Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275882 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#791725}
-
Brandon Goddard authored
This cl fixes a bug where scale was not applied to the positioning of the computed track size labels for CSS Grid overlay, causing them to be misplaced on high dpi monitors. Before: https://imgur.com/B970mXx After: https://imgur.com/GLR5s2l Bug: 1109014 Change-Id: Id762b7ef04041ff8fffe9db958dfc58585858cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316793 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791724}
-
Kent Tamura authored
Bug: 1108270 Change-Id: I7f2e5e9cc547342f580f8c87bae768981fa3341d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318952 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#791723}
-
Takashi Sakamoto authored
This is a sub-variant of ENABLE_TAG_FOR_MTE_CHECKED_PTR. At first, the tags in the bitmap have to be initialized for an entire slot span upon allocation (rare operation) and then subsequently set to a new value for an entire slot (not slot span) every time that slot is freed. Bug: 1092288 Change-Id: I0c2f06ab580e941f3db1a4c51dfa8e4617acd1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308554 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#791722}
-
sauski authored
CL enables the deletion of access records which effectively contain browsing history by extending the AccessContextAuditService as a HistoryServiceObserver. Access records are deleted for top frame origins when the service is notified that no more history entries exist for that origin. Bug: 1101675 Change-Id: If98eda4d27f35a92f6580231d7a4c67179aa3dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288085 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#791721}
-
Renato Silva authored
Extend the Quick Unlock Private API to support two additional methods - setPinAutosubmitEnabled - canAuthenticatePin setPinAutosubmitEnabled will allow Chrome OS settings to control the PIN auto submit behaviour. canAuthenticatePin is a simple method that checks whether it is still possible to authenticate using a PIN. This only adds the skeleton for the extension and does not call any code yet. It only returns with false for now. Bug: 1107367 Change-Id: I0c961b2d2cf236e05b9bf959603d4e4a459b6f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306040 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#791720}
-
Yuki Shiino authored
Ports a temporary support of @@asyncIterator introduced at https://crrev.com/c/2248414 to the new IDL interface implementation. Bug: 839389 Change-Id: Ib0ea64ec8c8fbc582ba5472ab8d10ee4b43e0e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312456Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791719}
-
Hiroki Nakagawa authored
As a part of the Onion Soup project, this CL moves InternetDisconnectedWebURLLoader from content/renderer/loader to blink/public/platform/. Change-Id: I67883a154da02deeff3a64d12614c28c93e77e59 Bug: 860403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317585Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#791718}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/53453f76b5d0..befe11cae7c1 2020-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0d158ac68107 to d5a4775cfc77 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I8ec2359242ec0f8843c8c95c6741e646c766309a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791717}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca17e785dd06..c0b2923dc9d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: Id61e80ea3d4b28df1365ef582dd14f0c51de8ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791716}
-
Chris Harrelson authored
This removes a reference to IsPaintInvalidationContainer in LayoutTable, which in turn removes a dependency of PrePaint on compositing. The need to paint on the table's DisplayItemClient appears to no longer be necessary. The code was added in: https://chromium-review.googlesource.com/c/chromium/src/+/540178/ Change-Id: Ib1066d176511cfa4adc16579cc8aa7fc7475868f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317848Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791715}
-
Mario Sanchez Prada authored
This test has been disabled in https://crrev.com/c/2303433 due to it being flaky. However its stack trace matches the one observed recently in production code (crbug.com/1107103) so we're re-enabling it now and adding some extra debugging information in order to help us fix the issue, as it hasn't been possible to reproduce it locally so far. Bug: 1107103 Change-Id: Ifeee8483c83e72b52a232b71ef2437ecab6bf305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316101Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Auto-Submit: Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791714}
-
nancylingwang authored
ARC apps use arc::IconDecodeRequest to decoding images safely in a sandboxed service for the security reason, so modify app_icon_factory to call arc::IconDecodeRequest to decode ARC icons. Modify AppServiceAppWindowArcTracker::OnTaskDescriptionChanged to use the unified apps::ArcRawIconPngDataToImageSkia interface. BUG=1083331 Change-Id: Iea350de985ff60203e0acd7a427fe0a9e34c098e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318846Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791713}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07ae186b5ed8..3f851efa2adc 2020-07-27 syoussefi@chromium.org Vulkan: Fix overflow in maxCombinedUniformComponents If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I9fcce09e69c5109b77611ef85b8383baa330dcd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791712}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1c1a51ad. With Chromium commits locally applied on WPT: 9c2ef271 "[COOP report] Add support for report-only" 78eb43f6 "Fix hit-testing culled inline for atomic inlines" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I0033df4748ca13054cc0123b52fe5824a889b25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318530Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791711}
-
Johann authored
Sometimes this file shows up in the chromium sheriff-o-matic as an ongoing failure for webkit_lint. It's very flaky which is probably why it has not been resolved before. This clears these warnings: TestExpectations:2728 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t425-hsla-basic-a.xht' is redundant with 'external/wpt/css/css-color/t425-hsla-basic-a.xht' in line 2736 TestExpectations:2733 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' is redundant with 'external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' in line 2730 TestExpectations:2734 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' is redundant with 'external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' in line 2731 TestExpectations:2735 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' is redundant with 'external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' in line 2732 TestExpectations:2737 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t422-rgba-a0.6-a.xht' is redundant with 'external/wpt/css/css-color/t422-rgba-a0.6-a.xht' in line 2729 TestExpectations:6844 Expectation 'virtual/prefer_compositing_to_lcd_text/scrollbars/custom-scrollbar-adjust-on-inactive-pseudo.html' is redundant with 'scrollbars/custom-scrollbar-adjust-on-inactive-pseudo.html' in line 6845 I chose to remove the 'virtual' versions because of the way the lint warning is worded. BUG=chromium:1108689 Change-Id: I851f971fa6f7e421a4a4c8d8b710175e99c6adcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319490 Commit-Queue: Johann Koenig <johannkoenig@google.com> Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#791710}
-
Joe DeBlasio authored
This CL adds a feature param to let us selectively disable suspicious site safety tips. It also introduces another test parameter for this case. This significantly impacts test runtime, but still seemed like something we should test. Fixed: 1107583 Change-Id: I25d9bae52a5850f3aaedf37dc8f2b303bfeb2ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316891 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791709}
-
Gavin Williams authored
Reduce the font size and remove the weight to bring in line with standard for error text. http://screen/akhrO8wiP8o Bug: 1059607 Change-Id: I75e857bcdd49cb8c042aabab985812bb949ee89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315920Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#791708}
-
Owen Rodley authored
These aren't used right now, but having them at the ready will make it easier for sheriffs or troopers who want to stop a builder from closing the tree (temporarily or otherwise). Change-Id: Iec0b12b460d54da1413f578a2b8f350fb31c9070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315719 Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#791707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b484c6ce52..ca17e785dd06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: I63b72820efd04d66bf9499c896aaa1a488f62ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319890Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791706}
-
Gavin Williams authored
Enable Printer Status flag by default Bug: 1059607 Change-Id: Ic8706b815905f9ff9208158f2657d980ad013796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315919 Auto-Submit: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#791705}
-
Miyoung Shin authored
This CL converts FrameHostMsg_Detach to content's FrameHost and RenderFrameProxyHost Mojo interface. Bug: 1093911 Change-Id: I07e762be86dc2cc0ed8981a429d4345ec2971a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282625 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#791704}
-
My Nguyen authored
Updated according to UX designer. Bug: 1109570 Change-Id: I0a39e294dd023241680a936e2551f160307402b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319806Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#791703}
-
Yoshifumi Inoue authored
This patch renames "tools/win/DebugVisualizers/webkit.natvis" to "blink.natvis" because we use term "blink" instead of "webkit" for ease of locating file. Bug: 843412 Change-Id: Ifd3150bba001b122b3ad52a88aba60ab6076e9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309321Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791702}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/342ad5228da2..0606ae6f9a56 2020-07-27 fancl@chromium.org Add subscription name to issue summary If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108677 Tbr: wenbinzhang@google.com Change-Id: I30039a707bb39ff143492e5ccaf24298b1c536d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319886Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791701}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I7c3351be98c309e93361f746d812be0dc361866d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319791Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791700}
-
Fergal Daly authored
NavigationControllerBrowserTest.SameDocumentNavigationToHttpPortZero exposed this by killing the renderer for having sent a bad message from ValidateDidCommitParams. By that point the |navigation_request_| has been consumed so ResetNavigationRequest does nothing and so CancelPendingIfNecessary does not destroy the speculative render frame. This test only fails when RenderDocument for subframes is enabled however, it seems it could happen without that. The fix is to ensure that CleanUpNavigation gets called even if there is no navigation_request_. Bug: 1100745 Change-Id: Icdcc17822be04237e9f038063d45ec993dc7ed92 Fixed: 1100745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275640 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#791699}
-
jongdeok.kim authored
Disallows LCD text if the effect node has normal filter operations. This CL simply checks only the intermediate node. Bug: 1074521 Change-Id: I6e9caec484599fa47e1649356e9762ca265bee22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312059Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Cr-Commit-Position: refs/heads/master@{#791698}
-
Honglin Yu authored
Add another two owners who come form the same team and are also primarily working on mlservice in CrOS. BUG=none TEST=no need for test Change-Id: If299a76ae10a50ed1a58edf7f02b7b34bcde3a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308614Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791697}
-
Wei Lee authored
Since we use worker for mp4 encoding in CCA. Bug: 980846 Test: The error in CCA(SWA) about content security policy gone Change-Id: Iaabec3ed8b80c1a53eec7f411f5fd3ff7284aa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257080 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#791696}
-
jongdeok.kim authored
Uses explicit deletion instead, removes use of base/macros.h. Bug: 1010217 Change-Id: If003b6afe03b27581949e4a5aaaa64eab686d7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315722 Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791695}
-
Rachel Carpenter authored
Previously this was crashing if the user tried to open the help app from an incognito browser via shortcut or menu item. Bug: 1109517 Change-Id: I217e8d0d710c4b68ef22762752727bdc7ef0f03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318888Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791694}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 97dc0827. With Chromium commits locally applied on WPT: 9c2ef271 "[COOP report] Add support for report-only" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I71c3ce16c2e52c41910bc26a6b5701aa60055da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318430Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791693}
-
Andrew Moylan authored
This reverts commit 5d615d61. Reason for revert: Rollback per pdyson concerns post-commit Original change's description: > Simplify some code and rely on TimeDelta::operator/() less. > > This code can use TimeDelta::operator%() to express the same thing in a > shorter way. Add a comment on one less-obvious block. > > Bug: none > Change-Id: I2d639ee85b4427a78a902cf8b8c1930828132edc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318967 > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Commit-Queue: Andrew Moylan <amoylan@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791688} TBR=pkasting@chromium.org,amoylan@chromium.org Change-Id: Ib9e224f477393b8798c91fe2f3c2a1e99cb7c42b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319809Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791692}
-
Koji Ishii authored
This pathc fixes hit-testing [culled inline] in the following conditions: a. The first fragment does not fit, but it is an atomic inline that it cannot be truncated. b. The atomic inline is within a culled inline. The culled inline algorithm relies on fragments from a |LayoutObject| appear in a row. Ellipsis for an atomic inline has the same |LayoutObject| as the atomic inline, but can appear at the top level. This patch fixes this by eliminating ellipsis from culled inline logic. [culled inline]: https://chromium.googlesource.com/chromium/src/+/master/third_party/blink/renderer/core/layout/ng/inline/README.md#culled Bug: 1104477 Change-Id: Ib0f7e5899e58c766554c78ddf45019deaf35ca96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318887 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791691}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4092923f790e..e1b484c6ce52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: I6e01e74514685db08ef6537735e2ec10c098ddb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319829Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791690}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595785360-983d9025ff958d5a15a6c9927ca675e304475be4.profdata to chrome-mac-master-1595807480-d008dd705c9cf90df13ad0e43c19aa435d2837a8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iffefcc9bcecaf63de79e60639180fd7f796128e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791689}
-
Peter Kasting authored
This code can use TimeDelta::operator%() to express the same thing in a shorter way. Add a comment on one less-obvious block. Bug: none Change-Id: I2d639ee85b4427a78a902cf8b8c1930828132edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318967Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791688}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1595505150-4b6923c63ca1fabc99171826cfe4658bec498e66.profdata to chrome-win32-master-1595789207-a5f1c4250bc5f6d42bdf1b980d8df879d82cd223.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I0dda001a1380258f2fef6c0e2ab9a3041f65e7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791687}
-
dpapad authored
This is necessary in order to have the Viewport class work for both PDFViewerUpdate=false/true codepaths. Previously the Viewport constructor was expecting a Window instance to be passed as the scrolling container, but that is no longer the case in the PDFViewerUpdate UI. This CL modifies the code such that the scrolling container passed to the Viewport constructor is: - the <html> element for PDFViewerUpdate=false - the #main element for PDFViewerUpdate=true In order to do so - the <html> element is given a height of 100%, so that offsetHeight has a meaningful non-zero value. - innerHeight/innerWidth is replaced with offsetHeight/offsetWidth. - pageXOffset/pageYOffset is replaced with scrollLeft/scrollTop - a new MockElement class is introduced to replace MockWindow in some tests (MockWindow is still used in toolbar_manager_tests.js) Bug: 1101598 Change-Id: I0d3fa1a8a0146c97ef636b01954911750b5be942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308865 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791686}
-