- 01 Oct, 2020 40 commits
-
-
Alex Rudenko authored
DevTools has been rolled so enabling this test. The test was marked to time out in Release builds before it was disabled. I have run the test multiple times to make sure it is not flaky and does not time out so I am removing the expectation of timeout as well. Bug: 1044424 Change-Id: Ia13dd440b4310a0c4802796619649f9d9ba2e95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440590 Auto-Submit: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#812584}
-
Makoto Shimazu authored
Bug: 1095896 Change-Id: I5f38333e48d61d42239254cbe58176d1ba5b3829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440001 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#812583}
-
Alice Wang authored
This reverts commit bd3b0ee6. Reason for revert: Likely the cause of of the compile crash on https://ci.chromium.org/p/chrome/builders/ci/arm64-unpublished-builder-rel/14332 Error: ../../clank/android_webview/next/java/src/com/android/webview/chromium/PacProcessorForS.java:34: error: constructor AwPacProcessor in class AwPacProcessor cannot be applied to given types; mProcessor = new AwPacProcessor(network); ^ required: no arguments found: Network reason: actual and formal argument lists differ in length 1 error Original change's description: > [aw] Allow to set Network in AwPacProcessor. > > Bug: 1085115 > Change-Id: I8846261a0f21ecb48692b70ab778f68996843760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414173 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Anna Malova <amalova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812494} TBR=torne@chromium.org,amalova@chromium.org Change-Id: I087cdfa4fd0f4ca71c50a38b3a01fec1f67fa7aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440600Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812582}
-
Daniel Hosseinian authored
1) Use a new method focusAndScroll() on thumbnails that disables the default scrolling behavior of focus() and uses scrollIntoView() instead. That way the scrolling behavior of focused and active thumbnails are unified. 2) Add a top padding to the first thumbnail so the box shadow is shown when the thumbnail is scrolled into view. 3) Remove the opacity transition on thumbnails, which was causing some flashing to occur while scrolling through the active thumbnail quickly using the keyboard. Bug: 652400 Change-Id: Ie8b26c670b03b4829444215d184e54e39f344924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441936Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#812581}
-
Alexander Dunaev authored
Blocking the power save mode has platform-specific bits. Ozone didn't have any support for that. This CL introduces the concept of a power save blocker for Ozone, and implements the X11-specific part of it. Bug: 1121926 Change-Id: Ic60210b55808cb30e27b0811e5fade69ac01512e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378071 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#812580}
-
Ramin Halavati authored
kRequestedFileSystemTemporary is recently removed from UseCounters in crrev.com/c/2414917 along with a number of other highly used metrics. This metric and kRequestedFileSystemPersistent are now replaced with dedicated UKMs. Bug: 990731, 1129061 Change-Id: Iba8be6a1fe4063388843f2a54f95827fefd3a42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421746Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#812579}
-
Miyoung Shin authored
This is a reland of fe6e27d6 Old ExtensionApiTest.OpenOrClosedShadowRootInBackgroundPage navigated to unnecessary empty.html and timeout error occurs as flaky, but TC already runs the background page successfully, so this CL rewrites the test case using ExtensionApiTest::RunExtensionTest simply to fix a flaky issue. Original change's description: > Allow access to closed shadow root from Extension > > This CL introduces chrome.dom.openOrClosedShadowRoot that is a > read-only property to allow access to the closed shadow root in > the Extension's content script. > > Bug: 778816 > Change-Id: I933bc5d3996a74f46ee75181c535150901a5a46a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319951 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809277} TBR=peria@chromium.org,yukishiino@chromium.org,tkent@chromium.org,karandeepb@chromium.org,mkwst@chromium.org,masonfreed@chromium.org Bug: 778816 Change-Id: I3bb7289cbc0c7c8a1c970000d87458f937acd4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428528 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812578}
-
Scott Violet authored
In contrast to other overflow types, 'clip' does not create a PaintLayerScrollableArea (a PaintLayer is created though). The approach taken to apply the clip is to accumulate overflow as is normally done, and then apply the clip (as necessary) at the end. This enables some layout tests exercising this code, but a couple are still disabled: external/wpt/css/css-overflow/clip-003.html : this one (currently) has indeterministic behavior. It triggers a vertical scrollbar, but the presence of the vertical scrollbar necessitates a horizontal scrollbar. Whether the horizontal scrollbar is added varies between ng and classic. external/wpt/css/css-overflow/overflow-body-propagation-008.html: I believe the reference test needs to be updated. The test case has a border-right, where as the reference does not. This seems to be triggering a difference on the mac, which I need to further investigate. BUG=1087667 TEST=various tests in external/wpt/css/css-overflow Change-Id: I7a44505b556da1a26da1eeffd612eeebf20c509c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414911Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812577}
-
Istiaque Ahmed authored
This CL adds the histogram Extensions.Events.DispatchWithServiceWorkerBackground when an extension event is dispatched to the background service worker of an extension. Bug: None Change-Id: I6a119dfb4d39b518201c8cf166e99a2f4595dac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441949 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#812576}
-
Nick Burris authored
This patch fixes a bug in the SPC controller logic that checks for the existence of the PaymentRequestSpec. This bug results in no UI shown when the feature is activated. Bug: 1133822 1127322 Change-Id: I27d1d6f2a53e859a132f2f73237a360979efe6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441937 Commit-Queue: Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812575}
-
Siyu An authored
We found in the metrics the number of (bubble shown) and number of (bubble closed with reason) are not matched. I am suspecting in some cases it will be logged before the close_reason is returned, and in this case the reason will be unknown[1]. [1]https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/autofill/payments/save_card_bubble_views.cc;l=123-134;drc=d9daac114a9f5c8a7bc99042d92f40dcd62c3d08 Added a logging to verify Bug: 1070799 Change-Id: I8a0cb2eb4c4158d11fcd6593777ad568947812d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441014 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#812574}
-
Hazem Ashmawy authored
Batch all espresso devui tests in PER_CLASS batches. Bug: 1120847 Test: run_webview_instrumentation_test_apk -A Batch=android_webview_devui Change-Id: I59c117d0f26e75dfe4200954ce2153db81d842e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438536 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#812573}
-
Irina Fedorova authored
This CL adds localized strings for compromised credentials sections to be used if a user is not sign in but has compromised credentials that have been found in the past. Bug: 1119752 Change-Id: Idb3a825b248f5a8f273b0ccb81f9c6229821cb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438461 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#812572}
-
Eric Willigers authored
WebApplicationInfo now uses apps::ShareTarget, for easy detection of changes. Note that ShareTarget is only implemented for web apps, not bookmark apps. Bug: 1127213 Change-Id: Iadba1cd798cc5f87c58c1af9ec1a12a66d3b60c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437994Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#812571}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c4be5db9..e9a57883 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9aa710465a2366ab9ef9d537c3e71c6357937526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440239Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812570}
-
Esmael El-Moslimany authored
Bug: 1132424 Change-Id: I1b56fdec5c37d81a4939e986b3282af4585772ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440970 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812569}
-
Nate Fischer authored
The kOutOfBlinkCors base::Feature was removed in https://crrev.com/c/2415752. This removes the corresponding Dev UI switch since it's obsolete. Fixed: 1132134 Test: N/A Change-Id: I314358545fd89ccdcf68a340da671242e4be99c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441933 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#812568}
-
Omid Tourzan authored
Bug: 491043 Change-Id: Ib87a5acf508ad25cbd5a84e584c75cb5df0d5c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422102Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812567}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b8265a309314..fae3f2841bd0 2020-10-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8e84efc7aefde658de5d075fbeebb8297e4a2e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812566}
-
Shakti Sahu authored
This CL adds metrics for the video player, which includes user clicks on various buttons, video latency, and various video playback states. Some more metrics will be added in the next CL. Bug: 1117155 Change-Id: I6ef8a515dfff43c66ca2197cf8db087b058db236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434096Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812565}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8e0aa441a550..8c337a36b2e8 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ad421a248adb to da5828c06b4c (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I1e3b628e6109eece6444228801062ae16da8f956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812564}
-
Alex Newcomer authored
For clipboard history, record the format of the item pasted or deleted in two separate metrics. Bug: 1099338 Change-Id: I903f83a6b0e22f7d55cc9e478584146aa52af4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424680 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812563}
-
Xiaohan Wang authored
A binder for interface media.mojom.CdmInfobarService for the frame scope was only registered at the chrome/ layer, but not in the content layer. So when running content_browsertests, the render process was terminated for bad Mojo message. This CL fixes the issue by using an EmptyBinderForFrame for the service at content layer. Bug: 1128445 Change-Id: I5ce49b2af3a17035bad71b165bc8c24a0bd1b9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441292 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812562}
-
chrome://flagsAustin Tankiang authored
Bug: 1067346 Change-Id: I6a4425e6398ad95b693b1a7a5d089d1da6f580b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440324Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#812561}
-
Alexandre Courbot authored
The V4L2 IP only supports MMAP and DMABUF as storage types for output buffers. Make sure to fail building the IP if the client requests output storage to be user memory, so we can fall back to another IP in this case. Bug: None Test: image_processor_test on Kukui and Hana falls back to libyuvIP instead of failing to queue the USERPTR output buffer. Change-Id: I3c66d6eb8aecaf4240b4ceac516d3c43b4d6e141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123498Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#812560}
-
Mei Liang authored
Using PopupWindow as a container has shown some disadvantages, and it is listed in https://docs.google.com/document/d/1z49-ehX2VzoY_KcMUOSDi3FU7NzqLlrQocD_M-bPZ1A/edit?usp=sharing. In addition, crrev.com/c/2399314 has also shown the difficulties of supporting accessibility with the focusable PopupWindow. This CL removes the PopupWindow usage in TabSelectionEditor by allowing TabSelectionEditorLayout attaches itself to the parent view when TabSelectionEditorController#show is called, and removes itself from the parent view when TabSelectionEditorController#hide is called. Bug: 1133014, 1124919 Change-Id: Ic53efddd9de1c22d02753c3f40df2769a5603495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438769Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812559}
-
Charlie Hu authored
This CL uses unique image URLs for image policy tests, so that the policy violation console messages do not get deduplicated. This is the prework to land violation report deduplication for document policy violation(https://chromium-review.googlesource.com/c/chromium/src/+/2405646). Bug: 924684, 926199 Change-Id: Ib736799fb7370b639e8102361c0b0d4627f0ccb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416849 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#812558}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/de0105d0bb7a..5e947adaf26e 2020-10-01 capn@google.com Fix clamping cube face coordinates to [0.0, 1.0) range If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I448a204ca60d8f0493f9ea786d637156ab3d9fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442061 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812557}
-
Chih-Yu Huang authored
The V4L2 stateful API requires the caller pass the same buffers to the output queue slot. This CL change V4L2Queue::GetFreeBuffer() signature that allows the caller get a specific output queue slot. BUG=b:159688625 TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I5245998b236dbb698df3d1ca11b6f269dd5de374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413943 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812556}
-
Ben Goldberger authored
-Resolve issue with text overlapping close button on multiline chips -Add top and bottom padding for multiline chips (12dp) -Increase start and end chip padding (16dp) and padding close button padding (16dp) -Switch to lens icon with color -Increase size of close icon to 24dp to match lens icon -Align text to viewStart Screenshot light: https://drive.google.com/file/d/1kpiDc_Wr14hPvrPqF5T9ExZhhl-nW7MQ/view Screenshot dark: https://drive.google.com/file/d/1LPfy4zJ9wYZRR9E71A6fvvgwFpPh2-b0/view Bug: 1099982 Change-Id: I41307dd2168bd3a7e0ecb3fb8c01b0df1ee64764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436516 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#812555}
-
Changhao Han authored
DevTools frontend CL: https://crrev.com/c/2438385 Bug: chromium:1133675 Change-Id: I54cc0e61a260f13944520002632109e30dbb1881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440599 Auto-Submit: Changhao Han <changhaohan@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#812554}
-
Takashi Sakamoto authored
This reverts commit 84d8dbe7. Reason for revert: Suspect causing blink_web_tests failures on WebKi_Linux_ASAN because of heap-use-after-free. First detected build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/18333 blink_web_tests failure: https://test-results.appspot.com/data/layout_results/WebKit_Linux_ASAN/18333/blink_web_tests/layout-test-results/results.html --- STDERR: ==1==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d0000065e8 at pc 0x562d5af2328d bp 0x7ffd61c33860 sp 0x7ffd61c33858 STDERR: READ of size 8 at 0x60d0000065e8 thread T0 (content_shell) STDERR: error: unknown argument '--demangle=True' STDERR: #0 0x562d5af2328c in content::AgentSchedulingGroup::RemoveRoute(int) ./../../content/renderer/agent_scheduling_group.cc:133 STDERR: #1 0x562d5af2328c in ?? ??:0 STDERR: #2 0x562d5af61740 in content::RenderFrameProxy::~RenderFrameProxy() ./../../content/renderer/render_frame_proxy.cc:248 STDERR: #3 0x562d5af61740 in ?? ??:0 STDERR: #4 0x562d5af61b7d in content::RenderFrameProxy::~RenderFrameProxy() ./../../content/renderer/render_frame_proxy.cc:246 STDERR: #5 0x562d5af61b7d in ?? ??:0 STDERR: #6 0x562d5af6712d in content::RenderFrameProxy::FrameDetached(blink::WebRemoteFrameClient::DetachType) ./../../content/renderer/render_frame_proxy.cc:620 STDERR: #7 0x562d5af6712d in ?? ??:0 --- Original change's description: > [MBI]: Use |render_thread_| instead of RenderThread::Get in AgentSchedulingGroup > > R=haraken@chromium.org, kouhei@chromium.org, talp@chromium.org > > Bug: 1111231 > Change-Id: Ia7151587a3459c5262edd5721c63dfec60870cc9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438709 > Commit-Queue: Dominic Farolino <dom@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Tal Pressman <talp@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812463} TBR=haraken@chromium.org,kouhei@chromium.org,dom@chromium.org,talp@chromium.org Change-Id: I1cda1459c45d129c669fa2736a4ea4322533515c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442211Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#812553}
-
Shakti Sahu authored
This CL adds : 1 - Sending Country code, and accept language to the server. 2 - Provides dependencies for video tutorial service creation. TBR=dtrainor@chromium.org Bug: 1133657 Change-Id: I04ed5cfecb481810e8e24102aff2d4468b44f6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438780Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812552}
-
Dana Fried authored
Changes two behaviors around hover cards: - overlong domains are now middle-elided, reducing the chance that bad data at either the beginning or end (depending on scheme) will mislead the user - blob: URLs now display as "temporary data" and no effort is made to display the "domain" of these URLs as it is not interesting at all to the user and only a source of potential exploitation Bug: 1133183 Change-Id: I4779fa477a05e0017acffb2d9b98290939887f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437154Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#812551}
-
Melissa Zhang authored
Add ActivityName to AccessibleName for screenreaders. Bug: 1131296 Change-Id: I5f01a14f8113cd00cfb3bda526da5975f7ceeb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440226Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812550}
-
Jiewei Qian authored
This reverts commit 29736b94. Reason for revert: Tests are failing consistently in linux-chromeos-rel Sample failing jobs: [1] https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41574 [2] https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41572 Tried to reproduce locally, HasMaskLayerWithLongText fails 9 out of 10 times. Error message: ../../ash/ambient/ui/media_string_view_unittest.cc:285: Failure Value of: GetMediaStringViewTextContainer()->layer()->layer_mask_layer() Actual: false Expected: true Original change's description: > ambient: handle suspend case better > > Previously ambient mode will trigger lockscreen on screen dimm and then > rely on lock screen idle to show screen saver. This works in some cases, > but in suspend case the time between screen dim and cpu suspend is too > short. Screen saver was not able to enguage. The reason we have the set > up is because the screen saver was sharing the same window constainer as > the lock screen, it cannot show before lock screen is ready. > > Now screen saver has its own window container, we changed the flow to > show ambient mode immediately when idle. This will prevent cpu suspend > because screen saver will take a wake lock if charging. Screen saver > will still lock the screen in the back if user reference indicated > lockscreen after wake. > > Bug: b:169442907 > Test: unitests and manual tests > Change-Id: I1a5df2c58c976bba492c709e0a61dd5a6314d084 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435334 > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812397} TBR=xiaohuic@chromium.org,wutao@chromium.org,cowmoo@chromium.org Change-Id: I307c11aed04801e6705be083dcaabfa2c5099802 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:169442907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440326Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812549}
-
Eric Willigers authored
We now use CreateShareIntentFromFiles to create the ChromeOS intent. Bug: 1110119 Change-Id: Ic748392818e775f7466ea7c0937f8195025b8052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437679 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#812548}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ca3683da3ad6..b8265a309314 2020-10-01 asraine@google.com [Lighthouse] Roll Lighthouse 6.4.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icb46289cb9f222620f4767ba42ca8d611d0a6647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812547}
-
Bailey Berro authored
- Adds helper methods to convert between fields in the PowerSupplyProperties proto and new mojom enums. Bug: 1128204 Change-Id: I1ceeb4e9987b5975189a725d8f346c39b45186b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431477Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812546}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 47270d12. With Chromium commits locally applied on WPT: 0c934f62 "[tables] Tables should respect the min content-size." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org, ksakamoto@chromium.org: external/wpt/css/css-font-loading NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: If857635edef8d390f942695bb53571b0397eba80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441301Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812545}
-