- 03 Oct, 2016 40 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/42b8c87e471284970ffbb20c7f2d96791f2973cd Converted the 3 nested steps into 1 step. (hzl@google.com) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=605572 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2388313002 Cr-Commit-Position: refs/heads/master@{#422576}
-
cbiesinger authored
Also for deprecated flexbox R=eae@chromium.org Review-Url: https://codereview.chromium.org/2388673003 Cr-Commit-Position: refs/heads/master@{#422575}
-
boliu authored
Revert of Android: Free GLHelper context ashmem when it makes sense (patchset #4 id:60001 of https://codereview.chromium.org/2336043004/ ) Reason for revert: Causes a null pointer crash. And also apparently doesn't work? BUG=652050 Original issue's description: > Android: Free GLHelper context ashmem when it makes sense > > Free the 'mapped_memory' that is used in readbacks through > CopyFromCompositingSurface() when there is memory pressure > in the system (or no activities are running and a readback > completes). > > This memory gets lazily allocated during the first readback > and it'd be the size of the texture after scaling. Freeing it > is harmless at a slight reallocation cost when the next readback > is triggered. > > BUG=641962 > TBR=boliu@chromium.org > > Committed: https://crrev.com/98f7c133cdef22c26922c56371f84989f7a2cd60 > Cr-Commit-Position: refs/heads/master@{#421357} TBR=danakj@chromium.org,sievers@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=641962 Review-Url: https://codereview.chromium.org/2392623003 Cr-Commit-Position: refs/heads/master@{#422574}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2390853002 Cr-Commit-Position: refs/heads/master@{#422573}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/d61f958385be..76383db4906c $ git log d61f95838..76383db49 --date=short --no-merges --format='%ad %ae %s' 2016-10-03 dsinclair Fix potentially uninitialized value. 2016-10-03 tsepez Rename CFX_WeakPtr::Clear() to DestroyObject() 2016-10-03 dsinclair Guard against double deletion of page views. BUG=651632,652103 TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2388133003 Cr-Commit-Position: refs/heads/master@{#422572}
-
einbinder authored
BUG=none Review-Url: https://codereview.chromium.org/2371393002 Cr-Commit-Position: refs/heads/master@{#422571}
-
chrome://bluetooth-internalsmbrunson authored
Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page. Adds mojom files for Bluetooth service definition and internals page handler. Adds basic Bluetooth device retrieval using starter Bluetooth service implementation for logging on web front end. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=651282 Review-Url: https://codereview.chromium.org/2357383002 Cr-Commit-Position: refs/heads/master@{#422570}
-
michaelpg authored
Fixes scrolling when tapping an item in the drawer nav menu below the current scroll position. https://codereview.chromium.org/2230123002 made MainPageBehavior try scrolling to a section synchronously, but settings-main updates the overscroll after a setTimeout. We should be able to update the overscroll synchronously as well -- we originally had issues with tests but hopefully the code is now more robust. This consolidates toggleScrolling_ into settings-main via the freeze-scroll event. Testing is difficult because of timing issues: we have to wait for the page to be fully 100% loaded before testing scrolling, or sections could change height and interfere with the test. But we don't have any way of knowing that. BUG=644583 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2312423003 Cr-Commit-Position: refs/heads/master@{#422569}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6efaefc15ef4..bd5814787caa $ git log 6efaefc15..bd5814787 --date=short --no-merges --format='%ad %ae %s' 2016-10-03 achuith Disable testTrafficSettings on chromeos. BUG=652385 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2388953002 Cr-Commit-Position: refs/heads/master@{#422568}
-
csharrison authored
BUG=647764 Review-Url: https://codereview.chromium.org/2386143003 Cr-Commit-Position: refs/heads/master@{#422567}
-
wychen authored
Review-Url: https://codereview.chromium.org/2332253002 Cr-Commit-Position: refs/heads/master@{#422566}
-
thakis authored
Also disable clang-format in one test that runs into a clang-format bug. BUG=563793 NOTRY=true Review-Url: https://codereview.chromium.org/2386333002 Cr-Commit-Position: refs/heads/master@{#422565}
-
asvitkine authored
This was showing up in the UMA callstacks profiler as taking significant time on start up. Turns out, creating and Init'ing the BreakIterator does some icu initialization which is expensive, e.g. ~50ms at the mean from dev UMA users. However, we only ever need the BreakIterator if there's a grapheme run of over 2 characters - which might be uncommon for many users. So this change makes that initialization lazy - only done when we actually need it. BUG=651848 Review-Url: https://codereview.chromium.org/2379033004 Cr-Commit-Position: refs/heads/master@{#422564}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2390833002 Cr-Commit-Position: refs/heads/master@{#422563}
-
erg authored
mash now shows tooltips on hover over items. BUG=599558 Review-Url: https://codereview.chromium.org/2379073003 Cr-Commit-Position: refs/heads/master@{#422562}
-
sadrul authored
Add content::mojom::RenderWidgetWindowTreeClientFactory to the renderer manifest, so that the browser can connect to it. BUG=none Review-Url: https://codereview.chromium.org/2385983003 Cr-Commit-Position: refs/heads/master@{#422561}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2384213003 Cr-Commit-Position: refs/heads/master@{#422560}
-
Nico Weber authored
BUG=563793 R=dcheng@chromium.org Review URL: https://codereview.chromium.org/2386353002 . Cr-Commit-Position: refs/heads/master@{#422559}
-
ericrk authored
Certain sites in the top_25 pageset are non-quiescent, which makes them non-suitable for the power metrics. We had already excluded one, but two others were causing issues. Update the filter to remove these as well. BUG=550537 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2384673002 Cr-Commit-Position: refs/heads/master@{#422558}
-
mahmadi authored
BUG=638467 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2387063003 Cr-Commit-Position: refs/heads/master@{#422557}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2388823002 Cr-Commit-Position: refs/heads/master@{#422556}
-
khushalsagar authored
This sets up the framework for a LayerTreeHostRemote that implements the LayerTreeHost API when the compositor is running across a network boundary. This change only sets the framework for running/scheduling main frame updates and pushing the serialized state using the CompositorProtoStateSink. Subsequent patches will add state serialization. BUG=648442 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2362073002 Cr-Commit-Position: refs/heads/master@{#422555}
-
watk authored
API level < 16 is not supported by Chrome, so we don't need to handle it. Review-Url: https://codereview.chromium.org/2379303003 Cr-Commit-Position: refs/heads/master@{#422554}
-
dgozman authored
Fixed immediate UI problems by introducing TargetNameChanged event. This is enough for the targets scope, modulo attach/detach tests. UI polish would be addressed later under a separate bug. BUG=648775 Review-Url: https://codereview.chromium.org/2383743003 Cr-Commit-Position: refs/heads/master@{#422553}
-
ajuma authored
This deletes AnimationCurve::AffectsScale, TransformOperations::AffectsScale, and ElementAnimations::HasAnimationThatAffectsScale. These are all unused. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2388943002 Cr-Commit-Position: refs/heads/master@{#422552}
-
jbudorick authored
Speculative -- they each are posting tasks w/ a 10s delay and may be responsible for a rash of shard timeouts on the N5X CQ bot. BUG=651279 TBR=pkotwicz@chromium.org Review-Url: https://codereview.chromium.org/2390033002 Cr-Commit-Position: refs/heads/master@{#422551}
-
asvitkine authored
Generating the icon via GetAvatarIcon() can be expensive - according to UMA sampling profiler it takes ~35ms mean time from a recent Windows dev release. Turns out, it's not even used - so this CL simply removes it. Additionally, removes a unit test that stayed around after the code it was testing was removed because it wasn't referenced in any BUILD file: ui/message_center/cocoa/settings_controller_unittest.mm BUG=651848 Review-Url: https://codereview.chromium.org/2383893002 Cr-Commit-Position: refs/heads/master@{#422550}
-
ericrk authored
The GpuWatchdogThread currently allows multiple tasks to disarm the watchdog to be posted in a row, only stopping posting when the watchdog is actually disarmed. This is fairly wasteful, as all but the first task will just early out. This change adjusts the logic so that we only post one disarm task, at a time, blocking future disarm tasks until we have successfully disarmed / rearmed the watchdog. This change also removes the current "volatile bool", and replaces this with a base::subtle::Atomic32, which makes the expectations regarding synchronization more explicit. BUG=612219 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2389633003 Cr-Commit-Position: refs/heads/master@{#422549}
-
scottmg authored
Should have filtered all of BookmarkBubbleSignInDelegateTest per bug 652402. TBR=jam@chromium.org BUG=504347,652342,652402 Review-Url: https://codereview.chromium.org/2390843002 Cr-Commit-Position: refs/heads/master@{#422548}
-
ntfschr authored
getWebViewClient returns the default client instead of null when the client is not yet set. BUG=627248 Implement getWebViewClient and getWebChromeClient Implement getWebViewClient and getWebChromeClient for new APIs in Android Review-Url: https://codereview.chromium.org/2384063003 Cr-Commit-Position: refs/heads/master@{#422547}
-
twellington authored
BUG=603343, 651317 Review-Url: https://codereview.chromium.org/2386753002 Cr-Commit-Position: refs/heads/master@{#422546}
-
proberge authored
Note that the new incident types (BYPASS_CLEARED and BYPASS_CHANGED) are only used when external (registry) validation fails and existing (secure_preferences-based) validation succeeds. BUG=624858 Review-Url: https://codereview.chromium.org/2384213002 Cr-Commit-Position: refs/heads/master@{#422545}
-
mariakhomenko authored
- Refactors app_banner_settings_helper to reuse for instant app banners - Adds persistence for app banner behaviour. Record when an instant app has been opened, dismissed, or ignored to decide whether the app should be opened by default, or the banner should be hidden. - Adds all the needed intent extras to the instant app intent. BUG=639497 Review-Url: https://codereview.chromium.org/2379783002 Cr-Commit-Position: refs/heads/master@{#422544}
-
xlai authored
This CL reflows comments based on new Blink format in the following folders: third_party/WebKit/Source/core/html/ third_party/WebKit/Source/core/offscreencanvas/ third_party/WebKit/Source/modules/canvas/ third_party/WebKit/Source/modules/canvas2d/ third_party/WebKit/Source/modules/offscreencanvas2d/ This CL has no behavior change. BUG=563793 Review-Url: https://codereview.chromium.org/2387093002 Cr-Commit-Position: refs/heads/master@{#422543}
-
jianli authored
The offline page info from extra request headers needs to be persisted in serialized navigation entry in order for it to be restored when Chrome restarts. Otherwise, we may be opening an online page without this info. The design doc for this can be found here: https://docs.google.com/document/d/1vz0a9N-9egdm3yMDYMHcNVmQHOL8Qglz54lgG4ATwhc BUG=644553 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2310363002 Cr-Commit-Position: refs/heads/master@{#422542}
-
fdoray authored
With this CL, the shutdown behavior of a task posted with a delay to a BLOCK_SHUTDOWN TaskRunner is automatically adjusted to SKIP_ON_SHUTDOWN. This ensures that a delayed task never blocks shutdown before being scheduled. This matches the behavior of SequencedWorkerPool. TBR=danakj@chromium.org BUG=553459 Review-Url: https://codereview.chromium.org/2383193002 Cr-Commit-Position: refs/heads/master@{#422541}
-
qinmin authored
This could happen for Reader mode, as it generates a new webcontents. Enabling download on Reader mode will cause other issues like overwrite infobar. As a result, we should disable download in reader mode. Will work on removing the download button from media controller in reader mode. BUG=650738 Review-Url: https://codereview.chromium.org/2392673002 Cr-Commit-Position: refs/heads/master@{#422540}
-
twellington authored
Call ShortcutManager#reportShortcutUsed when the user seelcts a shortcut or completes an action that is equivalent to selecting the shortcut. BUG=652023 Review-Url: https://codereview.chromium.org/2387193002 Cr-Commit-Position: refs/heads/master@{#422539}
-
fdoray authored
FileDescriptorWatcher is a new API that should be used instead of MessageLoopForIO::WatchFileDescriptor when possible. BUG=645114 Review-Url: https://codereview.chromium.org/2391743002 Cr-Commit-Position: refs/heads/master@{#422538}
-
yuweih authored
DesktopViewFactory is no longer used after DesktopView becomes renderer independent. This CL removes the interface. Review-Url: https://codereview.chromium.org/2386693003 Cr-Commit-Position: refs/heads/master@{#422537}
-