- 14 Dec, 2017 40 commits
-
-
Christopher Cameron authored
These are marked as obsolete in histograms.xml, but are still being generated. Bug: 777695 Change-Id: I02797b2fc00dd5eff444104bc5b665755a360599 Reviewed-on: https://chromium-review.googlesource.com/826143Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#524151}
-
Charlie Andrews authored
The benchmark regularly takes around 2h50m-3h on Android One, and has been regularly timing out for the past several months on the waterfall. NOTRY=true TBR=nednguyen@google.com Bug: 775242 Change-Id: I2945eef4c12bcf9540c93760c33f54df66dffc9a Reviewed-on: https://chromium-review.googlesource.com/827605 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#524150}
-
Justin Carlson authored
BUG=764562 Change-Id: I0e8dfdf4769c78e949da9d662fba0898ce8a98d4 Reviewed-on: https://chromium-review.googlesource.com/776010Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Commit-Position: refs/heads/master@{#524149}
-
Vlad Tsyrklevich authored
gold, used to link on Android and CrOs, does not create a read-only segment. It places read-only sections, like the one for ProtectedMemory, in the read-execute segment and could cause executable pages to be marked read-only. Workaround this by requiring the use of lld on Linux builds while those platforms are ported to lld. BUG=chromium:792777 Change-Id: I5e9fd5cebb96852f1f2891109e1ecca6cd23790e Reviewed-on: https://chromium-review.googlesource.com/823274Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#524148}
-
Stephen McGruer authored
Both EffectStack::GetAnimatedBoundingBox and CompositorAnimations::GetAnimatedBoundingBox are unused, and have been for some time. The functionality involved in them moved to the compositor at one point, then was later deleted from even there. Bug: None Change-Id: I0662e19af9c45dfdf6cba6c897b42479931076f2 Reviewed-on: https://chromium-review.googlesource.com/824565Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#524147}
-
Corentin Wallez authored
BUG=chromium:793055 TBR=zmo@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I47ae5b9c289631b8182c6015e0e975dfb341e6ab Reviewed-on: https://chromium-review.googlesource.com/825147 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#524146}
-
Steven Bennetts authored
This adds a wrapper, IsNetworkSettingsConfigEnabled() so simplify inverting the switch again if necessary. Bug: 380937 Change-Id: I5036beeb359d0381d04ec9ae0fc36a33dfee215c Reviewed-on: https://chromium-review.googlesource.com/818567 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#524145}
-
Andrey Lushnikov authored
This patchs starts running browser-side reload for data URLs. Note: this means that "scriptToEvaluateOnLoad" argument will be ignored when reloading data URLs. BUG=754470 R=dgozman Change-Id: Ib0a07a4395ea2aca881958587e82d18dded81d95 Reviewed-on: https://chromium-review.googlesource.com/823702Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524144}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7382ee76. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7713 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts TBR=leon.han@intel.com No-Export: true Change-Id: I11efa6fdb9efe2e84d40af8176fb3a58c4b75784 Reviewed-on: https://chromium-review.googlesource.com/826286 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524143}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/e9188850ec2f..77dd6c28d090 $ git log e9188850e..77dd6c28d --date=short --no-merges --format='%ad %ae %s' 2017-12-14 angle-deps-roller Roll skia/third_party/externals/angle2/ 9af765dd2..9d4d7f06f (1 commit) 2017-12-14 brianosman Remove SkClampRange (unused) 2017-12-14 mtklein quick-reject before transforming images 2017-12-14 brianosman Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGB 2017-12-14 reed convert pipe over to serial procs 2017-12-14 caryclark fix broken flatten example and update usingBookmaker 2017-12-13 reed pre-api change, preparing for expanding metadata 2017-12-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 21f67ae06..9af765dd2 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I72904aff829fa24e7d7be999d7cdf09d4c7a836d Reviewed-on: https://chromium-review.googlesource.com/827162Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524142}
-
Dirk Pranke authored
This CL adds - site_per_process_components_browsertests - site_per_process_components_unittests - site_per_process_content_browsertests - site_per_process_content_unittests - site_per_process_extensions_browsertests - site_per_process_extensions_unittests - site_per_process_interactive_ui_tests - site_per_process_sync_integration_tests to the Linux Tests and Linux Tests (dbg)(1) builders; this will also add them to linux_chromium_rel_ng in the CQ. This CL also removes these tests from the "Linux Site Isolation" builder on chromium.fyi. R=jam@chromium.org, creis@chromium.org, jbudorick@chromium.org BUG=786554 Change-Id: I5b26655138a0120e17a88e1f6aee1ae73cbb8571 Reviewed-on: https://chromium-review.googlesource.com/821554Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#524141}
-
Matthew Jones authored
Metrics indicate that users are more likely to use the bottom sheet when it is quickly swiped open instead of slowly dragged. This change updates the relevant code to handle this. The expectation in this state is that ~50% of useless swipes will be blocked while only blocking ~30% of useful ones (requiring a more deliberate fling). BUG=779615 Change-Id: Iad9928da98da9e95e77052b6bd070553b0d94243 Reviewed-on: https://chromium-review.googlesource.com/825992 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#524140}
-
Dale Curtis authored
This refactors the existing WatchTimeRecorderProvider and the existing VideoDecodeStatsRecorder::SetPageInfo into a common provider interface, MediaMetricsProvider. This is done in preparation of providing a common ID to both that represents the associated WebMediaPlayerImpl instance in a session unique way that can be used for UKM reporting. There are no functional changes in this CL, but the lifetime of the provider interface has changed. The provider interface is now bound to the lifetime of a given WebMediaPlayerImpl instance; again this is do that we can have 1:1 mapping of playback_id to WMPI. BUG=779192 TEST=existing tests all pass. Change-Id: Ia1ff5d99f2bc833fed3a973e0888666a106fdbf9 Reviewed-on: https://chromium-review.googlesource.com/821770Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#524139}
-
Vlad Tsyrklevich authored
As brought up in crbug.com/771365, if this file was compiled with use_gtk3=false it would fail because the declaration of g_gdk_set_allowed_backends was not guarded by the same #if statement guarding its use. Bug: 771365 Change-Id: Ib765cf8d59d7249aeb2f9cb1144121228edf826d Reviewed-on: https://chromium-review.googlesource.com/826622Reviewed-by:
Marshall Greenblatt <marshall@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#524138}
-
Zhenyao Mo authored
BUG=744658 TEST=bots R=piman@chromium.org,danakj@chromium.org,junov@chromium.org,dcheng@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0f75939f5996ad0767214ba817344639332f1f18 Reviewed-on: https://chromium-review.googlesource.com/826252Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#524137}
-
Daniel Vogelheim authored
Bug: Change-Id: I8cae31aaf14516949aa812f2fd65db7503bfeeb2 Reviewed-on: https://chromium-review.googlesource.com/823963 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#524136}
-
Jonathan authored
This is the initial test config for the Linux Viz FYI bot. I'll be adding more tests as we prepare them. Bug: 793820 Change-Id: I13140ef85c2b0c4819b099a83cee343814b8970c Reviewed-on: https://chromium-review.googlesource.com/826424Reviewed-by:
-
Boris Sazonov authored
This CL moves Profile instance obtaining from ProfileDataCache clients to ProfileDownloader. It improves testability of ProfileDataCache and dependent code by removing requirement for Profile object and allowing simple faking with FakeProfileDataSource. Bug: 746519 Change-Id: Ia81ef9c429384f2b9ec5e04ecb220f9aba90358a Reviewed-on: https://chromium-review.googlesource.com/824662 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#524134}
-
Vadym Doroshenko authored
This CL contains 3 small cleanups. 1.Removed unused functions isAutofilled/setAutofilled (setAutofilled is used, but isAutofilled is not used, so no reasons to keep them) 2.Removed try/catch in getPasswordFormDataList, this function is called only for main frame or same origin iframes. So no need in try/catch. Moreover function fillPasswordFormWithData_, which is called in the same circumstances, doesn't have try/catch. 3.Rewritten for loop by iframes with one line with call of .some(). Bug: 782224 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I72a07181ffd643329b7217825ec182e948b3c57b Reviewed-on: https://chromium-review.googlesource.com/825998Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#524133}
-
Fan Yang authored
Flip quic_reloadable_flag_quic_explicit_close_after_tlp to true. Fix direct reference to FLAGS_quic_reloadable_flag_quic_2rtt_drop_client_cached_certs. Merge internal change: 178764077 https://chromium-review.googlesource.com/c/chromium/src/+/825467 Deprecate FLAGS_quic_reloadable_flag_quic_bbr_fully_drain_queue and gfe2_reloadable_flag_quic_bbr_slower_startup. Merge internal change: 178696596 https://chromium-review.googlesource.com/c/chromium/src/+/824986 In QUIC, add OnStreamFrameLost to QuicSession and QuicStream. No functional change expected. When QuicStream gets chance to write, it will try to retransmit lost data if any before write new data. Add list of streams with lost data to QuicSession. When QuicSession gets chance to write, it will try to let streams retransmit lost data. A special case is crypto stream, as the data needs to be retransmitted with appropriate encryption level. Merge internal change: 178674419 https://chromium-review.googlesource.com/c/chromium/src/+/825146 Deprecate FLAGS_quic_reloadable_flag_quic_frames_deque3. Merge internal change: 178636591 https://chromium-review.googlesource.com/c/chromium/src/+/825145 Add quic_array_size. Merge internal changes: 178382821, 178776675 https: //chromium-review.googlesource.com/c/chromium/src/+/825164 Change-Id: I1006534e79cfaf2890674ea2a4841ab5419838eb Reviewed-on: https://chromium-review.googlesource.com/826083 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#524132}
-
Becca Hughes authored
It looks like some of the bots are still having problems with the preloading browser test. This ensures we use full paths for referencing files. BUG=794629 Change-Id: I814d74bf973968350207e4b6f4879f767c82a225 Reviewed-on: https://chromium-review.googlesource.com/827135Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#524131}
-
Jonathan authored
We want to begin getting coverage of browser_tests with --enable_viz. To start we would like to run them on a Windows FYI bot to find flakes. I'll be triaging the failures found so far, and updating the filter later on with the associated bugs. TEST: viz_browser_tests BUG: 794961 Change-Id: I554af1c3d308da1b7fd0496c08efa24e17bd6799 Reviewed-on: https://chromium-review.googlesource.com/822295Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524130}
-
Nico Weber authored
64-bit builds have been working for a while now. 32-bit chrome/win still cannot build on Mac hosts due to bug 794838. TBR=brettw Bug: 774209,794838 Change-Id: I762853e7e5d2b4470642402e8b585dfe8f84b53e Reviewed-on: https://chromium-review.googlesource.com/826010 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#524129}
-
Robert Phillips authored
GrBackendObject is deprecated and going away in Skia so switch to its replacement: GrBackendTexture. This does rely on the following Skia CL having rolled into Chrome: https://skia-review.googlesource.com/c/skia/+/82823 (Update SkImage::MakeFromYUVTexturesCopy to GrBackendTexture) Change-Id: I3a6445ac44d4799ce6f4d10d1ff19cda6743f955 Reviewed-on: https://chromium-review.googlesource.com/824563Reviewed-by:Brian Salomon <bsalomon@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#524128}
-
Albert J. Wong authored
LLVM fixed the bug where framepointers were not located next to the return address in thumb mode. https://bugs.llvm.org/show_bug.cgi?id=18505 With that fix, enabling framepointers on arm32 bring it in line with other build configurations and allows for better stack traces. Bug: 786450 Change-Id: I01a1c9f82fac22b2bbc15c6f52deed8aca7263ea Reviewed-on: https://chromium-review.googlesource.com/826255Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/4b9d944868d0..0e2365136c55 $ git log 4b9d94486..0e2365136 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 bsheedy Add ACCESS_VR_STATE to blacklist Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Icc2670ba271f69e3027cfd6bbf449146e3a334a6 Reviewed-on: https://chromium-review.googlesource.com/826701 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524126}
-
Devlin Cronin authored
Support displaying the errors dialog from drag-and-dropped directories. To do this, notify the developerPrivate API when a drag begins to cache the directory that is being dragged. Also add an additional parameter to loadUnpacked, useDraggedPath, to use the cached dragged path rather than prompting the user to choose a path or using a retryId. When the user drops the directory, use this to load the extension. Going through the loadUnpacked method like this has the advantage of displaying load errors to the user and allowing them to retry. Note that we cannot simply provide the filepath directly from the JS to the C++ for security reasons (in the case of a compromised renderer, we don't want to be able to add an arbitrary extension - this ensures that the user dragged the extension over the extensions page). The fact that the drag_and_drop_handler is also used by the non-MD version complicates this slightly, because we have to work for both versions of the code. This means there's a bit more mess than I'd otherwise like. This can be cleaned up when MD extensions launches. Bug: 788926 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I888b2094dcda1e964bca0f2680573387e714ea77 Reviewed-on: https://chromium-review.googlesource.com/809953 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#524125}
-
Benoit Lize authored
https://chromium-review.googlesource.com/c/chromium/src/+/823219 rolled clang past the revision including -finstrument-function-entry-bare. This reduces the instrumentation size and runtime overhead. Use this new instrumentation when possible. Size of libchrome.so: Before: 67MB After: 55MB No Instrumentation: 47MB Bug: 776702 Change-Id: I74bea84e7e6b0fa98c841ce0f2c492b6a7a7e31f Reviewed-on: https://chromium-review.googlesource.com/826623Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#524124}
-
Eric Lawrence authored
A change in Chrome 63 causes Chrome to urlencode the fragment component of URLs. The Chrome omnibox should decode the fragment component as it does for other URL components and matching Firefox. Bug: 789163 Change-Id: If82d72445d904495c8d3e4129ab63be141745328 Reviewed-on: https://chromium-review.googlesource.com/822819 Commit-Queue: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#524123}
-
James Cook authored
The switch is used to enable out-of-process chrome os system ui (ash). It used to be used by the Linux Ozone build, but isn't anymore. Limit it to OS_CHROMEOS builds to make it clear where it is actually used. Bug: 722527 Test: bots, chrome --mash, browser_tests --mash Change-Id: If980d1f843950f93f89404b658108ae0091639d9 Reviewed-on: https://chromium-review.googlesource.com/823259 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Quinten Yearsley authored
This is a follow-up to https://crrev.com//f41d2d3d4e8af. Reason: Previously, the results argument from MockGitCL would sometimes be a CLStatus, and sometimes be a dict of Build to TryJobStatus. Furthermore both try_job_results and wait_for_try_jobs would return the same type, which is longer the case for the real GitCL. The purpose of this CL is to make MockGitCL easier to use and also reflect the behavior of the actual GitCL class. Change-Id: I6d08dbdc205a1191b47039002b4a18a9579b022b Reviewed-on: https://chromium-review.googlesource.com/826707Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#524121}
-
Tim Brown authored
All usages of gconf have now been removed, so we can remove the build flag too. After this, I will remove gconf from the instrumented libraries, sysroots, and install-build-deps.sh. Bug: 768027 Change-Id: Idf5e8d60da387b3287f875092feba488217ca642 Reviewed-on: https://chromium-review.googlesource.com/826046Reviewed-by:
-
Fadi Meawad authored
As part of page lifecycle, we need to notify the page that it is getting STOPPED. This CL introduced window.onfreeze, a new callback that will fire when the page is STOPPED. If the page is resumed and not killed, then window.onresume is called. Currently, the page is stopped on Android after being backgrounded for a few minutes. More stopping scenarios are being added. When a page is stopped, all the timers will stop firing, and any load activities will be halted. The onfreeze is the last callback made to the page before it is either resumed or killed. When the page re-enters the ACTIVE or HIDDEN states, window.onresume is called. This feature is currently under a "test" RuntimeEnabled flag. Bug: 765401 Change-Id: I09486e4298a80f4a08c6c8d78bf060745e81d687 Reviewed-on: https://chromium-review.googlesource.com/764503Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#524119}
-
spqchan authored
Update the Security Overview Page in DevTools to MD. Modified the strings and introduced a title value to SecurityStyleExplanation. Updated tests to reflect this change. Screenshot: https://screenshot.googleplex.com/Qqjc0TmkaS5.png Bug: 617311 Change-Id: If7893e2fd795c53e6a9fed0542f84bbe7006f59b Reviewed-on: https://chromium-review.googlesource.com/772002Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#524118}
-
Tibor Goldschwendt authored
This change configures Chrome to - Download asset component version 1.y, - Load and decode background.png/.jpeg, - Only register assets component on Chromes (not Chromiums). Bug: 793977, 793405, 793384 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I33de68ac0c3317360c0e26ae4274242e87092ff5 Reviewed-on: https://chromium-review.googlesource.com/822835 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#524117}
-
Dmitry Gozman authored
This reverts commit 5fc3b9d0. Reason for revert: crashes, see crbug.com/794927. Original change's description: > [DevTools] Implement waitForDebugger for OOPIFs > > Using NavigationThrottle for this. Since during throttling > the navigation has not committed yet, we have to create > agent host for soon-to-be-committed frame in advance. > > Bug: 750901 > Change-Id: I88dbd982481b88eeec36209b6bf3ad7f74863200 > Reviewed-on: https://chromium-review.googlesource.com/818076 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523835} TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org Change-Id: I367776fd716614f4fd113c2f88ed3bfcbc5ac5c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 750901 Reviewed-on: https://chromium-review.googlesource.com/826496Reviewed-by:
-
Robert Sesek authored
Bug: 598854 Change-Id: Ia8bf724deef748dafa262125bad8e8b1bdaf64bd Reviewed-on: https://chromium-review.googlesource.com/826002Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#524115}
-
Eugene Ostroukhov authored
Removes "help-" prefix from the classnames as none of those styles are used on an actual help screens. Also, disables Ctrl+A on settings screens. Bug: 778585 Change-Id: I28bcd05122c1e06952db4597db2038d73f15e089 Reviewed-on: https://chromium-review.googlesource.com/822924Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
-
Quinten Yearsley authored
This is a small follow-up to https://crrev.com//f41d2d3d4e8af. Change-Id: I7d79d97a385fc964e39bd56f323dfe448cb82b89 Reviewed-on: https://chromium-review.googlesource.com/826268Reviewed-by:
-
Brett Wilson authored
This changes about 50 files, mostly in ash, to use the new API. There about 200 more files to update. A forwarding function is left for backwards compatibility for these files. Clarify usage of GridLayout::CreateAndInstall and fix payment_sheet_view_controller.cc which was installing the layout manager twice. The only functional change should be in sidebar_widget.cc where some calls are reordered. Change-Id: Iab5bad2055cc561dbc9a92600da838660849944e Reviewed-on: https://chromium-review.googlesource.com/825402 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
-
