GitLab

Review URL: https://codereview.chromium.org/981723007

Cr-Commit-Position: refs/heads/master@{#319831}

First attempt at browsers tests. I've added two tests to cover a regression
issue that came up recently where clicking the search result in the
autocomplete box didn't show all of the results. Pressing enter didn't do
anything either.

I have refactored drive_specific/autocomplete so I could make use of it.

BUG=chromium:440251,chromium:454907
TEST=browser_tests --gtest_filter="*DriveSpecific/FileManagerBrowserTest.Test/{5/6}"

Review URL: https://codereview.chromium.org/983983002

Cr-Commit-Position: refs/heads/master@{#319830}

This CL implements Fetchers which can call endpoints defined for the
IDP IFrame protocol, specifically listSessions and getToken. This will
be used as part of the Cross-Device Promo so that Chrome can mint
access tokens of a particular scope based on cookies.

BUG=463611

Review URL: https://codereview.chromium.org/973953002

Cr-Commit-Position: refs/heads/master@{#319829}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/baae7d7..95e34ab

TBR=jbroman@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/992873002

Cr-Commit-Position: refs/heads/master@{#319828}

For target android_webview_apk. This only fixes a subset
of the issues.

BUG=

Review URL: https://codereview.chromium.org/991783006

Cr-Commit-Position: refs/heads/master@{#319827}

Widen the keyboard detection logic on Windows 8 touch devices and detect slate mode to force OSK on.

Changes in this patch as below:-

1. We now check if the device is docked and avoid displaying the OSK in this case.

2. Check the auto rotation state of the device via the
   GetAutoRotationState API. If auto rotation is disabled
   or not supported we can safely assume that a keyboard
   is present on the system.

3. Allow ACPI\* device names in the keyboard device name matching code.

4. Detect if the device is in slate mode, i.e. the keyboard is flipped. We need to display
   the OSK in this case.

BUG=335735

Review URL: https://codereview.chromium.org/988883003

Cr-Commit-Position: refs/heads/master@{#319826}

BUG=358678
R=hclam@chromium.org

Review URL: https://codereview.chromium.org/983143004

Cr-Commit-Position: refs/heads/master@{#319825}

Review URL: https://codereview.chromium.org/955283002

Cr-Commit-Position: refs/heads/master@{#319824}

This CL adds the plumbing to replicate window.name updates to the
associated RenderFrameProxies.  This consists of:
- sending a FrameHostMsg_DidChangeName to the browser process whenever
  there's a window.name update in JS
- recording the changed name in the frame's FrameReplicationState
- forwarding the updated name to any of the frame's proxies in other
  renderer processes via FrameMsg_DidUpdateName.

This is a Chromium-only patch since the plumbing for getting
window.name notifications out of Blink was already in place and used
in <webview>.  <webview>'s Chromium-side window.name code is
refactored to use the new plumbing in this CL.

BUG= 426512

Review URL: https://codereview.chromium.org/974723002

Cr-Commit-Position: refs/heads/master@{#319823}

As the TODO comment by devlin in extension_toolbar_model.h, rename the methods
in ExtensionToolbarModel to be OnFoo.

BUG=
R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/988633002

Cr-Commit-Position: refs/heads/master@{#319822}

InspectorBackend converts exceptions generated by the websocket library into
Telemetry exceptions. In the process, it was losing the original stacktrace.

BUG=NONE

Review URL: https://codereview.chromium.org/990153003

Cr-Commit-Position: refs/heads/master@{#319821}

This flag will prevent an on* property from being created on the view's element.

Review URL: https://codereview.chromium.org/988293004

Cr-Commit-Position: refs/heads/master@{#319820}

Although ultimately we want to remove validators from command buffer, but the
fastest way to allow an experimental WebGL 2 is actually appending the current
validators.

Appended the BufferTarget as an sample to make sure code generator works.

BUG=463599
TEST=gpu_unittests, webgl conformance tests
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/987123003

Cr-Commit-Position: refs/heads/master@{#319819}

Add -fsanitize=cfi-vptr to list of flags disabled in AVX2 code.
https://codereview.chromium.org/982363003/

Update to b12f53
https://codereview.chromium.org/996503002

BUG=464797
R=tomfinegan@chromium.org,pcc@chromium.org

Review URL: https://codereview.chromium.org/990203003

Cr-Commit-Position: refs/heads/master@{#319818}

Previously Gallery.app truncates the file before a blob of new image is created.
This means that when some error happens during the creation of new image,
the file is overwritten with 0 bytes.
To avoid it, this CL creates the blob before truncates the file.

BUG=463837
TEST=out/Release/browser_tests --gtest_filter=GalleryJsTest.GalleryItemTest

Review URL: https://codereview.chromium.org/988273002

Cr-Commit-Position: refs/heads/master@{#319817}

We no longer use uncategorized mode.

BUG=451222

Review URL: https://codereview.chromium.org/975383003

Cr-Commit-Position: refs/heads/master@{#319816}

ServiceWorkerProviderHost will maintain associated
registration and all matching living registrations during
its lifetime. Get registration for "ready" property request
will be handled by fetching the longest matched one without
hitting the DB.

The MatchRegistration() method could also be used by
"claim" functionality later.

Blink CL: https://codereview.chromium.org/894983002/
Cleanup & Test: https://codereview.chromium.org/912443002/

BUG=454726,454250,462529

Review URL: https://codereview.chromium.org/894973003

Cr-Commit-Position: refs/heads/master@{#319815}

Chromecast has a utf8 locale, and all calls to setlocale with non-NULL
locale name fail.  Some of these issues were addressed previously in
https://codereview.chromium.org/790903003/
but we still had failures remaining in SysStrings unit tests, in
particular ScopedLocale was failing to set the locale.

BUG=internal b/19627216

Review URL: https://codereview.chromium.org/987943002

Cr-Commit-Position: refs/heads/master@{#319814}

BUG=464578
TEST=Launch the app, check the tooltip when fully backed up.

Review URL: https://codereview.chromium.org/988413004

Cr-Commit-Position: refs/heads/master@{#319813}

These are mostly unit test changes. There are a fair number of
occurances still, but they are not easy (or possible) to change due
to STL, third_party, or template requirements.

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/992083002

Cr-Commit-Position: refs/heads/master@{#319812}

Ran into infinite recursion while looking at skia benchmarked skpictures
in trace viewer.  BenchmarkingCanvas::onDrawPicture was calling
SkCanvas::drawPicture, which would call BenchmarkingCanvas::onDrawPicture.

BenchmarkingCanvas::onDrawPicture now calls SkCanvas::onDrawPicture,
which should break up pictures into multiple commands.

Review URL: https://codereview.chromium.org/990373002

Cr-Commit-Position: refs/heads/master@{#319811}

This is a re-do of https://codereview.chromium.org/927183002/ which
was reverted in CL https://codereview.chromium.org/981853002/ because
of (unsubstantiated) concerns that it caused a crash.

Adding StringPiece/StringPiece16 read/write support to pickle, and
update unit tests.

The IPC perf tests do a lot of allocations which can, with large block
sizes, harm their performance. The high allocation counts also make
their performance very dependent on the quirks of the Windows heap, as
it applies undocumented heuristics to decide when to decommit memory
and when to save it for later.

And, doing unnecessary allocations is generally always a bad thing.

So, this change adds StringPiece support to PickleIterator (reading)
and Pickle (writing). The StringPiece function now handles all strings
when writing, but must be requested explicitly when reading.

ipc_mojo_perftests does more allocations than ipc_perftests. This
removes one message-sized allocation from both tests.

The unit tests were updated so that WriteString and WriteString16 are
exercised with both string objects and char/char16 arrays (no
allocations required!). Reading into StringPiece and StringPiece16 is
also tested and the tests were verified with:
out\Release\base_unittests --gtest_filter=PickleTest.*

The main performance test command line used was:

out\Release\ipc_mojo_perftests --gtest_filter=MojoChannelPerfTest.ChannelPingPong

Typical test results on HP Z620 (Windows 8.1) with thread affinity and
high-performance power settings prior to this change:
IPC_Channel_Perf_50000x_12      1140.01 ms
IPC_Channel_Perf_50000x_144     1182.55 ms
IPC_Channel_Perf_50000x_1728    1266.42 ms
IPC_Channel_Perf_12000x_20736   1289.19 ms
IPC_Channel_Perf_1000x_248832   584.619 ms

Typical test results with same settings but using base::StringPiece:
IPC_Channel_Perf_50000x_12      1123.33 ms
IPC_Channel_Perf_50000x_144     1164.53 ms
IPC_Channel_Perf_50000x_1728    1242.99 ms
IPC_Channel_Perf_12000x_20736   1186.84 ms
IPC_Channel_Perf_1000x_248832   496.469 ms

Modest improvement with small buffers, but significant speedup with large buffers.

Typical test results with large-blocks only prior to this change:
IPC_Channel_Perf_1000x_248832   1211.33 ms
IPC_Channel_Perf_1000x_248832   961.404 ms
IPC_Channel_Perf_1000x_248832   600.911 ms
IPC_Channel_Perf_1000x_248832   468.356 ms
IPC_Channel_Perf_1000x_248832   430.859 ms
IPC_Channel_Perf_1000x_248832   425.147 ms

Typical test results with large-blocks only (base::StringPiece):
IPC_Channel_Perf_1000x_248832   909.571 ms
IPC_Channel_Perf_1000x_248832   731.435 ms
IPC_Channel_Perf_1000x_248832   493.697 ms
IPC_Channel_Perf_1000x_248832   417.966 ms
IPC_Channel_Perf_1000x_248832   397.377 ms
IPC_Channel_Perf_1000x_248832   397.725 ms

Note that it takes a while for the Windows heap to 'realize' that it
should hang on to some of the large blocks which is why performance
increases over multiple runs.

Chrome will not immediately be affected because StringPiece reading has
to be explicitly selected. Note that the effect on ipc_perftests is
more variable due to the odd Windows heap heuristics.

Reliable results require setting the power plan to high-performance.
On Linux this is done with this command:
sudo cpupower frequency-set --governor performance

The ipc_perftests command-line is:
out/Release/ipc_perftests --gtest_filter=IPCChannelPerfTest.ChannelPingPong

Typical before/after Linux results for ipc_perftests are:
IPC_Channel_Perf_50000x_12      465.271 ms
IPC_Channel_Perf_50000x_144     480.224 ms
IPC_Channel_Perf_50000x_1728    510.871 ms
IPC_Channel_Perf_12000x_20736   318.016 ms
IPC_Channel_Perf_1000x_248832   309.325 ms

IPC_Channel_Perf_50000x_12      459.245 ms
IPC_Channel_Perf_50000x_144     479.347 ms
IPC_Channel_Perf_50000x_1728    506.57  ms
IPC_Channel_Perf_12000x_20736   289.583 ms
IPC_Channel_Perf_1000x_248832   255.083 ms

Before after Linux results for ipc_mojo_perftests:
IPC_Channel_Perf_50000x_12      670.727 ms
IPC_Channel_Perf_50000x_144     713.6   ms
IPC_Channel_Perf_50000x_1728    808.157 ms
IPC_Channel_Perf_12000x_20736   464.221 ms
IPC_Channel_Perf_1000x_248832   365.258 ms

IPC_Channel_Perf_50000x_12      653.12  ms
IPC_Channel_Perf_50000x_144     697.418 ms
IPC_Channel_Perf_50000x_1728    772.575 ms
IPC_Channel_Perf_12000x_20736   446.315 ms
IPC_Channel_Perf_1000x_248832   348.38  ms

So, consistent improvements on Linux.

Review URL: https://codereview.chromium.org/987033003

Cr-Commit-Position: refs/heads/master@{#319810}

Introduce gfx::XScopedPtr<> as a convenience wrapper around scoped_ptr<>
for managing X11 objects. The return types of the X11 deleter functions are
somewhat inconsistent (e.g. XFree returns int, whereas XIFreeDeviceInfo
doesn't return anything), which makes this a bit tricky. So introduce a
custom deleter gfx::XObjectDeleter to use with XScopedPtr<>. Using this
XScopedPtr<> allows for cleaner code in a few places, and should generally
make it easier to manage X11 objects.

Additional clean-ups:
. content/common/gpu/x_util.cc is unused. So remove that.
. ui::XScopedString is unused. So remove that.
. DeviceListCacheX11 has support for maintaining the device-list cache for
  multiple X11 connections, but chrome doesn't have support for more than
  one. So replace the map with a single cache. (necessitated by the use of
  XScopedPtr<> in DeviceList.)

BUG=none
R=piman@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/989993002

Cr-Commit-Position: refs/heads/master@{#319809}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/86e31a1..167eb17

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/989343004

Cr-Commit-Position: refs/heads/master@{#319808}

Revert of [Sync] Add size and crc32c to AttachmentId. (patchset #8 id:140001 of https://codereview.chromium.org/982883002/)

Reason for revert:
Broke build on iOS_Device

http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26684/steps/compile/logs/stdio

Undefined symbols for architecture armv7:
  "syncer::Attachment::CreateFromParts(syncer::AttachmentId const&, scoped_refptr<base::RefCountedMemory> const&, unsigned int)", referenced from:
      syncer::(anonymous namespace)::MockAttachmentStore::RespondToRead(std::__1::set<syncer::AttachmentId, std::__1::less<syncer::AttachmentId>, std::__1::allocator<syncer::AttachmentId> > const&) in attachment_service_impl_unittest.o
      syncer::(anonymous namespace)::MockAttachmentDownloader::RespondToDownload(syncer::AttachmentId const&, syncer::AttachmentDownloader::DownloadResult const&) in attachment_service_impl_unittest.o
      syncer::gtest_case_AttachmentStoreTest_::Write_NoOverwriteNoError<syncer::InMemoryAttachmentStoreFactory>::TestBody() in in_memory_attachment_store_unittest.o
      syncer::OnDiskAttachmentStoreSpecificTest_MismatchedCrc_Test::TestBody() in on_disk_attachment_store_unittest.o
      syncer::gtest_case_AttachmentStoreTest_::Write_NoOverwriteNoError<syncer::OnDiskAttachmentStoreFactory>::TestBody() in on_disk_attachment_store_unittest.o
  "syncer::CreateAttachmentIdProto()", referenced from:
      syncer::AddAttachment(sync_pb::AttachmentMetadata*, bool) in directory_commit_contribution_unittest.o
      syncer::DirectoryUpdateHandlerProcessUpdateTest_ProcessAndApplyUpdatesWithAttachments_Test::TestBody() in directory_update_handler_unittest.o
      syncer::DirectoryUpdateHandlerApplyUpdateTest_SimpleConflictDifferentAttachmentMetadata_Test::TestBody() in directory_update_handler_unittest.o
      syncer::DirectoryUpdateHandlerApplyUpdateTest_SimpleConflictSameAttachmentMetadataDifferentOrder_Test::TestBody() in directory_update_handler_unittest.o
      syncer::AttachmentIdProtoTest_UniqueIdFormat_Test::TestBody() in attachment_id_proto_unittest.o
      syncer::AttachmentIdProtoTest_CreateAttachmentMetadata_NonEmpty_Test::TestBody() in attachment_id_proto_unittest.o
      syncer::SyncManagerChangeProcessingTest_AttachmentMetadataOnlyChanges_Test::TestBody() in sync_manager_impl_unittest.o
      ...
  "syncer::AttachmentId::Create()", referenced from:
      syncer::(anonymous namespace)::SyncDataTest_CreateLocalDataWithAttachments_Test::TestBody() in sync_data_unittest.o
      syncer::AttachmentDownloaderImplTest_HappyCase_Test::TestBody() in attachment_downloader_impl_unittest.o
      syncer::AttachmentDownloaderImplTest_SameIdMultipleDownloads_Test::TestBody() in attachment_downloader_impl_unittest.o
      syncer::AttachmentDownloaderImplTest_RequestAccessTokenFails_Test::TestBody() in attachment_downloader_impl_unittest.o
      syncer::AttachmentDownloaderImplTest_URLFetcher_BadToken_Test::TestBody() in attachment_downloader_impl_unittest.o
      syncer::AttachmentDownloaderImplTest_URLFetcher_ServiceUnavailable_Test::TestBody() in attachment_downloader_impl_unittest.o
      syncer::AttachmentDownloaderImplTest_NoHash_Test::TestBody() in attachment_downloader_impl_unittest.o
      ...
ld: symbol(s) not found for architecture armv7
clang:error: linker command failed with exit code 1 (use -v to see invocation)

Original issue's description:
> [Sync] Add size and crc32c to AttachmentId.
>
> The purpose of this change is to ensure that if a client knows about an
> attachment (i.e. has an AttachmentId or AttachmentIdProto) it will know
> the attachment's size even if the attachment has never been available on
> the local device.
>
> The idea is that by storing size locally, we can simplify remote storage
> management.
>
> Move crc32c out of Attachment now that it's part of AttachmentId.
>
> BUG=464431
>
> Committed: https://crrev.com/23ae3128db0d84a6b1ffa640568a5ec90cfc8808
> Cr-Commit-Position: refs/heads/master@{#319794}

TBR=pavely@chromium.org,maniscalco@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464431

Review URL: https://codereview.chromium.org/995683002

Cr-Commit-Position: refs/heads/master@{#319807}

BUG=464610
TEST=base_unittests

Review URL: https://codereview.chromium.org/985573003

Cr-Commit-Position: refs/heads/master@{#319806}

Roll up all the changes for issue 443863 and issue 401971 into google.patch.
google.patch is not code, so no new tests or try runs needed.

BUG=443863,401971
TEST=none needed

Review URL: https://codereview.chromium.org/990813002

Cr-Commit-Position: refs/heads/master@{#319805}

As the comment in net/spdy/spdy_frame_builder.h by hkhalil@,
rename WriteString to WriteStringPiece16.

BUG=458880
R=bnc@chromium.org

Review URL: https://codereview.chromium.org/910393003

Cr-Commit-Position: refs/heads/master@{#319804}

BUG=465458

Review URL: https://codereview.chromium.org/987163002

Cr-Commit-Position: refs/heads/master@{#319803}

This is an extra check in FindLocalIdToUpdate which should
help to narrow down the cause of the crash in syncer::syncable::ChangeEntryIDAndUpdateChildren and gather
more information on the state of the directory leading to the crash.

BUG=362467

Review URL: https://codereview.chromium.org/986463004

Cr-Commit-Position: refs/heads/master@{#319802}

This is a temporary line-saving solution for ease of merging. A proper
separation of concerns will be done in a future CL.

BUG=442831

Review URL: https://codereview.chromium.org/979353002

Cr-Commit-Position: refs/heads/master@{#319801}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/796d284..baae7d7

TBR=jbroman@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/990353002

Cr-Commit-Position: refs/heads/master@{#319800}

BUG=451771

Review URL: https://codereview.chromium.org/883773003

Cr-Commit-Position: refs/heads/master@{#319799}

Block platform verification and file IO in the CDM adapter if the CDM configuration disallows access to them.

Based on the configured value of distinctiveIdentifier and persistentState, we compute permission bits and pass them through PPAPI to the CDM adapter. This enables us to enforce 'not-allowed' configs even when user permission has been granted.

BUG=487452

Review URL: https://codereview.chromium.org/985113003

Cr-Commit-Position: refs/heads/master@{#319798}

Add unittest for Spdy::GetNumberRequiredContinuationFrames, including the test
case provided in the bug report.

BUG=464748

Review URL: https://codereview.chromium.org/995453003

Cr-Commit-Position: refs/heads/master@{#319797}

Adding support for disabling the parity symbol.
Improving reliability for long tokens.

See cl/87989795 for the NaCl changes.

BUG=464967
R=rkc@chromium.org

Review URL: https://codereview.chromium.org/988973002

Cr-Commit-Position: refs/heads/master@{#319796}

The operator& is dangerous as it makes code unclear what is happening.

For ScopedPropVariant there is already a get() method returning a
const& of the internal type. So doing &foo.get() will get a pointer to
the internal type.

For ScopedVariant, there is only operator&, so replace it with an
operator*() that returns a const&. This changes callsites from doing
something like V_FOO(&scoper) to V_FOO(&*scoper) which makes it clear
that it is getting the address of the thing inside scoper, not the
scoper itself.

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/985853005

Cr-Commit-Position: refs/heads/master@{#319795}

The purpose of this change is to ensure that if a client knows about an
attachment (i.e. has an AttachmentId or AttachmentIdProto) it will know
the attachment's size even if the attachment has never been available on
the local device.

The idea is that by storing size locally, we can simplify remote storage
management.

Move crc32c out of Attachment now that it's part of AttachmentId.

BUG=464431

Review URL: https://codereview.chromium.org/982883002

Cr-Commit-Position: refs/heads/master@{#319794}

Header guards should be defined based on the path and file name of the
header file. Some headers have it wrong, some are missing the guards,
and some just have the matching comment wrong.

R=Nico
BUG=464816

Committed: https://crrev.com/301b392761fd8f66f3a701ab1dd011c6e7a55e19
Cr-Commit-Position: refs/heads/master@{#319722}

Review URL: https://codereview.chromium.org/985003004

Cr-Commit-Position: refs/heads/master@{#319793}

for store locally checkbox

BUG=464640

Review URL: https://codereview.chromium.org/990543002

Cr-Commit-Position: refs/heads/master@{#319792}