- 20 May, 2020 40 commits
-
-
Greg Daniel authored
These spots were missed on the original update CL. Change-Id: I83563b18df9ebe7bb4e10668ba210b7712d8c547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209533Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com> Cr-Commit-Position: refs/heads/master@{#770578}
-
David Bienvenu authored
When a long press touch drag drop is initiated, we generate a right mouse button down event and a mouse move event, which ::DoDragDrop needs to start drag drop. Then, when we see a pointer move or pointer up event, we generate the corresponding mouse events, because DoDragDrop doesn't handle pointer events. When drag drop finishes, we generate a right mouse button up event, and we cleanup the source window's gesture state, because it has gotten a bit confused. Bug: 229301 Change-Id: Ibcc3553a873b395f51116a33143d1836ff34cfbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203409Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770577}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1bfa636e36a..690f0c26c832 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: Ie577840254108c8d684fd9e3a4e515a09c53714e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210373Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770576}
-
sebsg authored
This reverts commit 79488bbd. Reason for revert: Suspecting of causing KioskTest.SpokenFeedback to fail intermitently. More info in https://bugs.chromium.org/p/chromium/issues/detail?id=1085004 Original change's description: > Reland "Batch accessibility event processing during page load" > > This is a reland of f5d9ecea > > The only change from the original is in kiosk_browsertest.cc > We need to WaitUntilSatisfied when check_launch_data is set. > > Original change's description: > > Batch accessibility event processing during page load > > > > This change allows us to defer sending events to > > improve performance during the initial page load. > > > > EventScheduleMode determines if we schedule events > > with a delay or not. > > > > EventScheduleStatus replaces ack_pending_, and tracks > > what state we are in with regard to event scheduling. > > > > This is based on: > > CL 1691523: Large batch accessibility event processing > > during page load > > > > Bug: 976849 > > Change-Id: I74cd5f31102199f8c5752e0ef5d0eb623fdbd9d0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123310 > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > > Commit-Queue: Jacques Newman <janewman@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#769010} > > Bug: 976849 > Change-Id: Ia3450c1c59c6bac173046c389afeb403ab2991a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203772 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Jacques Newman <janewman@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#770405} TBR=dmazzoni@chromium.org,dtseng@chromium.org,alemate@chromium.org,adithyas@chromium.org,janewman@microsoft.com Change-Id: Id8a9156f42bd9a77dda1243446259175141662a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210484Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770575}
-
Nick Diego Yamane authored
As observed in crbug.com/1069690, KeyEvent's repeat flag detection has regressed after crrev.com/c/1816777. Calling the repeat flag detection function after the flags "normalization" causes this issue. This patch fixes it and adds an unit test to prevent future similar regressions. R=sadrul@chromium.org Bug: 1069690 Change-Id: Idee080cb6803d2f1487e10d176b65225ae99a221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208180Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#770574}
-
Alice Wang authored
This CL adds a fake AccountManagerFacade implementation for tests and uses it in AccountManagerTestRule. Bug: 914920 Change-Id: I022671152908772b8605d3fefb3a1945570c4d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179164Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770573}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99a56e31aca7..34dc00881b0b 2020-05-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-05-20 sigurds@chromium.org Typescriptify ServiceWorkerManager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I310e6f6d128536a231fd97f756ca664fd2f85f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770572}
-
Denis Kuznetsov authored
Fixed: 1067210 Fixed: 1078325 Change-Id: I02b88009f8bf646efbc9d88d1b6e58273f90859c Bug: 1067210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210235 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770571}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1589961590-b5238e477e88144b4ee977d3e9b375905cf319c2.profdata to chrome-win64-master-1589976000-30e90b5636af5c2bba45569eb90bae781c77ad14.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib1ec14be68fc81bf61f0dcf209f52582a56f8525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210377Reviewed-by:
-
Rushan Suleymanov authored
This reverts commit 9581c8be. Original change's description: > Revert "Enable bookmark sync metadata invalidation if mismatching guid by default." > > This reverts commit d13f56f8. > > Reason for revert: suspicious numbers of corrupted metadata. > > Original change's description: > > Enable bookmark sync metadata invalidation if mismatching guid by default. > > > > Bug: 1032052 > > Change-Id: I55801e98e7729d2bba895272ea21ab285ec20cb9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167282 > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Commit-Queue: Rushan Suleymanov <rushans@google.com> > > Cr-Commit-Position: refs/heads/master@{#765030} > > TBR=mastiz@chromium.org,rushans@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1032052 > Change-Id: I3bda5defd8cf41c13974c81f51858aac982bef05 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199104 > Reviewed-by: Rushan Suleymanov <rushans@google.com> > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Cr-Commit-Position: refs/heads/master@{#768290} TBR=mastiz@chromium.org,rushans@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032052 Change-Id: I0428b711b4be70e8ca398d9096fabf2211515a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207229Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#770569}
-
David Schinazi authored
This will allow members of the networking team to make minor changes to their networking histograms. R=rkaplow@chromium.org Change-Id: Ic9d0879745f84dfe2463adc33b392bc1d3191071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207933 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770568}
-
Maksim Sisov authored
This CL fixes spurious problems when new frames are sent and a buffer is attached earlier than WaylandSurface/WaylandPopup are configured. Thus, add a new interface into the WaylandWindowObserver that notifies the WaylandBufferManagerHost if the window has been configured. The manager resets |configured_| variable upon ResetWindowContents as long as the wl_surface becomes unmapped and it is reinitialized with new xdg_surface, xdg_toplevel or whatever only during the next Show() call. In that case, it will be configured again and the host will be notified about that. Bug: 1083949 Change-Id: I9895bc8876748ba69bc0461c2aeb300175a40065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207172Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#770567}
-
Alexander Timin authored
toplevel.flow trace events ended up being quite useful. Move them out of disabled-by-default for better visibility. R=gab@chromium.org TBR=rockot@google.com BUG=932167 Change-Id: I90076f2e776b591ed7a485ed42bf8b64daedc1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111310 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#770566}
-
Kamila authored
This cl adds a new variation parameter that can be used to run A/B testing on the link we display in the mini infobar on Android. Change-Id: Ifca13cd4ba9857203ee08118bbca91e1a02c2d1b BUG: 1084524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207167 Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770565}
-
Robert Sesek authored
The MediaPlayer framework is only available on macOS 10.12+, so it has to be -weak_link'd. When the linker argument was added in a3d32982, it used all_dependent_configs to push the config with the right ldflags up the dependency tree. This had the side effect of propagating those flags all the way up to the main chrome_app_executable. That executable should not directly link on system libraries since all the code instead resides in the chrome_framework_shared_library, where is where the -weak_link should occur and stop propagating upwards. To fix this, use GN's new weak_frameworks variable. Bug: 1082896 Change-Id: I1f0336f145ad3c4281a9d91f0bf5e0025b6f0ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202938Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#770564}
-
Peter E Conn authored
UiUtils.setNavigationBarIconColor works on Android versions greater than or equal to Android Oreo. Our calling code incorrectly assumes it only works on Android versions strictly greater than Android Oreo. This CL fixes that. Bug: 1082357 Change-Id: I34794a8f5bc84ff3b7312291737a5bdd6ea9bed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209080 Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#770563}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1589961590-5bcd8ca24d15822b25b9ab44f061677dc2856648.profdata to chrome-mac-master-1589976000-662c96b2b7dcbccd935f47b39ee73fe1b7f0b5b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibfc09b8c9df374d43f1edfdadaf02c422f85610a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210374Reviewed-by:
-
clamy authored
This CL marks one compositing web test as failing. Bug: 1084448 Change-Id: Id172b80285058daeef68ff82f6a23aaac3e88ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209463 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770561}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ec1b8b70. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" 70901619 "[Trusted Types] Add Trusted Type to href for SVGScriptElement." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Id5f14cd532fa133107deb8d5c5f446e2b55f5637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209812Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770560}
-
Alice Wang authored
This CL destroys mSetActivity in rule teardown. The activity is launched manually inside the test rule and it is not ended prior to this change. This is necessary to avoid crash once we will teardown the SigninTestUtil properly. Bug: 1083138 Change-Id: Ibacf4a78c22b5316983a3ae208070c075b042738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202796Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770559}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ifab1cd0c37374f2a06f5664120e7adb627fa9e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210372Reviewed-by:
-
Rouslan Solomakhin authored
This is a reland of 0f9b2fd4 Reason for revert: Deps have not been updated yet, so compile broke. Reason for reland: Deps have been updated. TBR=sahel@chromium.org Original change's description: > [Web Payment] Cleanup PaymentRequestUpdateEventListener. > > Move PaymentRequestUpdateEventListener from sub-interface in > PaymentApp.java to its own file. > > Bug: 1083242 > Change-Id: I0d8323b7dc2f75546ca3086897cb642e1e85111d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205873 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770319} Bug: 1083242 Change-Id: I8520859fee2e888507c9905d49f42b433f39bf39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209813Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770557}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5e736fbd7e3d..99a56e31aca7 2020-05-20 sigurds@chromium.org Alphabetically sort some methods in InspectorBackend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieb78d7007f50915f210c036181d65aaadc3e2025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210370Reviewed-by:
-
Maksim Moskvitin authored
This CL removes some outdated unittests, which blocks removal of SyncEncryptionHandlerImpl. Bug: 1083924 Change-Id: I2af118b22c1943bce535cf329f5da5afa69f6956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207208Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#770555}
-
Rune Lillesveen authored
We could end up with a MatchedPropertiesCache hit for a ComputedStyle which was cached while in display:none, but was now supposed to be rendered. The problem with that is that for non-rendered elements we don't fetch image resources and have StylePendingImage set during style application. In order to use the MPC in this case we would have had to re-traverse the ComputedStyle for StylePendingImages an start fetching them. Instead, avoid using MPC for these cases. Bug: 1082486, 1084911 Change-Id: Ifecd66ef6d135990d9083616bd07d076815ab839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209464 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#770554}
-
Matt Menke authored
URLLoaderFactoryParamsHelper::CreateForRendererProcess is deprecated and untested, but it's still used in production under certain circumstances. It was using an empty IsolationInfo, which is no longer allowed. This CL makes it use a transient IsolationInfo instead, which prevents a DCHECK in the network service from triggering, due to the IsolationInfo being empty. Bug: 1082280,891872 Change-Id: I80c632957937f4d09be0bc20625397d9a1f04ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208369Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#770553}
-
Wei Lee authored
It is useful and this CL moves it to the upper directory so other components in CCA can use it as well. Bug: 980846 Test: tast run [DUT] camera.CCAUI* Change-Id: Ib37ae32dcda3cbc9fb79a8faf6e36f8d9641d562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210290 Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#770552}
-
Yuichiro Hanada authored
The tests in input_ime_apitest_nonchromeos.cc are running only on Win and Linux bots, so disabling on Win and Linux bots means it's disabled simply. Change-Id: I862dde9915fb417d0d111d6e565a9e5e1b5ac5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208487 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770551}
-
arthursonzogni authored
The origin of the error page is already an opaque data-url. Updating the sandbox flags isn't necessary. This unlocks https://crbug.com/1041376. After that, the browser is able to compute the sandbox flags by itself, without relying on the (potentially compromised) renderer process. Bug: 1041376 Change-Id: Ida3635d4a07bcb486072b7dd6a271317fe274939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203199Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#770550}
-
arthursonzogni authored
Two new fields have been added to ContentSecurityPolicy: - treat-as-public-address - sandbox The ConvertToBlink function needs to be updated. Note: Ideally, the ConvertToBlink function should be future-proof. It shouldn't require developers to make update each time the ContentSecurityPolicy struct is updated. This has been proposed below: https://chromium-review.googlesource.com/c/chromium/src/+/2126933 but this has been rejected. This patch doesn't introduce a regression test, because those values are not used yet. This patch is required for: https://chromium-review.googlesource.com/c/chromium/src/+/2190680 Bug: 1041376 Change-Id: I490920aae96c8666aebf97a9f636aeb2405f824f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203070 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Nazerke authored
This is a reland of 3585551d Original change's description: > [iOS][tabmodel] Deprecation of TabModel in tab_test_util. > > This CL removes tab_test_util's dependence on TabModel by getting > WebStateList from Browser instead. > > Bug: 1045575, 1050138 > Change-Id: I981eae54cc934d444a93824cfa9bc6bb46199aff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171480 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Nazerke Kalidolda <nazerke@google.com> > Cr-Commit-Position: refs/heads/master@{#765981} Bug: 1045575, 1050138 Change-Id: I0c0e8f1318db598ef4e6a54ebf2ec1f9edb6a139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199337Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#770548}
-
Esmael El-Moslimany authored
chrome-search://local-ntp/local-ntp.html is being replaced with chrome://new-tab-page. Change-Id: I57f8b19f72edbe52a2c7830bd3e8e5c0ecc467cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209303Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770547}
-
Roman Aleksandrov authored
The X button of the window could be removed since config dialogs have their own Cancel button. Bug: 1023768 Change-Id: I05c0f5551c4c5f63119faeed79537e1dc05ded4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209076Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#770546}
-
Denis Kuznetsov authored
Also replaced class-based selectors with hidden attribute, removed unused APIs. Bug: 1017156 Change-Id: I6daf2e6f75943c9f1186e31dd207c53ca160db92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207218Reviewed-by:
Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#770545}
-
Roman Sorokin authored
Before this CL Login screen hid the Oobe dialog when switching from empty user list to non empty. I believe this might cause an issue when Device Disabled screen was shown but then Login screen hid it on the first run. Now Login screen hides the dialog only if the Gaia login is shown. Also removed LoginScreenController::HideGaiaSignin Fixed: 1084460, b/155437418 Change-Id: I80bd5290488824d9a094a334cfa39712adb1da4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209130Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d45b30b5a554..583c9a38d9bd 2020-05-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 67eac5116ba3 to 4683991f7675 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ic3bdcaa3b59ba0c4f5dc3a0e6157232a9a87ae69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209324Reviewed-by:
-
Antonio Sartori authored
The file /services/network/public/cpp/content_security_policy/csp_source_unittests.c was not being built as part of the services_unittests. I guess we forgot to add it after a refactoring. This commit enables those tests. Change-Id: If451b06f05bf375fca18ad7c1a7a206700d6c572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209079Reviewed-by:
-
Mark Cogan authored
Bug: 1072370 Change-Id: I1edcafd14b31472b80e165c22b6ffeab7ef1667d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199336 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770541}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b3bb9d3aa2c5..5e736fbd7e3d 2020-05-20 wolfi@chromium.org Port DOMDebuggerModel to ts 2020-05-20 sigurds@chromium.org Typescriptify ServiceWorkerCacheModel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9547f2c0118badcbcb3583515589828f64a390b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209327Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1007876 Change-Id: If20a2e559c49d5df22e71b2a49ad74c4fbd9b460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209065 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
