GitLab

BUG=none
R=maniscalco@chromium.org, pavely@chromium.org

Review URL: https://codereview.chromium.org/254713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368280
TBR=awong@chromium.org,robliao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/254013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/260233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266896 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Split animating and drawing into separate actions
> 
> Split impl-side animating and drawing into separate actions. This is
> needed to allow for the possibility of a commit between animating and
> drawing so that the main thread gets a chance to consume the new
> animation state. In particular this allows the main thread to
> synchronize with a fling animation using an onscroll handler.
> 
> BUG=347366
> 
> Review URL: https://codereview.chromium.org/206793003

Reason for revert: Broke some downstream unit tests.

TBR=skyostil@chromium.org
BUG=368064

Review URL: https://codereview.chromium.org/254883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364468
R=bshe@chromium.org

Review URL: https://codereview.chromium.org/252743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266894 0039d316-1c4b-4281-b951-d872f2087c98

Also doing some light refactoring to make the code cleaner.

BUG=360512
NOTRY=True

Review URL: https://codereview.chromium.org/260333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266893 0039d316-1c4b-4281-b951-d872f2087c98

First two test cases:
  password change detected when SU is signed in, only su is signed in after
  password change is detected when manager is signed in.

R=nkostylev@chromium.org

BUG=354607

Review URL: https://codereview.chromium.org/243103007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266892 0039d316-1c4b-4281-b951-d872f2087c98

Store default search provider data in dictionary pref, and add DefaultSearchManager class to handle the reading and writing of this pref (DefaultSearchManager will eventually all default search related concerns).

This pref will be used to persist data about user-selected
default search providers. In future CLs, support will be added for default search providers set by policy and sync.

BUG=365762

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266479

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266615

R=gab@chromium.org, pkasting@chromium.org

Review URL: https://codereview.chromium.org/229763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266891 0039d316-1c4b-4281-b951-d872f2087c98

Typedef not currently needed.

R=ben@chromium.org
TBR=ben@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/253673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266890 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

BUG=239179

Review URL: https://codereview.chromium.org/259623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266889 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266887 0039d316-1c4b-4281-b951-d872f2087c98

Easier this way for clients to track and not worry about overflow.

BUG=none
TEST=none
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266793

Review URL: https://codereview.chromium.org/253883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266886 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff rossberg@chromium.org in case of problems.

TBR=rossberg@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/255183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266885 0039d316-1c4b-4281-b951-d872f2087c98

Uses gtest parameterization for two of the WebRTC
browser tests so they can be re-run with different
constraints (and reference files).

To run 360p only:
out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest*0 --run-manual --ui-test-action-max-timeout=300000
and 720p only:
out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest*1 --run-manual --ui-test-action-max-timeout=600000

This CL should get a follow-up after 
https://codereview.chromium.org/254803002/ is landed 
(then webrtc_video_quality_test_hd.html can be removed).

We also really should look into making the test more hermetic
so ffmpeg and zxing is bundled and auto-downloaded on all the
target platforms (using Google storage).

BUG=286290
TEST=locally running the test on Linux, Mac and Windows.

Review URL: https://codereview.chromium.org/247723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266884 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266883 0039d316-1c4b-4281-b951-d872f2087c98

> Roll gyp r1895:1907
> 
> r1907 Test handling of empty RULE_INPUT_DIRNAME and fix this on android.
> r1906 gyp performance: Another fixed O(n^2) in dependency calcs.
> r1905 gyp: isinstance -> type for another 1-5% save.
> r1904 gyp: avoid copying items that will be deleted.
> r1903 Show ASM output file instead of input file, just like CC and CXX.
> r1902 win: disable two flaky tests on gyp-win32
> r1901 Remove the default setting for clcompile_cmd in msvs-ninja
> r1900 gyp: cache conditional ASTs for 3 CPU seconds (5%) gain.
> r1899 gyp: use a set() in DeepDependencies for less O(n^2).
> r1898 gyp: fix O(n^2) in dependency calculations.
> r1897 gyp: 1% faster by optimizing IsPathSections
> r1896 gyp: use all processors instead of hard-coded 8.
> 
> TBR=thakis@chromium.org
> BUG=
> 
> Review URL: https://codereview.chromium.org/253493009

TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/259223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266882 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266881 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff rossberg@chromium.org in case of problems.

TBR=rossberg@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/253873011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366103
R=sky@chromium.org, yoz@chromium.org

Review URL: https://codereview.chromium.org/246653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266878 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266877 0039d316-1c4b-4281-b951-d872f2087c98

r1907 Test handling of empty RULE_INPUT_DIRNAME and fix this on android.
r1906 gyp performance: Another fixed O(n^2) in dependency calcs.
r1905 gyp: isinstance -> type for another 1-5% save.
r1904 gyp: avoid copying items that will be deleted.
r1903 Show ASM output file instead of input file, just like CC and CXX.
r1902 win: disable two flaky tests on gyp-win32
r1901 Remove the default setting for clcompile_cmd in msvs-ninja
r1900 gyp: cache conditional ASTs for 3 CPU seconds (5%) gain.
r1899 gyp: use a set() in DeepDependencies for less O(n^2).
r1898 gyp: fix O(n^2) in dependency calculations.
r1897 gyp: 1% faster by optimizing IsPathSections
r1896 gyp: use all processors instead of hard-coded 8.

TBR=thakis@chromium.org
BUG=

Review URL: https://codereview.chromium.org/253493009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266876 0039d316-1c4b-4281-b951-d872f2087c98

R=dgozman@chromium.org, vsevik@chromium.org
TBR=jam for chrome/chrome.gyp

Review URL: https://codereview.chromium.org/253823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266873 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266871 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13019: (dyen) Added temporary code to clean out old toolchain directories.
r13020: (noelallen) Roll bionic
r13021: (dyen) Added pinned toolchain revision files using the new revision pin scheme.
r13022: (dschuff) Update WINVER to 0x602 in NaCl
r13023: (sbc) Fix stat.st_mode bits reported by win32 sel_ldr
r13024: (teravest) Remove unused NACL_NAME_SERVICE_LIST interface.
r13025: (dyen) Modified gyp toolchain directories so they match the standardized format.
r13026: (dyen) Toolchain bionic build can now output output package files.
r13027: (dyen) Fixed typo in toolchain bionic build.
r13028: (jvoung) Remove nosys references from spec2k harness.
r13029: (dyen) Fixed a typo in toolchain build bionic.
r13030: (sehr) Make Android sel_ldr build under Darwin
r13031: (dschuff) PNaCl: Update libc++ revision in pnacl/COMPONENT_REVISIONS
r13032: (earthdok) Filter out -fsanitize=memory when building nacl_bootstrap.
r13033: (dyen) Updated deps file so it uses package_version to synchronize toolchains.
r13035: (sbc) Add libdbus-glib and libexif to ARM sysroot image builder.
r13036: (noelallen) Convert (handle, path) MakeTempFile to (path) MakeEmptyFile
r13037: (dyen) Empty toolchain directory no longer causes a failure when running hooks.
r13038: (petarj) [MIPS] Fix build failures with bitcode=1
r13039: (jvoung) PNaCl: Update LLVM and binutils revision in pnacl/COMPONENT_REVISIONS
r13040: (dschuff) pnacl/build.sh: Don't print git revisions before git checkout
r13041: (dschuff) once.py: Cache hashes of file paths within a run
r13042: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13043: (dyen) Shortened gyp toolchain path to avoid windows path limit.
r13044: (dyen) Fixed an issue with package_version setting a custom toolchain package.
r13045: (mseaborn) TLS: Reduce the cost of getting the thread pointer by one jump on x86-64
r13046: (jfb) Make package_version.py executable
r13047: (dyen) Added getrevision command to package_version.py.
r13048: (jfb) Update pnacl_newlib.json for PNaCl r13013->r13042
r13049: (jvoung) Test validation cache/mmap main nexe w/ mock cache info and fix bug.
r13050: (jvoung) Remove "PackageCheck" from pnacl/scripts (the check for texinfo, etc.).
r13051: (jfb) PNaCl: Test support for GCC/LLVM vector extensions
r13052: (mseaborn) PNaCl: Only define __nacl_read_tp() on architectures that need it
r13053: (noelallen) Roll bionic
r13054: (dyen) Move back to build_pnacl.sh version of the PNaCl toolchain to distribute.
r13055: (dschuff) Generate biased bitcode using the same triple everywhere
r13056: (dyen) Made sure buildbot_pnacl.sh uses native python to escape cygwin on win32.
r13057: (bradnelson) Switching DEPS to use googlecode_url variable.
r13058: (bradnelson) Fix DEPS typo.
r13059: (noelallen) Roll bionic to get libc_stubs.c cleanup.
r13060: (noelallen) Roll to office bionic build.
r13061: (mseaborn) Unsandboxed IRT: Fix some warnings from -Wextra
r13062: (dyen) Pinned pnacl_newlib toolchain and pnacl_translator to revision 13060.
r13063: (dschuff) Use toolchain_build for PNaCl FYI bots instead of build.sh
r13064: (dyen) Added better logging package_version.py when syncing.
r13065: (mseaborn) PNaCl: Allow targeting Non-SFI Mode for ARM
r13066: (noelallen) Roll Bionic to take in cleanup of g_nacl_irt_syscalls_ptr
r13067: (dyen) As a safety precaution, delete output package file before extraction.
r13068: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13069: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13070: (noelallen) Roll bionic
r13071: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13072: (jfb) PNaCl LLVM tests: fix known failures for vector tests
r13073: (dyen) Updated PNaCl tool revision update script to use package_version.
r13074: (jfb) Update revision for PNaCl r13060->r13072
r13075: (petarj) [MIPS] Update the toolchain build script
r13076: (mcgrathr) toolchain_build: Make arm-nacl-gdb and i686-nacl-gdb aliases
r13078: (dyen) toolchain_build should only upload what we will download for (arm).
r13079: (mcgrathr) Update tools_rev in DEPS
r13081: (mcgrathr) toolchain_build: Update EXPAT library
r13082: (mcgrathr) toolchain_build: Update GMP library
r13083: (jvoung) Change PNaCl --noirt use of rosegment-gap to something bigger.
r13084: (dschuff) Add relocate.o to libs_support_native build in toolchain_build_pnacl.py
r13086: (jvoung) Build test prereqs on pnacl FYI bots early, instead of relying on each suite.
r13087: (mcgrathr) toolchain_build: Generate a series file with the patches
r13088: (jvoung) Fix for 13086 -- build pre-reqs explicitly in other pnacl buildbot script.
r13089: (dyen) Reverted gyp and DEPS rules to use old toolchain tars.
r13091: (dyen) download_toolchains no longer delete old toolchain directories.

BUG=none
TEST=browser_tests and nacl_integration
R=bradnelson@chromium.org, bradnelson@google.com

Review URL: https://codereview.chromium.org/260103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266870 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266868 0039d316-1c4b-4281-b951-d872f2087c98

Includes the following CLs:

Disable Intel AES assembly code on Windows because of memory corruption
in the GCM assembly code.
https://codereview.chromium.org/258013011/

R=agl@chromium.org
BUG=367515

Review URL: https://codereview.chromium.org/253873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266867 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368134
TBR=robliao@chromium.org, ajwong@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/253103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358265
NOTREECHECKS=true
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/256203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266865 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Password bubble: Introduce a command to open the bubble. (https://codereview.chromium.org/246393004/)

Reason for revert:
This is causing leaks on linux asan lsan:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/2361

Original issue's description:
> Password bubble: ManagePasswordsIconView is now a BubbleIconView.
> 
> This CL introduces a new browser command to open the Manage Passwords bubble,
> and converts the ManagePasswordsIconView class into a subclass of
> BubbleIconView, which uses the new command to control the bubble's state.
> This allows us to more easily test the view and the UI controller, as each
> object's job is now more clearly defined (and the view is now doing a good
> deal less work), and to independently verify that the command is doing the
> right thing.
> 
> After this CL, we'll (finally!) have something approaching reasonable test
> coverage for the core of the views code.
> 
> BUG=365678
> TBR=cpu@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266859

TBR=markusheintz@chromium.org,vabr@chromium.org,cpu@chromium.org,pkasting@chromium.org,mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365678

Review URL: https://codereview.chromium.org/256333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266862 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [WebsiteSettings] Update permission bubble manager policy (https://codereview.chromium.org/243543003/)

Reason for revert:
This breaks Linux ASAN, heap use after free:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/2360

Original issue's description:
> [WebsiteSettings] Update permission bubble manager policy
> 
> This policy is more in accord with the design doc changes. Moves to
> showing the dialog upon DOMContentLoaded in source pages, and then
> subsequently for user gestures.
> 
> R=leng@chromium.org
> BUG=332115,364159
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266855

TBR=leng@chromium.org,markusheintz@chromium.org,rdsmith@chromium.org,phajdan.jr@chromium.org,gbillock@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=332115,364159

Review URL: https://codereview.chromium.org/260373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323766
TBR=skuhne@chromium.org

Review URL: https://codereview.chromium.org/250843007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266860 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces a new browser command to open the Manage Passwords bubble,
and converts the ManagePasswordsIconView class into a subclass of
BubbleIconView, which uses the new command to control the bubble's state.
This allows us to more easily test the view and the UI controller, as each
object's job is now more clearly defined (and the view is now doing a good
deal less work), and to independently verify that the command is doing the
right thing.

After this CL, we'll (finally!) have something approaching reasonable test
coverage for the core of the views code.

BUG=365678
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/246393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266859 0039d316-1c4b-4281-b951-d872f2087c98

The cloud policy protocol can also be used to fetch policy for extensions; this change makes an update to the protocol such that extension IDs are never uploaded to the server.

Note that this feature is still disabled by default behind the --enable-component-cloud-policy flag.

BUG=361156

Review URL: https://codereview.chromium.org/233423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266857 0039d316-1c4b-4281-b951-d872f2087c98

This policy is more in accord with the design doc changes. Moves to
showing the dialog upon DOMContentLoaded in source pages, and then
subsequently for user gestures.

R=leng@chromium.org
BUG=332115,364159

Review URL: https://codereview.chromium.org/243543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266855 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces a TicSettingsProvider abstraction that allows
TiclInvalidationService to retrieve configuration settings without having
to directly observe a Profile's PrefStore.

The CL completes the work on removing the Profile dependency from
TiclInvalidationService.

BUG=358696
TEST=New and updated unit tests

Review URL: https://codereview.chromium.org/255443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266853 0039d316-1c4b-4281-b951-d872f2087c98

damaging viewport area covered by newly initialized tiles.

In the current implementation, during frame draw 
and visible tile update, LTHI was setting damage 
to the entire viewport area, irrespective of the 
initialized tiled content rect.
As part of the patch we are trying to ascertain newly 
initialized tile rect from TileManager, notify LTHI about it, 
and save it as damage rect in LayerImpl.
During frame draw, when the damage for surfaces and 
layers are tracked, we query for these damaged layer rects 
and unify with the DamageTracker's damage rect.

BUG=

Review URL: https://codereview.chromium.org/219963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266852 0039d316-1c4b-4281-b951-d872f2087c98

R=ager@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/260073010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266851 0039d316-1c4b-4281-b951-d872f2087c98

Previous CL (which caused memleaks):
https://codereview.chromium.org/225693005

BUG=165760, 140882, 141141, 141517, 142787

Review URL: https://codereview.chromium.org/246923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266850 0039d316-1c4b-4281-b951-d872f2087c98

Test code in https://codereview.chromium.org/255753003/

BUG=345296

Review URL: https://codereview.chromium.org/197453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266849 0039d316-1c4b-4281-b951-d872f2087c98

So far, the ONC IPConfig object was only validated but not translated to or from Shill.
This adds the one direction, from Shill to ONC.

This allows exposing the current IP config state of Shill through ONC, e.g. with in the networkingPrivate API.

BUG=288288

Review URL: https://codereview.chromium.org/249193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266848 0039d316-1c4b-4281-b951-d872f2087c98