- 25 May, 2020 40 commits
-
-
Noel Gordon authored
CL:2210194 updated <cr-toast> own deps, so no need our files app BUILD to interpolate <cr-toast> internal deps anymore. Remove the TODO. Tbr: adanilo Bug: 1002391,1033660 Change-Id: I50022f87ba14843a4e46b8c0088e7d7d922143a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213649Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771502}
-
tby authored
This CL sets up the MVP version of settings result ranking. We: - Show at most two results - Which are glued to the top of the launcher - But show no results for single-character queries. To avoid confusion, I've removed the max results constant from the search controller factory, and replaced it with a 'generic max results' version. This generic version is necessary for now because a value for max results is mandatory, but we're moving away from needing it. Bug: 1068851 Change-Id: I188324413dd120d6f8abbf1b0a8791d4fcaac0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214583 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771501}
-
James Cook authored
SingleClientStandaloneTransportSyncTest needs to include WEB_APPS in its list of OS transport-mode types. sync_integration_tests --enable-features=SplitSettingsSync passes after this change. This CL is in preparation to turn SplitSettingsSync on by default. Bug: 1060289 Change-Id: I7662ba9a4ac529db18ba8887eeebe6f4023a53f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211044 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#771500}
-
Koji Ishii authored
This patch adds |WritingMode| and |TextDirection| as members of |NGFragmentItemsBuilder|. The current code has problems if different |WritingMode| and |TextDirection| are given to, say, |Items| and |ToFragmentItems|. Giving them at the constructor can avoid such inconsistencies. This also allows delaying construction of |NGFragmentItem|, which is part of the performance work. Bug: 982194 Change-Id: If49c41d7ad0d65ac083d8fc58793128d2ed28616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212229Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771499}
-
Yoshifumi Inoue authored
This patch gets rid of useless "highlight.html" and expected images for ease of maintenance and help to implementing EditingNG. "highlight.html" was introduced for testing "-webkit-highlight" CSS property but this property is no longer used. This property is parsed and store in |ComputedStyle| but layout and paint don't refer it. Note: WebKit removed "-webkit-highlight" on 2014[1]. [1] https://bugs.webkit.org/show_bug.cgi?id=128456 Bug: 707656, 1086089 Change-Id: I945221634e0176123aee3677b1b3e9da711d0021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214801 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771498}
-
Koji Ishii authored
As part of the work to update |TextMetrics::Update| for issue 1010893, the call to |Font::BoundingBox| turned out to be unnecessary: * |Width()| is the sum of advances, which is already comptued as |real_width|. * |Y()| and |MaxY()| are the same as |glyph_bounds|, except that |Font::BoundingBox| clamps them to 0. This patch replaces the call to |Font::BoundingBox| with the equivalent, already computed values. This is to help supporting bidi in |TextMetrics::Update|. WIP: https://crbug.com/c/2196086 but also reduces call to CachingWordShaper and improves the performance. Note that the clamping behavior is not copied. It is most likely unintentional and unlikely to cause compat problems. Currently, this function is the only caller of |Font::BoundingBox|. We can remove it once this change is stabilized. Bug: 1010893 Change-Id: I79d255e1a308e5da501e65a95981c6f13148a57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196624Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771497}
-
Yutaka Hirano authored
- no-secure-context.html failures are platform independent. Unify the entries and associate it to an appropriate crbug issue. - javascript.https.html is no longer failing. - coep-frame-javascript.https.html is no longer failing. - require-corp.https.html is (sadly) flaky on both Debug and Release. Unify the entries. Bug: 1086066, 1015187, 1013523, 626703, 1086065 Change-Id: I016579257bf3175a08755ee34bd8c911eeeb1d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212120 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771496}
-
Yoshifumi Inoue authored
This patch changes "format-block-with-trailing-br.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I386ca10eb56a820cf9b7e2ee140016ab17043733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214458 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Make sure that ManifestUpdateManager doesn't cause FinalizeUpdate while web apps system is not ready. Note: we should do tasks_.clear(); in Shutdown to destroy all ManifestUpdateTasks. That's how we unsubscribe tasks from WebAppUiManagerImpl: void ManifestUpdateTask::UpdateAfterWindowsClose() { ... ui_manager_.NotifyOnAllAppWindowsClosed( app_id_, base::BindOnce(&ManifestUpdateTask::OnAllAppWindowsClosed, AsWeakPtr())); } In next CL: Plumb WebAppUiManagerImpl Startup/Shutdown. Bug: 1084939 Change-Id: I25112df44af57606e38bcc6c12f12f67bd94c8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212197 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#771494}
-
Yoshifumi Inoue authored
This patch changes "5065910.html" to utilize |selection_test()| and renames to "justify_block_starts_with_image.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ic22aa13b2da5c6dbcc0657d742c79bd4ffe37a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213646 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Julian Watson authored
Bug: 778674 Test: autoninja -C out/Release ui/file_manager:closure_compile Test: autoninja -C out/Release browser_tests && out/Release/browser_tests --gtest_filter=*/FilesApp* Change-Id: I1a9e532afc0122a78328eae857e0dbf34971fcbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212015 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#771492}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ibf4e509a959108ddee42bef7233a0436ee7376cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192574 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#771491}
-
Mason Freed authored
This CL is the result of the following mechanical replacements, within the third_party/blink/web_tests folder, on only .html and .js files: '.createShadowRoot()' -> '.attachShadow({mode: 'open'})' 'document.createElement('content')' -> 'document.createElement('span')' Several web_tests did not pass after the above replacements were made. Those tests were reverted - the changes in this CL are only the tests that pass in the same way that they did prior to the replacements. The only exceptions, which were re-baselined here, had *only* a console warning message like this, which is now missing: CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M80, around February 2020. Please use... In addition, most of the same test expectations files were completely removed from the virtual/web-components-v0-disabled folder, since these tests no longer depend on WCv0 features, and no longer fail. One exception is this one: fast/dom/shadow/disconnected-distribution-cycle-expected.txt which still uses getDestinationInsertionPoints() and so breaks differently now. Bug: 937746 Change-Id: I03c0f834c82bac79e48eb0ddd419c9351b61b455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208386 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:Stephen Chenney <schenney@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#771490}
-
Koji Ishii authored
Because |NGLogicalLineItem| can live longer than |NGInlineItemResult|, the pointer may become stale. Instead, this patch changes |NGLogicalLineItem| to copy necessary data from |NGInlineItemResult|. This is to prepare for vectorizing |NGFragmentItem|, by allowing to defer creating |NGFragmentItem| to after |NGInlineItemResult| is destroyed. This patch has no behavior changes. Bug: 982194 Change-Id: Idfad9fe4d4421ddd76b2348e6c17e50e327911a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212187Reviewed-by:
-
Kenichi Ishibashi authored
This CL starts using ServiceWorkerStorageControl in ServiceWorkerRegistry. For now, an instance of ServiceWorkerStorageControl is owned by ServiceWorkerRegistry as a drop-in replacement of ServiceWorkerStorage. Eventually the instance will live in the Storage Service once all ServiceWorkerStorage method calls are migrated into mojo methods. This CL only replaces UpdateLastUpdateCheckTime() call. Subsequent CLs will replace more ServiceWorkerStorage method calls. According to android-binary-size trybot, this increases the binary sizes by ~37kb. Most of the increase (~29kb) comes from mojo generated code and there isn't much we can do to reduce them. Introducing this mojo interface is necessary for migrating ServiceWorkerStroage to the storage service. See the design doc [1] for the motivation and plans. [1] https://docs.google.com/document/d/1hO0WEuoEOgEBlf5nDE3fDjuQY2bV_d5hLtk25iBo0LM/edit?usp=sharing Bug: 1055677 Binary-Size: Size increase is unavoidable (see above) Change-Id: Ic843e25f3556249b67252f52e9e16428ec488dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214582 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#771488}
-
Hajime Hoshi authored
This CL adds methods to WebPerformance to record the latest timing when the page is restored from the back-forward cache and the latest timing of first-paint event after restoring. This CL is a preparation to record first-paint event for back-forward cache at PageLoadMetricsObserver. Bug: 1014174 Change-Id: Ie0bd0e1cbfc070867a75b2574f05ad0797934875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210181 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes font-family-with-space.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I1dc4ec92ce7aeb3b095f9854a2a1699bb3fa9dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212196 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit 945fcd73. Reason for revert: Speculative revert for AppControllerPlatformAppBrowserTest.ActivationFocusesBrowserWindow failure. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/50628 Original change's description: > WebApp: Call RegistryOpenedCallback asynchronously. > > We should break down this synchronous call chain: > > web_app::WebAppSyncBridge::CommitUpdate() > web_app::ScopedRegistryUpdate::~ScopedRegistryUpdate() > web_app::WebAppInstallFinalizer::UninstallWebApp() > web_app::WebAppInstallFinalizer::UninstallWebAppOrRemoveSource() > web_app::WebAppInstallFinalizer::UninstallExternalWebApp() > web_app::InstallFinalizer::UninstallExternalWebAppByUrl() > web_app::PendingAppManagerImpl::UninstallApps() > web_app::PendingAppManager::SynchronizeInstalledApps() > web_app::ExternalWebAppManager::OnScanForExternalWebApps() > web_app::ExternalWebAppManager::ScanForExternalWebApps() > web_app::ExternalWebAppManager::Start() > web_app::WebAppProvider::OnRegistryControllerReady() > web_app::WebAppSyncBridge::OnDatabaseOpened() > web_app::WebAppDatabase::OnAllMetadataRead() > syncer::ModelTypeStoreImpl::ReadAllMetadataDone() > > WebAppSyncBridge::OnDatabaseOpened() must not cause immediate > WebAppSyncBridge::CommitUpdate() on same `this`. > > Bug: 1084939 > Change-Id: Ib32c52780a647a0985418c0f92985f041869f104 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212236 > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771473} TBR=ericwilligers@chromium.org,loyso@chromium.org Change-Id: I80600ec60e1f669ca0823caf77ce36a3985d9dbe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1084939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213648Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771485}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5598ba3c0e6f..34a30f39c0d1 2020-05-25 fancl@chromium.org auto-triage: Fix point range AlertGroup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1086055 Tbr: wenbinzhang@google.com Change-Id: If2105e1612a772b74c5f1b4709aa5d1747cd302d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771484}
-
shrekshao authored
TBR=kbr@chromium.org Bug: 1058744, 1085704, 1085846 Change-Id: Ia268bfe248a8fa7caa832e9e696a8039c7605b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214611Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#771483}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5391d98b8d8..340fee5c8499 2020-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 65ee6497d620 to 31c9c6949e02 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ifb853887942a5bc6c3ba3e50aada75309eff3ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214684Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5065910.html" to utilize |selection_test()| and renames to "typing_style_color_before_delete.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ic7ede76eaa15a7381eaeaeaf087b3b703788d5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214762 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "block-style-00{1,2}.html" to utilize |selection_test()| and integrates into "block-style-001.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ic2ae843b078ab9d85d6a7cb47337458fe3b031eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214584 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: -
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. The use of the function in SearchPermissionsServiceTest is updated and a new test is added for non-primary off-the-record profiles. Bug: 1060940 Change-Id: I39d1451c386d93fb47cbf2576d3b4280e634cb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213563 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771479}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590362592-27d6169705690c1f85a434239769339f2909dab4.profdata to chrome-win32-master-1590378757-fbe5ba418cc3b4a3b6daa4da92a12bf985342290.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5cfb578711a914a50ef8fa68ef46d0a5f7ce42a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214688Reviewed-by:
-
Xianzhu Wang authored
Adjust the order of field to fill gaps after inherited fields. Change-Id: Iafb34294d0643ffc4f761921a8382b595897463d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214462 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590362592-b410bf229b3e4363919a6ee2322f1e85184470ca.profdata to chrome-mac-master-1590378757-0e86ea9817fe6c644c14c0cd7e1701a48ebcda53.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I07879cf3c4faa1fd573ef6432a857687fa3bc63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214685Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "4916887.html" to utilize |selection_test()| and renames to "color_of_indented_text.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I97c3a41130d62af6b4255fd161d9f21aaeccb5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212239 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e6d4f1bcfd1..b5391d98b8d8 2020-05-25 csmartdalton@google.com Reland "Reland "Add a tessellation mode that uses indirect draws"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I526850c2a739f159ef2d0c695cbb2cf9fae86271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214681Reviewed-by:
-
Alexey Baskakov authored
We should break down this synchronous call chain: web_app::WebAppSyncBridge::CommitUpdate() web_app::ScopedRegistryUpdate::~ScopedRegistryUpdate() web_app::WebAppInstallFinalizer::UninstallWebApp() web_app::WebAppInstallFinalizer::UninstallWebAppOrRemoveSource() web_app::WebAppInstallFinalizer::UninstallExternalWebApp() web_app::InstallFinalizer::UninstallExternalWebAppByUrl() web_app::PendingAppManagerImpl::UninstallApps() web_app::PendingAppManager::SynchronizeInstalledApps() web_app::ExternalWebAppManager::OnScanForExternalWebApps() web_app::ExternalWebAppManager::ScanForExternalWebApps() web_app::ExternalWebAppManager::Start() web_app::WebAppProvider::OnRegistryControllerReady() web_app::WebAppSyncBridge::OnDatabaseOpened() web_app::WebAppDatabase::OnAllMetadataRead() syncer::ModelTypeStoreImpl::ReadAllMetadataDone() WebAppSyncBridge::OnDatabaseOpened() must not cause immediate WebAppSyncBridge::CommitUpdate() on same `this`. Bug: 1084939 Change-Id: Ib32c52780a647a0985418c0f92985f041869f104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212236Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#771473}
-
Kent Tamura authored
active_selection_*_ data members are referred only in listbox mode. We don't need to update them in the menulist mode. Bug: 1052232 Change-Id: Ib688c6e9977f42cd1cefdd83388fdc286345b842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212108 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit fb330032. Reason for revert: Failing on bots: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/b8879653217445589120 Original change's description: > Add tests for QuickAnswersView > > Add a test-fixture and basic tests for QuickAnswersView. Current tests > verify the view's positioning with respect to its anchor and more tests > will be added in follow-up CLs. > > Bug: b:157182213 > Test: Built and ran ash:ash_unittests on local build. > Change-Id: I44634313ff6538e48ef7375641e1971bfc989ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210977 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Abhijeet Singh <siabhijeet@google.com> > Cr-Commit-Position: refs/heads/master@{#771207} TBR=xiyuan@chromium.org,siabhijeet@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:157182213, 1085632 Change-Id: Iedb2530ed4d8c6b56ba8b5f3fe42fcc4d0052c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212238Reviewed-by:
-
Hiroki Nakagawa authored
This CL renames ServiceWorkerHost's running_hosted_version to version because it's obvious that the version kept by ServiceWorkerHost is the running hosted version. Bug: 931087 Change-Id: Icfa6ae852418c7e089b254b19a745756fd6d3c74 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206935 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Bo Majewski authored
Rather than counting time since last time we scheduled a throttled change event, we count time since last time we posted one. This allows us to post an event with 0 delay first, before starting to throttle them. Bug: 936790 Change-Id: Id9a40890d8d7fdb53e57f657c979f2ac5f4f7f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210089Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c63db0f9a76..7ca48df80a7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yhirano@google.com Change-Id: I2761e57aacdfe89c7024132321c6188aa5e10b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214580Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771468}
-
Yutaka Hirano authored
Tbr: yigu@chromium.org No-Try: True Change-Id: I95fdbddabf525f5455574622e138874b5245044e Bug: 1060164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213644Reviewed-by:
-
Fergal Daly authored
Move a lot of stuff from constructor to initializers and mark fields as const where possible. Also - add comment referencing https://crbug.com/855189 - delete GetClientHintsPreferences which is unused. There's more that can be done but this is all of the stuff that was easy. Change-Id: I97bc5b9cc67fada0bb57426271fd38c376adcac9 Bug: 855189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203040 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff64aa2b. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" fc4093a6 "Move mouse-pointer-preventdefault.html to wpt" 3304d0fe "Revert "Move mouse-pointer-preventdefault.html to wpt"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I700238d8da3501763e14cda400d973e536be2b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212388Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771465}
-
Alex Danilo authored
Adds a transition for the background-color property on the search box wrapper so that it fades out while the search text entry field is collapsing to stop the sudden change of color when the text field starts to collapse. Bug: 1075941 Change-Id: I25d38c2db817b2585b8c86c046e5d88e041ec30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210297Reviewed-by:
-
Hiroki Nakagawa authored
ServiceWorkerProviderHost is equivalent to RenderFrameHostImpl, DedicatedWorkerHost, and SharedWorkerHost. For name consistency, this CL renames ServiceWorkerProviderHost to ServiceWorkerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I583838006e8c10540acbe0a2681d11b8d9aad1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203781Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
