- 26 Oct, 2020 40 commits
-
-
Lukasz Anforowicz authored
This CL opportunistically uses the |typeWithEmbeddedFieldDecl| matcher introduced in a previous CL (in https://crrev.com/c/2492464) to fix the "union" filtering rule, so that it not only covers pointers stored directly as union fields, but also covers pointers stored in structs that are nested as a union field. This is motivated by the following examples: - flags_ui::FeatureEntry::(anonymous union)::(anonymous struct)::feature - ui::NativeTheme::MenuSeparatorExtraParams::paint_rect (MenuSeparatorExtraParams struct is embedded as a field of ExtraParams union). (the two examples above are currently excluded via manual-fields-to-ignore.txt) Bug: 1069567 Change-Id: I05fd59d0c93b7954321b375bce40d5325e3eab7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495822 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820928}
-
Sergey Poromov authored
This is a reland of aa433c9b Original change's description: > DLP: Do not start screen capture for restricted content. > > During creation of a screen capture (desktop, window or tab) it needs to > be checked whether the captured area contains any DLP > (Data Leak Prevention) restricted content. > The corresponding MediaAccessHandlers should do this check on Chrome OS. > > Bug: 1134566 > Change-Id: Id77739a9b6df9f3ed946e563d508c43df83b5580 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446329 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820713} Cq-Include-Trybots: luci.chromium.try:mac10.15-blink-rel,mac_chromium_10.15_rel_ng Bug: 1134566 Change-Id: Ie1bdd637d9364cc7e75248627c7393438353e230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497450Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#820927}
-
Matt Mueller authored
Bug: b/170619368 Change-Id: I5956a417161c45d12a933637576f462b4d5d215f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490865 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820926}
-
Steven Bennetts authored
This will allow NetworkState to properly reflect the Shill portal detection results. This also adds two new histograms for collecting better captive portal stats on Chrome OS. Bug: 1133376 Change-Id: I1b3a1b7f9b787587d45dc0a6f9c5a85ccb509cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490681Reviewed-by:
Kartik Hegde <khegde@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#820925}
-
Bailey Berro authored
This change adds the marketing name to the SystemInfo struct so that it can be displayed in the UI. Bug: 1128204 Change-Id: I61fdab68aa61701cfe9c6a1bc7a23b712aeec1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491989Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#820924}
-
Joey Arhar authored
remove-crypto.patch fixes an issue where configure will fail on linux due to a missing makefile Bug: 934413 Change-Id: I0a4413389ad7b4f884cc4dcb2bd6fd6144355751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461719Reviewed-by:
-
Xianzhu Wang authored
Bug: 1137884 Change-Id: I8f1848285f77fa4389b45f24abf097f10f1e92f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496185 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#820922}
-
Mohsen Izadi authored
Following metrics have been recently removed from rendering benchmarks: - percentage_smooth: Removed in http://crrev/c/2414410; - frame_lengths: Removed in http://crrev/c/2451211. This CL removes references to them from rendering benchmark doc. Bug: 894287,1135662 Change-Id: I72fd58c3c4be19e0cbb930dedd7ee6d733fac952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499201Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820921}
-
Guillaume Jenkins authored
Adds a new unit test to the ProfileReportGeneratorIOS delegate for the case where a profile has a signed-in user. The test generates a report with a few policies and verifies that the values in the proto make sense. Bug: 1114853 Change-Id: I22b10d978a864f54a3aa5ba8cb143a5a27e5fc55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495750 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820920}
-
Guido Urdaneta authored
Insertable Streams and Transferable Streams are shipping by default, but the ability to use them together (serialization of RTC encoded frames) was still behind a flag. This CL removes this restriction. The flag is currently reserved for the legacy version of the API and will be removed in M89. Serialization is part of the released API. Bug: 1142519 Change-Id: I64dcdb0b0974c9a582d79f604a01c73925f8e3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498491 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#820919}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/007c109b4594..40c5681ab92e 2020-10-26 wl@gnu.org * meson.build: Fix 'harfbuzz' and 'brotli' build options (#59347). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I39a055a17fbdd90a2cce2767971a74c19ec64255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499405Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#820918}
-
Erik Chen authored
Change-Id: I249c1c12724aa925f7e155df26de4077bcc1a8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495694 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#820917}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I357265e925d851ec533dba56ebea496391f5c653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499406Reviewed-by:
-
Alex Newcomer authored
Example of improvements: https://screenshot.googleplex.com/C8jxSzdyCWaqpUK.png Of note: - The images are tiling horizontally and vertically due to an issue with RoundedImageView, details here: https://crbug.com/1139498 - Images in the amazon screen shot load completely! 1. Add <!DOCTYPE html> to the data url. - This aids in proper sizing of the rendered HTML. 2. Allow the web view to auto resize. - This aids in proper sizing of the rendered HTML. 3. Debounce calls to CopySurface. - Ensures we get the fully loaded HTML. - Sometimes DidStopLoading and ResizeDueToAutoResize is called. multiple times per load. Copy on the final call. 4. Increase Request timeout time to allow for loading of full pages. - For example, copy a full Amazon page, it takes >5s to render. 5. Scale the screenshot to fit into the 222x66 multipaste screenshot. - Previously we relied upon clipping done downstream, but UX prefers scaling. Change-Id: I7759dafac0e774aa2c9a5836d65843f83453c653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481943 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820915}
-
Patrick Noland authored
Bug: 1142544 Change-Id: I9533d4f1350a5d539055f85a9bb1b48b21808b71 TBR: bashi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498655Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#820914}
-
Nicolas Ouellet-Payeur authored
The DestroyProfileOnBrowserClose didn't clean up data on disk when the profile got deleted, so the flag did nothing for ephemeral profiles, until now. With this patch, DestroyProfileOnBrowserClose applies to ephemeral profiles. When the last browser window in a profile closes, the Profile object is destroyed. Then, the profile directory is nuked from disk. This way, sensitive data gets deleted much earlier than it previously did. Bug: 88586 Change-Id: Ic74f8ceec0344f2759a88ab4a007f36316517037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485639Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#820913}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ief1d72ccf5f31a05639445068a4288cbbfa9cc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498833Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#820912}
-
Reilly Grant authored
This change refactors the use counters for the Shape Detection family of APIs so that usage of the detect() methods on BarcodeDetector, FaceDetector and TextDetector interfaces is recorded separately. These new use counters are then enabled for UKM. This removes the use counters for the constructors, which are less useful than recording usage of the detect() methods as constructing an instance of the detector does not indicate real usage and could overtrigger for feature detection. Bug: 1001217 Change-Id: Iec763bb8f0f175e098943228492ca6b27440a167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498825 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Scott Violet authored
Specifically if the NewTabCallback deletes then tab, then we shouldn't try to load a url. BUG=1142090 TEST=testOpenPopupFromInfoBarAndNewTabCallbackDestroysTab Change-Id: Ib31e7cb52d7dec6d1724c1e3471b7c5ace72c858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496160Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820910}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603713364-255d86fa5592c315dc7718e8b4c93f0ba1279e07.profdata to chrome-linux-master-1603735176-b32fad2c4d9cbe478f3c31f23cbc72f28c88ba53.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I10216ea86e7d5e1539e9754fdec24aa8b801fd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498850Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2663acda4ce..546b189d859d 2020-10-26 jalyn@microsoft.com Settings: Prepare shortcut editor for reset button If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I963de7d818ac55cae7b807cd4db08006738ab3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499417Reviewed-by:
-
Sebastien Lalancette authored
This value will be mainly used when facing parsing failures when converting responses from the text-fragments-polyfill JavaScript library used on iOS. Bug: 1136043 Change-Id: I2af25b336944a5ac4f7258de75aeec8f73b46ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499084Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#820907}
-
Peter Kasting authored
These are selected so as to unblock removing (and remove) the majority of the remaining ButtonListener-receiving APIs. Bug: 772945 Change-Id: If33924bb5b21a843c2b90717916e54ac281ce235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495834 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#820906}
-
Alexis Hetu authored
Using an RGBA8 image for an RG8 texture was causing confusion in the underlying driver where copyTexSubImage could be disallowed because of unequal formats between the framebuffer and texture (RG8 vs RGBA8) while the application was seeing 2 RGBA8 textures. Removing the workaround is now possible and fixes the issue. Bug: 985458 Change-Id: I6a1ac80f05adb67917ddda34835c9be7f0d5d1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499264Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820905}
-
Andre Le authored
- Add PhoneHubNotificationView to customize Phone Hub Notification. - After sending a reply, take the UI back to action buttons and briefly disable the reply button. BUG=1106937,1126208 Change-Id: Ie022f2a4955b6dd0ebd4b0120bfffae805038a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488364Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#820904}
-
Ilia Samsonov authored
Currently our builders run python in x86 architecture. This cl introduces the same routine as in depot tools to detect whether we are running on arm. https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2287751 Bug: 1130741 Change-Id: I139c1d6be042a43e73c80ae6aac789cdba9e352b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462484Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#820903}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7874beb5c5a1..306f03788f83 2020-10-26 johnchen@chromium.org [Telemetry] Speculative fix for missing win32gui If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1141914 Tbr: zhanliang@google.com Change-Id: Idbf758dd9a58341279d73cabf19efc5ea9a8dca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499412Reviewed-by:
-
Daniel Rubery authored
SafeBrowsingNetworkContexts is ready to roll out to Beta (see cl/337414650), so add a field trial for it. A few tests fail with the feature enabled, so we add a little code to fix those tests as well. Change-Id: I5254a0b632f5319f50d29756a996e69dcd3acc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477252Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#820901}
-
Victor Hugo Vianna Silva authored
Bug: 1099615 Change-Id: If712d3e7158ead902a6f93ccf85bcb45372a682c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498591 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#820900}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2a3a5b3b4c3..aaea0d98fb64 2020-10-26 johnstiles@google.com Update `nameVariable` to return the variable name directly. 2020-10-26 brianosman@google.com Slight tweak to SkTHashMap natvis support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I210d3a21b9a2f09684a3b8741adea931130dd3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498874Reviewed-by:
-
Jeroen Dhollander authored
This code path was previously not tested. The binary data for this test is committed in crrev.com/i/3324203. Bug: N/A Change-Id: I27c89cce52effc11accf3b4a03822ad2198c6ec9 Tests: browser_tests --gtest_filter=AssistantBrowserTest.* Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461249 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820898}
-
Philipp Hancke authored
following the pattern from https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/streams/transferable/worker.html Also moves the audio/worker test to the worker file BUG=chromium:1058021 Change-Id: I0a49166208aa5cd68a2660abed1ec5e0c52b9b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499521Reviewed-by:
-
Daniel Rubery authored
On Windows, when downloading the second or later part of a multipart archive, unrar will attempt to open another file. Due to the modifications we place on unrar to work within the sandbox, we don't open the file, but instead use File::hOpenFile as the handle. This is uninitialized memory, which is passed to GetFileType, causing a crash. This CL initializes hOpenFile to fix this problem and adds a test that would have caught the issue. Fixed: 1135503 Change-Id: I6cc83a5a2b5925900cde7b8b2dc8be64f0620d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490334 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#820896}
-
Rainhard Findling authored
* Workaround for crbug.com/1139806. * Writes the CCT scan completion time into a Chrome pref in case Chrome is open when the scan completes. * Uses this timestamp alongside the one from the registry in the Chrome cleaner child of safety check. Bug: 1087263,1139806 Change-Id: Ia3fda6e87058ba76089ce22e8367f41d8e0b8512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484700Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#820895}
-
Dan Harrington authored
There were two problems with these regexes: 1. it didn't support the syntax without curly braces: -checkdiscard @com.Foo class * 2. it ate newlines, which could break rules Change-Id: I667ec65f2e9c8a06c812d62578e700792cf172a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498828 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#820894}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603713364-eb28cdd9672687229cd838b6373ed78fbaa1ba2f.profdata to chrome-mac-master-1603735176-39200681b7df83b17975b9debf912df318fc5920.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia0e8059d7223b60f02ced18b1632c15ac8797d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499419Reviewed-by:
-
Eugene Zemtsov authored
Change-Id: I6ff42f27427b4ba171b7cb345523f4b1b550a8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495795Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#820892}
-
Victor Hugo Vianna Silva authored
Let's attempt to re-enable the test. Bug: 1111533 Change-Id: If091b686e3ba64395587ec029dbd82df61559466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498691 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/902077f931b9..84938ab95122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC slightlyoff@google.com,avi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475 Tbr: slightlyoff@google.com,avi@google.com Change-Id: I25b1cc8a18a150007184cf87604183510a2934eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499413Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820890}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I22a823fbe7d247fd5723bebddf4de3bb7ee69c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494765Reviewed-by:
-
