- 23 May, 2014 40 commits
-
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272520 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174635:174659&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/296953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272519 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Revert of Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable. (https://codereview.chromium.org/291333007/) Reason for revert: This removed the wrong file (safely-roll-deps instead of safely-roll-blink). Now Skia's AutoRoll Bot is broken. Original issue's description: > Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable. > > "tools/safely-roll-deps /src blink" > is the replacemnt syntax. No need to keep dead code around. > > BUG=242461 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272347 TBR=maruel@google.com,borenet@chromium.org,eseidel@chromium.org,blink-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true BUG=242461 Review URL: https://codereview.chromium.org/294163012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272518 0039d316-1c4b-4281-b951-d872f2087c98
-
andrewhayden@chromium.org authored
BUG=367239 Review URL: https://codereview.chromium.org/296943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272516 0039d316-1c4b-4281-b951-d872f2087c98
-
torne@chromium.org authored
The refactoring in the final patchset landed as r269766 got the condition backwards (the pre-refactoring version worked), so we were accidentally excluding flag only on *target* builds, instead of host builds as intended (the target compiler supports this flag). Fix it. BUG=321833 R=primiano@chromium.org Review URL: https://codereview.chromium.org/296273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272511 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=374758 Review URL: https://codereview.chromium.org/294783003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272510 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
BUG=n/a TBR=tzik@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/295203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272509 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272508 0039d316-1c4b-4281-b951-d872f2087c98
-
kkinnunen@nvidia.com authored
The implementation of glLoseContextCHROMIUM did not return early in gl error conditions of invalid enums passed as arguments. Add the early returns and tests for the invalid enums. Upon successful glLoseContextCHROMIUM, the subsequent calls such as glGetError would also fail, because the implementation would set the decoder error variable as well as return the error value. Fix this by just setting the decoder error variable. Add a test for this (LoseContextCHROMIUMValidArgs) BUG=373159 Review URL: https://codereview.chromium.org/298753004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272507 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
Please reply to the V8 sheriff jkummerow@chromium.org in case of problems. TBR=jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/299893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272506 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
The connection handlers will otherwise continue to call into blink which is bound to crash after it was shut down. BUG=337572 R=perkj@chromium.org,adamk@chromium.org Review URL: https://codereview.chromium.org/292163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272504 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
Revert of Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object. (https://codereview.chromium.org/283413002/) Reason for revert: Introduced flake on Mac: crbug.com/376550 Original issue's description: > Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object. > > The goal of this CL is to eliminate the dependence of > GoogleURLTracker(MapEntry) on NavigationController. To accomplish this goal, > GoogleURLTrackerNavigationHelper is turned into a conceptually per-tab > interface. GoogleURLTracker::OnNavigationPending() now takes in the > GoogleURLTrackerNavigationHelper with which the navigation is associated rather > than the associated NavigationController; GoogleURLTracker performs per-tab > actions by calling the navigation helper associated with the tab. > > A followup CL will turn GoogleURLTrackerNavigationHelper(Impl) into the > GoogleURLTrackerDriver interface and ContentURLTrackerDriver implementation. > > BUG=373230 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272094 TBR=pkasting@chromium.org NOTREECHECKS=true NOTRY=true BUG=373230 Review URL: https://codereview.chromium.org/294193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272503 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
This setting can be configured by device owners to indicate whether developer mode should be available on their device. session_manager will take care of configuring the system to behave accordingly. BUG=chromium:375772 TEST=None Review URL: https://codereview.chromium.org/293033012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272502 0039d316-1c4b-4281-b951-d872f2087c98
-
alph@chromium.org authored
Revert of Update AudioRenderer API to fire changes in BufferingState. (https://codereview.chromium.org/284763002/) Reason for revert: Broke blink tests: mediasource-redundant-seek.html mediasource-seek-during-pending-seek.html http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/28147 Original issue's description: > Update AudioRenderer API to fire changes in BufferingState. > > As a result, Pipeline now handles prerolling and underflow/rebuffering > by listening for BUFFERING_HAVE_NOTHING/ENOUGH callbacks. Preroll() is > renamed StartPlayingFrom() and no longer accepts a completion callback. > In this new model, AudioRenderers immediately enter and remain in > the "playing" state and fire buffering state callbacks to let Pipeline > know when to start/stop the clock. > > BUG=144683 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272465 TBR=acolwell@chromium.org,scherkus@chromium.org NOTREECHECKS=true NOTRY=true BUG=144683 Review URL: https://codereview.chromium.org/291093013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272501 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Previously we did not call onDetached on old native AwContents, which now no longer cleans up hardware resources correctly. This also had the side effect that the following onAttach with the new native AwContents is ignored in java code due to attach/detach mismatch. As make onDetached more strict with respect to ordering. And lock to protect variable accessed on multiple threads. Also need to ensure we never requestDrawGL on the blank native AwContents that's destroyed during pop up. BUG=376622 Review URL: https://codereview.chromium.org/288983007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272500 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
This regressed in r271640. Review URL: https://codereview.chromium.org/298803013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272499 0039d316-1c4b-4281-b951-d872f2087c98
-
ycheo@chromium.org authored
This method is needed to inject the other DRMs' keysystem and uuid mapping in MediaDrmBridge. BUG=322395 Review URL: https://codereview.chromium.org/284183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272498 0039d316-1c4b-4281-b951-d872f2087c98
-
treib@chromium.org authored
This is the Mac part of https://codereview.chromium.org/294593004 BUG=360559 Review URL: https://codereview.chromium.org/296503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272497 0039d316-1c4b-4281-b951-d872f2087c98
-
bratell@opera.com authored
Make the tests run for every commit to make sure tests and code stay in sync and are both working. BUG= Review URL: https://codereview.chromium.org/296003007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272496 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=374648 TEST=unit_tests Review URL: https://codereview.chromium.org/299623012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272495 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
* Replace base class of LocalToRemoteSyncer with SyncTask * Add testing SyncTaskToken. * Clean up LocalToRemoteSyncer implementation. BUG=344769 Review URL: https://codereview.chromium.org/297803011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272494 0039d316-1c4b-4281-b951-d872f2087c98
-
jorgelo@chromium.org authored
This is a reland of https://chromiumcodereview.appspot.com/255693002/ Race conditions in Skia have been fixed. BUG=322185 Review URL: https://codereview.chromium.org/286903021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272493 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272492 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
https://code.google.com/p/skia/source/list?num=22&start=14862 TBR= BUG= Review URL: https://codereview.chromium.org/294033015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272491 0039d316-1c4b-4281-b951-d872f2087c98
-
jyasskin@chromium.org authored
We can use this map to drop all the process references on shutdown, in order to fix http://crbug.com/368570. This starts to fix an assumption in the content layer that SiteInstances outlive their RPHs so that process permissions can be controlled through the SiteInstance instead of by process id. However, there's still work to do before that's completely fixed. This reverts https://codereview.chromium.org/296053013/ and avoids the incorrect down-cast that caused https://codereview.chromium.org/292903002 to break the Asan bot. BUG=368570 Review URL: https://codereview.chromium.org/294073009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272490 0039d316-1c4b-4281-b951-d872f2087c98
-
alph@chromium.org authored
Revert of Repurpose views+content example into a generic multiprocess views runtime (https://codereview.chromium.org/284113011/) Reason for revert: Broke Blink runhooks step http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/12039 Original issue's description: > Repurpose views+content example into a generic multiprocess views runtime > > This is to facilitate the addition of an app launcher example/demo app, > separate from the browser, and to assist testing of the out-of-process > compositor on mac. > > The change splits out from the current views_examples_with_content_exe > target a new views_content_client target placed in > ui/views_content_client. views_examples_with_content_exe is updated to > use it. > > This will allow the app launcher to have its own example app, while > reusing the logic to set up the multiprocess runtime environment for > using views and content. > > Follow-up patches for the views_content_client runtime will: isolate > aura dependencies, introduce the gpu_process UI compositor, and > implement the runtime environment for mac. > > BUG=365977 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272476 TBR=ben@chromium.org,tapted@chromium.org NOTREECHECKS=true NOTRY=true BUG=365977 Review URL: https://codereview.chromium.org/288313012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272489 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
Also add some error message in case LoadCurrentConfig fails. BUG= TEST=gpu_unittests R=kbr@chromium.org Review URL: https://codereview.chromium.org/299113003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272488 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
Back then EmbeddedWorkerContextClient used to be destroyed on the worker thread when corresponding WorkerGlobalScope's destructed, but after http://crrev.com/262813004 we started to destruct it on main thread (after the worker side termination), so resetting thread-local ptr in the dtor doesn't work (as it runs on main thread). This change clears the thread-local ptr in willDestroyWorkerContext(), where we're sure we're still on the worker thread. BUG=n/a Review URL: https://codereview.chromium.org/287193011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272487 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
r272301 uncovered a bug in ClocklessAudioSink where calling Pause() prior to Stop() would attempt to stop the thread twice. BUG=376578 TBR=dalecurtis Review URL: https://codereview.chromium.org/292363005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272486 0039d316-1c4b-4281-b951-d872f2087c98
-
hajimehoshi@chromium.org authored
BUG=None NOTRY=true Review URL: https://codereview.chromium.org/299443007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272485 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
This CL moves the GPU-related system profile metrics logging out of MetricsLog into GPUMetricsProvider, which is a metrics::MetricsProvider. A new unittest is created to provide the related test coverage that was previously provided in the MetricsLog unittest. BUG=374228 R=asvitkine@chromium.org, isherman@chromium.org Review URL: https://codereview.chromium.org/291163006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272484 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
BUG=347425 TEST=./unit_tests --gtest_filter="DriveBackend*:SyncEngine*:Conflict*:RegisterApp*:RemoteTo*:LocalTo*:ListChange*:MetadataDatabase*:TaskDep*" Review URL: https://codereview.chromium.org/294893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272483 0039d316-1c4b-4281-b951-d872f2087c98
-
posciak@chromium.org authored
BUG=366158 NOTRY=true Review URL: https://codereview.chromium.org/299833005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272482 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272481 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
This pulls in the following Native Client changes: r13217: (jvoung) Remove old copy of nacl_file_info.h now that chrome uses new copy. r13218: (noelallen) Roll GN binaries r13219: (dschuff) Add pnacl win bot to default trybot set r13220: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13221: (dyen) Fixed toolchain_build exception when gcc is not found on the system. r13222: (dschuff) Add -DDEFINE_MAIN to build of unsandboxed IRT in pnacl_targetlibs.py r13223: (sehr) Make android build with -Werror r13224: (sehr) First gyp changes for Android chromium build r13225: (dschuff) Update revision for PNaCl r13214->r13222 r13226: (dschuff) Move Mac and Linux32 Non-SFI and unsandboxed tests from toolchain bots BUG=none TEST=browser_tests and nacl_integration Review URL: https://codereview.chromium.org/292353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272480 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
This API is called when initial metrics gathering should start, and takes in a callback that is called when initial metrics gathering is complete. It is currently empty but will be filled in as initial metrics gathering code moves out of MetricsService. BUG=374231 R=asvitkine@chromium.org Review URL: https://codereview.chromium.org/299663011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272479 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
Previously we would not define it in component builds because it didn't work with old versions of MSVC. These days it should work. The macro is extra important for Clang, which doesn't currently support exceptions on Windows. BUG=82385 Review URL: https://codereview.chromium.org/287193012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272478 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
This is to facilitate the addition of an app launcher example/demo app, separate from the browser, and to assist testing of the out-of-process compositor on mac. The change splits out from the current views_examples_with_content_exe target a new views_content_client target placed in ui/views_content_client. views_examples_with_content_exe is updated to use it. This will allow the app launcher to have its own example app, while reusing the logic to set up the multiprocess runtime environment for using views and content. Follow-up patches for the views_content_client runtime will: isolate aura dependencies, introduce the gpu_process UI compositor, and implement the runtime environment for mac. BUG=365977 Review URL: https://codereview.chromium.org/284113011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272476 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=345922 Review URL: https://codereview.chromium.org/296053017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272475 0039d316-1c4b-4281-b951-d872f2087c98
-
mikelawther@chromium.org authored
Also includes an updated histograms.xml after running the script. Review URL: https://codereview.chromium.org/276663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272474 0039d316-1c4b-4281-b951-d872f2087c98
-