- 12 Aug, 2020 1 commit
-
-
Scott Haseley authored
If a postTask task throws an error, the associated promise is rejected with the error. Previously, the error would also be propagated to the global error handler leading to errors being reported even if the promise rejection was handled. This CL suppresses that propagation, resulting in errors being reported to the global error handler only if the rejected promise is not handled. Bug: 979017 Change-Id: Ibbafaf8bd370b05a10f48cb5a122c8411305aadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350113Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#797048}
-
- 11 Aug, 2020 39 commits
-
-
Tomasz Wiszkowski authored
This change ensures that the server-supplied default visibility hint for suggestion groups is respected on Android. Suggestion groups will appear collapsed if the server hints their initial state should be hidden. The change also repurposes (and subsequently renames) AutocompleteResult's GroupHeaders as GroupsDetails. Bug: 1113931 Change-Id: Ib9214eecf8f3939bb08098a05180281ecf20f21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341822 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#797047}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/72ea2ee4650f..afbc899f2ff2 2020-08-11 capn@google.com Implement VK_EXT_depth_range_unrestricted If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie3bce052897f22bb35ed2cb378f861b573250b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350012 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797046}
-
Sven Zheng authored
For the last 10 jobs, two failed: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/883? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/881? Bug: 1111979 Change-Id: Ia061c5d5111f0dd77be5603c9a994f8cb5536cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350487 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#797045}
-
Daniel Rubery authored
This CL lands new strings that may be used for Advanced Protection Program users to send their downloads for deep scanning: "file.exe is unknown. Advanced Protection recommends sending this file to Google for scanning." as well as changing the button from "Send" to "Scan" Screenshot: https://screenshot.googleplex.com/Mh8PfqxvHMy.png Bug: 1115142 Change-Id: Ib43a25bd68c51bf86f3a86836c1afc6e31697d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350383Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#797044}
-
Christian Biesinger authored
Implements the spec change in https://github.com/w3c/csswg-drafts/issues/5257 This allows respecting the aspect-ratio even when we're computing the block size from an aspect ratio with a max-height specified. Bug: 1104360 Change-Id: Ibdff4bf4a67aa0897fd24416fed67bbb2f1ef9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308999 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797043}
-
George Steel authored
Fixes flakiness due to a cause it is not supposed to be testing for. Bug: 1115277 Change-Id: I41d43339913577ef20cabf528d6d1934baab3197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350488 Commit-Queue: George Steel <gtsteel@chromium.org> Commit-Queue: Alex Russell <slightlyoff@chromium.org> Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Cr-Commit-Position: refs/heads/master@{#797042}
-
Merissa Tan authored
- Add method to query device rumble capabilities in EventDeviceInfo. - Add methods to support vibration (PlayVibrationEffect, StopVibration, StoreRumbleEffect, StartOrStopEffect, etc.) in GamepadEventConverterEvdev. - Route methods to control gamepad vibration through InputController to GamepadEventConverterEvdev. BUG=b:158685462 TEST=Add tests to GamepadEventConverterEvdevTest; all tests pass. Change-Id: Ic1a2d1d1965ddd0a9321a93224a59bc9d1b681fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294560 Commit-Queue: Merissa Tan <liyingtan@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO) <oshima@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Auto-Submit: Merissa Tan <liyingtan@google.com> Cr-Commit-Position: refs/heads/master@{#797041}
-
Gary Tong authored
This is a reland of 4421e3c9 Original change's description: > Infra: Use Mac 10.15 machines for mac-arm64-rel tryjob > > Bug: 1106950 > Change-Id: I69a3a8df07f40d0cc24de3f85212e51d5945bd46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350149 > Auto-Submit: Gary Tong <gatong@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796959} Bug: 1106950 Change-Id: Ia493c546714237deb751676f037224b29f02670f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350393Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Cr-Commit-Position: refs/heads/master@{#797040}
-
David Roger authored
Screenshots: https://drive.google.com/file/d/1GHXhrzx8817R9lrl0wbwefvJ1e0Nq2nW/view?usp=sharing https://drive.google.com/file/d/1gqs3fziupgIHcYa73hx1v1sQdkwJCUu1/view?usp=sharing Bug: 1076880 Change-Id: I6ba33abaebbea45c0f5efbc13605ed5b2ec6259b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341124 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#797039}
-
Yue Li authored
For background see go/cros-auto-select Added a new editing behavior type for ChromeOS to support select on contextual menu click. Bug: b/152643590 Test: Manual Test Change-Id: If52a53cce4a7959e5733058421c9d1c0b814540b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342469Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#797038}
-
Garrett Beaty authored
Change-Id: I9e3b5d5d30090fbcf3ab40933541ebb81350ce2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350241 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#797037}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0376edf14e58..f07b5182eeda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4f49c7b014bed1f78dda57080ca9e88d02d5d129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350154Reviewed-by:
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: I42175ba9b236541bb91ea732d731c10ae60fe458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349920 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797035}
-
Aleks Totic authored
These new faiures will be fixed by TablesNG Bug: 1115204 Change-Id: I4b6babba684bddc13a83ff0e06576aa891da5467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350484 Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Orin Jaworski authored
This CL causes the translation prompt to show when triggered from an omnibox Pedal, even when the page is in user's primary language. The language state logic usually prevents it, but in the case of Pedal activation, the user is explicitly requesting translation. Bug: 893183 Change-Id: Id3e99268a759d97dd148b5ddb2d32f36d5f51a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350230 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797033}
-
Yicheng Li authored
When the user enters password, authenticate the user by checking the password. PIN auth will be supported in a follow-up change. Also add unittests around this authentication. "testing/xvfb.py out/Default/ash_unittests" build unit_tests and "testing/xvfb.py out/Default/unit_tests" Bug: b:156258540 Test: build ash_unittests and Change-Id: I571f34d1cfc3849729240147635f9b685d68dd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340499 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797032}
-
Josh Nohle authored
Even if a metadata encryption key is decrypted successfully, i.e., bytes are returned, it might not correspond to the intended key. This is expected for Nearby Share because we try to decrypt the metadata encryption keys for all public certificates until we find the right one. Key decryption failures and mismatched key commitments will be common, so do not log errors. Change-Id: Ia916db644dc5e33bb7647a6cd0b3f925b22d3630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350301 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#797031}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2454323cb6e..f6ca01b98c51 2020-08-11 jalyn@microsoft.com Infobar: Don't expand without details If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1115211 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I00b7e4b2c9d2c39c61cb494fd961644576055d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350139Reviewed-by:
-
Daniel McArdle authored
The constructors for BigEndianReader and BigEndianWriter currently check that |ptr_ <= end_|. Given that |end_| was constructed from |ptr_| plus an unsigned length and that the constructors' inputs must correspond to a valid buffer, CHECK_LE(ptr_, end_) can never fail. Bug: 1114803 Change-Id: I9ae6c454e28967b036a8e1343d8e9a4cba166cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350151Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#797029}
-
chrome://media-appTrent Apted authored
Over time launchWithFiles() has evolved to support all the use-cases that load*File() needed. launchWithFiles() has better coverage of real code paths; poking around less in the internals of launch.js which makes them hard to maintain. The launchWithFiles() calls also tend to be more succinct. Bug: b/163287386 Change-Id: I58e7aaa455266efd56614e0561493fd7519b8f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345938Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#797028}
-
Nate Fischer authored
No change to logic. This adjusts the following colors: * Brighter red for warning text (dark theme only) * More contrast for text color of flag names (darker in light theme, brighter in dark theme) Fixed: 1111172 Test: Manual - verify colors in screenshot Change-Id: Ib8d1e5a8cbd10c8b7e3483adb31c893d220389f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347376Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797027}
-
Gavin Williams authored
These enums need to be changed to enum classes so they can be used as metric enums. Without being enum classes, when 'kMaxValue' is added to both, the compilation fails. Bug: 1059607 Change-Id: I36c6167efe93e45eb6b00daed686e52454e85397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349431Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#797026}
-
Yuly Novikov authored
From default 120 seconds to 180, to mitigate gtests shards timing out due to phone busy with other tasks. TBR=bsheedy No-try: true Bug: 1115157 Change-Id: I5e7f09947eca47038a91ea1da578ce5d9232e5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348582 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797025}
-
Peter Kasting authored
No intended behavior change. Bug: none Change-Id: Ib0496c5dcb42fb6388c3b68ab330ed36d39556dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345089Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797024}
-
Dan Harrington authored
We were not copying the prefetch data from wire to store protos Bug: 1044139 Change-Id: I85731b25af9e845b6fe274d47458a2de9c65952b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350229 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#797023}
-
Joshua Berenhaus authored
metrics_log.cc had a typo, fixed in this CL :) Change-Id: I51838078d29ff7747c4a208b6822ed1fac763b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350153 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#797022}
-
Daniel Rubery authored
This CL changes the URLLoaderFactory used be the ClientSideDetectionService. Pings to Safe Browsing will return to using the Safe Browsing network context (with profile keying). Model loading will continue to use the profile network context with credentials omitted, to support caching. Bug: 1049833 Change-Id: I963265b011c0f56b5e8634cd1fc9d0259e133a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349397Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#797021}
-
Nick Harper authored
Domain ownership verified via DNS TXT record. Change-Id: I0db37e0b8c2aa4340a1a5a2a23b6fa52ffa35e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350143 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797020}
-
Adam Rice authored
This test is flaky, so disable it for now pending further investigation. BUG=1113999 Change-Id: If2b4063281bbc83fc369d64dfb7b4eb342b8b39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349588 Auto-Submit: Adam Rice <ricea@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#797019}
-
Jan Wilken Dörrie authored
This change adds the algorithms from [alg.set.operations] to //base/util/ranges and adds appropriate tests. Bug: 1071094 Change-Id: If974fa8d4a204aa6ec3b3caa255bb6f07eef500b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349608 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797018}
-
Tamir Duberstein authored
This allows the features field to be changed to a FIDL |bits| type without breaking the Chromium build. The |static_cast|s introduced in this change will be removed after the next Fuchsia SDK roll. tools/fuchsia/local-sdk.py $FUCHSIA_DIR autoninja -C out/fuchsia net:net_unittests Test: with https://fuchsia-review.googlesource.com/c/fuchsia/+/399816: Bug: 1099393 Change-Id: I02a8612ccf6dfa2fe1157afa77ab1ac752fa0f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349488 Commit-Queue: Tamir Duberstein <tamird@google.com> Reviewed-by:Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#797017}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1553832ddd6c..61ca10cb63d0 2020-08-11 thestig@chromium.org Roll third_party/libjpeg_turbo/ 0241a1304..9d4f8005b (4 commits) 2020-08-11 thestig@chromium.org Check more headers in OpenJPEG. 2020-08-11 tsepez@chromium.org Remove CFWL_Widget::SetOuter(). 2020-08-11 thestig@chromium.org Remove an unnecessary check in CPDF_RenderTiling::Draw(). 2020-08-11 tsepez@chromium.org Remove CFWL_WidgetMgr::NextTab(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1114577 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I179842dbbac097815d1e274dc3783907f59f763d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350136Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f07b5182eeda..c4451adcce85 2020-08-11 cfijalkovich@google.com Merge "Utilize FB app suite tracepoints in trace processor" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I773198ebbd0ddc2e513a7095c040790a4653372a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350138Reviewed-by:
-
Nico Weber authored
Bug: 1107955 Change-Id: Ibfa333618be9d1d0296998a5fc53d10a6d59065d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349923 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
Add a python test suite for the Docserver. Currently these tests are run using presubmit scripts. However our logic for when to run presubmits is not completely correct, which has caused multiple regressions in the past. (crbug.com/1114299, crbug.com/1105211, crbug.com/700234) Fix this by introducing a test suite. Since the isolate requirement for tests needs us to list all the dependencies exhaustively, it also means that we'll always be able to catch regressions. A subsequent CL will remove these tests from being run on presubmits. Skipping presubmits since they flakily timeout (most probably due to the docserver presubmit checks, which should also be fixed once we remove these tests). BUG=1114299 No-Presubmit: true Change-Id: I805874908d7f622102809ac342168fb40f23155a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311823 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#797013}
-
Elly Fong-Jones authored
Bug: 1115238 Change-Id: I480c06b3c95c6eec3471ff470db4b104bbfc3d46 Tbr: beccahughes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350091Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797012}
-
Yusuf Sengul authored
Bug: 1115255 Change-Id: I29378e7a30a1997480e09580ff172e2e8ac1029b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350112 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#797011}
-
Weilun Shi authored
Remove fieldtrial related logic in extract_histograms.py as these fields are not used. Bug: 1115228 Change-Id: Ifd5e654203c12e573da02f133f339005c68ebe56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350130 Commit-Queue: Weilun Shi <sweilun@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797010}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c4d3ff474abe..d56f379356d9 2020-08-11 fdegans@chromium.org Set screenshot alpha channel to white. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1088062 Tbr: sadrul@google.com Change-Id: I1b5e50847854ddae9b7bded03a57791ff16be3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350128Reviewed-by:
-
