- 05 Mar, 2019 40 commits
-
-
Takashi Toyoshima authored
Current code expects OnComplete should not be called while handling redirects. But if an underlayout URLLoader request fails for some reasons, it results in OnComplete with an error status, e.g. net::ERR_FAILED. Also this fixes following tests for OutOfBlinkCors. - ExtensionWebRequestApiTest.WebRequestSubresourceRedirectsWithExtraHeaders - ExtensionWebRequestApiTest.WebRequestRedirectsWithExtraHeaders Bug: 934571 Change-Id: I0817c51b66e4cb81e1740ceedb64795c1dba25cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482282Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#637620}
-
Ramin Halavati authored
Incognito menu's color is modified to primary text color to ensure contrast with menu background. Bug: 896235 Change-Id: I96c31f2326bb249c5e5af9a42dd8944481eef281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482451 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#637619}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c46e9b49. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 682affef "Implemented setPlaybackRate for scroll-linked Worklet Animations." 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" 5a7d4abb "IndexedDB: Fix WPT bindings-inject-key to clean up Object.prototype" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc kojii@chromium.org: external/wpt/css/css-text/line-break meade@chromium.org: external/wpt/web-animations msisov@igalia.com: external/wpt/webvtt rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request skobes@chromium.org: external/wpt/css/css-scroll-anchoring yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3fc26ef8e8f00f1d7d29d71cb7597845c975e445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501758Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637618}
-
Giovanni Ortuño Urquidi authored
BookmarkApps can only be ENABLED or inexistent, so it doesn't make sense to query all extensions; querying ENABLED should be enough. Bug: 916381 Change-Id: I232514d79a5a4413a6e400280b4e1eaec0f3da8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502314 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#637617}
-
Maggie Cai authored
Currently a custom search box is used, however the ctrl+F is not working, updated to use the default search box (with UI permission) and move the sort box. BUG=931969,835712 Change-Id: Ibabc3a3dbfa67f6d38b481126f0983a20dd3aa9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491156 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#637616}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/edefc3380260..aa2881937a07 Created with: gclient setdep -r src-internal@aa2881937a07 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=yigu@chromium.org,peria@chromium.org,dgrogan@chromium.org,treib@chromium.org Change-Id: I90de7af49f60fd53d65c3d3ba7c9793eb4ba8c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502514Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637615}
-
Malay Keshav authored
Fix comments that were missed in the original patch. TBR=enne Bug: 903486 Change-Id: I28132b25e95141cf56663300a46e92299c9df8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502352Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#637614}
-
Guido Urdaneta authored
Header file initially in public/platform so that it can still be accessed by dependents in content. Once dependents are migrated to blink, it will be moved to renderer/platform. Bug: 704136 Change-Id: If66f57d7239fe585a77d07a098ad20dd51d8e4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499553Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#637613}
-
Dmitriy Lyamkin authored
There is a wrong MIME-type for ".png" files on internal pages. It sets 'text/html' for them. So we have some broken images like this: chrome://downloads/1x/incognito_marker.png Change-Id: I61f241c87fac50d8fbb65876536c7d0ef06358d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496979Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#637612}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/d3752ea20886..dc3db3a5ae5e git log d3752ea20886..dc3db3a5ae5e --date=short --no-merges --format='%ad %ae %s' 2019-03-05 cepheus@frii.com Fix #96: Don't include a comment after #endif for the C header. Created with: gclient setdep -r src/third_party/spirv-headers/src@dc3db3a5ae5e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia59182204c21c30306a7208e991f8327835092b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637611}
-
Dan Beam authored
Screenshots: https://imgur.com/a/CoU73B4 R=hcarmona@chromium.org BUG=926658 Change-Id: If741189597175b1068d7fcd4a8521b997a40a862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501792 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#637610}
-
Kunihiko Sakamoto authored
Setting a mock ContentBrowserClient via SetBrowserClientForTesting doesn't work on Android KitKat. (crbug.com/864403) After this patch, VariantMatch and VariantMismatch test cases will be skipped in Android version < 5. Bug: 937930,864403 Change-Id: Ia246305fbaa906c9a3f44d45b85e6b6e69b35d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501954Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#637609}
-
Maggie Cai authored
Currently on permission changes, the all sites list will be re-populated. This is a issue when we reset the permission for an etld+1. Because this resets every single permission settings for all the origins under the etld+1, which triggers 16*n (n=number of origins) on permission changes, therefore makes the all sites list repopulate that many time. This affect the performance, also make the list jump back to the top and lost the last selected entry. This CL removes the event listener for permission change in all sites page. In the future, we should implement the similar banner with reload when permission changes from other places (not all sites page) occurs. BUG=835712 Change-Id: I54596b1ba7d9901bdcd3ddd2192c1a0973aa5acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496118Reviewed-by:
-
Darren Shen authored
TBR=dstockwell@chromium.org Bug: 938192 Change-Id: If1b92cbb423874c9638e7676d1e8fafa0f2ca2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502492 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#637607}
-
Eliot Courtney authored
Bug: b/127224879 Test: drag-move an Android PIP window - no crash upon finishing drag. Change-Id: I3d455f3545ea1a7bfba4c9ec6f6b51d3b218078d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498744 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#637606}
-
Samuel Huang authored
Thin-LTO builds produce many (~3000 for Chrome) .L.ref.tmp symbols. SuperSize could not find |object_path| for them because: * The linker .map file points to thinlto-cache filenames (|thin_obj|). * ".L.ref.tmp" has high population, so name matching done in later nm step won't help. This CL associates .L.ref.tmp symbols with other symbols that share the same |thin_obj|, and attempts to deduce |object_path| if there is no ambiguity. Details: * In linker_map_parser.py, extract |address| -> |thin_obj|, and return the map. * In demangle.py, pass the map until after nm gets called to assign |object_paths| to regular symbols. * Add DeduceObjectPathsFromThinMap() that takes |address| -> |thin_obj| map, computes |thin_obj| -> |object_paths|, and assigns |object_path| to .L.ref.tmp symbols if no ambiguity arise, i.e., when |thin_obj| is associated with a unique |object_path|. For Chrome, this change causes about 30% of .L.ref.tmp symbols to gain |object_path|. Bug: 923936 Change-Id: I1864e764924d8e45ca5cb44d0ed7d0f73bec13ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500781 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#637605}
-
Maksim Sisov authored
GetWindowBoundsInScreen adds display origin to bounds in pixels, which is incorrect, because they contain a location in screen, and adding additional offset results in wrong positions for menus (when the browser is located on a secondary display). Bug: 927280 Change-Id: Ib16f46b095751cb3f29bfa6579d44eabdf104647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497052Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#637604}
-
Matt Falkenhagen authored
Follow-up of r637231 which removed the test parameters that were based on kServiceWorkerServicification. Bug: 926114 Change-Id: I4c1bd72a451dd882f8553254ff4f42a27edf920b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498808Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637603}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dacdbca1d6e..edefc3380260 Created with: gclient setdep -r src-internal@edefc3380260 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=yigu@chromium.org,peria@chromium.org,dgrogan@chromium.org,treib@chromium.org Change-Id: Ibd833194f6ffdcc64c3d8e2a05373d60193d2da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502372Reviewed-by:
-
Karandeep Bhatia authored
Remove custom handling code for the embedded test server in ExtensionsAPITest. Instead use net::test_server::RegisterDefaultHandlers. Also modify a couple of tests to make them pass. BUG=None Change-Id: I500f7abcf79d4a89f6abe6588bacd3894c077f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497428 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#637601}
-
Takashi Toyoshima authored
PermissionsUpdater::SetDefaultPolicyHostRestrictions needs to update cors access lists as well as other permission updating methods do. This patch extends NetworkPermissionsUpdateHelper to support the default policy host restrictions case in addition to permissions update. This makes following tests pass with OOR-CORS. - BackgroundXhrWebstoreTest.PolicyContentScriptXHR - BackgroundXhrWebstoreTest.PolicyUpdateXHR - BackgroundXhrWebstoreTest.PolicyUpdateIndividualXHR - BackgroundXhrWebstoreTest.PolicyUpdateDefaultXHR Bug: 907428 Change-Id: I0ae7777bd87baa1c98dfbefba44b9911eb9c08f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478661Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#637600}
-
François Beaufort authored
This CL record buttons pressed and tap gestures for all controls in the Picture-in-Picture window. Bug: 932410 Change-Id: Ie751322f7e4fe3026a47e95c1a839cb90e2ae85b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475433Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort 🦔 <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#637599}
-
Giovanni Ortuño Urquidi authored
AppRegistrar should be used by clients to query information about apps. For example, if an app is installed. AppRegistrar has two implementations BookmarkAppRegistrar and WebAppRegistrar. BookmarkAppRegistrar is built on top of extensions. PendingBookmarkApp uses BookmarkAppRegistrar to avoid querying the ExtensionRegistry and ExtensionPrefs directly. Bug: 916381 Change-Id: I0706bef37f2ecbf4b86d63eafe8de1dd168f440a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498736 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Dan Beam authored
R=dpapad@chromium.org BUG=930042 Change-Id: Ic20ceb781e363b033a56fbd541dabecd52f2158f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497541Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#637597}
-
Dan Beam authored
Screenshot: https://imgur.com/a/inurhXK R=dpapad@chromium.org BUG=926658 Change-Id: I26bca3932d0e92dad7d6c3cbfab35fe543e022f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501992 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Lei Zhang authored
As is, by the time PrintViewManager::PrintPreviewDone() gets called to unblock a Print Preview initiator, FocusController already tried to give the initiator focus and failed, because the initiator was in a blocked state. Add PrintViewManager::PrintPreviewAlmostDone() and call it right before the Print Preview dialog closes. This is necessary to get the timing right so the underlying Print Preview initiator can be unblocked before the FocusController tries to give it back focus. BUG=936542 TEST=Manual, see bug. Change-Id: Ifa7fcb451b94a6da82c554b685bca350be032120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497860 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637595}
-
Darren Shen authored
There was a flaky failure in compiling components/subresource_filter/content/browser/subresource_filter_client.h See: https://ci.chromium.org/p/chromium/builders/ci/win32-rel/12234 Error message was that it couldn't find: components/subresource_filter/core/mojom/subresource_filter.mojom.h Speculatively fixing this issue by adding the mojom file to DEPS. TBR=sky@chromium.org Change-Id: I72668d5e8d12af8d6cb32fae4b8258c4b1b62bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502332Reviewed-by:
-
Kyle Milka authored
If a customize background dialog is opened and the space key is pressed the main page shouldn't scroll. If the mouse is used to scroll the page the dialog should stay centered while the page scrolls in the background (this is consistent with the custom links dialogs). Screencast: http://go/scrcast/NTY3MzY0NjkyODQyOTA1Nnw1MzY0N2JhNS1hZA Bug: 908381, 899730 Change-Id: I71e99f6d4481c9e61d3f98d0ff23f4d059a21464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501934Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#637593}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/232c456db8e9..d69cdaba1445 git log 232c456db8e9..d69cdaba1445 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 loganchien@google.com Add -Wno-implicit-fallthrough Created with: gclient setdep -r src/third_party/swiftshader@d69cdaba1445 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/115344057 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1c5fdee380ff778b376bb09d4ba8e052b0ff00e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502095Reviewed-by:
-
Shao-Chuan Lee authored
In case of a crash, metrics from previous session is not available when generating initial stability logs, which is probably why aggregated crash counts on UMA don't have ARC state associated. This patch introduces StabilityMetricsManager, which persists stability metrics into local state and record value from local state to UMA when needed. Bug: 929583 Change-Id: I747493f2462454baa7fc187421932ea71d52c9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1469810 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#637591}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5610d5a7e96a..6dacdbca1d6e Created with: gclient setdep -r src-internal@6dacdbca1d6e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=yigu@chromium.org,peria@chromium.org,dgrogan@chromium.org,treib@chromium.org Change-Id: I8bf02633bad98c62a7cd3fdb2342517d505b330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502092Reviewed-by:
-
Shu Chen authored
This cl doesn't change any behaviors. Bug: 937167 Change-Id: I35be2c76784d38c651f0e3d21a12e07a96b5e1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498253 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
-
Dan Beam authored
<extension-code-section> is used from 2 places in extensions (AFAICT), when showing where runtime errors come from and when showing errors trying to load an extension (i.e. manifest errors). This CL should confine "light mode" to just the actual code parts, and show the load errors in dark mode. Screenshots: https://imgur.com/a/gF1gd5D R=dpapad@chromium.org BUG=936524 Change-Id: I99b9cc56df1712c04023206a493a883d42d6fb8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497804 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Simon Que authored
R=dpranke@chromium.org, hinoka@chromium.org, jbudorick@chromium.org Bug: 915568 Change-Id: I34e1cd438423e614db0652ff3c17f0832e8a6a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500714Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#637587}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b36f7a25a8a4..b8cff9e9347c git log b36f7a25a8a4..b8cff9e9347c --date=short --no-merges --format='%ad %ae %s' 2019-03-05 jiajia.qin@intel.com ES31: Add MAX_COMPUTE_SHARED_MEMORY_SIZE Created with: gclient setdep -r src/third_party/angle@b8cff9e9347c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8e8805b73514e6ca255591b1cd09390bdd987d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502094Reviewed-by:
-
Jérôme Lebel authored
For some reasons, those metrics were not implemented for sign-in before unity. + Signin_Signin_WithDefaultSyncSettings + Signin_Signin_WithAdvancedSyncSettings This patch adds implementations for those 2 metrics for pre-unity and unity code. Also "Signin_Undo_Signin" is added for unity code (already implemented) with pre-unity. Bug: 937820 Change-Id: I27ec9769e9954b1daeccd273f4d663c35f9fa605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496981Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#637585}
-
rbpotter authored
Only use color and duplex setByPolicy on Chrome OS, since these policies aren't implemented on other platforms. To make this simpler, move logic for computing whether any setting on the page is managed out of header.js and into model.js. This is also more reasonable since model.js is responsible for tracking the settings and is the only element where settings' |setByPolicy| field is updated. Change-Id: Ie682c38ffd775cccc4f47c15b66fa85a46761e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500785Reviewed-by:
-
Donna Wu authored
Bug: 716628 Change-Id: If48a9b1aaa71a9264475dd0ad62707a45bd927e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493716Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4f63c40831f1..525c349dbfeb git log 4f63c40831f1..525c349dbfeb --date=short --no-merges --format='%ad %ae %s' 2019-03-05 dhanyaganesh@chromium.org BuildStore: Unittest for GetSlaveStatuses 2019-03-05 dhanyaganesh@chromium.org BuildStore: Redirect InsertBuildMessage & GetBuildMessages Created with: gclient setdep -r src/third_party/chromite@525c349dbfeb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I01f56858d30011112969e431a5dfaf6376dd651d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501854Reviewed-by:
-
Dan Beam authored
No screenshots cuz I can't easily reproduce. And yes, this will mildly change the "light mode" (GB 500->700) but I think it's pretty clear that this UI is emulating a link and therefore should use the standard link colors. R=hcarmona@chromium.org BUG=926658 Change-Id: I6b9cc4697239edea6a165108935acb7ad2e07bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501795 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
