GitLab

Second blink side change, part 3 of the series in total.

BUG=382411
R=eae,behdad,tkent

Review URL: https://codereview.chromium.org/323963002

git-svn-id: svn://svn.chromium.org/blink/trunk@176207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoids keeping a bare pointer to the current anchor from the client
implementation object.

R=ager@chromium.org,zerny@chromium.org,haraken@chromium.org,tkent@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/334153003

git-svn-id: svn://svn.chromium.org/blink/trunk@176206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TimelinePresentationModel.Record now has three implementations: one for root record, one for coealesced record and one for representing actual TimelineModel.Record. This allows it to work fine with Timeline based on trace events.

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/337023004

git-svn-id: svn://svn.chromium.org/blink/trunk@176205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/332173002

git-svn-id: svn://svn.chromium.org/blink/trunk@176204 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The mock is currently assuming that the screen orientation is handled
by a RendererWebKitPlatformSupportImpl which is no longer the case. It
will move to be part of WebFrameTestProxy but that will require a two
sided patch so we should first disable the false-negative.

BUG=162827

Review URL: https://codereview.chromium.org/339553003

git-svn-id: svn://svn.chromium.org/blink/trunk@176203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With GeolocationController (now back) on the heap, maintain a persistent
set of them from GeolocationInspectorAgent.

R=haraken@chromium.org,ager@chromium.org,zerny@chromium.org
BUG=304341

Review URL: https://codereview.chromium.org/332153002

git-svn-id: svn://svn.chromium.org/blink/trunk@176202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a preparation patch for implementing all shorthand property.
This patch adds layout tests, which are currently failing.
After implementing all shorthand correctly, the tests will pass.

Spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand

BUG=172051
TEST=fast/css/all-shorthand-css-text.html,fast/css/all-shorthand.html,fast/css/getComputedStyle/getComputedStyle-all.html

Review URL: https://codereview.chromium.org/335733003

git-svn-id: svn://svn.chromium.org/blink/trunk@176201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds support for parsing default values of different types, but
only handles null default values when generating code.

Replaces existing

  [Default=Null] optional SomeInterface arg
  [Default=NullString] optional DOMString arg

with the now equivalent

  optional SomeInterface arg = null
  optional DOMString arg = null

in IDL files, and drops support for those [Default] attributes.

No changes to generated code.

BUG=258153

Review URL: https://codereview.chromium.org/312683005

git-svn-id: svn://svn.chromium.org/blink/trunk@176200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a media element is marked with the preload hint 'none', a load is not
started until data is explicitly requested. The progress timer is however
still started, which means that a 'stalled' event will be fired after ~3s.
This is confusing, since loading never actually started in the first place.
Fix this by implementing (the "optional") step 3 from the 'resource fetch
algorithm'.

BUG=382505
BUG=284413

Review URL: https://codereview.chromium.org/327553002

git-svn-id: svn://svn.chromium.org/blink/trunk@176199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=305497
NOTRY=true

Review URL: https://codereview.chromium.org/332183002

git-svn-id: svn://svn.chromium.org/blink/trunk@176198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, the ServiceWorker object returned by
navigator.serviceWorker.register() could be garbage collected
prematurely causing state change event handlers to never be invoked.
This patch makes ServiceWorker an ActiveDOMObject and keeps it alive
until either stop() is called on it (indicating detach of the parent
document) or it reaches the terminal "deactivated" state (soon to be
renamed "redundant").

For future work, it may be possible to be more clever and allow the SW
to die when it has no event handlers.

BUG=383972

Review URL: https://codereview.chromium.org/330173003

git-svn-id: svn://svn.chromium.org/blink/trunk@176197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- enable "Capture picture" check-box in Timeline capture filter when
    Timeline on trace events experiment is enabled;
- add disabled-by-default-devtools.timeline.{picture,layers} categories
    to trace filter when the above is checked;
- associate recorded SkPicture with the last paint event of the layer
    with matching id;
- display pictures preview in Timeline's details view, when these are
    available.

BUG=

Review URL: https://codereview.chromium.org/328143003

git-svn-id: svn://svn.chromium.org/blink/trunk@176196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead add includes to .cpp files that needs things that
StyleResolverState.h included for them.

This brings down the amount of recompilation drastically (from 
~720 to ~20) when touching files like FontBuilder.h or
StyleResolverState.h.

Review URL: https://codereview.chromium.org/327773004

git-svn-id: svn://svn.chromium.org/blink/trunk@176195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScriptPromise::then should use v8::Promise::Then in order to handle
multiply-wrapped Promises correctly.

BUG=371288

Review URL: https://codereview.chromium.org/316453002

git-svn-id: svn://svn.chromium.org/blink/trunk@176194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Calculating the animated value between two transforms of differing types
would give random results (and ASSERT in debug.)
Fix by requiring the effective 'from' value to have the same type as the
'to' value. If the types are not the same, then use a "zero transform" as
the 'from' value.

Also adjust the behavior of animateTransform additive to-animations in
this case by clearing the list in these cases too (matching Presto and
Gecko in this particular case.)

BUG=231409

Review URL: https://codereview.chromium.org/330813002

git-svn-id: svn://svn.chromium.org/blink/trunk@176193 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Let's use FrameSelection::DirectoinalOption instead of bool.


BUG=

Review URL: https://codereview.chromium.org/328243004

git-svn-id: svn://svn.chromium.org/blink/trunk@176192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=tkent@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/334793005

git-svn-id: svn://svn.chromium.org/blink/trunk@176191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Will allow reuse of this function in the implementation of the enterprise.platfromKeys Chrome extension API.

BUG=364435

Review URL: https://codereview.chromium.org/312393004

git-svn-id: svn://svn.chromium.org/blink/trunk@176190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We use VectorComparer to compare WTF::Vector<T>.
If T is not primitive type, we use std::equal to compare.
By the way, we use the WTF::VectorBufferBase class for a base class of Vector.  VectorBufferBase doesn't alloc a array if we init it without a size argument.
As a conclusion, we pass NULL object to std::equal when we compare Vectors with the default constructor.
It is asserted especially on a Windows debug build.

BUG=

Review URL: https://codereview.chromium.org/332113002

git-svn-id: svn://svn.chromium.org/blink/trunk@176189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Evaluate explicit "delete this[p]" to delete a property.

R=vsevik

Review URL: https://codereview.chromium.org/323423002

git-svn-id: svn://svn.chromium.org/blink/trunk@176188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since r276361 made chromium side not to use the methods, now we can remove these methods from Blink.

c.f. https://codereview.chromium.org/301883002 and svn://svn.chromium.org/chrome/trunk/src@276361

BUG=369451

Review URL: https://codereview.chromium.org/327483002

git-svn-id: svn://svn.chromium.org/blink/trunk@176187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=373120

Review URL: https://codereview.chromium.org/318393002

git-svn-id: svn://svn.chromium.org/blink/trunk@176186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We frequently saw object path dump like:

    Path to 1d6ec5d8 of WebCore::Node
    <- 7abc4660 of Persistent

Then, we needed to investigate what this Persistent is. It took much time.

This CL introduces 'tracing name' property to Persistent if
ENABLE(GC_TRACING). The property is automatically filled with
backtrace of a Persistent constructor. We'll get dump like:

    Path to 1bd56220 of WebCore::Node
    <- 1bd55ff8 of WebCore::Node
    <- 1bd55dc8 of WebCore::Node
    <- 7d046600 of Persistent ... Backtrace:
            Persistent<HTMLSelectElement, ThreadLocalPersistents<(ThreadAffinity)1> >::Persistent(HTMLSelectElement*)
            v8::Handle<v8::Object> V8DOMWrapper::associateObjectWithWrapper<V8HTMLSelectElement, HTMLSelectElement>(HTMLSelectElement*, WrapperTypeInfo const*, v8::Handle<v8::Object>, v8::Isolate*, WrapperConfiguration::Lifetime)
            v8::Handle<v8::Object> V8DOMWrapper::associateObjectWithWrapper<V8HTMLSelectElement, HTMLSelectElement>(WTF::RawPtr<HTMLSelectElement>, WrapperTypeInfo const*, v8::Handle<v8::Object>, v8::Isolate*, WrapperConfiguration::Lifetime)
            V8HTMLSelectElement::createWrapper(WTF::RawPtr<HTMLSelectElement>, v8::Handle<v8::Object>, v8::Isolate*)

Additional improvement of the object path dump:
* Correct host info name for heap collections
* Don't try to dump unknown objects.

BUG=

Review URL: https://codereview.chromium.org/337653002

git-svn-id: svn://svn.chromium.org/blink/trunk@176185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Internal properties inherently are not writeable, thus they should behave so in the frontend.

R=vsevik

Review URL: https://codereview.chromium.org/323313005

git-svn-id: svn://svn.chromium.org/blink/trunk@176184 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As bug305497 is marked WontFix, I'd like to merge back
ExecutionContextClient to ExecutionContext for readability. This is 1st
step for that.

Note about behavior change induced by this CL

addConsoleMessage():
When addConsoleMessage() is called via ExecutionContextClient, it just
calls addMessage(). But ExecutionContext has non-virtual
addConsoleMessage() which checks if m_client is non-NULL. We'll call
the latter after this CL. If this change breaks something, that means
such an addConsoleMessage() call has been invalid since it's called
on an ExecutionContext that is already partially destructed.

isDocument():
OK for the same reason.

disableEval():
OK for the same reason.

securityContext() and reportBlockedScriptExecutionToInspector():
No change as ExecutionContext doesn't have a non-virtual override for it.

contextURL() and contextCompleteURL():
No change as they're implemented only on ExecutionContextClient.

BUG=305497

Review URL: https://codereview.chromium.org/332993002

git-svn-id: svn://svn.chromium.org/blink/trunk@176183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the third parameter to PropertyWrapper was removed in
https://codereview.chromium.org/139273007 (legacy animation engine
removal) setZoomWithoutReturnValue lost its last caller.

Review URL: https://codereview.chromium.org/324063002

git-svn-id: svn://svn.chromium.org/blink/trunk@176182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384956
TBR=

Review URL: https://codereview.chromium.org/331583004

git-svn-id: svn://svn.chromium.org/blink/trunk@176181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384950
TBR=

Review URL: https://codereview.chromium.org/338743002

git-svn-id: svn://svn.chromium.org/blink/trunk@176180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The original CL https://codereview.chromium.org/329183002/ got reverted in
https://codereview.chromium.org/330933002/ as it was causing failures on the
Chromium Linux Tsan v2 bot.

The problem was that std::abs(int) is found in <cstdlib> but we apparently only
include <cmath> everywhere. So the compiler only knows about std::abs(float) and
variants.

There were two ways of fixing this:
1. include <cstdlib> whereever std::abs(int) is used.
2. use abs() as it was done earlier.

Because we already include <cmath> everywhere, and Since C++11, additional
overloads are provided in the header <cmath> for the integral types as well, so
its better to directly just use abs() rather than including an extra header file
This CL uses the second way.

BUG=None

Review URL: https://codereview.chromium.org/333173002

git-svn-id: svn://svn.chromium.org/blink/trunk@176179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This puts the blink heap asm targets in the GN build set and enables
both blink platform test targets behind a single flag. They compile, link
and run successfully on mac but (probably) don't link yet on linux due
to ffmpeg deps.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/332123002

git-svn-id: svn://svn.chromium.org/blink/trunk@176174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Page::willBeDestroyed() detachs any frames remaining in the frame tree,
so there's no need to do this before calling willBeDestroyed().

In addition, since frameDetached() recursively detaches all frames,
eliminate the loop inside Page::willBeDestroyed() to detach all frames.

Review URL: https://codereview.chromium.org/339493002

git-svn-id: svn://svn.chromium.org/blink/trunk@176173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't move uneditable paragraph contents in CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary

This patch makes CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary
not to move uneditable paragraph contents.

In attached test case, Blink tried to move contents in uneditable ABBR element.

BUG=381076, 383811
TEST=LayoutTests/editing/execCommand/justy-center-with-uneditable-crash.html

Review URL: https://codereview.chromium.org/335773002

git-svn-id: svn://svn.chromium.org/blink/trunk@176172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces Blink specific CSS classes for editing for
  - Apple-interchange-newline
  - Apple-converted-space
  - Apple-paste-as-quotation
  - Apple-style-span
  - Apple-tab-span
These CSS classes are defined in "core/editing/HTMLInterchange.h"

We would like to deprecate these Blink specific CSS classes for browser
compatibility, if possible.

BUG=383677
TEST=n/a

Review URL: https://codereview.chromium.org/327323005

git-svn-id: svn://svn.chromium.org/blink/trunk@176171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Textarea resize-able only to larger; min-height and min-width properly set (https://codereview.chromium.org/239983004/)

Reason for revert:
Regression for RTL textareas.


Original issue's description:
> Textarea resize-able only to larger; min-height and min-width properly set
> 
> Textarea does not respect the min-height and min-width property when they are
> set by user. When textarea min-height and min-width is set by the user and
> if we resize textarea it will only resize to value larger than the width and
> heght of textarea and not with value smaller than it's width and height. It
> assumes width and height as min-width and min height and does not take into
> account the actual min-width and min-height set by user. This patch removes
> this bug by initializing the setMinimumSizeForResizing value with min-width
> and min-height.
> 
> BUG=94583
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173269

BUG=94583,371743
TBR=harpreet.sk@samsung.com, chaffraix@chromium.org

Review URL: https://codereview.chromium.org/336143002

git-svn-id: svn://svn.chromium.org/blink/trunk@176170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will make it possible to get the text surrounding the
current selection by calling WebFrame::selectionRange() and
passing that range to WebSurroundingText.

BUG=330238

Review URL: https://codereview.chromium.org/294073005

git-svn-id: svn://svn.chromium.org/blink/trunk@176168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove useless override of executionContext() in HTMLMediaElement. This was
previously done to remove ambiguity because HTMLMediaElement inherited two
implementations of executionContext() from its base classes (Node and
ActiveDOMObject). This CL gets rid of the override and uses a "using"
statement instead to remove ambiguity, which is the proper way to do this.

The executionContext() override in Node can now be marked as FINAL as a
result.

R=tkent@chromium.org

Review URL: https://codereview.chromium.org/334063002

git-svn-id: svn://svn.chromium.org/blink/trunk@176167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, sigbjornf@opera.com
BUG=384246

Review URL: https://codereview.chromium.org/338533002

git-svn-id: svn://svn.chromium.org/blink/trunk@176166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384857
TBR=tonyg@chromium.org
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/336093002

git-svn-id: svn://svn.chromium.org/blink/trunk@176165 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is removing ~250 files that are not required because they are
passing testharness output in an expected file. Adding such file will be
prevented via a PRESUBMIT check, see https://codereview.chromium.org/332583002/

BUG=None

Review URL: https://codereview.chromium.org/328243002

git-svn-id: svn://svn.chromium.org/blink/trunk@176164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CachedUAStyles are large (160b) and not cheap to create because they
include several Length objects which have non-trivial destructors,
making CachedUAStyles expensive to destruct. This patch reduces the
number of CachedUAStyles by only creating them when needed.

There are two changes in this patch:
1) CachedUAStyle& is no longer a member on StyleAdjuster but is
instead passed in through StyleAdjuster::adjustRenderStyle.

2) The cached UA style is now constructed as-needed in
StyleResolverState::cacheUserAgentBorderAndBackground.
StyleResolverState always owned the CachedUAStyle but this patch
makes it explicit by changing the type to OwnPtr<CachedUAStyle>. A
null check was needed in RenderTheme::adjustStyle but otherwise
CachedUAStyle was not accessed without being set.

Before patch:
  facebook.com - 19,850 CachedUAStyles constructed
  wikipedia cat - 22,686 CachedUAStyles constructed

With patch:
  facebook.com - 538 CachedUAStyles constructed
  wikipedia cat - 16 CachedUAStyles constructed

Review URL: https://codereview.chromium.org/338673002

git-svn-id: svn://svn.chromium.org/blink/trunk@176163 bbb929c8-8fbe-4397-9dbb-9b2b20218538