- 11 Sep, 2019 40 commits
-
-
Sigurd Schneider authored
The devtools network tab receives a notification via "requestWillBeSent" that corresponds to the time when the browser process queues a network request. This enables the network tab to calculate how long the task was queued. The timeline (performance) panel does not receive a corresponding tracing event, and hence does not know how long a task was queued. This results in different times being reported as totals in the network vs the performance panel if the task was initiated from the browser (and not from the renderer). This CL adds a tracing event to the browser that indicates that a network request will be queued, and processes the event in DevTools so that the network access time reported in the performance tab matches the time reported in the network tab for requests initiated in the browser. For requests initiated in the renderer, the ResourceSendRequest tracing event already has the time when the request gets queued (up to a few 1/100 ms). Bug: chromium:865066 Change-Id: I1edfac4ec7ada8407b5dd931920e26e139b4f8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771398 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#695614}
-
Peter Kasting authored
Bug: none Change-Id: If9aa04d802ea9e89bddf2d879cd6996a4fa5648d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795309 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#695613}
-
Miyoung Shin authored
This CL converts FingerprintPtr and FingerprintRequest in chrome, services and ui to the new Mojo type. Bug: 955171 Change-Id: I17f91e608d749fe868c4a50c5483e573237cd461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792466Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#695612}
-
Peter Wen authored
SystemClock#uptimeMillis is better for interval timing since it stops counting when the system enters deep sleep, which would otherwise greatly inflate our module installation metrics. Details: https://developer.android.com/reference/android/os/SystemClock Bug: None Change-Id: I58ce7f1b64ae1dbfbf6402f0380eafd76a161555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776706Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695611}
-
Jérôme Lebel authored
Adding -[SigninEarlGreyUI signinWithIdentity:isManagedAccount:]. And removing a call to TapButtonWithLabelId(). Bug: 684817 Change-Id: I8951ec6ec36ac9fd6c8b976d1e72ff1dd65fb486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793090 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695610}
-
Mohamed Amir Yosef authored
The new API will be used by password manager code within the effort of Butter4Passwords TBR=vasilii@chromium.org Change-Id: I1b0bc300fce37e3695f579aaabbbc7c5bfba4796 Bug: 1002000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795323 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#695609}
-
Yuki Shiino authored
Implement a "do almost nothing" bindings generator. bindings/core/v8/v8_example.cc is generated purposelessly. Bug: 839389 Change-Id: I39445cd361677d5a78d96a2d45589c571802b63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782212Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#695608}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c13cb6e62441..d96ef09317d6 git log c13cb6e62441..d96ef09317d6 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 benjaminwagner@google.com Add Pixel3a (sargo) jobs Created with: gclient setdep -r src/third_party/skia@d96ef09317d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Ic2ecb68405ccdae73831157eaf71dad3e57469b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798203Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695607}
-
Alex Chau authored
Bug: 1001098 Change-Id: I71a8f2c664e6ff525656e48b80f23d1b551f32a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789383Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#695606}
-
Abhijeet Kandalkar authored
This CL converts interface Coordinator to uses new Mojo types. Bug: 955171, 978694 Change-Id: Iba377d93282198bccc27d6c071d9697e9d0aa28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789216Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#695605}
-
Abhijeet Kandalkar authored
This CL converts interface AgentRegistry and port AgentPtr to uses new Mojo types. Bug: 955171, 978694 Change-Id: I99b583e0582bc81243075b14945a2abfbfe4469b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789215Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL changes the background color in dark mode according to the elevation level. Screenshots before and after are attached to the linked bug. Bug: 1002594 Change-Id: Icaabb2b6468a11adaf580015ef994029e9552422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798348Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695603}
-
Sam Maier authored
Change-Id: I462a66af6934bfd5ca3f2e20bdf4e2cb6c929842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795760Reviewed-by:
-
Brian Sheedy authored
Switches views_perftests to use PerfResultReporter instead of PrintResult directly and whitelists it for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I7e4b90b136aa554be6effa479e5d286f6f78e0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797339 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695601}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fcfeefe03386..9a91161b9f65 git log fcfeefe03386..9a91161b9f65 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 kisicmar@webrtc.org Fixing way of printing logs because RTC_LOG() on Android has limit on printing 1024-60 characters in line. 2019-09-11 nisse@webrtc.org Trim dependencies in modules/video_coding/ 2019-09-11 danilchap@webrtc.org Stop using rtc_event.h forward header Created with: gclient setdep -r src/third_party/webrtc@9a91161b9f65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I256229973ba686f746eb94bfc5ebce07fcaa2fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798204Reviewed-by:
-
Anton Bikineev authored
This option disables checks whether a class needs to inherit from GarbageCollectedFinalized or to have a manual finalize-dispatchers. This is needed to eventually remove GarbageCollectedFinalized from Blink. Bug: 990913 Change-Id: Ib1f1c3c85f77333648aaaf08f5708cce2d35b267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796365 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695599}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/sync_file_system. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=tzik@chromium.org Bug: 891670 Change-Id: I3485baef3e82ab552590b6a60c644611dccf4685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787072 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695598}
-
Robbie Gibson authored
For the launch screen, I think there may be an Apple bug with xibs and system colors. In my custom project, when the deployment target was 13, the launch screen supported dark mode fine, but when I switched to 12, it didn't any more. To fix this, I instead used our named color "background_color" in the xib. This sidesteps the issue because named colors are supported on both iOS 12 and 13 and it's actually a better experience than having the background be solid black. This color doesn't show up in Interface Builder in Xcode because the color isn't defined in an xcassets collection, but it does work. The other changes are changing the first-run experience to also use this background color instead of systemBackgroundColor/black. The ChromeSigninViewController remains black by default because it is also presented from settings, which uses the standard Apple color palette. Bug: 997170 Change-Id: Icd71fa2aedf1f3828fa2cefb5382deacc964cae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795905 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695597}
-
Yoav Weiss authored
Currently we don't report performance entries with failing status codes. From the spec's perspective, reporting aborts is a MAY, but failing status code responses should not be considered aborts. [1] Chromium is the only engine which doesn't report those entries. This CL fixes that to report them similarly to successful status codes. Bug: 883400, 990849 Change-Id: Ic5e99e3df77f3869aa0dd70f0141d88016fdb972 [1] https://github.com/w3c/resource-timing/issues/165#issuecomment-441413636 Change-Id: Ic5e99e3df77f3869aa0dd70f0141d88016fdb972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796544 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#695596}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d10454e66ac1..61336619eaf0 Created with: gclient setdep -r src-internal@61336619eaf0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I568d44cd04efefcb0eb408a06a0691bb8875e8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798383Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695595}
-
Allen Bauer authored
Set hide_ink_drop_when_showing_context_menu to false. Bug: 1001931 Change-Id: I6e61db469ae0291a4041d18e52e3317671e47c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791628 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695594}
-
vitaliii authored
Disable WebRtcImageCaptureSucceedsBrowserTest.GetTrackCapabilities on Linux, because flaky. TBR=guidou@chromium.org BUG: 998116 Change-Id: I5f9784bfb3c22e210a544db0b043364c0fa0b42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796350Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695593}
-
Pavel Shmakov authored
The next simple step in cleaning up CustomTabActivity. Bug: 916542 Change-Id: Ieac666a376249a4269352baaf70581075bd205ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795792Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#695592}
-
Daniel Vogelheim authored
The current origin policy interstitial uses the all-red super danger interstitials style, and the text messages indicate an imemdiate security threat (which could be true, but it might also be a simple mis-configuration). This changes this to an SSL-error-like interstitial design, and a more neutral language. Bug: 971598, 751996 Change-Id: I31dba2ae7646eb1e2ee747ab93c9854516ffeddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795604Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695591}
-
Mitsuru Oshima authored
This reverts commit c954302b. Reason for revert: This broke ChromePFQ bots (in chromeos infra) Bug: 1002895 Original change's description: > Roll src/third_party/dawn f35dcfe60a62..03e31edd98f1 (1 commits) > > https://dawn.googlesource.com/dawn.git/+log/f35dcfe60a62..03e31edd98f1 > > git log f35dcfe60a62..03e31edd98f1 --date=short --no-merges --format='%ad %ae %s' > 2019-09-11 rafael.cintron@microsoft.com Cleanup d3d12::Device::ExecuteCommandLists > > Created with: > gclient setdep -r src/third_party/dawn@03e31edd98f1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/dawn-chromium-autoroll > Please CC cwallez@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel > TBR=cwallez@google.com > > Bug: None > Change-Id: Ie97ffefe9e808bbb711df73a180d44e8f0407eff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797802 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#695501} TBR=cwallez@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Ifc95a0aade560a1dad9fd405e42f8154ffc226d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797089Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#695590}
-
Omer Katz authored
HasPendingActivity of classes inheriting from ScriptWrappable are not allowed to allocate. Using GetNFCProxy in HasPendingActivity resulted in allocation. This issue was found by clusterfuzz. Added a call to GetNFCProxy during NFCReader initialization. This guarantees that a NFCProxy object exists when we call HasPendingActivity down the line and avoids the allocation. Bug: 1001974 Change-Id: I83abd54641618a56d33a73150ffdfccd3d64a73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796370 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, when merchant requested a shipping address before providing any shipping options, Chrome would show the payment overview sheet with deselected shipping address. The user would need to first click [Select] in the shipping address section, then select the shipping address. This patch shows the shipping address selection when the user needs to select a shipping address. After this patch, Chromes shows the shipping address selection screen when the merchant requests a shipping address before providing any shipping options. Disabled by default behind "StrictHasEnrolledAutofillInstrument" feature. Can be tested with: chrome://flags/#enable-web-payments-experimental-features Bug: 1001644 Change-Id: I1eef3021f474f8de244412204afd7b5b63e84821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787702 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695588}
-
Renato Silva authored
ChromeOS Login Screen - Aura Shell Change the way how a PIN gets checked if its composed of only numbers. PINs were checked with base::StringToInt which returns false when their value would overflow an Int. Replace it with base::ContainsOnlyChars(). Bug: 998930 Change-Id: I44fdee46413f82cdfe24d18d66af0ec00ed3d95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783146 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695587}
-
Alex Oldemeier authored
The policy template needs to be updated to reflect the new default behaviour of WebRtcEventLogCollectionAllowed. Bug: 983113 Test: compile Change-Id: I72184fecf3841400aa9db49302fd10dbfed50263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795242Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#695586}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5e7e89d. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" 30dde1e3 "[LayoutNG] Fix `vertical-align: top/bottom` with leading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ia15ad858029761d2f759338c233442f543e30f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798262Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695585}
-
vitaliii authored
Disable WebRtcDataBrowserTest.CallWithDataAndMedia on Win and Linux, because flaky. TBR=liberato@chromium.org,phoglund@chromium.org Bug: 986872 Change-Id: Ifcfe2480ca77cdd3745dbd9a0bb31abbc1a86dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796666Reviewed-by:
-
Jérôme Lebel authored
Enabling testSignInDisconnectFromChromeManaged test. Updating the test to support unity, and closing the settings after doing the sign-in. Bug: 929967 Change-Id: I3185916df9f9bfe01ef430d630d94c435be0db0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793185 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#695583}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0b8eca795349..9dbfeac8b553 git log 0b8eca795349..9dbfeac8b553 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 7f7236f1eba0..c0e9807094ef (4 commits) Created with: gclient setdep -r src/third_party/angle@9dbfeac8b553 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:None Change-Id: I49a9398da9e33670ffe821d307377538330e7be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797159Reviewed-by:
-
Vadym Doroshenko authored
The dataflow is the following: 1.The user is typing in the non-password field, this data is saved in PossibleUsernameData struct in PasswordManager. 2.When the password form is submitted PossibleUsernameData instance is passed to form manager. 3.If as a result of the parsing, the username is not found and data from PossibleUsernameData looks plausible (see possible_username_data.h::IsPossibleUsernameValid for more details). then the typed value is taken as username. Bug: 959776 Change-Id: I33de65211af2de5f2f8b7f486682fcf303b89414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715352 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695581}
-
redatawfik authored
- Create class "CreditCardScannerImageProcessor" which handles processing a credit card image and call the consumer with the results. - Move all text recognition logic from mediator to "CreditCardScannerImageProcessor". Bug: 984545 Change-Id: Ifbdb1b6fbc22804ba969c2c2dec89fadbaa095d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783443 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#695580}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70767cba4254..fcfeefe03386 git log 70767cba4254..fcfeefe03386 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 mbonadei@webrtc.org Move rtc_error.{h,cc} to its own build target. 2019-09-11 srte@webrtc.org Reland "Adds peer scenario connection interface." Created with: gclient setdep -r src/third_party/webrtc@fcfeefe03386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I8b9b59334a47bd92999fb9f2685283ffce712f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797160Reviewed-by:
-
Felipe Andrade authored
Changes references to the old policy documentation, replacing by the new policy list page. The patterns for the old and new URLs can be found on the bug description. Bug: 987706 Change-Id: I53b020af2499731b159987f1995da943bf160ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780836 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#695578}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/14318c140949..c13cb6e62441 git log 14318c140949..c13cb6e62441 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 olivernewman@google.com Handle output placeholder missing backing file Created with: gclient setdep -r src/third_party/skia@c13cb6e62441 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I585c63a2c67a772181338aa75c513dd837920ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798382Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts SSLPrivateKeyPtr to new Mojo types. It updates ContinueWithCertificate from network_context.mojom and methods and members which use SSLPrivateKeyPtr with new mojo types. Bug: 955171, 978694 Change-Id: I7a97cc208aa1b6d354b8c5e82556f2fb0c929fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786376 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Denis Kuznetsov authored
This is a cleanup that removes unused "android" attribute: 1) cr_button does not support this attribute anymore, so it does not have sense to have it in oobe_buttons. 2) There is no code that uses this attribute for oobe dialogs, so it can be safely removed. android attribute was introduced to make sure Assistant buttons were looking android-like about 2 years ago. TBR=alemate@chromium.org Bug: 1000606 Change-Id: I97f1988de91c8945f915110c705e9cc2b83697e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789706 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
