- 18 Aug, 2020 40 commits
-
-
Vicky Min authored
The class BluetoothSerialPortImpl is intended to support Serial API features for Bluetooth SPP devices. The Close() function is implemented todisallow any more calls to BluetoothSerialPortImpl functions and tested. Bug: 1043300 Change-Id: Ic42095eb587a5dd099f48f2babe75882c9dd385a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354682 Commit-Queue: Vicky Min <vickymin@google.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#798998}
-
Andrew Moylan authored
The rollout is still underway, give some leeway. Bug: 1067048, 937063 Change-Id: I4af7f51fc6a45c05b15af0211ce2c4821c133802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355354 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#798997}
-
Justin DeWitt authored
This allows desugaring to work by including required classes in the desugar run. Change-Id: I11828b8ff4edb0312a0c07821a2c9d5e853925a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357914 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#798996}
-
Andres Calderon Jaramillo authored
This CL extends the GpuMemoryBufferFactory interface to allow CreateGpuMemoryBuffer() to take a framebuffer size. This is so that we can take advantage of the framebuffer_size parameter in the SurfaceFactoryOzone::CreateNativePixmap() argument. This is useful in Chrome OS to be able to allocate a buffer of a specific size while adding a DRM framebuffer of a different size. For example, suppose a hardware video decoder needs buffers of size 640x368 to decode a video whose visible rectangle is 640x360. In this case, the size of the DRM framebuffer should be 640x360 so that the display controller doesn't sample non-visible data if the video gets promoted to a hardware overlay. The extended API is needed because the new direct VD uses a GpuMemoryBufferFactory to allocate native buffers. It is only needed within the GPU process (it doesn't need to be exposed to clients). The extended API is used in CL:2340115. Bug: b:162880731 Test: None. Change-Id: Idf0c13e598fe730098424458af7515a320e6d511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340069Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798995}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 939e2f7e. With Chromium commits locally applied on WPT: 5599375e "[WPT] Only load *.mojom.js through loadMojoResources" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I788467020d11bcab13fb840fea7e6d215e0d76e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360718Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798994}
-
Ilia Samsonov authored
Some baselines have changed, baselines are from https://test-results.appspot.com/data/layout_results/linux-blink-optional-highdpi-rel/67/high_dpi_blink_web_tests%20%28with%20patch,%20experimental%29/layout-test-results/results.html Bug: 1068400 Change-Id: I7fcc694168d2e0c574d84fee9751fd0fb9cc0ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358607Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798993}
-
Robbie McElrath authored
This is a reland of b207aafb The original version of this CL would disable animations when destroying BrowserControlsContainerView, including the bottom view, which asserted that setAnimationsEnabled wasn't called on it. This would fail depending on whether or not weblayer's teardown finished before the test finished. Original change's description: > [WebLayer] Let the embedder animate top controls in/out. > > This CL adds an "animate" flag to Browser.setTopView that allows the > embedder to tell WebLayer to animate the top view off the screen when > setting it to null, or to animate it down from the top when setting it > to a non-null value. > > The animation off the screen is achieved by removing the View from the > view tree, but keeping the bitmap layer in place, hiding the top > controls, and then deleting the layer after the animation is complete. > > Bug: 1108956 > Change-Id: Idb9bce6c2633ef6d1d369ccb2741ae6fd1fe43a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335800 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797826} Bug: 1108956 Change-Id: I79050b417cf68714061e515cf3ec6433dbbfac6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357369 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#798992}
-
Maksim Sisov authored
We need to initialize the FeatureList as early as possible. Otherwise, VizTestSuite, AuraTestSuite, and others may not be properly initialized because they need to check whether OzonePlatform is used (that is not a problem when either use_x11 or use_ozone is set. But when both are set, the tests fail to initialize for Ozone case and take non-Ozone X11 path). IsUsingOzonePlatform has static const initializer now so that tests won't override the return value of this method. However, we need to call that at least one as early as possible. Thus, TestSuite::Run is the best place for that. What is more, we also need to append UseOzonePlatform feature to the CommandLine so that other processes get the same value as the original process. The reason why we need to do that is that CommandLine takes enabled/disabled features during the tests overriding the initial FeatureList. Once it is restored, the CommandLine has already been updated and won't be updated again. Thus, we need to append the flag and let other processes start correctly (like GPU process). ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I122bec7441b3dbd199eb4287338f8903878d2b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333844Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798991}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/03f545114e8e..26ea611a4edb 2020-08-18 dberris@chromium.org chromeperf: Remove non-OAuth ids from allowlist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1103145 Tbr: rmhasan@google.com Change-Id: I7f16edf6b380dd87db772721286adf291567ad63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798990}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_DidGetDocumentCookie message to DidGetDocumentCookie() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I8cb535babd6fbd70efa408675e235ba8375c5873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352297Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#798989}
-
Olivier Yiptong authored
The exposed data in Font Access can be used for fingerprinting. Implements user activation checks for the Font Access API as means to further gate this API, which has a permission request flow already. The permission prompt and UA checks together greatly mitigate accidental or malicious activations of this API. A blink-side UA check first gates access to the API. But since we ought to trust the browser process rather than a renderer process, a check is also made browser-side. Fixes: 1116194 Change-Id: I1e95433fe7139489adeb940aed1662a3fe645bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359236 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#798988}
-
Michael Bai authored
- Sets UserActivation if the proper user input occurred. - Schedules the shortest delay task if any change happened within a active UserActivation. - Otherwise, applies exponential delay up to 128s. - Guarded with feature for finch experiment. Bug: 1114819 Change-Id: I4580a1168f0b06706f9b5837074263a03254fee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349402Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#798987}
-
Hiroki Nakagawa authored
Before this CL, BlinkOptimizationGuideHints were wrongly filtered out when there are no subresources to block. This CL fixes it. Bug: 1113980 Change-Id: Ie1f449f0cc5d8beab3b94eaa6cf94c60e67711e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359659Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#798986}
-
John Abd-El-Malek authored
Change-Id: I791ecbaa3541dfbff9ae636d9737e2e1cbd175ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360426 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798985}
-
Fergus Dall authored
This reverts commit 0fb7ef15. Reason for revert: Speculative revert May have broken webgl_conformance_tests on chromeos-amd64-generic-rel: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/45665 Original change's description: > Revert back to the default GPU when no renderers are using WebXR > > The GPU process may have been restarted and initialized on a different > GPU than the default if the VR headset is not plugged into the default > GPU. Staying on this XR compatible GPU can drain battery a lot quicker. > When there are no longer any renderers using WebXR, this change reverts > reverts the GPU process back to the default GPU. > > Bug: 1090951 > Change-Id: Ibc5e7f709d2c82d5a6e8cbda08766d1d654951a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321771 > Commit-Queue: Patrick To <patrto@microsoft.com> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798950} TBR=patrto@microsoft.com,alcooper@chromium.org Change-Id: I14e44c4fe60cdde138ea281b8766ac113887aa99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359663Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798984}
-
Fergus Dall authored
This reverts commit 3da0177b. Reason for revert: Speculative revert May have broken webgl_conformance_tests on chromeos-amd64-generic-rel: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/45665 Original change's description: > Add GLImageEGLPixmap for vaapi linux support. > > This new image type can hook an X11 pixmap up to an egl pixmap surface, > which lets VaapiPictureNativePixmapAngle create xlib pixmaps and bind > them as surfaces. > > With this cl, the flag --enable-accelerated-video-decode will be > functional on a modern intel graphics linux system while using ANGLE. > > Bug: 1103510 > > Change-Id: I9c2bce16729be1e8f007b47da5a5160074f78483 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288633 > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798952} TBR=dalecurtis@chromium.org,zmo@chromium.org,geofflang@chromium.org,mcasas@chromium.org,tmathmeyer@chromium.org,andrescj@chromium.org Change-Id: Ied00f4a03cf404f948b5670b836beeff3b6c2c4e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359952Reviewed-by:
-
Vicky Min authored
The class BluetoothSerialPortImpl is intended to support Serial API features for Bluetooth SPP devices. StartReading and StartWriting to read from or write to the bluetooth socket connected, and Flush/Drain to make sure Read and Write are handled correctly when they are finished. Bug: 1043300 Change-Id: I97fc2970215c2bfa479a0a8c61d78a03aa9a7ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334682 Commit-Queue: Vicky Min <vickymin@google.com> Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit 1785af75. It caused crash in Android, where VerifyCertForSignedExchange() can call its callback synchronously. Bug: 1117177 Change-Id: Iaa65bde258f43f8c4ca8cee37af087c03eca681c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360099Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798981}
-
Peter Kasting authored
Bug: 1104532 Change-Id: I0578584a42e7557b0baa23519cebcbe96a3729ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353346 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798980}
-
K. Moon authored
Fixes a DCHECK in PDFiumEngine::OnPendingRequestComplete() that incorrectly asserts that the document should be finished loading, when it actually should assert the opposite. Updates PDFiumEngineTest::TryLoadIncrementally() to trigger coverage of this code path. This code path is executed only when pages are in the pending state when OnPendingRequestComplete() is called, which only happens when pages become visible outside of a loading operation. Fixed: 1051548 Change-Id: I035d95c7e626c294a0b3189fcbc6c5ab33944786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067743Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Fergus Dall authored
This reverts commit a5f47e82. Reason for revert: Broke ash_unittests on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20052 Original change's description: > [Switch Access] Convert event handler into event rewriter > > Switch Access is not receiving some key events that it should be when > certain UI elements are focused. The events are instead passed directly > to those UI elements (e.g. Launcher text field, omnibar), effectively > trapping the user and leaving them unable to use the device. > > This change converts the SwitchAccessEventHandler into an event > rewriter, so that Switch Access will receive events before any other > source. > > AX-Relnotes: n/a. > Bug: 1106573 > Change-Id: Ib34de857acc8d6985e769fb83adb93b9ea41649e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317833 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798766} TBR=jamescook@chromium.org,dtseng@chromium.org,anastasi@google.com Change-Id: Id17140968403e57012f3560a658420911dbfcc5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361223Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d2a9f6661597..1756465158d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1ea89c75242b16d50bbe9837baba15938ba82734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360908Reviewed-by:
-
Peter Kasting authored
Bug: none Change-Id: I6e15b5deef982c5b3a0467337537cb61d2233925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359001 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798976}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/988f19e208bb..d95180deded1 2020-08-17 rharrison@chromium.org Roll 4 dependencies 2020-08-17 enga@chromium.org D3D12: only lazy clear OutputAttachment textures with render target ops If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibcb597d53a688ed40d98a8496d24123e219d915f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360962Reviewed-by:
-
Fergus Dall authored
This reverts commit bd949c8f. Reason for revert: Broke several browser tests on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20053 Original change's description: > cr_components/network: Convert NetworkListItem to Polymer 3. > > Also convert the types in NetworkListTypes as well since they are > trivial and NetworkListItem depends on them. > > Bug: 1045266 > Test: NetworkNetworkListItem* > Change-Id: Iabe3a94bd80a9269215f1298c30e154442014003 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359397 > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Auto-Submit: James Hawkins <jhawkins@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798826} TBR=jhawkins@chromium.org,khorimoto@chromium.org Change-Id: I3a8d8526dbcb9be3b71c96cbd9b33fa7e901df4a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359661Reviewed-by:
-
Glen Robertson authored
Change-Id: Ie7ceb049a3ad622fe0b3e1c998dd88b7e5de1dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358726Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#798973}
-
Adam Rice authored
Now that the standard changes for transferable streams have landed, add comments to the source referencing the spec. No functional changes. BUG=894838 Change-Id: I3107c62a361257fb6bad81f45e6d108de4a74622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359812Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#798972}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: Idde01476544d3ec2227a4fb82ba9db558b7f20b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360949Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798971}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2549f174b533..88816e373d30 2020-08-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2ecce21d..a0c9fe7f (798579:798709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifcf02cf75a1b4e06d1d9327c31a19cfac4158655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360882Reviewed-by:
-
Mark Schillaci authored
This is a reland of 82d92693 Speculative revert was incorrect Original change's description: > Add accessibility support for multiselectable aria-activedescendants on Android > > This CL adds support for multiselectable aria-activedescendants > > For nodes that are multiselectable (e.g. listbox of items with an > aria-activedescendant role), we add more descriptive labels. For > Android R we use the new stateDescription on AccessibilityNodeInfo > object for the given node. To support pre-Android R, we append the > labels to the text for the node. > > For a multiselectable node that has no items selected, we add the > text: > > "multiselectable, none selected." > > For a multiselectable node with n children selected of k total, we > add the text: > > "multiselectable, n of k selected." > > > > multiselectable aria activedescendants > > AX-Relnotes: Added more descriptive accessibility labels for > Change-Id: I9fe04714c5800939b73b11c3339e628ae7760939 > Bug: 1101660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341826 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mark Schillaci <mschillaci@google.com> > Cr-Commit-Position: refs/heads/master@{#798926} TBR=dmazzoni@chromium.org,sky@chromium.org,pinkerton@chromium.org,mschillaci@google.com Bug: 1101660 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I8ee35f5a04cb09c9b462a08fcf92c611bdb2f2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360064Reviewed-by:
-
Miguel Casas authored
This is a reland of 02aec841 Speculative revert was incorrect Original change's description: > RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > The relanded CL was reverted due to crashes when used from ARC++: > Video Frames coming from this path are not GpuMemoryBuffers, so there's > a DCHECK not verified, and then a crash. This CL addresses that > situation, fixing `video_decode_accelerator_tests --use_vd_vda`: > see crrev.com/c/2359734/1..3. > > Bug: b:163920993 > > Original RELAND description ------------------------------------------- > > The original CL was reverted due to crashes in betty initialization: > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > TBR=andrescj@chromium.org > > Original CL description ----------------------------------------------- > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > error in the tracking of the VASurfaces lifetime in the driver: every > time we get a new resource from the pool to decode onto, this is > imported into libva as a VASurface: this works fine almost everywhere > but doesn't play well in these old platforms (see CreateSurface() body). > > This CL adds a map that keeps the ref-counted VASurfaces alive and > indexed by the unique GpuMemoryBufferId until the VA Context is > destroyed. In so doing, we're basically observing the "contract" of > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > contexts using these surfaces have been destroyed". > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > Bug: b:142019786 b:143323596 > Change-Id: I16e74eb2b483b892961eca27aed30112240aa8ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#795026} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359734 > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Auto-Submit: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798931} TBR=mcasas@chromium.org,andrescj@chromium.org Bug: b:163920993 Bug: b:142019786 b:143323596 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I6124e960d93f6985dbf9a546bc9d34372815e002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359975Reviewed-by:
-
Fergus Dall authored
This reverts commit 02aec841. Reason for revert: Speculative revert, may have broken Network Service Linux: https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/10157 Original change's description: > RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > The relanded CL was reverted due to crashes when used from ARC++: > Video Frames coming from this path are not GpuMemoryBuffers, so there's > a DCHECK not verified, and then a crash. This CL addresses that > situation, fixing `video_decode_accelerator_tests --use_vd_vda`: > see crrev.com/c/2359734/1..3. > > Bug: b:163920993 > > Original RELAND description ------------------------------------------- > > The original CL was reverted due to crashes in betty initialization: > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > TBR=andrescj@chromium.org > > Original CL description ----------------------------------------------- > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > error in the tracking of the VASurfaces lifetime in the driver: every > time we get a new resource from the pool to decode onto, this is > imported into libva as a VASurface: this works fine almost everywhere > but doesn't play well in these old platforms (see CreateSurface() body). > > This CL adds a map that keeps the ref-counted VASurfaces alive and > indexed by the unique GpuMemoryBufferId until the VA Context is > destroyed. In so doing, we're basically observing the "contract" of > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > contexts using these surfaces have been destroyed". > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > Bug: b:142019786 b:143323596 > Change-Id: I16e74eb2b483b892961eca27aed30112240aa8ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#795026} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359734 > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Auto-Submit: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798931} TBR=mcasas@chromium.org,andrescj@chromium.org Change-Id: I4e2d835e7551210298fa150442250bc5dce6475a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:163920993 Bug: b:142019786 b:143323596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359974Reviewed-by:
-
Fergus Dall authored
This reverts commit 82d92693. Reason for revert: Speculative revert, may have broken Network Service Linux: https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/10157 Original change's description: > Add accessibility support for multiselectable aria-activedescendants on Android > > This CL adds support for multiselectable aria-activedescendants > > For nodes that are multiselectable (e.g. listbox of items with an > aria-activedescendant role), we add more descriptive labels. For > Android R we use the new stateDescription on AccessibilityNodeInfo > object for the given node. To support pre-Android R, we append the > labels to the text for the node. > > For a multiselectable node that has no items selected, we add the > text: > > "multiselectable, none selected." > > For a multiselectable node with n children selected of k total, we > add the text: > > "multiselectable, n of k selected." > > > > multiselectable aria activedescendants > > AX-Relnotes: Added more descriptive accessibility labels for > Change-Id: I9fe04714c5800939b73b11c3339e628ae7760939 > Bug: 1101660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341826 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mark Schillaci <mschillaci@google.com> > Cr-Commit-Position: refs/heads/master@{#798926} TBR=dmazzoni@chromium.org,sky@chromium.org,pinkerton@chromium.org,mschillaci@google.com Change-Id: I6ef8ea0fb314eda1f8cb962cea0bd0f089dc7713 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361222Reviewed-by:
-
Evan Stade authored
since it's now available in the SDK. Bug: 1057100 Change-Id: I10c867cdc40ab0a5d7eb41b6892d1220e1ee23dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354561 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#798965}
-
Daniel Classon authored
Combine the OS Sync Controls "turn on sync" and "turn off sync" buttons. This is better for a11y as the button doesn't lose focus when clicked. This is related to settings deep linking as its easier to deep link to a single element rather than two elements sharing one setting. Bug: 1084154 Change-Id: I545498954934368f47c8f6af168830014e41947d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359164 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798964}
-
Yuke Liao authored
This CL refactors the skipped tests for unit_tests so that it applies to both linux-lacros-tester-rel and linux-lacros-rel. Bug: 1116180 Change-Id: Ia7657ff8eb00d49fd1108dda4ffd76bbc1be4d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360679Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#798963}
-
Kent Tamura authored
We do something like: shadow_root.lastChild.textContent = 'foo.txt'; when input[type=file] receives the result from a file chooser dialog. If a file input requests to open a file chooser and the input type is changed before receiving the result, we remove shadow elements by the textContent setter in some cases. This CL fixes it by - Introduce InputTypeView::will_be_destroyed_, which becomes true when a InputTypeView is disconnected from the owner HTMLInputElement. - Check will_be_destroyed_ in functions which receive asynchronous results from pickers. Bug: 1116378 Change-Id: I76fb166a0e5221441fcabeea34ab8a5bbd7d4af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358718 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
When caret browsing is enabled it should cause the cursor to start blinking if it wasn't already. To do this, it's sufficient to just invalidate style. This results in calling FrameCaret::UpdateStyleAndLayoutIfNeeded() which starts the caret timer if needed. Bug: 1116658 Change-Id: I55a249878a1646a358a584e6ffccd501bfdd8189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357963 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#798961}
-
Orin Jaworski authored
This CL adds `en-GB, es, es-419, et, fa, fi, fil, gu, he, hi, hr, id, it` to the set of languages supported by Pedals. Bug: 893183 Change-Id: I6740e0074fbd6eeaf3a668973cf6423ae2ce8df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360219 Auto-Submit: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#798960}
-
Tommy Li authored
This reverts commit e8ecbf8b. Reason for revert: This flag is too broadly scoped. When it's disabled, it also turns off MostVisited on Android and iOS, which is not intended. Original change's description: > [omnibox] Add kFocusGestureTriggersContextualWebZeroSuggest flag > > This CL adds an enabled-by-default flag that causes on-focus gestures > to trigger ZeroSuggest on the Contextual Web page classification > (OTHER). > > We add this flag so we can disable it in some experiments, where we > want to use on-clobber instead. > > It also adds a test to make sure this flag doesn't affect other page > classifications such as the NTP. > > Bug: 1106096 > Change-Id: I32d4b9fc396874f836c60ae347ac3894818cf1d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350309 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797491} TBR=tommycli@chromium.org,jdonnelly@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106096 Change-Id: Icfef70ed62561fcfc2f9f14af6a5234e2fd65f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358907Reviewed-by:
-
