- 19 Mar, 2018 40 commits
-
-
Misha Efimov authored
- Removes Cronet dependency on Breakpad. - Applies to developer environment and public bots. - Reduces Cronet binary size, especially on iOS. - Official buildbots will be updated separately. Bug: 811308 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I24fe9075a731a507ed8861e1f4811d4d463bb80d Reviewed-on: https://chromium-review.googlesource.com/964596 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#544211}
-
Bill Budge authored
- Set shared memory handle to invalid so we don't try to close it twice. Bug: chromium:763174 Change-Id: Ibdb27f6dd36b15e58d7fe144946b2695531b6ccd Reviewed-on: https://chromium-review.googlesource.com/969118Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#544210}
-
Brett Wilson authored
Avoid a crash caused by mutation of the list being iterated over from inside the foreach loop. This does a full copy of the the iterated list since the code inside can't mutate the array via the loop variable anyway. Although theoretically slower, this doesn't seem to have a measurable performance regression in practice (we generally iterate over few large lists). Adds documentation and tests for iteration while mutating the underlying list variable. Bug: 818525 Change-Id: I221fa230685b8998f5874154cad8d5c655b8006c Reviewed-on: https://chromium-review.googlesource.com/959228 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Roland McGrath <mcgrathr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544209}
-
Tibor Goldschwendt authored
Bug: 823272 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I74cd47e699cd999ec4bd44a5e82fef71fd931d27 Reviewed-on: https://chromium-review.googlesource.com/969451Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544208}
-
Robert Ogden authored
The actual webpage will no longer have CSS and JS resources, so remove them from this test's comments. Bug: 744967 Change-Id: Ic3d8e2a0a5b1c46d1a453ff1e1a9366b46a4e4bf Reviewed-on: https://chromium-review.googlesource.com/969719Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@google.com> Cr-Commit-Position: refs/heads/master@{#544207}
-
Tsuyoshi Horo authored
crrev.com/c/956654 introduced the bad flags warning of "stability and security will suffer" for Android. This change caused parformance regressions because a bad flag "--ignore-certificate-errors-spki-list" is used for perfomance testing. (crbug.com/822258#c13) So this cl introduces the check of "--enable-automation" flag in ShowBadFlagsPrompt(). This check already exists in startup_browser_creator_impl.cc for Desktop not to show the infobar during performance tests. crrev.com/c/catapult/+/965712 will add the flag in the script of catapult. Bug: 822258,803774 Change-Id: Icef23b907460f3a60284675f1dd2f55a73375b72 Reviewed-on: https://chromium-review.googlesource.com/965727Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#544206}
-
Danyao Wang authored
WKBasedNavigationManager::Restore() calls WebState::LoadCurrentURL() to load the restore_session.html into WKWebView. However, after a cold start, LoadCurrentURL() early exits because there is no _containerView, and the pending navigaiton to restore_session.html is only completed when the tab becomes active. While a tab is in this state, the WebState title is empty, causing "Untitled" to be displayed in the tab switcher, and any call to BuildSessionStorage() will incorrectly save an empty session. If the app is backgrounded, the previously restored session will be lost. This CL fixes the issue by temporarily caching the last restored session storage in WebStateImpl, so it can be returned in GetTitle() and BuildSessionStorage() in the intermediate state. The cached version is invalidated as soon as a new navigation item is committed. Bug: 822771 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I573c33f8d3282d4af0ef98c19fedb767c7ab987d Reviewed-on: https://chromium-review.googlesource.com/969638 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#544205}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/page/DragControllerTest.cpp:57:72: error: declaration of ‘blink::DragMockChromeClient& blink::DragControllerTest::ChromeClient() const’ [-fpermissive] DragMockChromeClient& ChromeClient() const { return *chrome_client_; } ^ In file included from ../../third_party/WebKit/Source/core/loader/EmptyClients.h:39:0, from ../../third_party/WebKit/Source/core/layout/LayoutTestHelper.h:17, from ../../third_party/WebKit/Source/core/page/DragControllerTest.cpp:14: ../../third_party/WebKit/Source/core/page/ChromeClient.h:94:19: error: changes meaning of ‘ChromeClient’ from ‘class blink::ChromeClient’ [-fpermissive] class CORE_EXPORT ChromeClient : public PlatformChromeClient { ^~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having a |ChromeClient()| method can change the meaning of references to |ChromeClient| in the code depending on where it is declared, which contradicts the C++ standard. Fix it by taking advantage of covariant return types: instead of having a GetChromeClient() method that returns a |ChromeClient| and a ChromeClient() method that returns a |DragMockChromeClient|, make GetChromeClient() return a |DragMockChromeClient| and do away with ChromeClient() entirely. Change-Id: I97834bfe22acb0745e5307d13e377f596587e199 Reviewed-on: https://chromium-review.googlesource.com/968496 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544204}
-
Yngve N. Pettersen authored
Git bash on Windows will remove the leading slash for "//" labels, changing absolute labels from //foo to /foo. This CL fixes these labels back to //foo, file system absolute labels are not "fixed". This modification by Git Bash may be a bug, but looking at the source, the removal seems to be intentional. Change-Id: I16d0ca796ce4c1187717f97ab9c3b1c14a6c6a73 Reviewed-on: https://chromium-review.googlesource.com/957084Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> Cr-Commit-Position: refs/heads/master@{#544203}
-
Andrew Grieve authored
Caused by the way stdout and stderr were being combined. Never saw this when I first added this logic, so I'd guess something changed on the Android / adb side. This was failing 3/4 time on my O device. Change-Id: I7b905a109a312fd57ab3c2e1d4dfa9521f505f02 Reviewed-on: https://chromium-review.googlesource.com/969148Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544202}
-
Ryan Hamilton authored
No Flag Changes Remove NeuterUnencryptedStreamData because it's no longer used. n/a (Dead Code Removal) Merge internal change: 189460977 https://chromium-review.googlesource.com/c/chromium/src/+/969593 Deprecate FLAGS_quic_reloadable_flag_quic_use_write_index. Merge internal change: 189382131 https://chromium-review.googlesource.com/c/chromium/src/+/969591 Rename kQuicMaxStreamId to kMaxQuicStreamId Merge internal change: 189349101 https://chromium-review.googlesource.com/c/chromium/src/+/969411 Rollback internal change 184015574. *** Original change description *** Use flat_hash_map for QuicSmallMap. *** Merge internal change: 189252210 https://chromium-review.googlesource.com/c/chromium/src/+/969292 LSC: Replace calls to deprecated absl::string_view methods as_string, to_string, and ToString with string(). The former member functions are deprecated and will soon be removed. Merge internal change: 189187480 https://chromium-review.googlesource.com/c/chromium/src/+/969288 Enable TLS in QuicConnectionTest Merge internal change: 188740951 https://chromium-review.googlesource.com/c/chromium/src/+/969337 Change-Id: Ib411613726bc319547678777dcd6f76efe8bf946 Reviewed-on: https://chromium-review.googlesource.com/969596Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#544201}
-
Farah Charab authored
Add RendererScheduler.TaskDurationPerTaskType.UseCase histogram to record time we spend running tasks of different task types split per RendererScheduler's UseCase. Change-Id: Icd53e095f5cbbddb5419207b2b5767aa2f09bf62 Reviewed-on: https://chromium-review.googlesource.com/968511Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#544200}
-
Emircan Uysaler authored
This CL skips HW frame creation for two input cases: - Frames with odd coded_size - Odd positioned visible_rect Bug: 638906, webrtc:9033 Change-Id: Ie945c4626d236c1c97f2ec55cd67bc00d1d9c909 Reviewed-on: https://chromium-review.googlesource.com/965322Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544199}
-
Julien Isorce authored
This is a reland of ed312194 Original change's description: > Skip GpuOESEGLImageTest on ATI proprietary driver > > Detect the GL_VENDOR string from the default GL implementation. > If it is the ATI proprietary driver then do not switch to EGL/GLES2 > as there is a known bug and this driver crashes in eglInitialize > instead of failing properly. > > BUG=822716 > > Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I00b883012c31867f938bf3f68440058738bb312b > Reviewed-on: https://chromium-review.googlesource.com/966662 > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543735} TBR=kbr@chromium.org Bug: 822716 Change-Id: I5af29ab9ac904ee90ed7d9d114300935fe26be66 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/966825 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#544198}
-
Greg Kerr authored
This CL allows access to the entire timezone folder subpath, as macOS has changed the layout of the timezone data on disk. Bug: 818249 Change-Id: Ied9b81977e0453616b72e74da86d4d67c211785b Reviewed-on: https://chromium-review.googlesource.com/969617Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#544197}
-
Pedro Amaral authored
BottomSheetContent#isIncognitoThemedContent() always returns false so this CL removes it. Bug: 814528 Change-Id: I85ad1676fd9847b3055ee69dc196baee1882579e Reviewed-on: https://chromium-review.googlesource.com/967098Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#544196}
-
dpapad authored
Bug: 823208 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I93a95f26e5910fe3fa98f6ad43c0d629bbf4f587 Reviewed-on: https://chromium-review.googlesource.com/969095Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#544195}
-
Siddhartha authored
The memory metrics added in UKM were not recorded in UMA. Add metrics in UMA for all these metrics. Removed duplicate UMA metrics: <Process>2.PrivateMemoryFootprint and <Process>2.Resident. BUG=730783 Change-Id: I568a7d455fd37e48532c722a1ddb7feff4fa05f0 Reviewed-on: https://chromium-review.googlesource.com/961384 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#544194}
-
Richard Bustamante authored
The test testLitePageBTFOldFlags depends on a LitePage being served in the response, but fails when a stale preview is served instead. We should update the test to force a Lite Page using the "alt6" experiment. Bug: 823459 Change-Id: I5b460a4286bdaeef2319954ea2ad8e68cd5ea0b9 Reviewed-on: https://chromium-review.googlesource.com/969620Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/2a467ca516e1..734f737c6b57 $ git log 2a467ca51..734f737c6 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 perezju [Telemetry] Set WebView implementation when using Monochrome.apk 2018-03-19 eakuefner [Dashboard] Add IS_SUMMARY diagnostic 2018-03-15 simonhatch Dashboard - Convert anomaly_config.GetAnomalyConfigDict to tasklet. Created with: roll-dep src/third_party/catapult BUG=chromium:815133,chromium:711073 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I285a1e120abf596080d7fa0c8e187f384cd7d89b Reviewed-on: https://chromium-review.googlesource.com/969447Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544192}
-
Lucas Furukawa Gadani authored
Bug: 822690 Change-Id: I593a80ad739cbb39c5090a47cfbcb2872622785a Reviewed-on: https://chromium-review.googlesource.com/969456Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544191}
-
xlai authored
This CL cleans up code in canvas/OffscreenCanvas and their rendering contexts in a world after ImageBuffer has been removed. It does the following: - Renamed certain functions/variables to avoid misleading future readers. - Split CreateImageBuffer into two functions, one for creating Canvas2dLayerBridge in 2d context, another for creating resourceProvider for webgl in webgl context. It was unnecessary and misleading to lump these two unrelated operations together. - Drive-by deletion of some unused code. TBR=zmo@chromium.org Bug: 776806 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id06026649894ddf20677f509296d87c5cfb4a5d6 Reviewed-on: https://chromium-review.googlesource.com/967252 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#544190}
-
https://pdfium.googlesource.com/pdfium.git/+log/20c94774cc7e..ef44194f4f4c $ git log 20c94774c..ef44194f4 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 thestig Remove non-const ref parameters in CPDF_TextPage. 2018-03-19 thestig Remove redundant code in CPDF_TextPage::CountRects(). 2018-03-19 thestig Avoid crashing in FPDFText_CountRects() for invalid start values. Created with: roll-dep src/third_party/pdfium BUG=chromium:821305 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I726b9c8d8cabcce76876a1adf89ffb67ab63eaa8 Reviewed-on: https://chromium-review.googlesource.com/969589Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544189}
-
bsheedy authored
This is a reland of f308efb9. Original change's description: > Add WebXR non-exclusive session tests > > Ports existing WebVR tests that use magic window to WebXR now that > non-exclusive sessions are supported. Also adds two new WebXR-only tests > involving non-exclusive sessions. > > Bug: 804043 > Change-Id: I283438d2206e2563636188b5f2a6537d56f2c10e > Reviewed-on: https://chromium-review.googlesource.com/916728 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537975} TBR=mthiesse@chromium.org,bajones@chromium.org Bug: 804043 Change-Id: I24dd7e2327f10d11c39d0dee4eb49f2e7bd42e3a Reviewed-on: https://chromium-review.googlesource.com/929522 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#544188}
-
Pedro Amaral authored
BottomSheetContent#getViewsForPadding() was never used so this CL removes it. Bug: 814528 Change-Id: I9f4113671a8b2784096e99d5d1bbcdd675a97550 Reviewed-on: https://chromium-review.googlesource.com/967093Reviewed-by:
-
Xiaohan Wang authored
Now ScopedFeatureList::InitWithFeatures() takes vectors instead of initializer_lists, we can make this much simpler. Change-Id: Iaa807df1873ce5bf4215d1523dd53de4b0819b7f Reviewed-on: https://chromium-review.googlesource.com/964934Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#544186}
-
Alexis Hetu authored
This cl enables experimental support for SwiftShader on MacOS. It is still disabled by default since use_egl_on_mac is still false in ui/gl/features.gni. Bug: 726075 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I01093a2203a94d05e0588ff1deeb8016848d82b9 Reviewed-on: https://chromium-review.googlesource.com/955949 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Bug: 822190 Change-Id: I63fd40f80f243dbf4a40baac940f2dd999d3e443 Reviewed-on: https://chromium-review.googlesource.com/964541Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#544184}
-
Ran Ji authored
Previously the fetch request happens very early during Chrome startup. It does not seem necessary to fetch the list that early. Move the request after Chrome startup and to when a page is eligible for translation. Bug: 782900 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I543ecf43f3aec8c8629d1c48452f1bce11f7cc88 Reviewed-on: https://chromium-review.googlesource.com/894891Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#544183}
-
Andrey Kosyakov authored
- expose request id in NetworkServiceClient methods; - plumb host process id to DevToolsURLLoaderInterception; - maintain a static map from (process id, routing id, request id) to InterceptionJob*; - wire auth request callbacks from NetworkServiceClient to InterceptionJob. BUG=812464,721408 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9eee7b2e9bc436376c741fcca7e2f67a2f04a32d Reviewed-on: https://chromium-review.googlesource.com/967092Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544182}
-
Dale Curtis authored
Per upstream, this is totally normal to happen and they won't accept changes to fix this without undertaking a large refactoring of the AVParser infrastructure: http://ffmpeg.org/pipermail/ffmpeg-devel/2018-February/225800.html This behavior may also occur with ADTS streams, but is rarer in practice because ffmpeg's ADTS demuxer does more validation on the packets, so when invalid data is received, av_read_frame() fails and playback ends. Since we haven't had a rash of complaints about too-short ADTS streams, don't bother doing this for ADTS streams at this time. BUG=822341,794782 TEST=existing tests all still pass. Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iabcad145bb75f742e4ba7658ab95c377b811efa1 Reviewed-on: https://chromium-review.googlesource.com/965121 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#544181}
-
Pedro Amaral authored
Bug: 814528 Change-Id: Id48a4a0d90579c68961752747c252338ff6c73c7 Reviewed-on: https://chromium-review.googlesource.com/967246 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
-
Lei Tian authored
Bug: none Change-Id: I1e50971fd5bf501c46429cea115421af49fcc01b Reviewed-on: https://chromium-review.googlesource.com/959390 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544179}
-
Pedro Amaral authored
Bug: 814528 Change-Id: I957587117090cfea68277964adabdf8464d77298 Reviewed-on: https://chromium-review.googlesource.com/967276Reviewed-by:
-
Karan Bhatia authored
BUG=822071 TBR=pkasting@chromium.org, krb@chromium.org Change-Id: I57ea1d13d8f859cd3bcf9f3c192781b48c748dd5 Reviewed-on: https://chromium-review.googlesource.com/969592 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544177}
-
Chong Zhang authored
The same issue has been fixed in f8572183. TBR=kinuko@chromium.org Bug: 822891 Change-Id: I1f4dcc4e925f315da97b6c7e7ff2278bb1c86564 Reviewed-on: https://chromium-review.googlesource.com/969583Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#544176}
-
Alexei Svitkine authored
Tests disabled on iOS: VariationsCrashKeysTest.BasicFunctionality SubresourceFilterFeaturesTest.AdTaggingDisabled_DisablesDryRun The other two tests are already failing, but are being masked by the SyntheticTrialRegistryTest failure which is crashing the test harness. Disabling them in this CL to green up the bots and they can be investigated/fixed separately. Bug: 821162, 823449 Change-Id: Id6200cb1e5b086a8ee36babc669b408a16c1f5bb Reviewed-on: https://chromium-review.googlesource.com/969610 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544175}
-
Scott Chen authored
When HandleStartSignin is called, we know for sure authentication is needed, so its unnecessary to call OpenSyncSetup(), which will go through all the setup work for sync, realizing authentication is needed, then undo all the setup work before bringing up GAIA UI. Bug: 800972 Change-Id: I0b38d90dd4b5a1f9c0fc8dfc6afa607c2b27e616 Reviewed-on: https://chromium-review.googlesource.com/967244 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#544174}
-
Joshua Bell authored
The Web Audio tests (in /webaudio) have idlharness test on an interface-by-interface basis, but the new hotness is to have the IDL fragments consolidated. This also allows dependent specs to include the master interface definitions. Bug: 679813,697123,785409,823431 Change-Id: I60bc8415627b8b3f43c13060e4bf65f47bc17c2b Reviewed-on: https://chromium-review.googlesource.com/965401 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544173}
-
yiyix authored
Added |root_background_color| to RenderFrameMetadata. Since |root_background_color| does not change with every frame,it's added to low frequency fields. One use case is added together with this change: RenderWidgetHostViewAura::SubmitCompositorFrame is used to sniff the |root_background_color| from the CompositorFrame, after this change, RWHVA listens to RenderFrameMetadataProvider and updates the background color when the RenderFrameMetadata changes. Bug: 716911 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6857d0096fe3662b53410e2a7dc8a1682c0544c5 Reviewed-on: https://chromium-review.googlesource.com/952303 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#544172}
-
