GitLab

Legacy Skia flag.

BUG=475017
TBR=reed@googl.ecom,mtklein@google.com

Review URL: https://codereview.chromium.org/1067403002

Cr-Commit-Position: refs/heads/master@{#324245}

BUG=356285

Review URL: https://codereview.chromium.org/964503002

Cr-Commit-Position: refs/heads/master@{#324244}

ContentViewCoreImpl holds a weak reference to the java peer. This means
reference returned by GetJavaObject may be null.

Go through all callers of this API and make sure they correctly handle
null reference.

BUG=469803

Review URL: https://codereview.chromium.org/1067023005

Cr-Commit-Position: refs/heads/master@{#324243}

Review URL: https://codereview.chromium.org/1069413002

Cr-Commit-Position: refs/heads/master@{#324242}

BUG=None
R=ellyjones@chromium.org

Review URL: https://codereview.chromium.org/1068493003

Cr-Commit-Position: refs/heads/master@{#324241}

R=phajdan.jr@chromium.org
BUG=412513

Review URL: https://codereview.chromium.org/1070613002

Cr-Commit-Position: refs/heads/master@{#324240}

BUG=474696

Review URL: https://codereview.chromium.org/1069223002

Cr-Commit-Position: refs/heads/master@{#324239}

This is in addition to the SafeSites histogram.

Also, cleanup some unused histograms in the URL filter.

Review URL: https://codereview.chromium.org/1043113002

Cr-Commit-Position: refs/heads/master@{#324238}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c654e90..05e4aba

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1070743002

Cr-Commit-Position: refs/heads/master@{#324237}

BUG=474727

Review URL: https://codereview.chromium.org/1063233002

Cr-Commit-Position: refs/heads/master@{#324236}

Revert of Disable container overflow check on Linux and Mac. (patchset #2 id:20001 of https://codereview.chromium.org/951083002/)

Reason for revert:
Container overflow is stable on linux, we can safely revert it.

Original issue's description:
> Disable container overflow check on Linux and Mac.
>
> BUG=459632
> TBR=glider@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/6c3ce96dedaf8f23fce9cbd9c5279fe20c531ac6
> Cr-Commit-Position: refs/heads/master@{#317681}

TBR=marcheu@chromium.org,glider@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459632

Review URL: https://codereview.chromium.org/1069793002

Cr-Commit-Position: refs/heads/master@{#324235}

Updates RFHM::CommitPendingIfNecessary to actually commit in a few more
cases and not crash when navigations happen simultaneously.

Also updates RFHM::CommitPending to make some logic clearer.

BUG=376094

Review URL: https://codereview.chromium.org/1036243003

Cr-Commit-Position: refs/heads/master@{#324234}

This refactoring of 'name' to 'tag' is part of tracking the latest spec changes found in https://github.com/slightlyoff/BackgroundSync/pull/74

BUG=474573

Review URL: https://codereview.chromium.org/1068863003

Cr-Commit-Position: refs/heads/master@{#324233}

This enables event tracing in ANGLE via the new APIs. This can
replace the old methods via SetTraceFunctionPointers.

BUG=436191

Review URL: https://codereview.chromium.org/1064163002

Cr-Commit-Position: refs/heads/master@{#324232}

This CL implements a new tool called mb (//tools/mb) that wraps both GYP
and GN to implement the 'gen' and 'analyze' steps on the bots. It
serves three purposes:

1. To move the decision to use GYP or GN to generate the build files to
   a configuration stored in the repo (and to hide it from the bots).
2. To move which flags are used to a configuration stored in the repo,
   so that we can version the flags alongside the code, and change the
   flags without needing to change things in the build repo.
3. To consolidate a list of all of the different build configs we need
   to support and verify for the GYP->GN migration.

For more details on the above, see //tools/md/README.md and the linked
docs.

R=scottmg@chromium.org, brettw@chromium.org
BUG=466436

Review URL: https://codereview.chromium.org/1062613004

Cr-Commit-Position: refs/heads/master@{#324231}

Review URL: https://codereview.chromium.org/1058933002

Cr-Commit-Position: refs/heads/master@{#324230}

This CL introduces the implementation for handling the inter-process
memory dumps on the child-process side.
Conceptually this consists of a simple plumbing in TraceMessageFilter
in order to propagate the request up to the browser's MemoryDumpManager,
as the child processes' MDM play a very passive role in the inter-process
coordination game.
In practice, some extra care is required to match the lifetime of MDM
MDM (long) and ChildTraceMessageFilter (shorter) in a thread-safe
manner, which requires the introduction of the proxy class herein
called ChildMemoryDumpManagerDelegateImpl.

More context and design doc are available in the attached BUG.

Reason for NOTRY: all but one bots are green. I started goo.gl/tBX5f1
on infra-dev about the failure and it seems due to a bot out of space.
The change has been sitting for 4+ hours and there are other CLs blocked
on this.

BUG=462930,474973
NOTRY=true

Review URL: https://codereview.chromium.org/1039963003

Cr-Commit-Position: refs/heads/master@{#324229}

BUG=470453

Review URL: https://codereview.chromium.org/1043173003

Cr-Commit-Position: refs/heads/master@{#324228}

Originally landed here: https://codereview.chromium.org/845373002/
Reverted here: https://codereview.chromium.org/1020863007/
because it caused issues on memory bots.

BUG=287883
TBR=rogerta@chromium.org (already reviewed in original CL, there are no changes here)

Review URL: https://codereview.chromium.org/1038423004

Cr-Commit-Position: refs/heads/master@{#324227}

Collecting the metrics was sometimes causing a crash and has been removed
until the root cause is found.
This is only a partial revert because items are not to be removed from
tools/metrics/histograms/histograms.xml.

BUG=474702

Review URL: https://codereview.chromium.org/1070693002

Cr-Commit-Position: refs/heads/master@{#324226}

Currently some instrumentation tests relating to Battery Status API appear to fail
on Android L devices. This patch contains the fix.

BUG=474637

Review URL: https://codereview.chromium.org/1061303003

Cr-Commit-Position: refs/heads/master@{#324225}

flag that makes chrome default browser, the flag beats Policy. This is wrong
behavior. Thus added the condition that checks policy before set chrome as
a default browser.

BUG=361527

Review URL: https://codereview.chromium.org/927163002

Cr-Commit-Position: refs/heads/master@{#324224}

Review URL: https://codereview.chromium.org/1073433002

Cr-Commit-Position: refs/heads/master@{#324223}

Cr-Commit-Position: refs/heads/master@{#324222}

Extract common code for all login test from SamlTest.
Separate HTML for /embedded/setup/chromeos in fake_gaia.
Updated SAML test to use new GAIA endpoint in webview cases.

BUG=472095
TEST=browser_tests

Review URL: https://codereview.chromium.org/1054403002

Cr-Commit-Position: refs/heads/master@{#324221}

Store an 0-255 alpha value instead of a 0-1 opacity value on the class
since that is what we will use for painting.

R=pkasting

Review URL: https://codereview.chromium.org/1064213002

Cr-Commit-Position: refs/heads/master@{#324220}

ATM there is a recordActionUMA method in devtools_ui_bindings which is
responsible for UMA metrics. However, the method hard-codes the bucket
sizes, which is unfortunate.

The patch introduces new RecordEnumeratedHistogram method which gets
bucket sizes as an argument.

R=dgozman
BUG=468026

Review URL: https://codereview.chromium.org/1056073003

Cr-Commit-Position: refs/heads/master@{#324219}

GaiaCookieServiceManager handles general request types. This is a prerequisite to the GCMS being able to handle ListAccounts requests as part if its queue. Remove the unused single-account LogOut() method, and rework LogOutInternal() method.

Still to do, in future CLs:
- Make the GaiaCookieManagerService independently check for freshness of ExternalCCConnections before executing any MergeSession (every 3 hours?)
- Move all /ListAccounts calls into the GaiaCookieManagerService, and have it publish to all observers when that fails/succeeds
- Move all logic that listens to cookie changes into GCMS, publish a notification when change happens
- Rename the MergeSessionComplete method of the signin_tracker
- Add retry (and backoff) logic for AddAccount calls
- Remove CrOS's direct calls to gaia_auth_fetcher->StartMergeSession

BUG=466799

Review URL: https://codereview.chromium.org/1044933002

Cr-Commit-Position: refs/heads/master@{#324218}

TaskQueue::UpdateWorkQueue had a duplicate call to
MoveReadyDelayedTasksToIncomingQueueLocked.  That's not intended but
benign.  This patch removes it.

BUG=

Review URL: https://codereview.chromium.org/1057993002

Cr-Commit-Position: refs/heads/master@{#324217}

Review URL: https://codereview.chromium.org/1057933002

Cr-Commit-Position: refs/heads/master@{#324216}

This CL does two things;

 * Makes the commit requested test explicitly check that
   a commit only occurs during the impl frame.

 * Adds check for the case where commit is requested by
   can't draw.

This test was extracted from my original CL at
https://codereview.chromium.org/792803008/

BUG=346230

Review URL: https://codereview.chromium.org/1055673005

Cr-Commit-Position: refs/heads/master@{#324215}

The ReadBack response should be notified to the Java Client to make necessary decisions.

BUG=472457

Review URL: https://codereview.chromium.org/1040393002

Cr-Commit-Position: refs/heads/master@{#324214}

WebRTC 8931:8945
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/6f9fcb2..f814f6d

Libjingle 8930:8941
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/e9dbaf8..82bd4f4

TBR=perkj

Review URL: https://codereview.chromium.org/1068173002

Cr-Commit-Position: refs/heads/master@{#324213}

This CL use the multiline attribute only to see if it's multiline or not
and Changes Chromium to treat TextField and TextArea identically.

BUG=471152

Committed: https://crrev.com/7e576157bba19b8918f0ad2e3a43d0171a675155
Cr-Commit-Position: refs/heads/master@{#324189}

Review URL: https://codereview.chromium.org/1046883002

Cr-Commit-Position: refs/heads/master@{#324212}

This CL moves several methods from ProfileSyncService to
sync_driver::SyncService so that they can be called on iOS.

Review URL: https://codereview.chromium.org/1067843002

Cr-Commit-Position: refs/heads/master@{#324211}

The canvas() is now only accessed through the Recorder classes (ie.
PaintRecorder and friends).  Now we can put a DisplayItemList instead
of a Canvas inside PaintContext.

R=piman@chromium.org
BUG=466426

Review URL: https://codereview.chromium.org/1069183002

Cr-Commit-Position: refs/heads/master@{#324210}

BUG=None

Review URL: https://codereview.chromium.org/1050473002

Cr-Commit-Position: refs/heads/master@{#324209}

Also combine the enable/disable flags for blacklist and online check into a single multi-value flag.

BUG=417722

Review URL: https://codereview.chromium.org/698253002

Cr-Commit-Position: refs/heads/master@{#324208}

Revert of Fix mips build error 'undefined reference to dlopen' (patchset #1 id:1 of https://codereview.chromium.org/1056043002/)

Reason for revert:
Speculative revert. The newest v8 roll might fix the problem.

Original issue's description:
> Fix mips build error 'undefined reference to dlopen'
>
> BUG=473473
> TBR=thakis@chromium.org
>
> Committed: https://crrev.com/89311d3481dc434284972239982a426f8e2154e9
> Cr-Commit-Position: refs/heads/master@{#323734}

TBR=carlosk@chromium.org,thakis@chromium.org,pasko@chromium.org,wangxianzhu@chromium.org
BUG=473473

Review URL: https://codereview.chromium.org/1066363002

Cr-Commit-Position: refs/heads/master@{#324207}

and if not, what disabled them: the local setting or domain policy.

BUG=470383

Review URL: https://codereview.chromium.org/1064843003

Cr-Commit-Position: refs/heads/master@{#324206}