- 25 May, 2020 40 commits
-
-
nancylingwang@google.com authored
BUG=1068884 Change-Id: I33f31eeec0f520f0a135c2c70f56b96d6e42a9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203787 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771525}
-
Kim-Anh Tran authored
This adds a webtest to check if we can pause execution in a script compiled using streaming compilation. Bug: chromium:1079328 Change-Id: I68756c333a0ff69294f5bf210b0a6004412ee774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202897 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#771524}
-
Matthias Körber authored
Without this addition, the interpretation of the current metric is hard because it is not post-selected on the presence of a valid ADDRESS_HOME_LINE1 field. Change-Id: Ibdd9a34a80c702729d6abbd188d4174161026b46 Bug: 1083867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206653Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#771523}
-
Saurabh Nijhara authored
This is a follow up CL of https://chromium-review.googlesource.com/c/chromium/src/+/2161072 in which it was recommended to convert the |expected_version| member variable from std::string to base::Version. Bug: 1076376 Change-Id: Iaf49b0374aedbe47127e6c794204adc99853f3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207216Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#771522}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I9728063d5b8144d5bef557580d3a97438995ac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214921 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#771521}
-
Marina Ciocea authored
This reverts commit 769719f1. Reason for revert: Suspect of breaking win-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/14224? Original change's description: > Adding mojolpm fuzzer generators. > > This adds code that generates libprotobuf-mutator based > structure-aware fuzzers as part of the mojom compilation process. > (changes in //mojo). > > This is a cherrypick/split from > https://chromium-review.googlesource.com/c/chromium/src/+/2108507 > > Pragmatic fixes for the remaining missing dependencies. > > Change-Id: I0e0d34a4b99b31f99ee872fb95be993043aef402 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170830 > Commit-Queue: Mark Brand <markbrand@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#771513} TBR=rockot@google.com,markbrand@google.com Change-Id: I15ea11fbc72b9e2a804ca8c49be12f89d4c465a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213566Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#771520}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590378757-0e86ea9817fe6c644c14c0cd7e1701a48ebcda53.profdata to chrome-mac-master-1590392885-f817e2f6c6f861a55dc86221cdd5b022c49b4b4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I364be619f6aa2009ae25085338fdbb80a2f00c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771519}
-
Fredrik Söderqvist authored
Everything that accesses SVGAnimatedEnumeration<Enum> will read the current enum value, so cut directly to the chase instead and drop the unnecessary CurrentValue/BaseValue overloads. Change-Id: Ib7b56ae106ca6531e461e3b47973782112860ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207450Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#771518}
-
Dale Curtis authored
Changing the buffer size when streams are active appears unsafe, so avoid increasing it. Future stream creation will still use a lower buffer size where possible. I'd expect this use case to be rare. R=henrika Bug: 880261 Test: None. Change-Id: I5fb857da5ae31b3d90df90dd784f90c9511264e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208295 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#771517}
-
Morten Stenshorne authored
This is the final missing piece for bug 1053768, which is about adding support for named pages and page orientation, so that an author can specify that certain pages should be rotated clockwise or counter-clockwise, without affecting layout. The effect of the rotation will only be observable in print preview, and when saving the paginated layout to file (typically PDF). The page-orientation descriptor is defined here: https://drafts.csswg.org/css-page-3/#page-orientation-prop Test: third_party/blink/web_tests/printing/page-orientation.html Bug: 1053768 Change-Id: I7f7b67b322592c1e90305c88a2088a567247b044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206633 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#771516}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. The use of the function in c/b/profiles tests is updated. Bug: 1060940 Change-Id: I168e48fac82eec6dc968a15818412c5eceaeb352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213564Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#771515}
-
Alexey Baskakov authored
A callback code may call Write() on `this` database immediately in the callback. Since previous fix was reverted, https://chromium-review.googlesource.com/c/chromium/src/+/2213648 let's start with a more simple synchronous fix. We will investigate that test on Mac separately. TBR=ericwilligers@chromium.org Bug: 1084939 Change-Id: I6561789f226384e724940bc9bf024d6969c719ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213650Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#771514}
-
Mark Brand authored
This adds code that generates libprotobuf-mutator based structure-aware fuzzers as part of the mojom compilation process. (changes in //mojo). This is a cherrypick/split from https://chromium-review.googlesource.com/c/chromium/src/+/2108507 Pragmatic fixes for the remaining missing dependencies. Change-Id: I0e0d34a4b99b31f99ee872fb95be993043aef402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170830 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#771513}
-
Dominic Mazzoni authored
It flaked on Mac due to slightly more than 0.01% of pixels in the page already having the focus highlight color. I updated the numbers to be more robust, with more margin for deviations that will still allow it to pass. By making the input element taller, that means more pixels get the focus highlight color. Bug: 1083806, 1021939 Change-Id: I34787ab08eedaaba9dde2cc960b0ab948e711a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209683 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#771512}
-
Anders Hartvoll Ruud authored
Bug: 1057072 Change-Id: I3323687393ac07a05cc14f39b3076e66d8ba49d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207169 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#771511}
-
Alexey Baskakov authored
NotifyOnAllAppWindowsClosed API should not cause notifications before Start or after Shutdown. Bug: 1084939 Change-Id: I18b1299bd0cc1115a7024bd6ac8fc37a02a3e30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214459Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ifbdfc9b74eda975d5ef1547d07dfe1999cd64e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212228Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#771509}
-
Hitoshi Yoshida authored
Some IDL dictionaries have to receive v8::Isolate to instantiate ScriptValue type members with null default values. This CL defines constructors and Create methods to accept v8::Isolate to make them consistent, and disabled default constructors and Create() for dictionaries which need an isolate. Bug: 839389, 1070964 Change-Id: I5ea2533b5987af707a354b58151a343b5dea1e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203244Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#771508}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/340fee5c8499..ebf28a80ca38 2020-05-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 96a80283cc0f to c746ac65e9d6 (5 revisions) 2020-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f1735ff5 to 10bf4a61 (177 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ib573fff781c8803db4062f4043937bad0ac580b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214696Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ca48df80a7b..471dd7ffcd7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yhirano@google.com Change-Id: I3446daaab419f3db68b94b48c670275728162622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214692Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771506}
-
Julian Watson authored
Bug: 1049453 Change-Id: I9df2aa516105e8f4aa230c4f9f62f9002bda8f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208801 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#771505}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af8825a827c4..3b84585447f1 2020-05-25 bmeurer@chromium.org [wasmparser] Update wasmparser to 0.14.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifba3135c9c7a6bda9177dea0e56e28568e480ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214697Reviewed-by:
-
Miriam Polzer authored
Currently, chrome deals with powerwash after an update (e.g. on channel downgrade) itself, from computing whether it should happen, to actually issuing a powerwash which is never executed because the update engine takes care of it. After this change and the corresponding changes in the update engine, chrome will rely on the update engine sending a flag indicating whether a powerwash will happen after the update. The system notifications will be addressed in a separate CL because adapting the code there also requires properly dealing with the rollback flag. Depends on https://crrev.com/c/2187672 Bug: 2187671 Change-Id: I2aa7024fb7978c21e6396e366f9876d42a72e873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187635 Commit-Queue: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#771503}
-
Noel Gordon authored
CL:2210194 updated <cr-toast> own deps, so no need our files app BUILD to interpolate <cr-toast> internal deps anymore. Remove the TODO. Tbr: adanilo Bug: 1002391,1033660 Change-Id: I50022f87ba14843a4e46b8c0088e7d7d922143a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213649Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771502}
-
tby authored
This CL sets up the MVP version of settings result ranking. We: - Show at most two results - Which are glued to the top of the launcher - But show no results for single-character queries. To avoid confusion, I've removed the max results constant from the search controller factory, and replaced it with a 'generic max results' version. This generic version is necessary for now because a value for max results is mandatory, but we're moving away from needing it. Bug: 1068851 Change-Id: I188324413dd120d6f8abbf1b0a8791d4fcaac0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214583 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771501}
-
James Cook authored
SingleClientStandaloneTransportSyncTest needs to include WEB_APPS in its list of OS transport-mode types. sync_integration_tests --enable-features=SplitSettingsSync passes after this change. This CL is in preparation to turn SplitSettingsSync on by default. Bug: 1060289 Change-Id: I7662ba9a4ac529db18ba8887eeebe6f4023a53f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211044 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#771500}
-
Koji Ishii authored
This patch adds |WritingMode| and |TextDirection| as members of |NGFragmentItemsBuilder|. The current code has problems if different |WritingMode| and |TextDirection| are given to, say, |Items| and |ToFragmentItems|. Giving them at the constructor can avoid such inconsistencies. This also allows delaying construction of |NGFragmentItem|, which is part of the performance work. Bug: 982194 Change-Id: If49c41d7ad0d65ac083d8fc58793128d2ed28616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212229Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771499}
-
Yoshifumi Inoue authored
This patch gets rid of useless "highlight.html" and expected images for ease of maintenance and help to implementing EditingNG. "highlight.html" was introduced for testing "-webkit-highlight" CSS property but this property is no longer used. This property is parsed and store in |ComputedStyle| but layout and paint don't refer it. Note: WebKit removed "-webkit-highlight" on 2014[1]. [1] https://bugs.webkit.org/show_bug.cgi?id=128456 Bug: 707656, 1086089 Change-Id: I945221634e0176123aee3677b1b3e9da711d0021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214801 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771498}
-
Koji Ishii authored
As part of the work to update |TextMetrics::Update| for issue 1010893, the call to |Font::BoundingBox| turned out to be unnecessary: * |Width()| is the sum of advances, which is already comptued as |real_width|. * |Y()| and |MaxY()| are the same as |glyph_bounds|, except that |Font::BoundingBox| clamps them to 0. This patch replaces the call to |Font::BoundingBox| with the equivalent, already computed values. This is to help supporting bidi in |TextMetrics::Update|. WIP: https://crbug.com/c/2196086 but also reduces call to CachingWordShaper and improves the performance. Note that the clamping behavior is not copied. It is most likely unintentional and unlikely to cause compat problems. Currently, this function is the only caller of |Font::BoundingBox|. We can remove it once this change is stabilized. Bug: 1010893 Change-Id: I79d255e1a308e5da501e65a95981c6f13148a57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196624Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771497}
-
Yutaka Hirano authored
- no-secure-context.html failures are platform independent. Unify the entries and associate it to an appropriate crbug issue. - javascript.https.html is no longer failing. - coep-frame-javascript.https.html is no longer failing. - require-corp.https.html is (sadly) flaky on both Debug and Release. Unify the entries. Bug: 1086066, 1015187, 1013523, 626703, 1086065 Change-Id: I016579257bf3175a08755ee34bd8c911eeeb1d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212120 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771496}
-
Yoshifumi Inoue authored
This patch changes "format-block-with-trailing-br.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I386ca10eb56a820cf9b7e2ee140016ab17043733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214458 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Make sure that ManifestUpdateManager doesn't cause FinalizeUpdate while web apps system is not ready. Note: we should do tasks_.clear(); in Shutdown to destroy all ManifestUpdateTasks. That's how we unsubscribe tasks from WebAppUiManagerImpl: void ManifestUpdateTask::UpdateAfterWindowsClose() { ... ui_manager_.NotifyOnAllAppWindowsClosed( app_id_, base::BindOnce(&ManifestUpdateTask::OnAllAppWindowsClosed, AsWeakPtr())); } In next CL: Plumb WebAppUiManagerImpl Startup/Shutdown. Bug: 1084939 Change-Id: I25112df44af57606e38bcc6c12f12f67bd94c8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212197 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: -
Yoshifumi Inoue authored
This patch changes "5065910.html" to utilize |selection_test()| and renames to "justify_block_starts_with_image.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ic22aa13b2da5c6dbcc0657d742c79bd4ffe37a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213646 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Julian Watson authored
Bug: 778674 Test: autoninja -C out/Release ui/file_manager:closure_compile Test: autoninja -C out/Release browser_tests && out/Release/browser_tests --gtest_filter=*/FilesApp* Change-Id: I1a9e532afc0122a78328eae857e0dbf34971fcbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212015 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#771492}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ibf4e509a959108ddee42bef7233a0436ee7376cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192574 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#771491}
-
Mason Freed authored
This CL is the result of the following mechanical replacements, within the third_party/blink/web_tests folder, on only .html and .js files: '.createShadowRoot()' -> '.attachShadow({mode: 'open'})' 'document.createElement('content')' -> 'document.createElement('span')' Several web_tests did not pass after the above replacements were made. Those tests were reverted - the changes in this CL are only the tests that pass in the same way that they did prior to the replacements. The only exceptions, which were re-baselined here, had *only* a console warning message like this, which is now missing: CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M80, around February 2020. Please use... In addition, most of the same test expectations files were completely removed from the virtual/web-components-v0-disabled folder, since these tests no longer depend on WCv0 features, and no longer fail. One exception is this one: fast/dom/shadow/disconnected-distribution-cycle-expected.txt which still uses getDestinationInsertionPoints() and so breaks differently now. Bug: 937746 Change-Id: I03c0f834c82bac79e48eb0ddd419c9351b61b455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208386 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: -
Koji Ishii authored
Because |NGLogicalLineItem| can live longer than |NGInlineItemResult|, the pointer may become stale. Instead, this patch changes |NGLogicalLineItem| to copy necessary data from |NGInlineItemResult|. This is to prepare for vectorizing |NGFragmentItem|, by allowing to defer creating |NGFragmentItem| to after |NGInlineItemResult| is destroyed. This patch has no behavior changes. Bug: 982194 Change-Id: Idfad9fe4d4421ddd76b2348e6c17e50e327911a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212187Reviewed-by:
-
Kenichi Ishibashi authored
This CL starts using ServiceWorkerStorageControl in ServiceWorkerRegistry. For now, an instance of ServiceWorkerStorageControl is owned by ServiceWorkerRegistry as a drop-in replacement of ServiceWorkerStorage. Eventually the instance will live in the Storage Service once all ServiceWorkerStorage method calls are migrated into mojo methods. This CL only replaces UpdateLastUpdateCheckTime() call. Subsequent CLs will replace more ServiceWorkerStorage method calls. According to android-binary-size trybot, this increases the binary sizes by ~37kb. Most of the increase (~29kb) comes from mojo generated code and there isn't much we can do to reduce them. Introducing this mojo interface is necessary for migrating ServiceWorkerStroage to the storage service. See the design doc [1] for the motivation and plans. [1] https://docs.google.com/document/d/1hO0WEuoEOgEBlf5nDE3fDjuQY2bV_d5hLtk25iBo0LM/edit?usp=sharing Bug: 1055677 Binary-Size: Size increase is unavoidable (see above) Change-Id: Ic843e25f3556249b67252f52e9e16428ec488dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214582 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#771488}
-
Hajime Hoshi authored
This CL adds methods to WebPerformance to record the latest timing when the page is restored from the back-forward cache and the latest timing of first-paint event after restoring. This CL is a preparation to record first-paint event for back-forward cache at PageLoadMetricsObserver. Bug: 1014174 Change-Id: Ie0bd0e1cbfc070867a75b2574f05ad0797934875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210181 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes font-family-with-space.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I1dc4ec92ce7aeb3b095f9854a2a1699bb3fa9dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212196 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
