- 03 Dec, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6f862e54f2a0..4f870714be35 git log 6f862e54f2a0..4f870714be35 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 eakuefner@chromium.org Remove myself from Catapult OWNERS files Created with: gclient setdep -r src/third_party/catapult@4f870714be35 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7f0d3f008fd225286bb2aac02810a6ec37e014e0 Reviewed-on: https://chromium-review.googlesource.com/c/1358752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613144}
-
Scott Violet authored
All classes in chrome now have Client in the name. Additionally the suffix ChromeOS has been removed to Impl. BUG=875111 TEST=covered by tests Change-Id: I5f41beeb10fa14e54fe5ce911c4b4782dd9f0830 Reviewed-on: https://chromium-review.googlesource.com/c/1355767Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#613143}
-
Alexandr Ilin authored
TBR: bsheedy@chromium.org Bug: 911144 Change-Id: I924a28122faa58c8719d65871e947e8c96fe373a Reviewed-on: https://chromium-review.googlesource.com/c/1358460Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613142}
-
Evan Stade authored
- ArcVoiceInteractionFrameworkServiceTest.CapturingScreenshotBlocksIncognitoWindows Bug: 905430 Change-Id: If332da0d0abcd722a82a51c9a84bc39d2c0735e3 Reviewed-on: https://chromium-review.googlesource.com/c/1354678Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#613141}
-
edchin authored
This CL inverts the relationship between |currentBVC| and |currentBrowserCoordinator|. This CL makes |currentBrowserCoordinator| the source of truth, and |currentBVC| simply returns the corresponding BVC. Change-Id: Ibdcb79ca3f6fb2f3c2d8cecae1be036c58962dae Reviewed-on: https://chromium-review.googlesource.com/c/1355995Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613140}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=dnicoara@chromium.org Bug: 903957 Change-Id: Ie052b76a8c8c4083857f9deb5d46eb03e1cb15e6 Reviewed-on: https://chromium-review.googlesource.com/c/1338482 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#613139}
-
John Abd-El-Malek authored
Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled. Reland after the revert by disabling the test when network service is enabled. TBR=cudvall@chromium.org Bug: 837753 Change-Id: I2f96b37fa9f2773799a6f9e23df9196d0abc74fe Reviewed-on: https://chromium-review.googlesource.com/c/1358968Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#613138}
-
Yao Xiao authored
Implements the feature while keeping it disabled. Will follow the Intent to Implement/Ship process to enable it. Bug: 539938 Change-Id: I83ef89691e5977717cdcf2c9a121177e5de52ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1336493Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#613137}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/67b2e1555ab6..b9f9a3bc9f36 git log 67b2e1555ab6..b9f9a3bc9f36 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 zoddicus@users.noreply.github.com Add WebGPU Execution scope check (#2148) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b9f9a3bc9f36 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib45fe789006563934062b323bcc4edd89212f5b6 Reviewed-on: https://chromium-review.googlesource.com/c/1358798Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I5d914cd64396fbc0cd3d6610981f50f8ffc0b31e Reviewed-on: https://chromium-review.googlesource.com/c/1352263Reviewed-by:
-
Allen Bauer authored
Change-Id: Id7f4268b5d37803a03a987840e79c79a6a7332e4 Reviewed-on: https://chromium-review.googlesource.com/c/1347610 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#613134}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9ca9435087e0..d758e32610cb git log 9ca9435087e0..d758e32610cb --date=short --no-merges --format='%ad %ae %s' 2018-12-03 senorblanco@chromium.org Add some missing #includes. 2018-12-03 cwallez@chromium.org Vulkan: Handle errors on device creation. 2018-12-03 cwallez@chromium.org Suppress tests failing on GPU FYI Mac Pro (AMD) Created with: gclient setdep -r src/third_party/dawn@d758e32610cb The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I28436d61fcdeb57c6eb934d075fe424bb4c0c954 Reviewed-on: https://chromium-review.googlesource.com/c/1358794Reviewed-by:
-
Carlos Caballero authored
This will enable us to start trialing the MessageLoop replacement by SequenceManager. We only do this in the Blink main thread for now. There is some work needed around SequenceManager ownership to be done before this can be enabled in worker threads. Original change https://chromium-review.googlesource.com/c/1349316 TBR=dcheng@chromium.org Bug: 891670 Change-Id: I68a59ec2d780106bb5fd76cee5976e236f9316f6 Reviewed-on: https://chromium-review.googlesource.com/c/1358452 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#613132}
-
Kush Sinha authored
Bug: 820046 Change-Id: I01bc0f92f4c81ec314e4f775593c7bacf4213183 Reviewed-on: https://chromium-review.googlesource.com/c/1348065Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#613131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6305f38b584..b13658891bbd git log e6305f38b584..b13658891bbd --date=short --no-merges --format='%ad %ae %s' 2018-12-03 michaelludwig@google.com Revert "Send max coverage limit for subpixel rects" 2018-12-03 egdaniel@google.com Revert "Add support for Ycbcr Conversion Samplers in vulkan." 2018-12-03 egdaniel@google.com Add support for Ycbcr Conversion Samplers in vulkan. 2018-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4abdf74f0afc..35cd7332ab62 (1 commits) 2018-12-03 brianosman@google.com Revert "Share GP implementation between GrFillRectOp and GrTextureOp" 2018-12-03 caryclark@skia.org add breaktext doc skeleton 2018-12-03 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-12-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-12-03 reed@google.com breakText on font 2018-12-02 reed@google.com start to use font for measure, not paint 2018-12-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2018-12-02 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-12-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-12-01 reed@google.com don't trust convexity after a transform 2018-12-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-12-01 fmalita@chromium.org [skottie] Expose composition markers to embedders 2018-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 317a9ebdb019..4abdf74f0afc (2 commits) 2018-11-30 bsalomon@google.com Fix occurrences of "-Wextra-semi-stmt" 2018-11-30 reed@google.com experimental alternative isconvex 2018-11-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bffee5e5454c..bd49ad09c5ca (1 commits) 2018-11-30 bungeman@google.com Remove FontScalerTest sample. 2018-11-30 halcanary@google.com SkQP: doc simplify, make_apk_list to python, upload_apk tool 2018-11-30 michaelludwig@google.com Share GP implementation between GrFillRectOp and GrTextureOp 2018-11-30 michaelludwig@google.com Send max coverage limit for subpixel rects 2018-11-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d46faeb43287..bffee5e5454c (1 commits) 2018-11-30 bungeman@google.com Set mac windows to their current size. 2018-11-30 kjlubick@google.com [canvaskit] Save a copy on CPU backend by using RasterDirect 2018-11-30 bsalomon@google.com Uninstantiate proxies when not explicitly allocating 2018-11-30 herb@google.com Expand handling of empty glyphs to SDF and Path cases 2018-11-30 bungeman@google.com Fix new clang warning around shadowing. 2018-11-30 kjlubick@google.com [canvaskit] Fix conversion of large images to base64 2018-11-30 halcanary@google.com SkQP: refatctor C++ bits. 2018-11-30 herb@google.com Make SkGlyph::PathData own the path 2018-11-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b51eb09fb5bb..317a9ebdb019 (1 commits) 2018-11-30 egdaniel@google.com Add blacklist for intel 405 vulkan perf bot. 2018-11-30 herb@google.com Make path position handling consistant with SDF 2018-11-30 brianosman@google.com Add SkEncodedOrigin to SkYUVASizeInfo, fix JPEG orientation in GPU decode path 2018-11-30 reed@google.com update docs around fonthinting 2018-11-30 kjlubick@google.com [canvaskit] Add gradients and clips 2018-11-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8dc27f99b556..b51eb09fb5bb (5 commits) 2018-11-30 reed@google.com remove SK_SUPPORT_LEGACY_NESTED_HINTINGENUM code 2018-11-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a972758d6e10..d46faeb43287 (1 commits) 2018-11-29 brianosman@google.com Remove the lines-only "optimization" from AA convex path renderer 2018-11-29 hcm@google.com Update Skia milestone to 73 2018-11-29 csmartdalton@google.com Draw ovals with GrAAFillRRectOp 2018-11-29 brianosman@google.com In GrOpFlushState, store GrOp* rather than Unique ID 2018-11-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 7310da33bc7a..8dc27f99b556 (5 commits) 2018-11-29 benjaminwagner@google.com Add jobs for GalaxyS9 2018-11-29 bsalomon@google.com Modify workaround to never set base or max texture level for GL_TEXTURE_EXTERNAL_OES 2018-11-29 jvanverth@google.com Check for valid normals when offsetting 2018-11-29 michaelludwig@google.com Bugfixes for corner cases in per-edge AA 2018-11-29 mtklein@google.com check decal in 32.32 where we walk decal in 32.32 2018-11-29 caryclark@skia.org Update bookmaker 2018-11-29 fmalita@chromium.org [skottie] Expose property bindings in CK 2018-11-29 bsalomon@google.com Revert "Experimentally disable GrTextureOp chaining on Intel GPUs on Mac." 2018-11-29 caryclark@skia.org fix fuzz timeout in pathops 2018-11-29 mtklein@google.com clean up SK_WALK_DECAL_IN_1616 2018-11-29 reed@google.com remove textblobbuilder guard Created with: gclient setdep -r src/third_party/skia@b13658891bbd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899689,chromium:905337,chromium:908566,chromium:906453,chromium:910097 TBR=jcgregorio@chromium.org Change-Id: I5cfcadca44e3a695285931eabc243b9fd0599dc9 Reviewed-on: https://chromium-review.googlesource.com/c/1358793Reviewed-by:
-
Nico Weber authored
Compiles shouldn't shell out to non-clang processes, and we know that clang doesn't read DEVELOPER_DIR, so this shouldn't be needed. Bug: 780980 Change-Id: I811786f567c517aee9a82867336da7b2adb3bf44 Reviewed-on: https://chromium-review.googlesource.com/c/1358698Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613129}
-
Javier Ernesto Flores Robles authored
View was being hidden on prepare to reuse only, causing it to be shown the first time the cell was used. Bug: 845472, 911148 Change-Id: Ic59d5de5f476c7e499d40a244ef1291e4ccd3bfa Reviewed-on: https://chromium-review.googlesource.com/c/1358447 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613128}
-
Mikel Astiz authored
FakeServer/LoopbackServer is extended with logic that mimics what real servers do, in order to verify what contributes to synced history. This functionality is leveraged to add proper integration test coverage for various relevant scenarios to history sync, starting with the simplest, to more advanced including closed tabs. This approach is expected to fix some flakes we've observed in recent attempts to land tests, because it doesn't suffer from server-side session entities potentially being overwritten by newly open tabs. Bug: 882489,910947 Change-Id: I4a69fa080e3deacc8d33c64de17f964c34436ea3 Reviewed-on: https://chromium-review.googlesource.com/c/1356811 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#613127}
-
Dominik Röttsches authored
Previously reviewed in: https://chromium-review.googlesource.com/c/chromium/src/+/1353927 Reverted in: https://chromium-review.googlesource.com/c/chromium/src/+/1354411 Enable unit-test, but only for Mac OS 10.13 and above due to fonts before this version not supporting small-caps. Shaping code relies on feature detection to determine whether the font has small-caps support or not. If not, small capitals are synthesized from uppercased letters with scaled-down font size. Add feature detection for AAT fonts on Mac. Now the shaping code can enable the built-in small-caps glyphs for a set of system font that have them. Tests: open_type_caps_support_test.cc unit test for feature detection, fast/text/small-caps-aat.html layout test. Bug: 900955 Change-Id: I354eea0c0d7e5fec40b508df85708933d2c0e06a Reviewed-on: https://chromium-review.googlesource.com/c/1355168 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#613126}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0db3a5a14cd7..5199b83eef8b Created with: gclient setdep -r src-internal@5199b83eef8b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib42d8cca54f0757a509aff8eafcd8357aca2fa33 Reviewed-on: https://chromium-review.googlesource.com/c/1358796Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613125}
-
Kevin McNee authored
We currently leave the last touchscreen gesture target in |touchscreen_gesture_target_| and only overwrite it upon the next touchscreen gesture. This is a problem if the user switches from using a touchscreen to another input device, since the scroll bubbling logic will believe that there is an ongoing touchscreen gesture and drop any attempts to bubble scroll to this target. We now clear the target at the end of a touchscreen gesture (more specifically, after dispatching a gesture event which indicates the lift of the last finger). Bug: 865151 Change-Id: I8fddc1ac9c36ebf9b84a59b1304784188c46f142 Reviewed-on: https://chromium-review.googlesource.com/c/1351744Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#613124}
-
Javier Ernesto Flores Robles authored
Improves metrics by preventing sending an empty metric on start. Adds a nice loading cell while the passwords are fetched. Removes a race condition when "All passwords" was open while loading. Bug: 878388, 911086 Change-Id: If87dc51ee360af32de5bb5539d88bb5926dbfb63 Reviewed-on: https://chromium-review.googlesource.com/c/1356552 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Olivier Robin authored
Use ObjCCast instead of static_cast. Bug: 911136 Change-Id: I48b64dac72a4fea977ff86cf9d490659f2625476 Reviewed-on: https://chromium-review.googlesource.com/c/1358448Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613122}
-
Emircan Uysaler authored
This reverts commit 6e62467b as PS#1. Landing these interface changes will unblock WebRTC for changing the codec factory interfaces and allow us to do further work on supporting VP9 profile 2 HW codec on Chromium side. In PS#2, it makes the changes that will make sure we have a 1-to-2 mapping between media::BASELINE to webrtc::CONSTRAINED_BASELINE and webrtc::BASELINE profiles. This is a temporary workaround until https://crbug.com/345569 is solved. We don't expect to hit the earlier regressions that caused this to be reverted with this mapping. Bug: 908945,webrtc:7925 Change-Id: I93e408f8bd0ff0987d3f4c374132433a9ccdc0c6 Reviewed-on: https://chromium-review.googlesource.com/c/1351108Reviewed-by:
Magnus Jedvert <magjed@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613121}
-
Paul Meyer authored
Due to some privacy concerns that were raised (see bug comment #8), this patch removes crash IDs from Reporting API crash reports. The changes to spec are here: https://github.com/w3c/reporting/pull/136 Bug: 898860 Change-Id: I4085cb837c6b904d4ea1b32a6dd0930d507bb760 Reviewed-on: https://chromium-review.googlesource.com/c/1354229Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#613120}
-
Guido Urdaneta authored
Revert "Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled." This reverts commit 56a58d7d. Reason for revert: FindIt determined that this CL makes ConditionalCacheDeletionHelperBrowserTest.TimeAndURL flaky. FindIt's analysis looks correct. Sample failed run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29/45771 Sample logs: ../../content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc(107): error: Value of: TestCacheEntry(url) Actual: true Expected: false Stack trace: Backtrace: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00000001409F75B7+87] testing::internal::AssertHelper::operator= [0x00000001409F713E+78] content::ConditionalCacheDeletionHelperBrowserTest::CompareRemainingKeys [0x000000013FD458FE+510] content::ConditionalCacheDeletionHelperBrowserTest_TimeAndURL_Test::RunTestOnMainThread [0x000000013FD4634A+2410] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0000000141C5413D+445] content::ShellBrowserMainParts::PreMainMessageLoopRun [0x0000000142564E24+68] content::BrowserMainLoop::PreMainMessageLoopRun [0x0000000140CD4D3E+62] content::StartupTaskRunner::RunAllTasksNow [0x00000001410129BB+43] content::BrowserMainLoop::CreateStartupTasks [0x0000000140CD3B67+599] content::BrowserMainRunnerImpl::Initialize [0x0000000140CD6EDB+107] ShellBrowserMain [0x00000001447B04B5+21] content::ShellMainDelegate::RunProcess [0x00000001447AED2C+188] content::RunBrowserProcessMain [0x0000000140C020E9+89] content::ContentMainRunnerImpl::RunServiceManager [0x0000000140C02A1B+219] content::ContentMainRunnerImpl::Run [0x0000000140C0290E+238] service_manager::Main [0x00000001421C591A+554] content::ContentMain [0x0000000140C0202E+62] content::BrowserTestBase::SetUp [0x0000000141C53E44+1796] Original change's description: > Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled. > > Bug: 837753 > Change-Id: I35b75299bcea1cc2b93a3c47dcbea036cc4e2d03 > Reviewed-on: https://chromium-review.googlesource.com/c/1357567 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612858} TBR=jam@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 910891 Change-Id: I541e21663a02cdedae6aa4991d5e8633890ffbbd Reviewed-on: https://chromium-review.googlesource.com/c/1356946 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#613119}
-
Emily Hanley authored
Bug: 909752 Change-Id: Ic3556b4a2a4e403ab7c1ec4eacb1ada85b392668 Reviewed-on: https://chromium-review.googlesource.com/c/1355199Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#613118}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4c4627d5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ib6d6f06a0ba9db4185da65b601c1859648b79e42 Reviewed-on: https://chromium-review.googlesource.com/c/1357707 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613117}
-
Guido Urdaneta authored
This test is flaky on ChromeOS. Bug: 910834 Change-Id: I5cf214ce90aca8aafc623b526415516f52a46544 TBR: hanxi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1358461Reviewed-by:
-
Robert Flack authored
The test WizardControllerDeviceStateExplicitRequirement/WizardControllerDeviceStateExplicitRequirementTest.ControlFlowForcedReEnrollment has regularly timed out on the Linux Chromium OS ASan LSan Tests bot. TBR=pmarko@chromium.org Bug: 911154 Change-Id: I19f63abde5cc0522ae75cdfa6e53da56c0622da8 Reviewed-on: https://chromium-review.googlesource.com/c/1358797Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613115}
-
bungeman authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/e0307de818ad..000d4b128eba $ git log e0307de81..000d4b128 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 behdad Make shaper's override_features() override user features as well 2018-11-29 behdad [khmer] Move 'clig' to overrides 2018-11-29 behdad Fix "typename outside template" issues 2018-11-29 behdad 2.2.0 2018-11-29 behdad [icu] Minor 2018-11-27 vichang Replace @Deprecated ICU API - USCRIPT_CODE_LIMIT Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org Force 'paste' in the roll script read from stdin with '-' to work on Mac. This fixes the issue https://bugzilla.mozilla.org/show_bug.cgi?id=1458053 in Blink. Change-Id: I56cea6cf9f1e968f850ba9ae37f89aced2a5ac18 Reviewed-on: https://chromium-review.googlesource.com/c/1357337Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#613114}
-
Greg Thompson authored
- Log when the test waits for chrome.exe processes to exit. - Wait until after chrome processes are gone before emitting their log. - Emit chrome's log when the User Data dir cannot be deleted. BUG=907979 R=rogerta@chromium.org Change-Id: I3d142f4e3d23f79e67c367bee6b7477e66744a35 Reviewed-on: https://chromium-review.googlesource.com/c/1354452Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#613113}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9cf6ce3e1bb3..aa3d8ad71b9d git log 9cf6ce3e1bb3..aa3d8ad71b9d --date=short --no-merges --format='%ad %ae %s' 2018-12-03 eladalon@webrtc.org Reland "Fix output period in RtcEventLogImpl" 2018-12-03 eladalon@webrtc.org Fix race over RtcEventLogImpl::task_queue_ 2018-12-03 henrika@webrtc.org Speculative revert due to a long history of issues related to VP9 on Mac. Created with: gclient setdep -r src/third_party/webrtc@aa3d8ad71b9d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2228ae29bbc0df7f026dc5692107cc1b0efb4535 Reviewed-on: https://chromium-review.googlesource.com/c/1358751Reviewed-by:
-
Avi Drissman authored
BUG=556939 Change-Id: I0bb5e64f47203e3f71f0bf8eef8eaa6c449ad7b0 Reviewed-on: https://chromium-review.googlesource.com/c/1357552 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613111}
-
Bence Béky authored
Change type of HttpNetworkSession::websocket_endpoint_lock_manager_ from unique_ptr<WebSocketEndpointLockManager> to WebSocketEndpointLockManager. This member object is constructed upon HttpNetworkSession construction and is never explicitly destroyed (only implicitly when the unique_ptr goes out of scope upon HttpNetworkSession destruction). The same lifetime can be achieved with a WebSocketEndpointLockManager member. It is possible though not particularily likely that this will solve https://crbug.com/908734, but since the cause of that crash is not known, it is worth trying. This CL is an improvement regardless. Bug: 908734 Change-Id: Iddd2117dc5256e06672ae2964ad7cfebefe76fe0 Reviewed-on: https://chromium-review.googlesource.com/c/1356862Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#613110}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I868d222e9f7136c82a1225214f7d4f25652fa083 Reviewed-on: https://chromium-review.googlesource.com/c/1352364Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#613109}
-
Guido Urdaneta authored
Bug: 910869 Change-Id: I34cde842fdf16d85d563b20645039ffa0a53129a TBR: tedchoc@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1358440Reviewed-by:
-
bsheedy authored
Switches all VR instrumentation tests for scrolling using the Daydream controller to use the Chrome-side controller mock instead of the VrCore-side emulation via intents. The latter has always been somewhat flaky, so this should help reduce VR test flakiness. Bug: 902938 Change-Id: I560cda2129357c49bdfa3d095836e6ebd1b23da8 Reviewed-on: https://chromium-review.googlesource.com/c/1341061Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#613107}
-
Dan Harrington authored
See bug for more information about the problem, and solution. This was manually tested. Bug: 910458 Change-Id: I663a1354f12a917c478144530311b31e4bd1657f Reviewed-on: https://chromium-review.googlesource.com/c/1357520Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#613106}
-
Sidney San Martín authored
Effectively changes three things from r612882: 1. Reverts the checks in OnTextSelectionChanged(). This drops DumpWithoutCrashing(), which was louder than intended, and avoids potentially changing non-Touch Bar behavior. 2. Preserves the new behavior of ignoring an invalid selection instead of clearing the existing suggestions by removing the selection-clearing code. 3. Adds a bounds check that was removed in (1) into Touch Bar code. Bug: 893038, 910950 Change-Id: I6fdb30a71ce64680fb06ce73072c9171da36da32 Reviewed-on: https://chromium-review.googlesource.com/c/1358695Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613105}
-
