- 20 Mar, 2020 40 commits
-
-
John Palmer authored
There was a small cut and paste mistake in the earlier CL. Also, actually make the feature available for the keyboard to query. Bug: 1046641 Change-Id: I9f4abdf48e0436b2f4feb7f56b4c5cf3e68f86b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105672 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751903}
-
Alex Gough authored
Confines the sharing service WebRTC helper in the union of utility and renderer sandboxes. Windows:- Adds win32k lockdown. Adds dynamic code disable. Linux:- Utility style seccomp with some calls removed. Mac:- Shortcuts to utility. Testing:- Manual test on each platform of large remote clipboard copy to/from unmodified Canary with all sharing flags enabled. Bug: 1045590 Change-Id: I72c1270c7db0dcce9e532ac97ad756fd22970574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051405Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#751902}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ia715033aac447cd09ac11520d9c7c636e06a8b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111773 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#751901}
-
Frank Liberato authored
This CL adds |disable_dxva_video_decoder|, which turns off the DXVA VDA. In addition to refusing to instantiate one if the workaround is enabled, it also removes it from SupportedConfigs so that the renderer shouldn't bother to try. This CL also makes the D3D11VideoDecoder SupportedConfigs only show up if the decoder is enabled, so that the renderer doesn't try to instaniate one that will fail anyway. Bug: 625785 Change-Id: Ie9323049ce4263ea450127557e7ce20fec8e5625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106892Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#751900}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: I9a155e796d3fd7cda5b569f90b9aff45678c8083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109314Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751899}
-
Ahmed authored
This test verifies that when an editable element is focused within the page, top-chrome is forced-shown and is kept so until the element is blurred. The implementation of this behavior used the deprecated NotificationService for which we have now a replacement call in WebContentsObserver. This CL removes the use of the deprecated code. The flakiness in the test was due to a timing issue. In the cases when the test fails, I found that the generated fling events, cause gesture scrolling to be set to start and stop immediately in succession without generating any calls from the renderer to the browser to set the shown ratios. This was fixed by giving those events a chance to propagate, by waiting for at least 2 render frame submissions before generating the next one. With this fix, I ran the test with --gtest_repeat=40 and all instances passed. BUG=1049178 TEST=browser_tests --gtest_filter=TopControlsSlideControllerTest.*Editable* --test-launcher-bot-mode --gtest_repeat=40 Change-Id: I1ddfcfaf172e1fbcf1d6a851bb89ad051e1b8942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111064Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751898}
-
Victor Costan authored
Bug: 1062925 Change-Id: I7210f4557595f2a310b7d6db717d7f23b1ea5077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109178 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751897}
-
Justin Miron authored
Reverts the blink/content renderer changes of https://crrev.com/c/1982622 as they break chromeos with --thinlto. The entire CL cannot be reverted due to a windows_archive_rel build breakage (crubg/1062857). Reverting the culprit portion as this is blocking chromeos uprev (crbug/1062006). Disables the browser side tests as the correct intersections will no longer be propagated. There are currently other consumers of the intersections. This will be relanded following fixing for chromeos --thinlto. BUG=1062006 Change-Id: I9f4eb13527a48965c1eed5613f26bc226fa971ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108343Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#751896}
-
Tarun Bansal authored
Bug: 1037017,1037024,1052956 Change-Id: I778308ae01b3398ed877f1a82af32e3ae2967c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111754 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#751895}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1058196 Change-Id: I90b37842d62e3be88864cf011a0aaea134f726a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086332 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751894}
-
Johannes Henkel authored
This reverts commit d8d217c2. Reason for revert: Relanding original change with a fix, which I submitted upstream here: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2109466 New third_party/inspector_protocol revision: c69cdc36200992d21a17bf4e5c2f3a95b8860ddf Original change's description: > Revert "[DevTools] Roll inspector_protocol (Chromium)" > > This reverts commit c29bddc2. > > Reason for revert: this has broken exposeDevToolsProtocol somehow. > > Original change's description: > > [DevTools] Roll inspector_protocol (Chromium) > > > > Upstream PR: > > Introduce a crdtp/dispatch.{h,cc} library. > > https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1974680 > > > > New Rev: 8c2064ea99cffdb5647760ad3953c43e612e07fc > > > > Notable downstream changes: > > - ChromeDevToolsManagerDelegate::HandleCommand no longer carries > > a method. Reason being, the shallow parser (crdtp::Dispatchable) > > should be efficient enough to parse an incoming message a couple > > of times, e.g. once for the content layer and once for the > > embedder, and if we felt differently then we'd quite possibly > > want to carry more than just the method - e.g., we'd want to also > > pass the params. Anyway, for now simplifying this interface. > > - crdtp::FrontendChannel::FallThrough; here, it's advantagueous > > to keep the method around, but now it's a crdtp::span. This is > > much better than const std::string& because the generated code > > knows exactly which method is going to fall through and we > > can pass a C++ string literal via this span. > > - The crdtp/dispatch library presents a somewhat different surface > > between the UberDispatcher and the session implementations. > > The session implementations are responsible for creating a > > crdtp::Dispatchable instance (the shallow parser) which > > it then hands to the dispatcher for dispatching. Rather than > > querying for whether it can dispatch and then doing it, > > the result of the Dispatch indicates whether a method was > > found and can be executed. There's no more need to instantiate > > protocol::Value in a devtools session class. > > - Since the dispatch library uses crdtp::span to represent > > method names, we no longer need to reference platform specific > > routines for finding strings and making substrings. As a result, > > v8_inspector_string.h is losing a few more methods > > (and same for base_string_adapter_h.template). > > - crdtp::DispatchResponse (also known as protocol::Response) has > > some renames for consistency ( > > Response::Error -> Response::SeverError, > > Response::OK -> Response::Success). Touches all domain handlers > > but is mechanical. > > - All protocol error messages, such as the parameters passed > > to DispatchResponse::ServerError are required to be UTF8 strings, > > even for Blink, so when code generates them as WTF::String, > > we convert them to std::string using WTF::String::Utf8() > > before passing them to DispatchResponse::ServerError. > > - We're better about checking messages and sending errors when we > > can't parse them - esp. we no longer drop messages on the floor > > if we can't make sense of them; the LOG statements are gone, > > because we can either send an error or assume that we've > > previously parsed the message elsewhere and put a DCHECK (e.g., > > a message received by blink has always been shallow-parsed by the > > browser before). > > - DevToolsAgentHost::DispatchProtocolMessage no longer has a boolean > > return value. Reason being, it's not well defined what the > > boolean should indicate. If we reject the message and send > > an error, arguably we've also handled it. And of course, we > > always do that (now). So it's not useful to generate or check > > this return value, and there is only one DCHECK on it currently, > > which is also not covered by tests. > > - content::DevToolsSession uses binary searches to match method names > > (e.g. in ShouldSendOnIO). > > This is because I've switched the method names to span, and > > implemented similar searches for the dispatching library, so > > it's best to be consistent. It will also scale better if we add > > more methods. > > - The additional unittests added to the CRDTP library upstream cover > > shallow parsing, dispatching, etc. and are now also part of > > the content_unittests. > > - Improves Android binary size by about 36k, by reducing code > > duplication. There's now just one UberDispatcher, for example, > > as opposed to one for blink, one for content, one for headless, > > one for chromium, ... > > - Speeds up execution by 1-2% (based on internal measurements), > > because message serialization no longer takes a detour via > > protocol::Value. > > > > Change-Id: I422fe527d6f8a6ffb098b3992728ecba408b571f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047966 > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Leonard Grey <lgrey@chromium.org> > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#750284} > > TBR=dgozman@chromium.org,caseq@chromium.org,gogerald@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > Change-Id: I122738b9057cf6ab48b904a6ee0e67c7c9610b95 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103517 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750343} TBR=dgozman@chromium.org,caseq@chromium.org,gogerald@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org Change-Id: I5def0b19c3deb6516b52408e3a7c325b114c6edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111060 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751893}
-
Hwanseung Lee authored
This is a reland of 4143ca0e Original change's description: > Clean up the AndroidSetupSearchEngine feature flag > > The AndroidSetupSearchEngine feature is enabled by default > and the config has no effect anymore. > Therefore, remove the config and every reference to > AndroidSetupSearchEngine. > > Bug: 1057939 > Change-Id: I5e395d7ed031d93b64d4ae9d012f72351b0dec22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102032 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> > Cr-Commit-Position: refs/heads/master@{#750834} Bug: 1057939 Change-Id: Ic39bb381f413d013729586a5c3c308679aa02c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108272Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#751892}
-
Daniel Libby authored
Directly composited images is a feature that rasterizes images at their intrinsic size, when an image is the only thing drawn into a layer. However, this determination is today made prior to painting the image in blink, which can't be done with CompositeAfterPaint enabled. This CL adds support for detecting PictureLayers that qualify as directly composited images, by analyzing the paint ops of the display item list. If a single drawImageRect paint op is detected (with some facilities for detecting images for which orientation is respected), then we'll propagate the image's intrinsic size over to PictureLayerImpl on commit. PictureLayerImpl then uses that information to calculate a raster scale that results in the image being rasterized at its intrinsic size. There are a few additional changes needed outside that core calculation. If the aspect ratio of the layer bounds does not match the image's aspect ratio, we won't raster the image at the intrinsic size, but instead will choose the scale from one dimension. In these cases, we will choose to re-raster when the layer is resized until the layer bounds aspect ratio matches that of the image. If we do adjust the raster scale and add tilings to the active tree (as is seen in the default configuration for web_tests), we should drop the previous tilings (which are now non-ideal) since the max raster scale tile will be chosen when the SharedQuadState is created during AppendQuads. We also need to tell the LayerImpl if nearest neighbor should be used when the TileDrawQuad is scaled in the display compositor to preserve the same output of the original drawImageRect. Bug: 875110 Change-Id: I2cda143f483c2aa30a6ae1fb850e1c7ef1227882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036542Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751891}
-
Khushal authored
The transfer cache used to cache image uploads with OOP raster has an additional budget for these textures in addition to GrContext's budget. The budgeting is managed by ServiceTransferCache external to skia and these textures shouldn't be counted against GrContext's budget. R=bsalomon@google.com Bug: 936231 Change-Id: Ibd065aa75cda21fada019a9ded2811262c7bd85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108168 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#751890}
-
Noel Gordon authored
If the mouse/pointer/touch device is Pressed, adds a class to the root HTML element (and remove it when the device is released), to allow you to write CSS to prevent hover effects on inactive elements: html.pointer-active some-clickable-element:not(:active):hover { background-color: unset; } Bug: 1062902 Change-Id: I6bafc00b608f69ea35d61a8a9e77f22fb597a56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111810Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751889}
-
Ayu Ishii authored
Bug: 1062668 Change-Id: I40137e8782a2456364271b62a39c5a10cac068c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111372 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#751888}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f6e1e2b69e8..8fa0f9e0706b Created with: gclient setdep -r src-internal@8fa0f9e0706b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Id539e1c91f5dc667fa405bc3e89b92bdedb5675e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111590Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751887}
-
Luciano Pacheco authored
This rule applies to file list and grid view. Bug: 1062207 Change-Id: I42c46b367ee50c4c409eb89a7e74aae80e564a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110831 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#751886}
-
Dale Curtis authored
This wires up VP8 decoding through the same MFT we use for VP9 hardware decoding. The feature is default off. VP8 does not have color space information despite a comment in the spec saying its BT470NG. It does have range information though, so we indicate JPEG if full range. Bug: 1062849 Test: No intel hardware, so untested at present. Change-Id: Ia7006006f943c3dd1078f3a11ededa7e4b410c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109171Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#751885}
-
Reilly Grant authored
These tests are expected to time out on MSAN and the test names changed recently. Bug: 1063162 Change-Id: I0925fa2b0e3e5d0287755d6fc7b042237e8fe82e Tbr: harringtond@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111471Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751884}
-
Chris Harrelson authored
There is nothing behind the root element stacking context in the same frame, and it's also important not to blend with any white behind the root frame. This is also causing a problem at the moment in Chromium because to implement the semantics in [1] for filters of the root element group applying after drawing and before compositing into the root group, we now paint two PaintChunks for the LayoutView [2]. The second such PaintChunk has a PropertyTreeState that includes filters (including at the moment backdrop-filter). But since it's not composited the code fails to work correctly. This CL does not apply to iframes, because they do have a well-defined backdrop from their containing frame's contents. [1] https://drafts.fxtf.org/compositing/#pagebackdrop [2] https://chromium-review.googlesource.com/c/chromium/src/+/1979258 Bug: 1061802 Change-Id: I9212213d1787647b171fbefcf18ef80d51b74a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109318Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751883}
-
Felipe Erias authored
Add the "auto" value for the -webkit-appearance property. The element will have the appearance returned by AutoAppearanceFor() (in layout_theme.cc). Spec: https://drafts.csswg.org/css-ui/#valdef-appearance-auto Bug: 965432 Change-Id: Ia3c829637fcfa8a897b6a8d2e155f5861c3d9c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108264Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#751882}
-
Livvie Lin authored
Check whether it's possible to go back before trying to perform a back navigation on a committed interstitial when the "Back to safety" button is pressed. This CL fixes the stability issue--a follow-up CL will fix the actual functionality of the button on e.g. interstitial opened in new tab. Bug: 1059142 Change-Id: Icc03af381ca376731b451238ccb671a216764bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111411Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751881}
-
Donn Denman authored
This test is consistently failing on a builder on the M82 branch. Original CL https://crrev.com/c/1743028 TBR=sarsha@microsoft.com BUG=1063198 Change-Id: Iec2e5cc719ab54a7752447872296e9f13bfb1c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111831Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#751880}
-
Mason Freed authored
TBR=schenney@chromium.org Bug: 1055943 Change-Id: Iff49353d43a8366b0878862ffc2f4232b8d37d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111611Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#751879}
-
Shik Chen authored
GpuMemoryBuffer-based video capture is enabled on selected Chrome OS boards to reduce memory copies. This CL allows the Pepper media stream video track host to convert the GpuMemoryBuffer-based VideoFrames to the I420 buffer PPAPI MediaStream Video [1] supports. [1] https://source.chromium.org/chromium/chromium/src/+/master:ppapi/examples/media_stream_video/ Bug: 1039514 Test: Check the camera frames from the PPAPI media_stream_video example Change-Id: I02a41ef3a458cbe2df3740b4bd6b380ea6d57ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109510Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#751878}
-
Jarryd authored
Bug: 1062272 Change-Id: I11127d39c02ef5ae9e17743393ded51c43c39bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106963 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751877}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I91a78c8ea90916f22248e7731efcf0b023289cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751876}
-
Dale Curtis authored
Adds kMediaFoundationVP8Decoding as disabled by default. Updates our supported profiles code to use it. Bug: 1062849 Change-Id: I36b6c6b202411a7bd842a28727a7b67dd3f31882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110516 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#751875}
-
Peter Kotwicz authored
This CL: - Makes WebappActivity use CurrentPageVerifier - Adds homescreen-shortcut and WebAPK subclasses of Verifier - Introduces WebappActiveTabUmaTracker for recording metrics about active tab - Makes CustomTabDelegateFactory#shouldDisableExternalIntentRequestsForUrl() use ExternalIntentsPolicyProvider for Webapps & WebAPKs BUG=1054718 TESTS=WebApkInitializationTest.testInitialization AddToHomescreenCurrentPageVerifierTest.* WebApkCurrentPageVerifierTest.* CustomTabExternalNavigationTest.testShouldDisableExternalIntentRequestsForUrl Change-Id: I2bbd0505f28b99569c4bed8fb4e6e10295620eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068116 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751874}
-
Brian Sheedy authored
This reverts commit 04d9ccbc. Reason for revert: https://crbug.com/1063165 Original change's description: > [AW] DevUI: Always merge dev ui launcher manifest to the final manifest > > Always merge dev ui launcher manifest for standalone and trichrome > webview into the final manifest unconditionally similar to monochrome > launcher manifest. > > Use jinja_template to: > - Generate the manifests for all variants from one Manifest file. > - Pass a variable to determine the default enabled state for the > launcher activity-alias. > > Standalone, Trichrome and Monochrome WebView, all use one activity-alias > to show the launcher icon. > > Change the name and the behaviour of the GN flag to always show the > launcher icon. If the flag is set to true then Monochrome will always > show the icon unconditionally. > > Fixed: 1047824 > Test: Enable/Disable the flag for stable/prestable WebView variants > Test: check no changes permissions in standalone and trichrome manifest > Change-Id: Ida10e39e294715e69ad19f1253cf302113322cc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098804 > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Hazem Ashmawy <hazems@chromium.org> > Auto-Submit: Hazem Ashmawy <hazems@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751735} TBR=torne@chromium.org,ntfschr@chromium.org,hazems@chromium.org Change-Id: I7fea8cf56a9396d30ac272de4a870e0b4bcb9c99 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111950Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#751873}
-
Yulun Wu authored
Change-Id: I8be1da447a3728bb48bae48a5fa6018595089f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103365 Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751872}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1d34dc592fc1..1512c36ab69c git log 1d34dc592fc1..1512c36ab69c --date=short --first-parent --format='%ad %ae %s' 2020-03-19 tsepez@chromium.org Finish gutting logic from CFX_V8 2020-03-19 kmoon@chromium.org Roll v8/ 07a0ee92d..633234050 (457 commits) 2020-03-19 kmoon@chromium.org Roll third_party/zlib/ b9b9a5af7..156be8c52 (2 commits) 2020-03-19 kmoon@chromium.org Roll third_party/catapult/ ea794b87a..df670f0be (114 commits) 2020-03-19 tsepez@chromium.org Add exception helper to fxv8.h. 2020-03-19 tsepez@chromium.org Make more of CFX_V8 methods ordinary functions. 2020-03-19 negupta@microsoft.com Add keyboard tabbing for links & highlights 2020-03-18 tsepez@chromium.org Use proper namespace instead of CFX_V8 static functions. 2020-03-18 tsepez@chromium.org More small fxjs / v8 cleanup. Created with: gclient setdep -r src/third_party/pdfium@1512c36ab69c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:994500 Tbr: pdfium-deps-rolls@chromium.org Change-Id: If3c959722b8562b15fd78fb22f8ccd62e880ff54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751871}
-
Aaron Leventhal authored
SerializeNodeChanges() checks every descendant node to see if it was reparented, which is considered an error condition, because reparented nodes should be handled in the caller SerializeChanges(). When this error condition is reached, it means that the helper AnyDescendantWasReparented() did not detect a reparented node, and the tree is Reset() -- meaning it will need to be rebuilt. In addition, generated events on reparented nodes will be lost. This error condition occurred when nodes change their ignored status, because of a line in AnyDescendantWasReparented() that causes it to skip checking children recursively for valid nodes. Skipping this check when node is ignored avoids the error condition. In addition, a DumpWithoutCrashing() calls is added so that the accessibility team can understand how often this error condition occurs. This change has the side effect of detecting more reparenting changes, because when a subtree becomes display:none, a new accessible is created for each node in the subtree -- unless one of the objects in the subtree was already display:none. Those nodes will effectively get new parents. As a result of this side effect, menupopupend changes need to be fired on any menu nodes that are deleted, not just when they're the root of a subtree that's deleted. This is a more robust solution for menupopupend events in any case. Bug: 1059394 Change-Id: I0433690d6f7ac9708bcc54dafe4b3f9b09d30ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090736 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#751870}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1171d314efc7..4b55ff097b9d git log 1171d314efc7..4b55ff097b9d --date=short --first-parent --format='%ad %ae %s' 2020-03-19 bsalomon@google.com Fix cmake angle build on linux. 2020-03-19 chinmaygarde@google.com Allows Skia users to disable use of API_AVAILABLE in the Metal backend. Created with: gclient setdep -r src/third_party/skia@4b55ff097b9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: Ifacffe0c7cc6560b563c318094ff6deba1c0d73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110586Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751869}
-
Martin Šrámek authored
The Site settings menu entrypoint returns to use the old "Site settings" string. The new string resource which was previously added there can be removed. We will remove it in a followup CL to make this CL safer to merge: https://chromium-review.googlesource.com/c/chromium/src/+/2108543 The Password leak check toggle currently has an explanatory string that the feature only works for signed-in users, which only shows when the user is signed out. When the user is signed in, there is no secondary text. The design paradigm of privacy settings is that the secondary text should always explain the privacy implications. Therefore, we're adding existing explanatory string from the password leak check UI under this toggle as well, in both signed in and signed out cases. See mocks: https://docs.google.com/presentation/d/1utofQR2FyZlTOOsUgYGi0SyPeVA3DxCDjHmaAuu0EIo/edit?ts=5dcf17c5#slide=id.g700853307c_2_104 https://docs.google.com/presentation/d/1utofQR2FyZlTOOsUgYGi0SyPeVA3DxCDjHmaAuu0EIo/edit?ts=5dcf17c5#slide=id.g710b7438a5_5_83 Bug: 1062607 Change-Id: I6f404d147e09ec71caf0d843f371d2c4bf774b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108143 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751868}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fb670f56acbd..1c9f24263e6c git log fb670f56acbd..1c9f24263e6c --date=short --first-parent --format='%ad %ae %s' 2020-03-19 sugoi@google.com Fix float to r11g11b10 conversion Created with: gclient setdep -r src/third_party/swiftshader@1c9f24263e6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I73d7ecdb99c0b65c4adef2e466cfbccc28b9a7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751867}
-
Ken Rockot authored
This ensures that JS doesn't attempt to decode optional MinVersion'd fields in structs received with a lower version number. Fixed: 1063092,b:151950986 Change-Id: Id7e4d2c5ce2d355a6e87a38d729025929c42008f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110670 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751866}
-
Robert Ogden authored
Allows server experiments to set the probe timeout. Bug: 1023486 Change-Id: Ia64db9e855b5667da848b6727bdc5ef8a7998132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107718Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#751865}
-
Alexander Cooper authored
As part of the refactor to move the VRService into content, the isolated device service will need to move from chrome/services to components/services and from chrome/utility/services to content/utility/services. At that time, XRRuntimeProvider will no longer be able to use anything from either chrome_features or content_features. While it is a pattern for components to define their own features, these features indicate the support of an implemented runtime, and thus make more sense being implemented at this layer. Bug: 1031622 Change-Id: I7649bf5c20a2973ca4eaa818fa05a76a7f8432d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108964 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#751864}
-