GitLab

BUG=276739
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/234023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267030 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/220243003 removed the last client-side caller.
Service-side implementation of GetState is identical to GetLastState. So replace
all instances of GetState by GetLastState and remove the former.

BUG=None

Review URL: https://codereview.chromium.org/253943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267027 0039d316-1c4b-4281-b951-d872f2087c98

There is a bug in the Chromesite redirects where the Pepper reference docs
links incorrectly redirect back to themselves. This CL works around this by
removing the .html suffix on the links.

Note that these files are generated, so it will break the next time someone
generates docs (unless they're careful).

BUG=365825
R=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/260193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367986
R=mdempsky@chromium.org
TBR=jorgelo

Review URL: https://codereview.chromium.org/252323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267025 0039d316-1c4b-4281-b951-d872f2087c98

win_gpu is already experimentally receiving a percentage of the
Chromium and Blink CQs' load. Expand its testing to cover manually
submitted try jobs.

BUG=327170
R=phajdan.jr@chromium.org,maruel@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/258233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267023 0039d316-1c4b-4281-b951-d872f2087c98

preferences file.

This change reduces the size of Preferences file for around 3% of users
who have lot of entries (some users have more than 10,000 entries).

HttpServerProperties - Implement MRU for supports SPDY server list.
Persist only the most recently used 300 entries. In memory keep all the
entries.

This change is similar to MRU change for AlternateProtocol.

R=rch@chromium.org, mmenke@chromium.org
BUG=258189

Review URL: https://codereview.chromium.org/253903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://codereview.chromium.org/231873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330111
NOTRY=true

Review URL: https://codereview.chromium.org/253213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267017 0039d316-1c4b-4281-b951-d872f2087c98

Tests to ensure that ?-escaping works and \-escaping is not necessary.

BUG=360629

Review URL: https://codereview.chromium.org/259893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267016 0039d316-1c4b-4281-b951-d872f2087c98

Cancel button should not be disabled.

BUG=360589, 343076
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/256223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267014 0039d316-1c4b-4281-b951-d872f2087c98

No longer needed now that Blink has rolled.

BUG=245025
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/253123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267013 0039d316-1c4b-4281-b951-d872f2087c98

There's no need to use GenericChangeProcessor for a test like this.

TBR=mnissler@chromium.org
BUG=339726

Review URL: https://codereview.chromium.org/258753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267009 0039d316-1c4b-4281-b951-d872f2087c98

Implement connection, registration, and receiving activities recording on the google apis side, for gcm-internals page.

arv: please do owner review for chrome/browser/ui/webui/*

BUG=341256

Review URL: https://codereview.chromium.org/248213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/253753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267007 0039d316-1c4b-4281-b951-d872f2087c98

Restricting *kill on ASAN is crashing somehow. Allow *kill on ASAN for
now.

BUG=367986
R=jorgelo@chromium.org, mdempsky@chromium.org

Review URL: https://codereview.chromium.org/261543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/254143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365762

Review URL: https://codereview.chromium.org/237653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267002 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
views_unittest TooltipController test failures
views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs )
stdio
Capture
CloseOnCaptureLost
DontShowEmptyTooltips
EnableOrDisableTooltips
HideOnExit
ReshowOnClickAfterEnterExit
TooltipHidesOnKeyPressAndStaysHiddenUntilChange
TooltipHidesOnTimeoutAndStaysHiddenUntilChange
TooltipsInMultipleViews
ViewTooltip


TooltipControllerTest.ViewTooltip (run #2):
[ RUN      ] TooltipControllerTest.ViewTooltip
Xlib:  extension "RANDR" missing on display ":9".
Received signal 11 SEGV_MAPERR 000000000000
#0 0x000000a88e4e base::debug::StackTrace::StackTrace()
#1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f9474270cb0 \u003Cunknown>
#3 0x000000736b83 views::NativeWidgetAura::Activate()
#4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState()
#5 0x000000738acb views::Widget::Show()
#6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget()
#7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp()
#8 0x00000065a16a testing::Test::Run().

Original issue's description:
> Move DefaultActivationClient to wm/core
> 
> Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.
> 
> R=sky@chromium.org
> http://crbug.com/308710
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266975

TBR=sky@chromium.org,ben@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/261553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267001 0039d316-1c4b-4281-b951-d872f2087c98

the border color can still conflict with the theme (e.g., no visible border if the tooltip bg is dark), but fixing that is a lot harder because the border, window roundedness, and shadow are all one tiled set of images (see shadow.cc).

BUG=348194

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266974

Review URL: https://codereview.chromium.org/258713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267000 0039d316-1c4b-4281-b951-d872f2087c98

Looks like clang-format rules changed.

Updating to latest output of:
    ./gpu/command_buffer/build_gles2_cmd_buffer.py

BUG=

Review URL: https://codereview.chromium.org/247283005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266999 0039d316-1c4b-4281-b951-d872f2087c98

This moves handling of VSync over to WindowAndroid.
It can have one client to receive vsync signals 
for the main browser-side scheduling logic.
It also forwards the vsync to the WindowAndroidObservers,
i.e. RenderWidgetHostView where it's used for sending
BeginFrame signals to the renderer.

This prepares for consolidating the scheduling logic
in a single place upstream.

Which will then further allow us to use the
cc scheduler (with SingleThreadProxy) and
unblock the landing of https://codereview.chromium.org/134623005/.

BUG=234173,363479
NOTRY=True

Review URL: https://codereview.chromium.org/236193013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266995 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Linux Aura: get tooltip background color from theme (https://codereview.chromium.org/258713002/)

Reason for revert:
views_unittest TooltipController test failures
views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs )
stdio
Capture
CloseOnCaptureLost
DontShowEmptyTooltips
EnableOrDisableTooltips
HideOnExit
ReshowOnClickAfterEnterExit
TooltipHidesOnKeyPressAndStaysHiddenUntilChange
TooltipHidesOnTimeoutAndStaysHiddenUntilChange
TooltipsInMultipleViews
ViewTooltip


TooltipControllerTest.ViewTooltip (run #2):
[ RUN      ] TooltipControllerTest.ViewTooltip
Xlib:  extension "RANDR" missing on display ":9".
Received signal 11 SEGV_MAPERR 000000000000
#0 0x000000a88e4e base::debug::StackTrace::StackTrace()
#1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f9474270cb0 \u003Cunknown>
#3 0x000000736b83 views::NativeWidgetAura::Activate()
#4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState()
#5 0x000000738acb views::Widget::Show()
#6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget()
#7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp()
#8 0x00000065a16a testing::Test::Run()

Original issue's description:
> Linux Aura: get tooltip background color from theme
> 
> the border color can still conflict with the theme (e.g., no visible border if the tooltip bg is dark), but fixing that is a lot harder because the border, window roundedness, and shadow are all one tiled set of images (see shadow.cc).
> 
> BUG=348194
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266974

TBR=ben@chromium.org,estade@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=348194

Review URL: https://codereview.chromium.org/263533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266992 0039d316-1c4b-4281-b951-d872f2087c98

Introduces the classes required to support per-type debug information.
This system will eventually replace much of the StatusController and
ModelNeutralState.

Adds three counter objects.  There is one for counters incremented
during a GetUpdates, one for counters incremented during a commit, and
one for "status" indicators like the total number of sync entities.

Adds the DirectoryTypeDebugInfoEmitter, which will manage these
counters.  There will be one instance of this object per enabled
directory-style sync ModelType.  It owns the counters that will be
updated by the CommitContributors and UpdateHandlers.  It also
collaborates with the ModelTypeRegistry to allow these
CommitContributors and UpdateHandlers to notify observers of updated
counter state.

Adds the TypeDebugInfoObserver, the interface for classes that listen
for counter updates.

At the moment, this code won't actually do much.  The counters are never
incrememnted, no observers register for counter change events, and no
such events are generated.  Those pieces will be added in future
commits.

BUG=328606

Review URL: https://codereview.chromium.org/254473008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266991 0039d316-1c4b-4281-b951-d872f2087c98

It caused the patch in https://codereview.chromium.org/248763003/ to be
reverted and probably some others too.

BUG=None
TEST=green trybots
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/257873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266990 0039d316-1c4b-4281-b951-d872f2087c98

Add NULL check for window in GetNativeThemeForWindow() to avoid a crash.

BUG=367698

Review URL: https://codereview.chromium.org/258953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266989 0039d316-1c4b-4281-b951-d872f2087c98

NOTREECHECKS=true
NOTRY=true
TBR=ajwong
BUG=367817

Review URL: https://codereview.chromium.org/252323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266988 0039d316-1c4b-4281-b951-d872f2087c98

Compile failure in ChromiumOS (daisy) builder.
"irt_exception_handling.cc:101:15: error: 'LOG_FATAL' was not declared in this scope."

> NonSFI NaCl: Plumb Exception IRT enough for breakpad.
> 
> Implements irt_exception.
> 
> This is enough to get breakpad start reporting minidumps on crash.
> 
> Stack overflow case handling with sigaltstack will be handled in a followup change.
> 
> BUG=356925
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/230413002

TBR=uekawa@chromium.org

Review URL: https://codereview.chromium.org/265433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266987 0039d316-1c4b-4281-b951-d872f2087c98

Previously, accessibility keyboard uses 30 percent of screen
height as its height and compact keyboard uses 41 percent.

The IME VKs always use 41 percent for both full and compact
keyboards. This CL uses 41 percent for all system virtual
keyboards to make it consistent with IME VKs.


BUG=367947
TEST=
1. in about://flags disable input view flag and enable virtual
keyboard flag
2. click any text input area
3. a 4 rows virtual keyboard should show up and will occupy
about 41 percent of screen
4. enable accessibility virtual keyboard in chrome://settings
5. refocus a text input area
6. a 5 rows virtual keyboard should show up and will occupy
about 41 percent of screen

Review URL: https://codereview.chromium.org/258063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368037
TBR=bajones@chromium.org

Review URL: https://codereview.chromium.org/254173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266985 0039d316-1c4b-4281-b951-d872f2087c98

Compilation of these files w/instrumentation takes too long.
This is a temporary workaround for issue 360158

BUG=360158
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/224713013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266983 0039d316-1c4b-4281-b951-d872f2087c98

Pressing the "Go back" button on the managed user block interstitial page closes the tab if there is no previous URL to go back to.

BUG=307215

Review URL: https://codereview.chromium.org/248963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266982 0039d316-1c4b-4281-b951-d872f2087c98

Many places that don't need ContentView proper and just need the View
managed by ContentViewCore.
BUG=360664
NOTRY=true

Review URL: https://codereview.chromium.org/251443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266979 0039d316-1c4b-4281-b951-d872f2087c98

Fixing this issue exposed a race condition in .gni processing where an error parsing a file that another thread was waiting for wouldn't signal that other thread that the load was complete, so it would wait forever.

This patch separates out the loading from the signaling in the InputFileManager so we can't forget to do this.

BUG=368019
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/258073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266976 0039d316-1c4b-4281-b951-d872f2087c98

Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.

R=sky@chromium.org
http://crbug.com/308710

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616

Review URL: https://codereview.chromium.org/250113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266975 0039d316-1c4b-4281-b951-d872f2087c98

the border color can still conflict with the theme (e.g., no visible border if the tooltip bg is dark), but fixing that is a lot harder because the border, window roundedness, and shadow are all one tiled set of images (see shadow.cc).

BUG=348194

Review URL: https://codereview.chromium.org/258713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266974 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266973 0039d316-1c4b-4281-b951-d872f2087c98

> - Using realpath instead of android_src
> 
> BUG=367235
> 
> Review URL: https://codereview.chromium.org/259763004

TBR=michaelbai@chromium.org

Review URL: https://codereview.chromium.org/263463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266972 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This delta breaks telemetry_perf_unittests testMeasurementSmoke

ERROR:root:Errored pages:
http://localhost:8000/components/paper-calculator/demo.html
Traceback (most recent call last):
File "/mnt/data/b/build/slave/Linux_ChromiumOS_Tests__1_/build/src/tools/perf/../telemetry/telemetry/decorators.py", line 50, in wrapper
func(*args, **kwargs)
File "/mnt/data/b/build/slave/Linux_ChromiumOS_Tests__1_/build/src/tools/perf/measurements/measurement_unittest.py", line 73, in testMeasurementSmoke
msg='Failed: %s' % benchmark)
AssertionError: Failed: <class 'benchmarks.thread_times.ThreadTimesPolymer'>

Original issue's description:
> add more polymer tests
> 
> BUG=333078
> R=dtu@chromium.org
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266955

TBR=dtu@chromium.org,ykyyip@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=333078

Review URL: https://codereview.chromium.org/257253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266971 0039d316-1c4b-4281-b951-d872f2087c98

Linux: Remove some ChromeOS linker flag workarounds now that full ChromeOS builds set the flags explicitly.

BUG=360082

Review URL: https://codereview.chromium.org/242453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266970 0039d316-1c4b-4281-b951-d872f2087c98

KeyboardDrivenEventRewriter was previously called at the start of
chromeos::EventRewriter, and suppressed further rewriting if it made
any changes. Since EventSource follows that model of breaking out of
the rewriter list, it makes sense to have this be a ui::EventRewriter
itself.

EventRewriterController will also be used for chromeos::EventRewriter
when that is converted to a ui::EventRewriter.

BUG=354034
TEST=unit_test
R=derat@chromium.org, sadrul@chromium.org

Review URL: https://codereview.chromium.org/240173007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266969 0039d316-1c4b-4281-b951-d872f2087c98