GitLab

Also, we don't need field trial for dev and canary.

BUG=477084
TEST=new tests

Review URL: https://codereview.chromium.org/1139633005

Cr-Commit-Position: refs/heads/master@{#330273}

Revert of Disable user gesture checking for all autofill browser tests. (patchset #2 id:20001 of https://codereview.chromium.org/1125173006/)

Reason for revert:
This CL broke Linux GN Clobber bot.

Original issue's description:
> Disable user gesture checking for all autofill browser tests.
>
> When drmemory_full runs, the browser tests are slowed down enough to
> timeout the user gesture indicator, which prevents autofill from
> processing the input and passing the browser test. The fix is to disable
> user gesture checking for all autofill browser tests except
> AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges.
>
> BUG=484910

TBR=estade@chromium.org,thestig@chromium.org,rouslan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=484910

Review URL: https://codereview.chromium.org/1140013004

Cr-Commit-Position: refs/heads/master@{#330272}

Cr-Commit-Position: refs/heads/master@{#330271}

BUG=488739
TBR=derat@chromium.org

Review URL: https://codereview.chromium.org/1137393004

Cr-Commit-Position: refs/heads/master@{#330270}

Revert of Create net::FormatOriginForDisplay helper function. (patchset #8 id:140001 of https://codereview.chromium.org/1133943002/)

Reason for revert:
This CL needs more work, and potentially to be moved to a new module.

Original issue's description:
> Create net::FormatOriginForDisplay helper function.
>
> net::FormatOriginForDisplay provides a canonical, concise, human-friendly
> display for origins. It supports callers in any higher-layer module.
>
> Based heavily on earlier work by dewittj and felt. Thanks!
>
> BUG=402698
> TBR=thakis,brettw

TBR=asanka@chromium.org,dewittj@chromium.org,felt@chromium.org,rsleevi@chromium.org,thakis@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=402698

Review URL: https://codereview.chromium.org/1131813004

Cr-Commit-Position: refs/heads/master@{#330269}

This change removes the margin on either side of buttons in the Media Router WebUI.

Review URL: https://codereview.chromium.org/1133283005

Cr-Commit-Position: refs/heads/master@{#330268}

LoFi uses solid color image placeholders. Provide the user a context
menu option to load the origial image in place. Also, provide a way
for the context menu to know that an image was LoFi.

BUG=485295

Review URL: https://codereview.chromium.org/1105263004

Cr-Commit-Position: refs/heads/master@{#330267}

- Adds CastConfigDelegate which gathers casting data from the chromecast extension
- Provides access to the CastConfigDelegate to UI code via the SystemTrayDelegate

BUG=433140

Review URL: https://codereview.chromium.org/1115083002

Cr-Commit-Position: refs/heads/master@{#330266}

Cyclic refresh allows the encoder to update already coded sections of
the image at a higher quality.

BUG=134202

Review URL: https://codereview.chromium.org/1092813003

Cr-Commit-Position: refs/heads/master@{#330265}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/166b853..f1045f3

TBR=timvolodine@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1141083003

Cr-Commit-Position: refs/heads/master@{#330264}

Remove RouteIDManager as it is not and will not be used.

BUG=461815

Review URL: https://codereview.chromium.org/1143453005

Cr-Commit-Position: refs/heads/master@{#330263}

https://chromium.googlesource.com/angle/angle/+log/21ce9b02..8befcff5

BUG=
TEST=bots
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/1132873008

Cr-Commit-Position: refs/heads/master@{#330262}

When drmemory_full runs, the browser tests are slowed down enough to
timeout the user gesture indicator, which prevents autofill from
processing the input and passing the browser test. The fix is to disable
user gesture checking for all autofill browser tests except
AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges.

BUG=484910

Review URL: https://codereview.chromium.org/1125173006

Cr-Commit-Position: refs/heads/master@{#330261}

Introduce the histogram
Ash.WindowSelector.TimeBetweenActiveWindowChanges
which records the amount of time between uses
of overview mode in which the user selects a window
which was not previously active.

BUG=488180
TEST=TaskSwitchMetricsRecorderTest.VerifyTaskSwitchesFromOverviewModeAreRecorded

Review URL: https://codereview.chromium.org/1132293004

Cr-Commit-Position: refs/heads/master@{#330260}

This was re-enabled again temporarily to see if https://codereview.chromium.org/1142603002 fixed the issue, which unfortunately it didn't.

BUG=488059
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1139243002

Cr-Commit-Position: refs/heads/master@{#330259}

BUG=none

Review URL: https://codereview.chromium.org/1128983002

Cr-Commit-Position: refs/heads/master@{#330258}

The application of special storage policy is split out into a new class,
QuotaPolicyCookieStore, in content/browser/net.

This reverts commit ac4f4964.

TBR=avi@chromium.org
BUG=467596
TEST=No visible impact.

Review URL: https://codereview.chromium.org/1138643004

Cr-Commit-Position: refs/heads/master@{#330257}

DelegatedRendererLayerImpl passes the frame from the pending to the
active tree, but relies on there being a child_id_ on the active
layer that is known to the ResourceProvider. If the context was lost
while the frame was in the pending tree, the frames resources are
released, but we try to tell the resource provider to use the
empty frame with an invalid child id.

When the context is lost and we drop the frame, also unset the bool
saying we have a frame to pass to the active tree.

R=piman@chromium.org
BUG=488366

Review URL: https://codereview.chromium.org/1128043008

Cr-Commit-Position: refs/heads/master@{#330256}

Clearer API; flushes out a lot of unnecessary heap allocations.

depends on https://codereview.chromium.org/1129083003/

BUG=none

Review URL: https://codereview.chromium.org/1131113004

Cr-Commit-Position: refs/heads/master@{#330255}

net::FormatOriginForDisplay provides a canonical, concise, human-friendly
display for origins. It supports callers in any higher-layer module.

Based heavily on earlier work by dewittj and felt. Thanks!

BUG=402698
TBR=thakis,brettw

Review URL: https://codereview.chromium.org/1133943002

Cr-Commit-Position: refs/heads/master@{#330254}

BUG=488290

Review URL: https://codereview.chromium.org/1136763004

Cr-Commit-Position: refs/heads/master@{#330253}

Fix a crash due to unsafe iterator usage in the DisplayColorManager
destructor.

BUG=488487
TEST=compile

Review URL: https://codereview.chromium.org/1127213007

Cr-Commit-Position: refs/heads/master@{#330252}

BUG=486739

Review URL: https://codereview.chromium.org/1135333006

Cr-Commit-Position: refs/heads/master@{#330251}

Before this CL, AppCacheDiskCache could delete inflight ActiveCalls without
any abort operation when the backend is disabled, so callbacks bound with
ActiveCall objects are invoked in broken state.

After this CL, ActiveCall hides its constructor and manages its own lifetime
using refptr, so AppCacheDiskCache no longer has to take care of their
lifetime. In addition, AppCacheDiskCache passes its weakptr to ActiveCall,
which in turn checks it when an operation is completed. If the backend is
closed, ActiveCall closes the entry and returns net::ERR_ABORTED.

BUG=488757
TEST=n/a

Review URL: https://codereview.chromium.org/1136373003

Cr-Commit-Position: refs/heads/master@{#330250}

Reading of views is now handled using ChromeVox Next with the automation API. The current Next background page fails on non-CROS because there's no commands block. We get an error like
getAll called on undefined.

(chrome.commands is undefined).

TEST=manually build ChromeVox; verify views reads properly.

Review URL: https://codereview.chromium.org/1138773006

Cr-Commit-Position: refs/heads/master@{#330249}

Revert of [Contextual Search] Remove opt-in code. (patchset #6 id:100001 of https://codereview.chromium.org/1103163004/)

Reason for revert:
It broke Clank bots.

Original issue's description:
> [Contextual Search] Remove opt-in code.
>
> This CL requires a downstream change:
> https://chrome-internal-review.googlesource.com/#/c/214963/
>
> BUG=482618
> R=donnd@chromium.org, dtrainor@chromium.org, thakis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/277f043bb56fb1e4bb93d9d17fc3de4ada0eb81b

TBR=donnd@chromium.org,mathp@chromium.org,dtrainor@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=482618

Review URL: https://codereview.chromium.org/1123313006

Cr-Commit-Position: refs/heads/master@{#330248}

On Windows, clang-cl only parses template methods that are
referenced (-fdelayed-template-parsing), so members traced from
unreferenced template methods weren't seen by the plugin, which
caused it to warn about them.

Explicitly parse delayed template methods that look like they
are trace methods and that aren't in system headers to work around
this. This is based on Kim Grasman's patch for the IWYU project:
https://code.google.com/p/include-what-you-use/source/detail?r=566

This fixes 3 of the 4 failing oilpan plugin tests on Windows.

BUG=486571
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1140443005

Cr-Commit-Position: refs/heads/master@{#330247}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/117dbc2..166b853

TBR=timvolodine@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1139543004

Cr-Commit-Position: refs/heads/master@{#330246}

card unmasking prompt.

BUG=487866

Review URL: https://codereview.chromium.org/1134793009

Cr-Commit-Position: refs/heads/master@{#330245}

BUG=462671

Review URL: https://codereview.chromium.org/1143663003

Cr-Commit-Position: refs/heads/master@{#330244}

This adds GN build rules for the AppRemoting sample app.
Some DesktopRemoting build rules were prettified as part of this
process (to make the App- and Desktop- remoting build rules more
similar).

This re-re-lands crrev.com/1126393002 without any additional changes
required. The original issues with the GN clobber builds are fixed in
crrev.com/1137753002. The 2nd attempt to land was rejected due to
a merge race (fixed in this cl).

BUG=471916

Review URL: https://codereview.chromium.org/1143643003

Cr-Commit-Position: refs/heads/master@{#330243}

MSan requires all code be instrumented.

This also rolls BoringSSL. Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/a07c0fc..9660032

BUG=488708

Review URL: https://codereview.chromium.org/1139263002

Cr-Commit-Position: refs/heads/master@{#330242}

Get the omnibox to show up again. Sky's changes from yesterday removed the window manager interface. This is a temporary interface to allow the omnibox app to ask the browser app to place its window.

R=sadrul@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1135933003

Cr-Commit-Position: refs/heads/master@{#330241}

BUG=472152

Review URL: https://codereview.chromium.org/1144543005

Cr-Commit-Position: refs/heads/master@{#330240}

BUG=318217

Review URL: https://codereview.chromium.org/1129643002

Cr-Commit-Position: refs/heads/master@{#330239}

The reason to stop using URL{Request,Response} for HTTP server interfaces: some
fields of those structs belong to a higher level, e.g., |auto_follow_redirects|.
It seems cleaner to define Http{Request,Response} which match the HTTP
request/response definitions.

BUG=478249
TEST=None

Review URL: https://codereview.chromium.org/1129143005

Cr-Commit-Position: refs/heads/master@{#330238}

The dialog was broken because of race condition between
https://codereview.chromium.org/1115993002 and
https://codereview.chromium.org/1129063003

BUG=488629
TEST=manually

Review URL: https://codereview.chromium.org/1124213004

Cr-Commit-Position: refs/heads/master@{#330237}

BUG=480733

Review URL: https://codereview.chromium.org/1131933005

Cr-Commit-Position: refs/heads/master@{#330236}

BUG=392232

Review URL: https://codereview.chromium.org/1130603006

Cr-Commit-Position: refs/heads/master@{#330235}

The bug is that chrome.runtime.sendMessage looks for when its callback is
garbage collected, and when it is, close the associated port. It's important to
close the port to notify the other end of the closure, cleanup renderer state
both locally and on that other end, and potentially browser state.

Unfortunately the port management is implemented in JS itself, and port
releasing needs to go through JS. The problem is that it's not possible to call
into JS while in the process of garbage collection, so we delay it, by which
point the JS context may have been destroyed and again it's not possible to
call into JS. We fixed the former case a while ago, and this patch fixes the
latter.

BUG=471599
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1136953017

Cr-Commit-Position: refs/heads/master@{#330234}