- 27 May, 2020 40 commits
-
-
Stephan Hartmann authored
The decltype(<func>) passed as template parameter to CBBFunctionToVector does not return a function pointer and GCC complains like this: ../../device/fido/virtual_fido_device.cc:104:68: error: 'int(struct cbb_st*, const struct evp_pkey_st*)' is not a valid type for a template non-type parameter 104 | EVP_marshal_private_key>(pkey_.get()); | ^ Fix this by passing decltype(&<func>). Bug: 819294 Change-Id: I8114c3d75c9865779d58c0b6a6c48e6affd3175b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217414Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#772283}
-
Peng Huang authored
This is a reland of de6734f7 Original change's description: > vma_wrapper: create VmaAllocator for vulkan 1.1.0 > > For vulkan 1.1.0, VmaAllocator will use dedicated memory > allocation for some big vulkan memory request, and free > it when the allocation is released. Without this change, > the VmaAllocator will allocate memory from self managed > memory blocks for all vulkan memory request. And the > memory may not be released when the allocation is > released. VmaAllocator may keep the memory for later > usage. It could be the reason for the memory regression > in fuchsia. > > Bug: fuchsia:52463 > Change-Id: I7b905435d31b927b2344724f8a2e1738e0544410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215414 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Auto-Submit: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771927} Bug: fuchsia:52463 Change-Id: I4da1f291a574f72ad16811ffafffb3be36392af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218247 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#772282}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=mek@chromium.org Bug: 1026641 Change-Id: I3c723c41dc313d8eaa664260c7569a7bde398076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216737 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#772281}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a81e3dba0fd..ca092f016532 2020-05-27 gbiv@chromium.org translator: explicitly specify underlying types for enums If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084580 Tbr: ynovikov@google.com Change-Id: I1d19ff3d8252d3f77950217be58b85a870cc4ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218432Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772280}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 1026641 Change-Id: Id38d941acd0e77333cdcef9c34a3eb509650755c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215917 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#772279}
-
Raphael Kubo da Costa authored
There is no need to pass a std::unique_ptr to PlatformSensorProviderLinux and also hold the raw pointer in PlatformSensorAndProviderLinuxTest. Instead, just pass the std::unique_ptr and access it directly, as the test class is already a friend of PlatformSensorProviderLinux. R=reillyg Change-Id: I41624ccedb9dfd886f047d0ad9550c877966af3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218047 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#772278}
-
Gabriel Charette authored
[base] Make PostTask destination explicit in /content/public/test/browser_task_environment_unittest.cc Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1026641 Change-Id: I87ec188abf4b2e6a359d69409a74bbf90674197c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215918 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772277}
-
Kurt Horimoto authored
When an OverlayPresentationContext's capabilities are updated, OverlayPresenter will hide the currently-presented overlay UI if the new capabilities are insufficient to present it. However, the previous implementation mistakenly checked against GetActiveRequest() rather than |presented_request_| to handle this logic. GetActiveRequest() returns the front request of the active WebState's queue, which is often, but not always the presented request when |presenting_| is true. |presented_request_| is more accurate, as there are two points in time where it differs from GetActiveRequest(): - When presented overlay UI is being dismissed due to request cancellation. At this point, the request will have already been removed from the active WebState's queue. - When presented overlay UI is being dismissed due to a change in the active WebState. The request still belongs to the previously- active WebState, so will not be returned by GetActiveRequest(). Bug: 1065564 Change-Id: I4c7eec8ba28311f520cff482d316bb4ac8e24a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212520Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772276}
-
Raphael Kubo da Costa authored
Its only call site was the function right above it. Merge them together for simplicity. While here, use base::MakeRefCounted<> rather than creating a scoped_refptr<> and passing it to base::Callback::Run(). Change-Id: Id1ccce0493dfdcaccb3689d07b661e0267e2ba46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218068 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#772275}
-
Raphael Kubo da Costa authored
This method was never implemented and is not called anywhere. It is better to readd it if we ever really have a use for it. Change-Id: I1c9b379e3dbe867e91f06f0170dce3abe04b8c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218087 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#772274}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1026641 Change-Id: I54a1ce913a2b19504b20494a930810d1a50f9139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215919 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772273}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=hansberry@chromium.org Bug: 1026641 Change-Id: If8c3e0326a77e5ffca7f6e885cbda1bd37c0b3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216735 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#772272}
-
Andrey Kosyakov authored
... by making sure the iframe under test is in-process (there's no point for testing for OOPIF, since JS context isolation is provided naturally there). Bug: 608015 Change-Id: I81382e9e0c8943c67c0226582c90f57a3964dd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216640Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772271}
-
Nate Chapin authored
Bug: 1083485 Test: fast/frames/document-addressSpace-in-initial-document-after-navigation.html Change-Id: I08229cb5143e3a348d0897d4ad186978a858b7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215443Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#772270}
-
Hitoshi Yoshida authored
This CL introduces following methods for dictionary members whose type is nullabe. These methods are migration adapters, and will be removed after IDL compiler migraiton. - fooNonNull(): Returns a non-null type value for a member |foo|. It crashes if foo() is missing or has a null value. - hasFooNonNull(): Returns true iff |foo| has a non-null value. In practice, however, they are aliases of foo() and hasFoo() in the running IDL compiler. We are changing behaviors of foo() and hasFoo() precisely in the new compiler, and expect these new methods work as migration adapters. Bug: 839389 Change-Id: If19479779ea3d19b498e23a5001aabd38366a2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215648 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#772269}
-
chrome://policyJérôme Gingras authored
Bug: 1020213 Change-Id: Ib637c351af63496ba9b7bb538b0df0639fd18f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212630 Commit-Queue: Jerome Gingras <jgingras@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#772268}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit 41989bd8 ("Remove/replace unnecessary logging.h includes in .cc files (cc)"). Bug: 957519 Change-Id: I1e782e8310ca548947b2d541af6a2159d928d1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218090Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#772267}
-
Dominic Farolino authored
R=hiroshige@chromium.org, kouhei@chromium.org Bug: 1086507 Change-Id: I4cc1401de2c642d24aab0f4bd6efd94eda18fe65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213820 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#772266}
-
Chris Hamilton authored
Follow-up CLs will add this to the graph display, and then individually wire up the types of opener relationships. BUG=1085129 Change-Id: If25406e0bc15fd6c6cbeeb62cc0db0c438fe9ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215281 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772265}
-
Jan Wilken Dörrie authored
TBR=bokan Bug: 777258 Change-Id: Iabe5d80b83db19610a4b1c775c802e41a9c8c66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218112Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772264}
-
James Cook authored
ExternalPrefLoaderTest.PrefReadInitiatesCorrectly is only relevant pre-SplitSettingsSync, so disable the feature for that test. ExternalProviderImplChromeOSTest.PriorityCompleted needs to be updated to mark OOBE completed and simulate the correct type of priority pref sync. This is in preparation to enable SplitSettingsSync by default. See failing tests in tryjobs from: https://chromium-review.googlesource.com/c/chromium/src/+/2210623 Bug: 1060289 Change-Id: I3a3807c304334fa5a22df7e102f85ee1c629c312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215249Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#772263}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=dcastagna@chromium.org Bug: 1026641 Change-Id: Ib464bb9af983f16e6561e54e9a40b3352ab33a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217209 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#772262}
-
Dave Tapuska authored
Move RenderWidgetInputHandler into blink and call it from the WidgetBase. Some intermediate methods have been added to WebWidgetClient while the WidgetInputHandlerManager and MainThreadEventQueue are still on the content side. These APIs will eventually disappear when those classes are moved beside the WidgetBaseInputHandler. BUG=1073560 Change-Id: I06a202fb832c1d8655428ae1dff19178a2ba69be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212805Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#772261}
-
Owen Min authored
All future policies will be ignored by default unless it's whitelisted by EnabledExperimentalPolicies. Bug: 1076560 Change-Id: I17cd79bd3d7e501f70eb326348d9b64d37c58bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211091 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#772260}
-
Bo Liu authored
This is a reland of 9d2c67b2 Landed changes to relax LifetimeAssert when DestroyActivitiesRule fails. See bug for details. Original change's description: > android: Add LifetimeAssert to WindowAndroid > > Bug: 1081250 > Change-Id: Id0924545fbdb1eb28ae3c8fe015559fd3e9c53d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191785 > Commit-Queue: Bo <boliu@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771220} Bug: 1081250 Change-Id: Iea2dd27c5b114d748c6f0de8edf17c68b3ec98de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216798Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772259}
-
Thomas Lukaszewicz authored
Moved the Accelerator initalizers for TabbedPane into the constructor. This enables TabbedPane to be reparented without redundantly adding accelerators. Bug: 1083822 Change-Id: Iaa6483c6c6484a21c9ad17fa5b3948ca5118d94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208590 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#772258}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1303a1a15c88..55822f17bd5c 2020-05-27 egdaniel@google.com Add submittedProc to GrFlushInfo. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ic05cc310246fe12a1898d12e8c4ec3cf9c575b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772257}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d0a8b04f..9990e869 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0b3bacad1f51306689668a298b9e80cb29668bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218367Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772256}
-
Julie Jeongeun Kim authored
This CL disables the function to enable AX mode through ATK calls since it seems to enable it even when it's not required. After figuring out what API causes false positives, it will be enabled. APIs on Linux and enabling AX mode is allowed with the command line option, '--force-renderer-accessibility'. Bug: 1086506 AX-Relnotes: It disables automatic enabling AX mode on using ATK Change-Id: I6c0b865349d4f965700bf0ff0639f0508e712de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216135 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772255}
-
Tommy Nyquist authored
This reverts commit bee2010f. Reason for revert: OmniboxQueryTileSuggestionTest was added by this CL and is failing on: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-arm64-rel/21620 https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel https://ci.chromium.org/p/chromium/builders/ci/android-pie-arm64-rel https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel Original change's description: > Reland "Query Tiles : Integration test" > > This is a reland of d95d2248 > > Original change's description: > > Query Tiles : Integration test > > > > This CL adds end-to-end Integration tests for query tiles. The network > > layer is substituted by a embedded test server that serves a fake > > server response. Added omnibox javatests that use this mechanism to > > test the full flow. > > > > Bug: 1083807 > > Change-Id: Ida65dd9e093ce2311def892158c6bbe4de1fe3c3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206153 > > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > > Reviewed-by: Hesen Zhang <hesen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#770512} > > Bug: 1083807 > Change-Id: I7f65bfb79006201bdaa545c0aba8dd7cf2b4a243 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210654 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772139} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: I345b9c70b3de4e964f3e309117928992b69deb0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1083807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218490Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#772254}
-
chrome://newtabTibor Goldschwendt authored
This is a reland of 142274a8 with a fix for DiceBrowserTest.EnableSyncAfterToken. Original change's info: > Bug: 1015293 > Change-Id: Ic76e7911403a925fa46a5b5fc58eca95fa292269 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209392 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771116} Bug: 1015293, 1085540 Change-Id: Ifad9f0583ef0f5ec82b20068bd186b923d4e4eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216325Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#772253}
-
Amin Hassani authored
We want to move away from OnInstallStatus signal and instead move to a per-DLC signal DlcStateChanged. This new signal is designed to make it much easier for clients to monitor the state of a DLC. BUG=chromium:1071260 TEST=./testing/xvfb.py ./out/Default/unit_tests --gtest_filter=Dlc* Change-Id: Ibc042670afb5ec1fa9183bb20833d12c911ec94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213892 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#772252}
-
Dmitry Gozman authored
After PerNavigationMojoInterface has been launched, most commits used NavigationClient::CommitNavigation instead. This IPC was only used by non-committed interstitials. After r766516, even interstitials do not use this IPC, and all commits now go through NavigationClient. Bug: 1020175, 1077074 Change-Id: Iea23c7bd2e22a8adf8023f2fae8fcc3d8e60c404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214626 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#772251}
-
Kurt Horimoto authored
The VoiceSearchController created by VoiceSearchProvider may depend on state that is no longer valid after shut down. Reset BVC's pointer to it early so that shutdown can occur properly when the BVC is later destroyed. Bug: 1083208 Change-Id: I05dffce9eb79d353443eae759bc990fb61d74308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216804 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772250}
-
Allen Bauer authored
DefaultWidgetDelegate descends from WidgetDelegate which already sets the private widget_ field and overrides GetWidget(). Adding yet another member field of the same thing seems redundant. Bug: N/A Change-Id: I6e5036fdf667540893c3c0104d0bc08da0003e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216606Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#772249}
-
Milica Selakovic authored
Bug: 1086109 Change-Id: I270ffc2e1498b3671c6a771066217d978c5ad703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216650Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#772248}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b7228caa9292..d81fad6de554 2020-05-27 wolfi@chromium.org Reland "Port IssuesModel to TypeScript" 2020-05-27 tvanderlippe@chromium.org Fix es_modules_import to handle `.mjs` files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic2d37587ec471a350de26b3da531b5cfc7c9da60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218327Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772247}
-
Vladimir Levin authored
This patch removes style containment checks from stacking context computation since whether containment has an effect depends on the type of layout object created: - Rename ComputedStyle::IsStackingContext to IsStackingContextWithoutContainment. - Remove containment checks from UpdateIsStackingContextWithoutContainment. - Add LayoutObject::IsStackingContext/IsStacked that checks. style values without containment and also containment values that apply. - Updates code to use the new functions where appropriate. R=futhark@chromium.org, pdr@chromium.org Fixed: 1068596 Change-Id: I6bc09d8e1087394227a1bf2cee8d7c9c69b0ac7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204316 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772246}
-
David Van Cleve authored
I guess the French TV I've been watching recently has had an effect on my spelling. TBR=csharrison Change-Id: I6fea013a281ec9675ab7071f480653ce1809c7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217728Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772245}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/014197b581a3..df95f5d43f28 2020-05-27 danilchap@webrtc.org Add parametrized unit tests for av1 to check scalability structures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f13bc411be686e94f247af1409b26d82a7a94d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772244}
-