- 30 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/804e625def2c..e9a7015ec876 2020-10-30 wl@gnu.org Avoid non-ASCII character in public header file. 2020-10-30 wl@gnu.org ftimage.h: Improve description of `FT_Span`. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I3a5db51227a30e87b3a4c7bf362baa90376cc175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509670Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#822599}
-
Wei Lee authored
For multiple window management, we implement CameraAppWindowManager which will has a instance for each browser context. When a window is created, it changed the camera resource ownership and notify inactive windows to suspend current camera stream. Bug: 980846 Test: Tested with the latter CLs to make sure CCA works normally for multi-window scenarios. Change-Id: Ice92e321a8973c54c5a20ef4ac0759560ad49fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345898 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822598}
-
sandromaggi authored
The util is currently based on the |ActionDelegate|. It's not possible to use it together with the |WebController|. This refactor proposes to take out the |FindElement| step: It depends on either an |ActionDelegate| or |WebController| and cannot be easily abstracted. Instead of overloading the |FindElementAndPerform| (et al), for |WebController| (alongside the current implementation for |ActionDelegate|) this CL introduces a new |TakeElementAndPerform| (+ |TakeElementAndGetProperty|), that can be used as a callback to the |FindElement| call. Bug: b/168107066 Change-Id: Icbb2534203b643daa08267766ed6c8d9837f8e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506029Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#822597}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/66af8a4f3d16..20088de02e9a 2020-10-30 sigurds@chromium.org Report CORS errors as such in the network panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141824 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I17b4b57ef32fa5562aa3881d0c4db74a875e58dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509669Reviewed-by:
-
Sergey Poromov authored
Change-Id: I142606a281df724e9d77e2c2d8d72191a55dac45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507469 Auto-Submit: Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#822595}
-
Hiroki Sato authored
Before this change, when window is transitioning from maximized to snapped in a clamshell mode, the new bounds sent to the client included the caption height. But actually it shouldn't. The same issue is also observed for a snapped window in a tablet mode is transitioning to in a clamshell mode. This change fixes these bounds to have a correct client bounds. Bug: b:171283459 Test: ClientControlledShellSurfaceTest Change-Id: I9b566d17dd6e11c478b26c336b77e43cb49ca2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494290 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#822594}
-
Tomasz Śniatowski authored
Building a clean build can fail when compiling obj/content/common/common/zygote_communication_linux.o or obj/content/common/common/zygote_handle_linux.o with: fatal error: 'content/public/common/zygote/zygote_buildflags.h' file not found Reproduces readily if ninja is asked to build either of these .o files in a clean outdir. In a full build, usually the buildflag header gets generated in time. Fix by adding an explicit dep other internals of //content already had. Bug: 655123 Change-Id: Ifcc56b3a70a81bb4dd44d5d3de0cb882d81ab99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502183 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#822593}
-
Koji Ishii authored
This patch changes |NGFragmentItems::DirtyLinesFromNeedsLayout| to static, matching other |DirtyLines*| in crrev.com/c/2505262. Also removes two calls to |FragmentItems|, which we need to eliminate to support block fragmentation, in DCHECK and test. This patch has no behavior changes. Bug: 1061423 Change-Id: I13c8ad366935f0d7e2c37230030da8d649259b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505707Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#822592}
-
Mikel Astiz authored
This reverts commit a1b6965a. Reason for revert: test failures reported, e.g. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9520 Original change's description: > [filesapp] Add a files app SWA load test > > Add a files app SWA integration test: test that files app SWA loads in > the files app browser test harness. > > Remember the SWA web_contents so we can shut it down at the end of the > test. Supports only one running files app SWA instance for now. > > Test: browser_tests --gtest_filter="*launchFilesAppSwa*" > Bug: 1113981 > Change-Id: I78b4fafab57622fecc134b009858554bdcb05126 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507316 > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822544} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org,majewski@chromium.org Change-Id: I1409cf4f17dc70b5cf2af08b7839de6279c3c7ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509575Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#822591}
-
Wez authored
CastRunner now supports a pseudo app-Id, "fuchsia.web.FrameHost", which creates a meta-component that publishes the fuchsia.web.FrameHost API. Requests made through this API are routed to the CastRunner's "main" web.Context, allowing it to be shared with selected peer components on the system. Bug: b/170476111, 1120914, 1144102 Change-Id: I34d8cfbd22ed8bdf975f2a36d0bde0d508bba92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476216 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#822590}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/39b777c6f00f..257b9ad9fed6 2020-10-30 syoussefi@chromium.org Add a perf test for scissored draw calls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I054afd2ea55f395af36871f0a12d7d802b363625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509352Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ce259ef71f7..b2df07dc6650 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mastiz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mastiz@google.com Change-Id: I04890d685205740fc1c5776b2f46fa143f42f4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509389Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822588}
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/bb003dd7b64e..29ce0bde7aa7 $ git log bb003dd7b..29ce0bde7 --date=short --no-merges --format='%ad %ae %s' 2020-10-29 fayang Do not send control frames (by session) until encryption gets established. 2020-10-29 quiche-dev Update s-maxage separately from max-age for CACHE_ALL_STATIC client_ttl 2020-10-29 quiche-dev Project import generated by Copybara. 2020-10-28 haoyuewang Internal QUICHE change 2020-10-27 vasilvv Repalce QuicheTextUtils::HexEncode/Decode with Abseil equivalents. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ic3cf6a4e0e89f03b20cc40f9a4dd31c69a9489c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508970 Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#822587}
-
Kent Tamura authored
Specifying a 'writing-mode' value different from the host INPUT to its ::-webkit-textfield-decoration-container broke many things, and it was not helpful because inner-editor always has the 'writing-mode' value same as the host INPUT. This CL prohibits authors to specify 'writing-mode' to ::-webkit-textfield-decoration-container. Bug: 1144088 Change-Id: I6f19f541fbcbd6e4ff4eb074807d764ddce15004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509409Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Peter Marshall authored
DevTools undocked mode creates a separate browser and OS-level window in which DevTools is displayed. When we trigger surveys for undocked DevTools, we'd like them to display in the DevTools browser window rather than the main one. This CL adds a special case into HatsNextWebDialog to use the top_container view as the anchor for the Dialog UI for the DevTools browser. The DevTools browser has no tabs or navigation buttons so the top_container is actually empty, although still participates in UI layout. This results in the survey dialog being anchored in the top-right corner of the DevTools browser, which is ideal. When DevTools is docked, we don't change anything about the survey layout. It stays anchored to the menu, the same as any other survey. We also enable displaying surveys for browsers with type == devtools. The survey WebContents can trigger the opening of new tabs if the user clicks on e.g. the Privacy policy link. The existing implementation intercepts the open event in CreateCustomWebContents(). We put a special case in here to get the DevToolsWindow from the Browser. DevToolsWindow has a reference the inspected WebContents which it can use to open the link in a new tab in the same Browser window as the inspected page. There's an image of the survey displayed in the DevTools browser attached to the linked bug. Bug: 1112738 Change-Id: I7d0f250d47613a0975982b1f82db20c854b1ca88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505759Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#822585}
-
Mikel Astiz authored
This reverts commit 6b11534a. Reason for revert: suspect of causing crostini test failures, e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10961 Original change's description: > Reland "Crostini settings string changes." > > This is a reland of da531d49 > > Now that https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2505407 > is landed, this should be safe. > > Original change's description: > > Crostini settings string changes. > > > > Instead of "Linux (Beta)", now shows as "Developers" > > > > Bug: 1140370 > > Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: David Munro <davidmunro@google.com> > > Auto-Submit: Nicholas Verne <nverne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#820205} > > Bug: 1140370 > Change-Id: Ibb5bd28f9647847dddaf109e9da86d91b17dd863 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505324 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822525} TBR=khorimoto@chromium.org,nverne@chromium.org,davidmunro@google.com Change-Id: I1822f227f52e26960785610ba00fd0e5b2ce378e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509574Reviewed-by:
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I05f4526ee929fdab498f802412fb2b7a319e4c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508186 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#822583}
-
Mikel Astiz authored
This reverts commit 20fb36e3. Reason for revert: speculative revert for chrome_all_tast_tests failures affecting inputs.VirtualKeyboard* tests, for example https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/9751 Original change's description: > [IME] Remove IME UIL flags. > > Simplify the UIL/IME service dev/testing. > > TEST=simple chrome > BUG=b/171846787 > > Change-Id: Ibeef37bc89b848cffd5a4a08d5619d41a5c35b33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507236 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: Leo Zhang <googleo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822479} TBR=wuyingbing@chromium.org,shend@chromium.org,googleo@chromium.org Change-Id: I2c2a4ccda60320dd7099afcfc28a12122b11e982 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/171846787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509749Reviewed-by:
-
Olivier Yiptong authored
This change fixes a bug where glyphs were being decoded erroneously, with the code assuming latin-1 encoding. Unfortunately, due to limited ability to change system languages, or or to override these configurations, only the Windows implementation has test coverage. Change-Id: Ife4057db3af686a7cb476ad4503174aa1e89b180 Fixed: 1139805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504595 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#822581}
-
Koji Ishii authored
This patch supports block fragmentation by: 1. |TryDirtyFirstLineFor| has micro-optimization by not using |NGInlineCursor| but calls |FirstInlineFragmentItemIndex| directly. This may crash when |LayoutObject| is not in the first fragment. This patch fixes this issue by using |NGInlineCursor| and its built-in block fragmentation support done in <crbug.com/1112657>. 2. Turn all functions to |static|, because which |NGFragmentItems| has the item to mark dirty isn't clear for callers. 3. The work 2 above eliminates two calls to|FragmentItems|, which calls |CurrentFragment|. No perf impacts were observed. layout: https://pinpoint-dot-chromeperf.appspot.com/job/16a9d285520000 paint: https://pinpoint-dot-chromeperf.appspot.com/job/17fba859520000 Bug: 1061423, 829028 Change-Id: I924ebe4eabcb9ec096830b8ecf53edbb63504f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505262Reviewed-by:
-
Ramin Halavati authored
Constructor of Browser class is marked private in favor of using Browser::Create function. This change ensures that browser window creation can only happen if the context permits it, as Browser::Create() blocks creation if the context is not appropriate. E.g. if params.profile is a type that is not allowed to create browser windows. All remaining usages of the constructor are updated. While the changes to callsites in this CL are behavioral changes, all of the usages of the constructor updated in this CL are in tests, so the green bots suffice as evidence that the behavioral change is unproblematic. Bug: 916859 Change-Id: Ibbcb800590e60dfc9694edf407195125e8f94938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507816 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0eec65e17008..66af8a4f3d16 2020-10-30 alexrudenko@chromium.org Add align-content icons to the styles panel 2020-10-30 sigurds@chromium.org Prepare FrameDetailsView for absence of COOP/COEP information If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1138945,chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ied9acbbb2df203e41aad26ad49d6f91aacd5655a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509047Reviewed-by:
-
Mikel Astiz authored
This reverts commit 8e85f058. Reason for revert: causes blink_web_tests failures on Mac for media/video-replaces-poster.html Original change's description: > Crash if more than 1024 media events are generated in a second. > > These should be low frequency, otherwise there's a bug. > > R=tmathmeyer > > Bug: 1141985 > Change-Id: Ibfc915e7f2a4d524da33100dd43fff10b463376e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496023 > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822364} TBR=dalecurtis@chromium.org,tmathmeyer@chromium.org Change-Id: I2b37e8fe1ad5429f05d47cca125d0a081749c585 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1141985,1144096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509469Reviewed-by:
-
Mariam Ali authored
This CL updates NTP strings for ephemeral guest profile by adding educational bullet points about items that will not be saved on the device vs. items that will be saved. Screenshot: https://screenshot.googleplex.com/7Gf3vSb5iAWBHxt.png Bug: 1134111 Change-Id: I7096631987dcc143552c2c721ed1ca4868265987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442690 Commit-Queue: Mariam Ali <alimariam@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#822576}
-
Colin Blundell authored
On Android, the user data dir in Chrome and WebLayer by default is ANDROID_APP_DATA_DIR. In the context of Java browsertests, this directory is set to the isolated test root, which is problematic as it can't be cleared between runs (see linked bug). This bleedthrough of state can result in cryptic test failures. //chrome's android_browsertests handles this issue by overriding the user data directory in C++ at the //chrome level (https://chromium-review.googlesource.com/c/chromium/src/+/1677591). However, we are now facing this issue for weblayer_browsertests. This CL introduces a general solution for this problem at the level of NativeBrowserTestsActivity.java by allowing subclasses of this class to specify the command-line switch for the user data directory. Doing this specification will result in the user data directory getting overridden to the embedder-specified private data directory, which *is* cleared between each run by NativeBrowserTestsActivity. We do this specification for //weblayer as well as Content Shell-based browsertests. The latter solves the problem for the existing content_browsertests and components_browsertests suites, which are run on Android. //chrome's ChromeBrowserTestActivity.java does not subclass NativeBrowserTestsActivity as it subclasses ChromeTabbedActivity. Changing //chrome's android_browsertests to use this mechanism rather than its current one is left as future work. Finally, we note that this solution is a stopgap, as it leaves open the possibility that the C++ and Java sides have different views of the conceptual "user data dir". The proper solution for this problem would be for ANDROID_APP_DATA_DIR to *not* be set to the isolated test root but rather to a directory that is cleared between each run (e.g., a temp directory). That solution is however not easily accessible for reasons detailed in the bug. In the meantime, the stopgap solution of changing the user data dir on the C++ side only has been working in the context of android_browsertests for ~18 months. Bug: 617734 Change-Id: I8dd2fe25595f01a540af9a6c6c4787bb6570b62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504262Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#822575}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8a6bdf14d215..c21902c0d3cc 2020-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e3eaa60f1faf to 39b777c6f00f (20 revisions) 2020-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6ce7ceff to 2357c735 (507 revisions) 2020-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 2be25f08deaf to e6c9497255c6 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Test: Test: Test: Build on AOSP and launch CuttlefishTest: Test: VulkanMultithreadingTest::MultiContextDrawSmallDescriptorPools() Change-Id: I6539bf235093cbb557f71da371bc3ba450bc93e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509037Reviewed-by:
-
Rune Lillesveen authored
TBR=roagarwal@chromium.org Bug: 1140751 Change-Id: Id4965b0e2fc3707f6e645d702f5b13cd2e04f357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506445Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822573}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604015897-a1b8341d837100918c78553c7c6bd57ce99f9313.profdata to chrome-mac-master-1604037316-5e92166f122bfd61a727a711ba5668734a1ff275.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I699751562cf0babc70e293ade07e16eb230659be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508568Reviewed-by:
-
Chih-Yu Huang authored
Make GpuArcVideoDecodeAccelerator able to leverage VideoDecoder-backed VDA (i.e. VdVideoDecodeAccelerator) if the arc::kVideoDecoder feature is enabled. Bug: b:136716838 Bug: b:171683262 Test: ./video_decode_accelerator_tests test-25fps.h264 --use_vd_vda passes on Kukui. Test: Add argument "--enable-features=ArcVideoDecoder" and check that VdVDA is used when using Youtube on Kukui. Change-Id: I9e94484f3f67240cbdba2f8b1a312a1a2407752e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923969 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#822571}
-
Sinan Sahin authored
Bug: 1137941 Change-Id: I102d0e4b45c26a3a91937b61aaf30a75917540dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490541 Commit-Queue: Sinan Sahin <sinansahin@google.com> Auto-Submit: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#822570}
-
Wolfgang Beyer authored
DevTools CL: https://crrev.com/c/2485085 Disable test CL: https://crrev.com/c/2487269 Design doc: https://goo.gle/devtools-si Bug: chromium:1035309 Change-Id: I6d677127666c378a4537a9a132bc86dcc03ad1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485068Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822569}
-
Wei Lee authored
We use 'beforeunload' event listener to show confirm to leave dialog. Bug: 1140391 Test: Manually Change-Id: Ied6c0542fce505d46c5bbcb809740effe278c5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494407 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/24bd418544c6..7030291356e4 2020-10-30 dproy@chromium.org Add a way to skip tests 2020-10-30 robdclark@chromium.org Add msm gpu trace support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1111537 Tbr: nuskos@google.com Change-Id: I44e9523ff00eb9f4611df3be33e2777f36ce5ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509032Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604015897-cbf2d5639eb5b5579fe2658cc59cbce3c1075df1.profdata to chrome-linux-master-1604037316-5cbbc085308516b08a183c882c2ebb61cfb969d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If7d5490ecb7a4188522dfed14256f1b79c43ca03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509038Reviewed-by:
-
Mikel Astiz authored
The predicate that determines whether sync allows uploading demographics metrics now adopts GetUploadToGoogleState(), which is the standard way to implement this kind of logic. Note that the patch can have behavioral differences because it's more strict. These changes are expected to be very small and even desirable, for example: 1. If user manually disabled sync-ing of preferences, then the new predicate will return false. 2. If there is permanent auth error (other than user signout, which was already handled before), the new predicate will return false. Change-Id: I05f1c93ba6028cc4c91b790fd142b494d499d837 Bug: 1137346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467519Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#822565}
-
Xiaodan Zhu authored
This CL implements an alert bubble to prevent fake login. When a device returns from sleep or low brightness and the active window is fullscreen. Others can utilize the fullscreen window to imitate the lock/login screen to steal user's password. To prevent this, we generate an alert bubble to remind the user to exit fullscreen before entering the password. The users can also use the button in the bubble to exit fullscreen. Bug: 1107185 Change-Id: I181f1173777ada1ec45fe7148e7dc889668d6753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505335 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822564}
-
Omar Morsi authored
This is a reland of CL:2435386. It was reverted in CL:2507465 because it broke linux-chromeos-rel (see https://crbug.com/1143713). The main reason was real work being done in a DCHECK in key_permissions_manager_browsertest.cc Original CL description: > This CL introduces KeyPermissionsManager (KPM). KPMs are responsible for > managing platform keys permissions by reading and writing permissions > into chaps keys' attributes. > > Bug: 1113115, 1127284, 1082459 > Change-Id: I5d242604fe784566d086d2012313f77ca0fdbc44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435386 > Commit-Queue: Omar Morsi <omorsi@google.com> > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Edman Anjos <edman@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822131} TBR=asvitkine@chromium.org,edman@chromium.org Bug: 1113115, 1127284, 1082459, 1143713 Change-Id: I6f482bd06cf4801299ea28210fcb1498f38f57fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507712 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#822563}
-
Antonio Sartori authored
The PolicyContainer is a property of the RenderFrameHostImpl that stores several security policies. This CL mirrors the PolicyContainer in Blink in the LocalFrame on creation. There are several paths for frame creation (some are started by Blink, some by the Browser), and this change covers all of them. Additionally, the LocalFrame's PolicyContainer is wired via a mojo remote to the RenderFrameHost counterpart. Change-Id: Ia058d4dde077b9cb9dd51f891155ef1849d60afa Bug: 1130587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428242Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#822562}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e3c2eb0f04c8..0eec65e17008 2020-10-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0290c2bcaef4bf2427e35bf6b324ee95d36f556b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509034Reviewed-by:
-
Asami Doi authored
This CL removes RunOrPostTaskOnThread from ServiceWorkerContainerHost because a service worker runs on the UI thread now. Bug: 1138155 Change-Id: I4b9d7631011f0fb9f7a294c4af68ba16a0fb9eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507301 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#822560}
-
