- 15 Oct, 2018 40 commits
-
-
Khushal authored
The change [1] meant to apply this workaround to all Android devices but missed removing the gl_renderer filter. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1272451 R=ericrk@chromium.org Bug: 860021 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I48537a12e14035eff7b8699f5a43c402f490e6cc Reviewed-on: https://chromium-review.googlesource.com/c/1280552Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#599718}
-
Rune Lillesveen authored
There should be no reason to force computed style for the root element if it doesn't have one when trying to figure out if body background is propagated to the viewport. Change-Id: Ibf0beb7848101bd1acc20f16a826f0787ef010b9 Reviewed-on: https://chromium-review.googlesource.com/c/1280278Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#599717}
-
Fady Samuel authored
This reverts commit d15ba9ba. Reason for revert: This doesn't seem to solve the deadline reporting bug. This was a speculative fix that didn't fix the issue. Original change's description: > Surface synchronization: Don't report blocked duration of throttled children > > A child can be "throttled" for an arbitrary length of time if it is never > embedded. This skews blocked duration metrics. Simply don't report those > metrics if a surface is blocked on a parent. > > Bug: 890767 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I3c8a8494a5b1e5a973b2e5c2b61cffe5c2b76f6f > Reviewed-on: https://chromium-review.googlesource.com/c/1274591 > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598886} TBR=fsamuel@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 890767 Change-Id: I3b1188d49a1301681391d526abaa25dcabf69f79 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1281083Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599716}
-
Dan Harrington authored
This is in preparation for a schema upgrade. Improvements: - we test that the new schema is compatible with the old one (minimally) - the test won't need to be changed with the next version (only the .sql/data files) - the history of schemas is now clearly documented, and diffable - we test that the migrated schema matches, not just the data - it guarantees the next schema upgrade (v3) CL will test the current schema (v2) accurately. Change-Id: Ibd0de797bcfd878b24956946552eb7a77117124b Reviewed-on: https://chromium-review.googlesource.com/c/1179977Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#599715}
-
Ben Kelly authored
R=morlovich@chromium.org Bug: 894982 Change-Id: Ic3c5ee9923bbd3ade6c0a269416684094d25dc43 Reviewed-on: https://chromium-review.googlesource.com/c/1278906Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#599714}
-
Siddhartha S authored
Helps to show the impact of settings parsing in startup. BUG=890129 Change-Id: Ia92ebd734600a9114b7cffaf1296d7ada2d1c4f5 Reviewed-on: https://chromium-review.googlesource.com/c/1260142Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#599713}
-
Thomas Tangl authored
When sync is paused, the string for the history checkbox is changed from "Clears history and autocompletions in the address bar. Your account may have other forms of browsing history at myactivity.google.com." to "Clears history and autocompletions in the address bar." Bug: 893696 Change-Id: I1aba27b8902b39bc2e28e8e66e564a58327fcc33 Reviewed-on: https://chromium-review.googlesource.com/c/1280672Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#599712}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6164a6e58d71..482b936f1be1 Created with: gclient setdep -r src-internal@482b936f1be1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I76ea9c516e9f3ff370c43e6003b3ce770ce00da4 Reviewed-on: https://chromium-review.googlesource.com/c/1280409Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599711}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/11dd1ab3b9e9..c064d0b121db git log 11dd1ab3b9e9..c064d0b121db --date=short --no-merges --format='%ad %ae %s' 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 271ddb4ed93a..9369e44523c7 (1 commits) 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 758796a466bc..71e256cae02a (1 commits) 2018-10-15 brianosman@google.com Revert "Use SkImage to manage mip map cache purging, not Bitmap/PixelRef" 2018-10-15 caryclark@skia.org fix bookmaker 2018-10-15 ethannicholas@google.com add support for clears to Metal backend 2018-10-15 kjlubick@google.com Add ignore to Bazel file 2018-10-15 mtklein@google.com fAddedToCache tidy up 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a2d15d1a268c..758796a466bc (1 commits) 2018-10-15 mtklein@google.com Flutter also won't need NVPR. 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 7362d8835a07..271ddb4ed93a (1 commits) 2018-10-15 brianosman@google.com Use SkImage to manage mip map cache purging, not Bitmap/PixelRef Created with: gclient setdep -r src/third_party/skia@c064d0b121db The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I2e033f029a241fba8f41342dde1f3f81b08fa233 Reviewed-on: https://chromium-review.googlesource.com/c/1281024Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599710}
-
Theresa authored
BUG=894850 Change-Id: I15583ce5f5ad2cfecebdaa18d34df3ddd1176f33 Reviewed-on: https://chromium-review.googlesource.com/c/1279190Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#599709}
-
Dmitry Gozman authored
Ensure that all frames in the page loaded from mhtml have unique origins and content-id urls (except for the main frame which has a file url). Bug: none Change-Id: I0c1d40b82404de2e95e6a7e10dd354826a799d84 Reviewed-on: https://chromium-review.googlesource.com/c/1279188 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599708}
-
Ted Choc authored
NOPRESUBMIT=true BUG=843596 Change-Id: I08316abfd1e7be7427337538c722716a0737048f Reviewed-on: https://chromium-review.googlesource.com/c/1279184 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#599707}
-
Peter K. Lee authored
There are no more users of this API. Bug: 863559 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I96b5d14bc53093f6e5a02c57191fbb9f4c108b7e Reviewed-on: https://chromium-review.googlesource.com/c/1280849Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#599706}
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: css1/ - fast/cookies/ Most of this patch is mechanical rebaseline, except that some LayoutNG-specific baselines become redundant and are removed. Bug: 887148 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id8ab195c13d762b4e060f127203c7e4206c301f3 Reviewed-on: https://chromium-review.googlesource.com/c/1278210Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599705}
-
Ben Pastene authored
This reverts commit d0e6a977. Reason for revert: crbug.com/895337 Original change's description: > Automated Commit: LKGM 11157.0.0 for chromeos. > > BUG=762641 > TBR=achuith@chromium.org > > Change-Id: Idbd7085f4d721c9cb0316d896b739008dbdea75a > Reviewed-on: https://chromium-review.googlesource.com/c/1279954 > Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> > Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#599535} TBR=achuith@chromium.org,3su6n15k.default@developer.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 762641 Change-Id: Ia02d93e87498e23f04a19aa0e1140a55164b0eac Reviewed-on: https://chromium-review.googlesource.com/c/1281085Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#599704}
-
Xing Liu authored
This CL changes the storage string to [storage used by download] of [total disk size]. Bug: 892328 Change-Id: I6516c89e4f6bf71101c56b43171375a037cc36bf Reviewed-on: https://chromium-review.googlesource.com/c/1277917 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599703}
-
Justin Cohen authored
Although ContentSuggestionsViewController has been presented as a proper view controller for a while now, it has still used the CRWNativeContent methods wasShown and wasHidden to manage some state. As CRWNativeContent for the NTP will be going away, stop using this methods and instead use normal UIViewController state methods. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I64c3f3aebddd4590d71e0edea927f306c63bb542 Reviewed-on: https://chromium-review.googlesource.com/c/1280048 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#599702}
-
Justin Cohen authored
When kBrowserContainerPresentsNTP is enabled, bypass CRWNativeContent and instead present the NTP directly and return nil to ios/web. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I373f43dfe02b3242c87fe997b97238c824bda116 Reviewed-on: https://chromium-review.googlesource.com/c/1280047 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599701}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor and has no intended behavior change. Bug: 842194 Change-Id: I0d635e46bbaf3f9cfb7d5083445319c341c0cb76 Reviewed-on: https://chromium-review.googlesource.com/c/1245861Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#599700}
-
Robert Ogden authored
This is a manual workaround so that HTTPS Server Previews can be team fooded in 71 and will need to be merged back into the M71 branch. This checks if the user is on a preview page and is reloading via clicking the "load original" UI and if so, loads the orignal page. Bug: 864187 Change-Id: I2c8ed4edba98f30f398675c38d7f89d3848a0212 Reviewed-on: https://chromium-review.googlesource.com/c/1280853Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#599699}
-
Dmitry Gozman authored
These are helpers to retrieve resources from the bundle. We better place them together. Bug: none Change-Id: I7613c84f7b36872b2fc8ed01e7a57e66e309f4b6 Reviewed-on: https://chromium-review.googlesource.com/c/1278958 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#599698}
-
Aaron Leventhal authored
The accessible tree was not being updated when layout tree included nodeless objects, which are used to parent inline objects when they have block siblings. This fixes the closest node logic used to find a node for a layout object or layout ancestor. Bug: 895183 Change-Id: Iec46a5d97f60137a35350a9c4a5c89d45056a9a0 Reviewed-on: https://chromium-review.googlesource.com/c/1280789Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599697}
-
Andrey Kosyakov authored
- enable cookie encryption by default (use --disable-cookie-encryption to turn it off); - configure OSCrypt iff cookie encryption is enabled and profile path is set (there was a bug there, but it was masked by cookie encryption being disabled); - properly configure SSL channel id storage; - use mock keychain on MacOSX Bug: 864744 Change-Id: Ice97864bb80d8988e3e090310b35c509031a8e7d Reviewed-on: https://chromium-review.googlesource.com/c/1274199Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599696}
-
Greg Kerr authored
This reverts commit 8f0c72bc. Reason for revert: Blocking canary signing. Original change's description: > macOS: Remove keychain reauthorizing logic. > > The keychain was re-authorized to support Chrome's new signing > certificate 18+ months ago. At this point, users who haven't re-launch > Chrome in 18 months are unlikely to do so, or need the keychain. This > removes the re-authorization code. > > Bug: 893729 > Change-Id: I75b5a40407d196adfa5c31996024b9bb278221a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1271935 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599341} TBR=avi@chromium.org,kerrnel@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 893729, 895202 Change-Id: I3a82d2485307e1c3a0702fc486efbe5d1e7a8a7d Reviewed-on: https://chromium-review.googlesource.com/c/1280855Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599695}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/79b914075cc5..bbd532d164f0 git log 79b914075cc5..bbd532d164f0 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 jsaarhelo@nvidia.com Fix querying large vertex attrib divisors Created with: gclient setdep -r src/third_party/angle@bbd532d164f0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I2a4cb23466ace0df4b3819222cb8a81b912f0520 Reviewed-on: https://chromium-review.googlesource.com/c/1281023Reviewed-by:
-
Xiaoqian Dai authored
When a dialog is added to a window that's currently showig in splitscreen, we should adjust the dialog bounds to show the dialog aligned within its own side of the split, rather than across the divider bar. Note the divider is still placed on top of the snapped windows and its transient children if they are placed in default container. Bug: 878268 TBR=xiyuan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1274197 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#598827} Change-Id: I3e7377c053d14fcf3fd882abff2f860a88a61332 Reviewed-on: https://chromium-review.googlesource.com/c/1280674Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#599693}
-
Morten Stenshorne authored
We incorrectly thought that we had no lines, because we looked for legacy line boxes. Changed the test to a testharness test, because the text dump has some space differences between NG and legacy. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic2ff3b44e222475fcb07700e99f2f0a965fb72ad Reviewed-on: https://chromium-review.googlesource.com/c/1280546Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599692}
-
Fredrik Söderquist authored
The former looks like an open-coded version of the latter. Using the latter will be more consistent (and future-safe.) Change-Id: I3353d0181201df681779575d78fe0df22065a9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1280447Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#599691}
-
Justin Cohen authored
In preparation to make the NTP a contained view controller of the BVC, add helper classes to track activating and deactivating the NTP from a tab helper. Currently the NTP is displayed as native content within the web content area via CRWNativeContent. Rather than go thru ios/web for a native page, instead create and use a new NTP tab helper and display the NTP directly from within ios/chrome. Historically the NTP has been a collection of fake view controllers predating view controller containment. While much of the NTP hierarchy has been updated, this will be the final change required to have a normal NTP presentation with normal UIViewControllers. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8517c0231dbfdf42185a7d82ce4ca009e9002bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1280046 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4f5ccaaecd7e..7c39bf7b87f8 git log 4f5ccaaecd7e..7c39bf7b87f8 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 thestig@chromium.org Make FlateEncode()'s buffer out parameter a unique_ptr. Created with: gclient setdep -r src/third_party/pdfium@7c39bf7b87f8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icb6b7074406174b6382c505367ab9ce6e3fc7889 Reviewed-on: https://chromium-review.googlesource.com/c/1281022Reviewed-by:
-
chrome://process-internalsNasko Oskov authored
Bug: 850087 Change-Id: If9f76424b0c2574c67e2a1ed24f3029dfbd798c6 Reviewed-on: https://chromium-review.googlesource.com/c/1268658Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599688}
-
Chan authored
TBR=wjmaclean@chromium.org Bug: 891155 Change-Id: I149449fe0f847f23edc5b0565c76c5ace3c79afd Reviewed-on: https://chromium-review.googlesource.com/c/1281049Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599687}
-
Wei Li authored
UI DevTools have been out of sync with platform DevTools protocol. This will cause some runtime errors due to protocol incompatibility. This CL updates UI Devtools' protocol and corresponding handling code. For protocol update, we update the domain fields and its properties according to browser_protocol.pdl. We also arrange the order to put the name or id at the first, and use consistent order across different fields to make it more readable and easier for future updates. BUG=894623 Change-Id: Ic650c126155044d2e25c4ff068c5a7a17144584f Reviewed-on: https://chromium-review.googlesource.com/c/1277835Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#599686}
-
Jun Mukai authored
The following tests are flaky only on SingleProcessMash. BUG=895070, 895110, 895068 TEST=None TBR=sky@chromium.org Change-Id: I38c1ce550e00472933dbd16fcddec1d6b7af0e54 Reviewed-on: https://chromium-review.googlesource.com/c/1280854Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#599685}
-
Lindsay Pasricha authored
Bug: 828031,850125 Change-Id: If24779bb6387cdf06fa2936f3deb2a86ddbe7f3e Reviewed-on: https://chromium-review.googlesource.com/c/1280788 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#599684}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03da150665d9..9f274436bd0d git log 03da150665d9..9f274436bd0d --date=short --no-merges --format='%ad %ae %s' 2018-10-15 tandrii@chromium.org git cl: partially remove Rietveld support for uploading code. Created with: gclient setdep -r src/third_party/depot_tools@9f274436bd0d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408 TBR=agable@chromium.org Change-Id: I64d34ef394a89cf80ad7604f7685c1c6d3b143fd Reviewed-on: https://chromium-review.googlesource.com/c/1280420Reviewed-by:
-
Valeriya Sinevich authored
If PerformSetCookiesAction(...) was called then is_reconcile_started is true and Schedulereconcile.. will return directly. Otherwise it will already be called inside OnSetAccountsInCookieCompleted. Change-Id: I5a849ad4a261fc9ead736792e5639f4e27edd68f Reviewed-on: https://chromium-review.googlesource.com/c/1278815 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599682}
-
Nasko Oskov authored
JavaScript files for WebUI pages in chrome/ already are subject to clang-format, ESLint, and other checkers. This CL is changing all JS files in content/browser/resources/ to be clang-format'd, so a PRESUBMIT rule can be put in place to enforce proper formatting in future commits. PRESUBMIT.py will come separately as part of work to make the process-internals WebUI clang-format and eslint checked in https://chromium-review.googlesource.com/c/chromium/src/+/1268658. Bug: 841000 Change-Id: I22ee7649b3d524d68c5cb2b39a53f057150b181c Reviewed-on: https://chromium-review.googlesource.com/c/1279178Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599681}
-
Ian Kilpatrick authored
This allows web developers to access pre-computed sizes for the border, scrollbar, and padding "edges". This adds two types of tests: 1) Uses the standard "green box" approach of testing the script values match what is expected. 2) Positions four children at each corner (using edges) are positioned the same as using an abs-pos technique. Bug: 726125 Change-Id: I3b53be9b44989d919cb657d4eabc6d3a1a79181b Reviewed-on: https://chromium-review.googlesource.com/c/1252776 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Arthur Sonzogni authored
This is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1122629 It makes subframes to stay alive after the navigation commit. Find-in-page needs to stop tracking these frames immediately when they are in pending deletion, not when they are deleted. Bug: 609963 Change-Id: I9c8fa05ec3d571e79ecc22c1609ee59ff90b2b45 Reviewed-on: https://chromium-review.googlesource.com/c/1254262 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#599679}
-
