- 10 Dec, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change fixes two small issues found by the recently proposed bugprone clang-tidy checks [1]. [1] https://groups.google.com/a/chromium.org/g/cxx/c/hDDUlz1OMUw Bug: None Change-Id: I885cd1e019684f27a36265d9a11f65d554dc29f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582123Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835698}
-
Dylan Cutler authored
constructor is private. This is part of a larger cleanup effort to make CanonicalCookie's constructor private. This CL was verified by building/running the unit test suite when CanonicalCookie's constructor was locally changed to have a private constructor. Bug: 1102874 Change-Id: I1faa1b63e96091642c1a92ac8142b9de22c7d310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569941Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#835697}
-
Leonard Grey authored
Bug: 1152274 Change-Id: Idc567b91983adc94a968789c5599c1bfccfdb74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583011 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#835696}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81356f4bf38c..0443332fe2b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If68956f587a21e9e56813af0a9570b1df96f317d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584326Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835695}
-
Guillaume Jenkins authored
Makes the basic policy infrastructure changes to begin supporting the BrowserSignin policy. The policy handler is hidden behind a command-line switch, since the policy isn't fully supported yet. Attempting to sign in while setting this policy to 0 (sign-in disabled) will make the browser crash, as not all parts of the authentication flow correctly handles sign-in being disabled yet. Change-Id: Iefad6d36685bb11a26e55494dc3be4222e8366c5 Bug: 1155745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562719 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#835694}
-
Shengfa Lin authored
HttpServer moves to its own classes. Links need to be updated in threading.md. Change-Id: I1abd459b0ef463593d3fc025e26a50eac5ec67af no-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584882 Auto-Submit: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835693}
-
Mike Dougherty authored
The base, common, and message JS files were previously always included for every js_compile_checked gn target even though all compiled scripts do not rely on functions defined in these files. In this CL, the script dependencies are split apart in order to more explicitly list JavaScript dependencies. This is done in preparation of moving these shared scripts to a new architecture in order to support isolated worlds on iOS 14 and later. Additionally, improve script error logging messages which were useful while debugging script execution. Bug: 1042335 Change-Id: Iee9adef123c32bb69ebb8b3c9bb1fc58878f04f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554900Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#835692}
-
Nico Weber authored
Also rename the binary to match the name of the source file. No behavior change. Bug: 1147069 Change-Id: I61ffe9e1e1672db4e5f1d954949e196cca7fc701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583382Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835691}
-
Abigail Klein authored
activated by the focus manager. Bug: 1055150, 1156235 Change-Id: Iafc65c8f3f4ba0a9fa57a9db11d1c1a9cd5710fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582298 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#835690}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2bfd1bbc8538..d0379a1cd635 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aaronhk@google.com,msramek@google.com Change-Id: I23fc01caf6488c585844a61d819f5ad6e467a55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584345Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835689}
-
Daniel Vogelheim authored
Fix-it week: The console warning "The JavaScript Function constructor does not accept TrustedString arguments" was added because initially the JS Function constructor didn't support TT. The fix for this is currently behind a flag. The message should no longer be shown when the flag is active. Bug: 1152789, 1087743 Change-Id: Ib0539e3550cda57252f465448d773e1c5abcbc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577779Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#835688}
-
Tibor Goldschwendt authored
Requires crrev/i/3453282 to be rolled. Bug: 1152205 Change-Id: Ifed4a0d5b5591f01eccb583c8b72239e9cde6143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583135 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835687}
-
Nohemi Fernandez authored
Clean up for AccountConsistencyServiceTest that removes unneeded code and reformats GAIA cookie update tests to use full URL navigation rather than GAIA-only shortcut method. Bug: 1131027 Change-Id: If942fc4cafa349860f9341314c82a1fc544746eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577201 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835686}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org, reillyg@chromium.org Bug: 1144462 Change-Id: I7d02cb187c62be37259f445a182f8c971aa03661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580483 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835685}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. Bug: 1144462 Change-Id: I9c4fde80a4124753c11845cbcc202cce2c3d31a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582928Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#835684}
-
Mario Sanchez Prada authored
Migrate these legacy IPC message to the media.mojom.MediaPlayerObserver mojo interface, implemented by MediaSessionController in the browser process, and update their callers in the renderer process. This CL migrates these messages together to simplify the review process by avoiding unnecessary cycles, since the way they both get migrated is nearly identical. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I2e05e9fc39f17f3875fadcbaf65a28eff5170be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560621 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#835683}
-
Alex Ilin authored
This CL adds several methods to ProfilePicker and ProfilePickerView that allow the profile picker to display UserManagerProfileDialogs. Bug: 1156096 Change-Id: I28e4ac97ea878e69b760f32a3e1afb828049d498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582060Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835682}
-
Mario Sanchez Prada authored
Migrate this legacy IPC message to the media.mojom.MediaPlayerObserver mojo interface, implemented by MediaSessionController in the browser process, update its callers in the renderer process. Finally, this also migrates the code checking if the legacy IPC message is correctly sent and received in RendererWebMediaPlayerDelegateTest's SendsMessagesCorrectly unit test, by creating a new unit test in the HTMLMediaElementTest test suite (i.e. SendsMediaPlayerObserverMessages) and adding the infrastructure there to check that the new mojo message is sent and received in the other end. Note that this new unit test and the newly added infrastructure will be useful to migrate more code from from RWMPDTest.SendsMessagesCorrectly as these migrations progress. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I5417d6e4707b59559fdbc567dce3844a19884c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552596 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Liquan (Max) Gu authored
Context: Now that mJourneyLogger.recordTransactionAmount() no longer needs to be recorded with Event.SHOWN, the code structures that supported that can be removed, which includes: * mDidRecordShowEvent: used to guarantee that Event.SHOWN was recorded only once so recordTransactionAmount() was invoked once. Since JourneyLogger is designed in a way that Event.SHOWN can be recorded multiple times, this structure actually applied for recordTransactionAmount() only. * enableAndUpdatePaymentRequestUIWithPaymentInfo()'s return: this was introduced to call recordTransactionAmount() after providePaymentInformationToPaymentRequestUI(). Since all providePaymentInformationToPaymentRequestUI() happened with recordShowEventAndTransactionAmount(), this CL combines the two methods. Changes: * Removed mDidRecordShowEvent * Inlined recordShowEventAndTransactionAmount() and merge it to providePaymentInformationToPaymentRequestUI(). * Makes enableAndUpdatePaymentRequestUIWithPaymentInfo return void Bug: 1149936 Change-Id: I5097d92e6d4eeda0e582a19a9312a8d54ed68eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580589 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835680}
-
Leonard Grey authored
Bug: 1152274 Change-Id: I96773aca058a77390d8f2e8ea818dd56cc7c5f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581462Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#835679}
-
Shuran Huang authored
Add enum class object SamePartyCookieContextType into CookieOptions, as well as one field to store the enum and one field to store the size of the full party_context set. Bug: 1136102 Change-Id: I2e72d0d973097ad6f993f8ecc0d979bd4167f328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570123 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#835678}
-
Ali Juma authored
NavigationManagerImpl::InitializeSession is now a no-op, so it can be deleted. Bug: 738020 Change-Id: If007c519b358a3b9cdedc6e097400fd71442db27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579950Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#835677}
-
Mario Sanchez Prada authored
Migrate this legacy IPC message to the media.mojom.MediaPlayerObserver mojo interface, implemented by MediaSessionController in the browser process, update its callers in the renderer process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: Ibdd7e52f843b193009925532840bbe2051d8da48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553423 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Sigurdur Asgeirsson authored
Bug: 1143281 Change-Id: Ie0daf7aadc96f737cf95a36b1d54cc81e214f278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582729 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#835675}
-
Scott Violet authored
While this now only works for 1p, I'm assuming eventually we'll open up cct incognito to all, so that this will just work. BUG=1023759 TEST=none Change-Id: I21672e863ed5dc2d2d9174ee09295f0cb3c54439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581447 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#835674}
-
arthursonzogni authored
Two new regression tests about a bug waiting to happen. I was about to introduce a regression with patchset: https://chromium-review.googlesource.com/c/chromium/src/+/2578902/6 without triggering any test. This checks that after using document.open(), the sandbox flags are still applying. Bug: 1041376 Change-Id: I8654177e7edb040b9f34f948540b697af84a92d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582318Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835673}
-
Liquan (Max) Gu authored
Behavioural changes: * Before the CL, JourneyLogger.recordTransactionAmount() was triggered only when Event.SHOWN or Event.SKIPPED_SHOW is recorded. This was different from the desktop's behaviour(read crbug.com/1149936#c5 for more context). * After the CL, the method is triggered whenever all of the following conditions are met: (1) show() has been called, (2) apps have been queried, (3) payment details has stabilized. Regardless of Event.SHOWN and Event.SKIPPED_SHOW, which are recorded when UI is shown or skipped. The new behaviour is consistent with the desktop one. Changes: * Moved the calling of recordTransactionAmount() into the hook onShowCalledAndAppsQueriedAndDetailsFinalized(). Bug: 1149936 Change-Id: I4fc72e2289ab95303165622e395f9d499ebf338d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581218 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835672}
-
Tim van der Lippe authored
During the module.json extensions migration, we discovered that these two tests were breaking on the sources/network migration. However, many other tests that use/interact with the sources and/or network panel are passing. A closer investigation of these showed that they are relying on an intricate loading order, which assumes the module.json loading. Since we are changing the loading order, these tests start failing. Taking a closer look at the intent of the tests, we realized that we already have existing e2e-test coverage in the DevTools frontend. Therefore, we propose removing the problematic tests to unblock the extensions migration, while we maintain coverage through our e2e-tests. R=aerotwist@chromium.org Also-By: andoli@chromium.org Bug: 1134103 Change-Id: I56a57d1c190897c8419b6c9c1a0b4c016966df52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584164 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/59df85b5457e..9f89587dc4fc 2020-12-10 delphick@google.com Merge "docs: Fix text on span_join restrictions" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I28317e4cc5c1d885f29971dcf1fdddc9b9b5ca8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584344Reviewed-by:
-
David Tseng authored
Update these fairly old tests, removing code that's obsolete. Try this change on bots and hopefully most if not all will stick. R=akihiroota@chromium.org Fixed: 754870, 622387, 892960, 894016, 833318 Change-Id: I345385f0c538346ea993f2a79a3196402857d020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582529Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835669}
-
Stephen McGruer authored
Upstream WPT is now Python 3-first. To minimize the likelihood of Chromium engineers writing incompatible tests*, we should run the WPT parts of blinkpy under Python 3. * Or, more likely, incompatible Python file handlers (https://web-platform-tests.org/writing-tests/python-handlers/index.html) Bug: 1135554 Change-Id: I9813a81543219ede80bb58de971d2e4509ef4b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558741 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#835668}
-
Jakob Ivarsson authored
Bug: chromium:949156 Change-Id: I55cb3a3680d3c0fc4c3ae92df0d4de4494ad3856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584005Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Jakob Ivarsson <jakobi@google.com> Cr-Commit-Position: refs/heads/master@{#835667}
-
Ioana Pandele authored
The help launcher is only called if the help button has a targeted help menu item id, but the menu contained the default help item id. Bug: 1157428 Change-Id: Ib6c3c25e4a71268c0c9afccbb84bf2e43dd3922e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584504Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#835666}
-
Jan Wilken Dörrie authored
This change replaces usages of Blacklist with Blocklist in the PasswordStore, LoginDatabase and fixes comments that were missed in other places. Note that this change does not yet rename the actual SQL columns in the Login Data database. Bug: 1147799 Change-Id: I3860001dc12c4a3dc7a80ef9ca6c250c751ac457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581935Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835665}
-
Kyle Horimoto authored
This class logs metrics when core Phone Hub functionality is used, which will be used to log our 28DA user count. Note that this class is not actually instantiated; a follow-up CL creates an instance of this class and calls its instance functions. Bug: 1150634, 1106937 Change-Id: I224a1dd25d5d7f48b601392843d1a31a72d6743c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576474Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835664}
-
Mario Sanchez Prada authored
Migrate this legacy IPC message to the media.mojom.MediaPlayerObserver mojo interface, implemented by MediaSessionController in the browser process, update its callers in the renderer process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I91069208d3c724ff82a8716163d3b443f6a53d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554541 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81356f4bf38c..0443332fe2b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaf42916df60fa2ec66c50f37d3ef4f8939cbc81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584324Reviewed-by:
-
Anastasiia N authored
Move `InlineLoginDialogChromeOS::Source` to `account_manager::AccountManagerFacade::AccountAdditionSource`. `AccountAdditionSource` is used for UMA stats, which will be sent by `AccountManagerFacade`. Currently they are sent by `InlineLoginDialogChromeOS::ShowDeprecated`, but these methods will be removed. Note: `InlineLoginDialogChromeOSOnboarding` will keep sending the UMA stats because it is a different dialog. Bug: 1140469 Change-Id: I652fb807b3285181e8b43ad0560983d1e3a8764e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550668 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#835661}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/55b7f38f9036..32f1a8e81217 2020-12-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 84b9bb6621c7 to d94a77b304f4 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I384e0d414e7c6e4ea8aa9c474f166c5b4117e663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584084Reviewed-by:
-
Tom Anderson authored
* With X11EventSource::dispatching_event(), all XEventDispatcher needs is DispatchXEvent(). * XEventObserver::DidProcessXEvent() is unused. BUG=739898,1054581 R=sky Change-Id: I8a030cc6f16766a67316e9c6787b5e5ca6a143d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577887 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#835659}
-
