- 26 May, 2020 40 commits
-
-
Bo Liu authored
WebLayer forked ContentView for expediency, and now we are unforking it. Features that are added to ContentView in components: * support for using EventOffsetHandler with ContentView * ability to set and change WebContents later * setIsObscuredForAccessibility to disable accessibility Features kept in weblayer: * autofill Note also ContentView is now a FrameLayout, which does not matter to weblayer since weblayer does not add child views to ContentView anymore. Change-Id: I995aad7a3cd9c4a6d8f819d9fd9080548e14cd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213064Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771976}
-
Michael Chang authored
initWithSuiteName for NSUserDefaults should not use its own app bundle identifier. initWithSuiteName should use a suite that is distinct from the apps own main bundle identifier. Reference: https://developer.apple.com/documentation/foundation/nsuserdefaults/1409957-initwithsuitename?language=objc Bug: 1086669 Change-Id: Iea3316ac8c6752bab3fa0644fd18b7dbdd018390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213787 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#771975}
-
Olivier Li authored
Flakes were caused by a race between the first thread registering and the first iteration of loop in HangWatcher::Run(). Problem is fixed by always performing the Wait->Check->Possible Monitor cycle even if there are no registered threads. The only caveat is that this means a HangWatcher with zero registered threads will still wakeup on a heartbeat to attempt monitoring. This is never the case post-startup in practice. HangWatcher::Start() now has to be invoked manually so it can be done safely after invoking *ForTesting functions. Bug: 1078828, 1081654 Change-Id: I52f2ea6bb66e6e05b36c52dbc3d8108e756055ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196831Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Oliver Li <olivierli@google.com> Cr-Commit-Position: refs/heads/master@{#771974}
-
Abigail Klein authored
This reverts commit a1ac2a1a. Reason for revert: Broke aria-atomic=false (crbug.com/910669), which is the default behavior of live regions. This breakage is worse than the original bug this change was trying to fix. Original change's description: > A11y: Read entire live region with NVDA/Jaws > > This change forces NVDA/Jaws to read the entire live-region whenever it > is updated, regardless of whether the text is actually different. These > ATs perform synchronous, in-proc callbacks to get_newText, so the end > result is accomplished by forcing get_newText to return the entire text > chunk. > > This change has no effect on Narrator, which isn't hosted in-proc. > Narrator *does* listen for the LIVE_REGION_CHANGED message (via the > MSAA->UIA bridge), but it appears to be doing its own change-detection > internally to prevent repeated messages from being read. > > Bug: 863375 > Change-Id: I073f06c2b514cf3332f8cf141229130fe223d60e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817215 > Commit-Queue: Ian Prest <iapres@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#721159} TBR=aleventhal@chromium.org,iapres@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863375, 1067257, 910669 Change-Id: Ibba3689365066a231def41f195113a524ef65151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212965 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#771973}
-
Allen Bauer authored
Bug: 1044687 Change-Id: Ifa558915f308912e5bc49d147cbd8afa084e4e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213895Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#771972}
-
Hongbo Song authored
Steps: 1. From `cc` to `blink`: `cc//layer_tree_host_impl` =>`cc//proxy_impl` => `cc//proxy_main` => `cc//layer_tree_host` => `blink//layer_tree_view` 2. From `blink` to `content`: `blink//layer_tree_view` => `blink//widget_base` => `blink//web_frame_widget_base` => `content//render_frame_impl`. The next CL is for plumbing FSD from `content` to `page_load_metrics/observers/ukm_page_load_metrics_observer.cc` Change-Id: I572dc463ff9d3db36f5063746cc539f255a62d27 Bug: 922980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175117 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771971}
-
Wan-Teh Chang authored
Officially document the two special cases of gfx::ColorTransform::NewColorTransform(): the source color space is invalid, or the target color space is invalid. I discovered them while reading the source code, and found that they are enforced by unit tests. I am interested in relying on the second special case for YUV to RGB color conversion. So I'd like to document the special cases officially. Also some minor test cleanup. Tested: gfx_unittests --gtest_filter=SimpleColorSpace.ToUndefined Change-Id: Ie80948dc8bf1677d7f7fbd69e78790d3e45df76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211127Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#771970}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/adef79808a7d..b41316cd4c22 2020-05-26 philipp.hancke@googlemail.com test: fix typo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If67dc5c2defe2ff1ceb8592b56c118fb97fcb9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771969}
-
Henrique Ferreiro authored
This is a precursor CL needed before adding Mojo traits for WebDragOperation and WebDragOperationsMask, so that the new dependencies don't introduce cycles. Bug: 1039255 Change-Id: I7ab4fb9df4c509bde86570413a6a7174ef878616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213561Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#771968}
-
Scott Violet authored
This renames BottomControlsTest to BrowserControlsTest and adds the top-control ones. Given how finicky these are it seems best to conslidate them and share as much code as possible. BUG=1074438,1077825 TEST=test only changes Change-Id: I4f6544e93921688da78028e212c9ed3f530082b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216383Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771967}
-
Eugene Zemtsov authored
Ignore presentation feedbacks that don't have kHWCompletion or kVSync flags. Bug: 1042111 Change-Id: Ic0378f7e95050caa817973daf7248bd692ccd737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209643Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590508570-56b410f167fcfdeb6392e467837742983549ce30.profdata to chrome-win64-master-1590522742-b76e1162c3da480ee6f6075020dc3e74b538d7b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie09b95c7fba0cc8c13615cd70f5b684f4a221fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216758Reviewed-by:
-
David Benjamin authored
Bug: 1082304 Change-Id: Ie8acbf67b4304dc67f7c8883b2a418c383b046d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216596 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771964}
-
Jordan Bayles authored
This patch fixes some issues with tab sink availability by modifying the MediaRouterMojoImpl to have a single SinksQuery for all tabs, tabs_sinks_query_, instead of registering a unique sinks query for each unique tab media source id. In places where a media source id is expected, specifically for the media router providers themselves, a hardcoded media source id for tab 0 is passed. Bug: 1013769, b/154115531 Change-Id: I8cdb05fba9aa813153e66bf3af8e5f3d17581903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200015 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#771963}
-
Rouslan Solomakhin authored
This reverts commit 64d75f14 and relands commit 3f4fcf06. Reason for original revert: Broke internal build. Reason for reland: Deps have rolled, so the internal build should work now. TBR=oshima@chromium.org Bug: 1068516 Change-Id: Ifa114f2a92aa7ba0bfc6f35981b3cb29895f403b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209494 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771962}
-
Zhenyao Mo authored
First, this path is emulated in ANGLE on top of D3D on Windows and is super slow, so it should be disabled. Second, this path still has a bug that it messes up certain GL states and therefore causes Meet present fullscreen to trigger rendering issues on Windows. TEST=manual Change-Id: Icdb2e506979cc6bc07788b71a1668d393c67fbed Bug: 1064245,1079184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216361Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#771961}
-
Matt Reynolds authored
Adds the WebHID permission state to Page Info, including information about devices that the current page has been granted permission to access. Devices are listed with a button that removes the device permission. If the guard permission is set to Block, a control is provided to change it to Ask. BUG=1030493 Change-Id: I2ca80fd137c9fb6898fa937a06c64567f5ead831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918681 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771960}
-
Ben Pastene authored
Instead of adding every version of a given item, this will add only the current version's. This is a bit tricky since individual versions of an item are keyed by symlink. And since isolate doesn't follow symlinks, we have to follow them ourselves. Bug: 1027382 Change-Id: I6b3ea4ec15de3804e99fd6af768daac64f490d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931155 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#771959}
-
John Lee authored
This CL aims to update the elevation shadows on a few of the lingering places where we are using paper's shadows. The added CSS variables also will allow other WebUI to consume the variables [1]. https://imgur.com/a/8qlbMMn [1] https://source.chromium.org/search?q=%220%204px%208px%203px%22%20filepath:html&ss=chromium&originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 973674 Change-Id: I3eeff199526fc499c405edb39494b526c446f45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209634Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#771958}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/31c9c6949e02..e370ec6de4fa 2020-05-26 brandon1.jones@intel.com Allow Attempted Eviction When The Residency LRU Is Empty If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I5289d8bec6f9acb1ce9fab561d67813045d684d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216467Reviewed-by:
-
Jon Mann authored
This change splits up the combined shared/sync string into two independent rows and cleans up the unused strings. This also requires plumbing information about whether the active user configured the network from the metadata store through settings js. Bug: 966270 Change-Id: Ife352f0f78523b2d2f776b2bfd1b98b342250823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211742Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#771956}
-
Yi Gu authored
This is similar to crrev.com/c/2211048. cc::ScrollTimeline is considered as inactive if the scroller is not composited (not in cc::ScrollTree). Bug: None Change-Id: Id933a41ba40f8a736692653a934f963d52c011be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216711Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771955}
-
Dominic Battre authored
The ServerCacheReplayer replays captured communication with the autofill server. With the switch of the legacy autofill server to the new API server we want to keep using the traces recorded with the old server. This CL extends the ServerCacheReplayer to intercept traffic to the old and the new server, to read recorded traffice to the old and the new server, and performs the conversion as necessary. The ServerCacheReplayer is parameterized with a server type that is set according to the features::kAutofillUseApi feature. If the feature is configured to use the API server, the ServerCacheReplayer will re-encode all stored network traffic to follow the new API server's format when loading the data from disk. Analog steps are taken if the ServerCacheReplayer is configured to serve as a legacy server. Bug: 1079488 Change-Id: I59cb1fe50bddcc4bbc98b7a45fddc7dcc953eaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209078Reviewed-by:
Vincent Boisselle <vincb@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#771954}
-
Steven Bennetts authored
Shill's Service.Metered property can be modified by the user, or potentially enforced by policy. This CL adds the property to the ONC spec and the mojo API, and provides translation to and from Shill. Bug: 1078427 Change-Id: Ic745d480a3f6898d14aa39130124f040c6d23423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212986Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771953}
-
Tim Volodine authored
Extend the Android.WebView.Callback.Counts histogram expiration date. No change in logic. BUG=1066112 Change-Id: Ie4bbfcc218b05dce5fec9a078899c24b2e1f41a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212129 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#771952}
-
Jun Mukai authored
As revealed in the discussion in the reported bug, ash::FpsCounter and ui::AnimationMetricsReporter calculates a slightly different data points. For this specific case, ui::AnimationMetricsReporter would be better. Note that this does not recover the reported number to the original; Ash.WindowCycleView.AnimationSmoothness.Show.2windows to be ~50 and slightly shorter than previous value (~67), but this would mean that ash::FpsCounter wouldn't be good for computing animation smoothness. Bug: 1085501 Test: tast ui.WindowCycleView on coral/astronaut Change-Id: I747d5eeaaeb2c319fbe661e8c1d4b6f8c67ec296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212492Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#771951}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590508570-a99506fab2213a01c13861c108d98c27cee7cc0b.profdata to chrome-mac-master-1590522742-0a47a4b988135fc20c9cc7cd17fdfcf6ba51301c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie6ee3c549ff3d04287f89cdd50c34854b039f618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216754Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ba4e2b94289d..30298dc25394 2020-05-26 cclao@google.com Vulkan: Optimize out barrier needs for transition between shaderReadOnly 2020-05-26 jmadill@chromium.org Clean up overlay RenderPass count reporting. 2020-05-26 aleino@nvidia.com Fix issue where last 8 bits of D24X8 influence depth calculation. 2020-05-26 nguyenmh@ad.corp.google.com Fix replay crash when captured sample doesn't create binary data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I4fbfc49ca9922ba4d1f9aba5125738e1a15564ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216461Reviewed-by:
-
Yi Gu authored
The tests are no longer flaky after crrev.com/c/2199405. Bug: 1081543 Change-Id: I17717b1b2030af751457b4f516593a8d92cd88c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216322Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771948}
-
Xianzhu Wang authored
Bug: 1084839 Change-Id: I96882277cbd4a95aff53dda5c0f6ecd37bbf954e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212669Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771947}
-
Raphael Kubo da Costa authored
Instead of requiring each test to call InitializeMockUdevMethods(), install the mocks automatically in MockSensorDeviceManager itself. There is no functional change, but the code should look cleaner. Change-Id: I428cca938b3d13163f23f7bd2a093ca168081833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214389 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771946}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f6c971abea1..fd68d8279234 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com,mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1068160,chromium:1086389 Tbr: bcwhite@google.com,mpearson@google.com Change-Id: I0ab96384a23b6aacc30c8aaadb8c37f90129be48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216460Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771945}
-
Sinan Sahin authored
When the status indicator is shown in fullscreen mode, the text wouldn't fade-in. The animation would run, but the frames wouldn't be presented to the screen even though they are drawn. To work around that, this CL adds a #requestLayout() call at the start of the animation. Bug: 1083461 Change-Id: If816b2882b77e41a7b00d8b863548e8629aff248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216281Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#771944}
-
Regan Hsu authored
Remove ChromeVox announcement for the number of results, since the total number of results is already mentioned in each search result a11y. This "Displaying x number of search results" is removed not only because the total number of search results is already mentioned, but also because it races with the search result a11y announcement itself, and only loses, sometimes verbalizing and sometimes not. Final 'general' a11y videos: https://photos.app.goo.gl/zLPSKH8wySyMhfak9 (search results present) https://photos.app.goo.gl/bCzC1nR3EtvsM25c7 (no search results) Fixed: 1071284 Change-Id: I5ec0bbae99e58f4976619790b63188d35d416d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216286Reviewed-by:
-
Michael Thiessen authored
These tests all use only the NativeLibraryTestRule, and aren't obviously modifying other global state. For reference, the UNIT_TESTS batch can be run locally using: run_chrome_public_test_apk -A Batch=UnitTests Bug: 989569 Change-Id: Ie870bff30d88d5de82051c05bfd074274a61b41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216044Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#771942}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/603989e2c0d6..2be61a1df411 2020-05-26 scheib@chromium.org Document the parameter {heading} avilable to --output-format-heading. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I696887e9d30cd87459ae558f096cd7d3b0869154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216458Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ia1b962108bf7ea619bf76e3ca84f3b808d3bef0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212631Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#771940}
-
Adenilson Cavalcanti authored
The idea is to allow building the utests outside of Chromium directory structure, thus allowing to run the tests as part of AOSP or any other downstream project. Bug: 1032721 Change-Id: I21a93b35221a9f5438c8a50908af05725c28022a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210904Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771939}
-
Thomas Lukaszewicz authored
Bug: 1044687 Change-Id: I5b146bcb29f65516049bfe6d5010151e0f22b3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212541Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#771938}
-
Thomas Lukaszewicz authored
Currently TooltipAura creates a single TooltipView for its tooltips and shares this single instance between transient instances of Widget which are created as needed. This patch changes the behavior such that a new TooltipView is created for each new TooltipAura Widget. This ensures that each Widget hierarchy can assert ownership over its View tree in alignment with current Views best practices. Bug: 1044687 Change-Id: I8441ec4264c012d00bd68fd5c7a1d15113e02246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212800Reviewed-by:
-
