GitLab

BUG=b/33693796
TEST=covered by unittest

Change-Id: Ie48bb6e93c3e591fd749b996bd8294f87def0ec6
Reviewed-on: https://chromium-review.googlesource.com/990082Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547505}

This is to gain some more understanding about how request and response
header modifications are used in practice. See bug for more details.

Bug: 827582
Change-Id: I589483173d16988f1c0676cd0a6d768da12e1037
Reviewed-on: https://chromium-review.googlesource.com/988237
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547504}

Chrome uses MediaPlayer to handle HLS videos on Android. Starting from
Android P, the default return value for isCleartextTrafficPermitted() is
changing to false. This breaks MediaPlayer playback. We need to
explicitly set the cleartextTrafficPermitted flag, in order to maintain
the same behavior as O.

Bug: 827265
Change-Id: Id162ff32684ed0caee6e40a071892e883a44ef40
Reviewed-on: https://chromium-review.googlesource.com/988304Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547503}

Change-Id: I7251d6d06c993d241233e27b59ca598594a322a9

NOTRY=true # documentation change CL

Change-Id: I7251d6d06c993d241233e27b59ca598594a322a9
Reviewed-on: https://chromium-review.googlesource.com/990590
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547502}

This uses the new TextureLayer APIs to register SharedBitmapIds instead
of using ClientSharedBitmapManager, in order to get the registration in
the same IPC channel that the compositor uses for submitting frames
that include the TestPlugin's shared memory bitmaps.

The formula used for this change is:
- Change std::unique_ptr<viz::SharedBitmap> to scoped_refptr<cc::CrossThreadSharedBitmap>
- Allocate shm with viz::bitmap_allocation instead of with viz::SharedBitmapManager
- Generate a SharedBitmapId when allocating and register it with SharedBitmapIdRegistrar
- Store ownership of cc::SharedBitmapIdRegistration alongside each cc::CrossThreadSharedBitmap
- Remove forward decls/includes for SharedBitmap and SharedBitmapManager (still need for SharedBitmapId)

However, for TestPlugin a SharedMemory, and thus, a SharedBitmapId, is
only given to the compositor a single time ever, and deleted in the
ReleaseCallback. As well the SharedMemory is allocated earlier than
when it is given to the compositor. So the SharedBitmapId registration
is delated from the allocation step to where the SharedMemory is handed
to the compositor. But since we only use a SharedMemory once, we can
always do the registration there without any conditions.

R=piman@chromium.org

Bug: 730660
Change-Id: Idaf69b854062482f55d359f7542f576be7df1dd4
Reviewed-on: https://chromium-review.googlesource.com/987096
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547501}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I26277bdb085fa06f5e9e6419f379b6f3f085e814
Reviewed-on: https://chromium-review.googlesource.com/986259
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547500}

Added simple BrowserContext, NetLog and UrlRequestContextGetter
implementations for WebRunner on Fuchsia.

Bug: 822474
Change-Id: I15e894b9909253146ab6bb2450ec3ffea2c8ea10
Reviewed-on: https://chromium-review.googlesource.com/988933
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547499}

The link at the top of this README claimed that it was a subset of itself.
Links to the EDK and C system documentation are a little more useful :)

R=rockot@chromium.org

R: rockot@chromium.org
Change-Id: I314fadea0f40e8b999c03b7414862b0e1602ed1e
Reviewed-on: https://chromium-review.googlesource.com/985241
Commit-Queue: Jeremy Apthorp <jeremya@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547498}

The GLDEBUGPROC type was fixed in mesa by https://crrev.com/c/969083 so
we can fix the skia binding code to not require a reinterpret_cast.

Bug: 786591
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4d36d115b1423a353af81c69a18d743007cebd85
Reviewed-on: https://chromium-review.googlesource.com/985801Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547497}

Bug: 805224
Change-Id: I08528e44e79d0a097cfe72ab4949dda538efd098
Reviewed-on: https://chromium-review.googlesource.com/988695Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547496}

This will be used to hold back display of the Emoji menu item until full cross-desktop support is complete.

Bug: 827404
Change-Id: I65e72e8da9ab1864f0773d51fe9facc9c4fc1a44
Reviewed-on: https://chromium-review.googlesource.com/988683
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547495}

Bug: 809261
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Idafb2b4cc5da3d6c7a054e479745288cc3b86513
Reviewed-on: https://chromium-review.googlesource.com/984338
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547494}

Bug: 793908, 793907
Change-Id: I28335e470c902c18f9aaed5d2611e1ac090cac53
Reviewed-on: https://chromium-review.googlesource.com/990208Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547493}

This test checks for a specific contentOffset, which is different under the
UIRefresh experiment.

BUG=825431

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibe5e4743eb6471025fde7b27785a4267f42e0e91
Reviewed-on: https://chromium-review.googlesource.com/989250
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547492}

1. Styling was updated for more consistency with the rest of the
   DevTools.
2. Ctrl/Cmd + F on the Network panel will now open network search view.
   Ctrl+Shift+F (Cmd+Opt+F) will open sources search globally.
3. Bugfixes.

R=pfeldman

Change-Id: Icab3bddc60fbcf3a4893171f92f59ff2247d0323
Reviewed-on: https://chromium-review.googlesource.com/988938Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547491}

This reverts commit 579e583e.

Reason for revert: monochrome_apk_checker.py needs to be updated.
crbug/827937

Original change's description:
> Reland "Reland "Enable extracting unwind table on official builds without channel""
> 
> This reverts commit 2298aca2.
> 
> Reason for revert: Remove changes made in monochrome since apk merge script needs to
> be updated first.
> 
> Original change's description:
> > Revert "Reland "Enable extracting unwind table on official builds without channel""
> >
> > This reverts commit 0db71a0d.
> >
> > Reason for revert: Monochrome apk merge is failing because the unwind
> > file for both apk has the same name.
> >
> > Original change's description:
> > > Reland "Enable extracting unwind table on official builds without channel"
> > >
> > > This reverts commit a2474b64.
> > >
> > > Reason for revert: The failure was due to parent CL getting reverted
> > > Relanded parent in: https://chromium-review.googlesource.com/c/chromium/src/+/984452
> > >
> > > Original change's description:
> > > > Revert "Enable extracting unwind table on official builds without channel"
> > > >
> > > > This reverts commit eb07cea1.
> > > >
> > > > Reason for revert: Windows tryjobs are failing.
> > > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-rel%2F81420%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout for an example.
> > > >
> > > > ERROR at //base/BUILD.gn:1802:33: Undefined identifier in string expansion.
> > > >     "CAN_UNWIND_WITH_CFI_TABLE=$can_unwind_with_cfi_table",
> > > >                                 ^------------------------
> > > > "can_unwind_with_cfi_table" is not currently in scope.
> > > > See //BUILD.gn:65:5: which caused the file to be included.
> > > >     "//base:base_perftests",
> > > >     ^----------------------
> > > > GN gen failed: 1
> > > >
> > > > Original change's description:
> > > > > Enable extracting unwind table on official builds without channel
> > > > >
> > > > > This CL enables extraction of unwind tables for chrome when
> > > > > is_official_build is set to true and when android_channel is not set to
> > > > > a release channel. This affects build time only on official builds.
> > > > > Also, Set legacy heap profiler to use unwinder for profiling.
> > > > >
> > > > > TBR=dpranke@chromium.org
> > > > > BUG=819888
> > > > >
> > > > > Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244
> > > > > Reviewed-on: https://chromium-review.googlesource.com/976944
> > > > > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#546425}
> > > >
> > > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> > > >
> > > > Change-Id: Id033094871dfcf74248f631390f15f379d9cd3c7
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 819888
> > > > Reviewed-on: https://chromium-review.googlesource.com/983893
> > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > Commit-Queue: agrieve <agrieve@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#546478}
> > >
> > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> > >
> > > Change-Id: I100f540c8d5bc9f59b9631ea207c7f290dc42e96
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 819888
> > > Reviewed-on: https://chromium-review.googlesource.com/985112
> > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#547196}
> >
> > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
> >
> > Change-Id: Ifa59a5882b18c2634bcf96c2c1fc58b09d7f303f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 819888
> > Reviewed-on: https://chromium-review.googlesource.com/989153
> > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#547332}
> 
> TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,ctzsm@chromium.org
> 
> Change-Id: I7750c70e52b55ccfbf1e2457a19fee4852575e59
> Bug: 819888
> Reviewed-on: https://chromium-review.googlesource.com/989192
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547361}

TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,ctzsm@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 819888
Change-Id: I064a5bdae54fa1552eee14ee72d08f15cf081a63
Reviewed-on: https://chromium-review.googlesource.com/990092Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547490}

BUG=820250

Change-Id: I0bda360c1bf70887a56937ce0fc42f05c9d37083
Reviewed-on: https://chromium-review.googlesource.com/990193Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547489}

This is less likely an issue because I'm no aware of an app that can't
be maximized/snapped in chrome (arc will use different code path)
but this is right thing anyway.

Bug: None
Change-Id: Ia7f49fd99000574b9431218b3be873baed9afdd0
Reviewed-on: https://chromium-review.googlesource.com/987542
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547488}

Changes:

Create docs/speed/benchmark/ folder
Move docs/speed/benchmark_harnesses/telemetry_device_setup.md to docs/speed/benchmark/
Move the rest of the docs in docs/speed/benchmark_harnesses to docs/speed/benchmark/harnesses

Change-Id: Ief809e8bc2da776ece0c595c449fd9b7f676825f

NOTRY=true # This is just documentation change

Change-Id: Ief809e8bc2da776ece0c595c449fd9b7f676825f
Reviewed-on: https://chromium-review.googlesource.com/990579
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547487}

This removes the feature from behind the flag to prepare for launch.

The string change was has been approved by the UI team.

Bug: 801410
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I348caab1905fba8d54f2981bd15e55301f6aad9e
Reviewed-on: https://chromium-review.googlesource.com/981158Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547486}

Just moving the files, no functional changes.

BUG=803135

Change-Id: I4784172d7b41152531ae3cb7e569613b66132cc7
Reviewed-on: https://chromium-review.googlesource.com/988416Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547485}

Creating common UI Element, Root Element, DOM, CSS and Overlay agents
for UI and Viz DevTools to avoid dependencies. CSS agent contains only
common logic, so there won't be ui-specific or viz-specific CSS Agent.

All the ui_devtools/views/ files are built for aura only. Once we add
Viz logic we want it to work in the same manner but with Viz objects. So
Agents' functionality and the structure of the UIElements must be left
as is. But currently all the agents and ui elements in UI DevTools are
the mix of aura-functionality (like DOMAgent::BuildTreeForWindow) and
non aura-functionality (like DOMAgent::GetDocument). If we just move
all these files to components/ui_devtools (assuming they'll be common
for Viz and Aura) Viz will then have to include aura as a dependency.
So I'm just separating aura-specific functionality (and leave it in
ui_devtools/views) from common functionality which I move to components/
ui_devtools.

Bug: 816802
Change-Id: I3fd3eaca1cd2a7cc8528c12d20979cddfaed994e
Reviewed-on: https://chromium-review.googlesource.com/979135Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#547484}

https://chromium-review.googlesource.com/c/chromium/src/+/985345 added
a second TryCatchScope test helper with different assumptions to the
existing one in bindings/core/v8/ScriptPromiseTest.cpp - which then
broke jumbo builds due to ambiguous namespace lookup results.

Let's rename the TryCatchScope in ScriptPromiseTest.cpp to avoid this
problem.

TBR=yhirano@chromium.org

Bug: 769663
Change-Id: If9911951669f806a17919c78e1990f3f04209df9
Reviewed-on: https://chromium-review.googlesource.com/989754
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547483}

This reverts commit fb48059c.

Original change's description:
> cc: Add some diagnostic CHECKs for sw image cache crashes.
>
> Change a few DCHECKs to CHECKs to validate if some crashes are
> resulting from using unlocked images, or incorrectly unlocking them
> earlier.
>
> R=​enne@chromium.org, ericrk@chromium.org
>
> Bug: 802976
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ibe0b9ef6ac52e6fafc9fd2670e20a9eefac17234
> Reviewed-on: https://chromium-review.googlesource.com/979160
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545724}

TBR=enne@chromium.org,khushalsagar@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826208
Change-Id: I152d1354ba7f43b77ae95d6edcf9f579109f6d91
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/980720
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547482}

Aura requires that display::Screen::GetScreen() returns a valid object.
1. Added WebRunnerContentBrowserClient,
2. Added WebRunnerBrowserMainParts,
3. Added display::Screen, created by WebRunnerBrowserMainParts.

Bug: 822474
Change-Id: Id22a6a369b89ed0f911513adb17f33ed8b503f26
Reviewed-on: https://chromium-review.googlesource.com/988841
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547481}

This behavior is missing in OOBE flow.

Bug: 826933
Bug: b/73338382

Test: Manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ccb4dc84469c4612c24cd6e5c387b4949277b13
Reviewed-on: https://chromium-review.googlesource.com/988807Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#547480}

Cleanup that was missed previously.

Bug: 822438
Change-Id: I070007a99f561debac65858da171d3b71b069211
Reviewed-on: https://chromium-review.googlesource.com/990482Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547479}

Tests pending since we probably want to get this out in the very next
canary to avoid messing up further metrics.

Bug: 827592
Change-Id: I522e1880a78e1bb2e60eae5ff974e027a3b00676
Reviewed-on: https://chromium-review.googlesource.com/990153Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547478}

Move EMF conversion test code into methods. These methods will soon be
used in multiple tests.

Also delete a temporary file generated by the test.

Change-Id: Ia7e9811dd617601fa0dff37a58c2f83715b7e3b1
Reviewed-on: https://chromium-review.googlesource.com/989427Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547477}

Using -[NSEvent description] can be slow, so instead build a description
string manually. This contains just the information that is useful in
crash analysis, so it's faster.

Bug: 770405
Change-Id: Ib4e0fd54daa0412f4f8c1e3d500d1f048f0940f8
Reviewed-on: https://chromium-review.googlesource.com/990155Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547476}

This reverts commit c7ab5772.

Reason for revert: Failing Linux ASan/LSan tests:

Indirect leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0xb77492 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:92:3
    #1 0xa3bea84 in __allocate buildtools/third_party/libc++/trunk/include/new:228:10
    #2 0xa3bea84 in allocate buildtools/third_party/libc++/trunk/include/memory:1793
    #3 0xa3bea84 in allocate buildtools/third_party/libc++/trunk/include/memory:1547
    #4 0xa3bea84 in __split_buffer buildtools/third_party/libc++/trunk/include/__split_buffer:311
    #5 0xa3bea84 in void std::__1::vector<PrefStore::Observer*, std::__1::allocator<PrefStore::Observer*> >::__push_back_slow_path<PrefStore::Observer* const&>(PrefStore::Observer* const&&&) buildtools/third_party/libc++/trunk/include/vector:1578
    #6 0xa3b5797 in push_back buildtools/third_party/libc++/trunk/include/vector:1599:9
    #7 0xa3b5797 in base::ObserverList<PrefStore::Observer, true, true>::AddObserver(PrefStore::Observer*) base/observer_list.h:246
    #8 0x162f16a5 in PrefValueStore::PrefStoreKeeper::Initialize(PrefValueStore*, PrefStore*, PrefValueStore::PrefStoreType) components/prefs/pref_value_store.cc:36:18
    #9 0x162f1e2a in InitPrefStore components/prefs/pref_value_store.cc:295:22
    #10 0x162f1e2a in PrefValueStore::PrefValueStore(PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefNotifier*, std::__1::unique_ptr<PrefValueStore::Delegate, std::__1::default_delete<PrefValueStore::Delegate> >) components/prefs/pref_value_store.cc:61
    #11 0x24a286b6 in make_unique<PrefValueStore, TestingPrefStore *&, nullptr_t, TestingPrefStore *&, nullptr_t, TestingPrefStore *&, TestingPrefStore *&, PrefStore *, PrefNotifierImpl *&> buildtools/third_party/libc++/trunk/include/memory:3079:32
    #12 0x24a286b6 in TestingPrefServiceBase<sync_preferences::PrefServiceSyncable, user_prefs::PrefRegistrySyncable>::TestingPrefServiceBase(TestingPrefStore*, TestingPrefStore*, TestingPrefStore*, TestingPrefStore*, user_prefs::PrefRegistrySyncable*, PrefNotifierImpl*) components/sync_preferences/testing_pref_service_syncable.cc:24
    #13 0x24a28d10 in sync_preferences::TestingPrefServiceSyncable::TestingPrefServiceSyncable() components/sync_preferences/testing_pref_service_syncable.cc:47:7
    #14 0x7195215 in chromeos::(anonymous namespace)::CupsPrintersManagerTest::CupsPrintersManagerTest() chrome/browser/chromeos/printing/cups_printers_manager_unittest.cc:256:27
    #15 0x71ac20e in CupsPrintersManagerTest_GetPrinter_Test chrome/browser/chromeos/printing/cups_printers_manager_unittest.cc:477:1
    #16 0x71ac20e in testing::internal::TestFactoryImpl<chromeos::(anonymous namespace)::CupsPrintersManagerTest_GetPrinter_Test>::CreateTest() third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:466
    #17 0x7a50817 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest-internal-inl.h
    #18 0x7a51c56 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2779:28
    #19 0x7a77366 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5036:43
    #20 0x7a765d6 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #21 0x116d296b in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2314:46
    #22 0x116d296b in base::TestSuite::Run() base/test/test_suite.cc:275
    #23 0x116d8c84 in Run base/callback.h:95:12
    #24 0x116d8c84 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    #25 0x116d874d in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #26 0x116b4b87 in main chrome/test/base/run_all_unittests.cc:30:10
    #27 0x7eff3bb53f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

Original change's description:
> Changing CupsPrintersManager to use Enterprise Printing Policy
> 
> Hooked up CupsPrintersManager to receive update callbacks whenever the
> value of the UserPrintersAllowed pref is changed. If the pref is set to
> false then CupsPrintersManager will disallow any changes made to
> non-enterprise printers.
> 
> R=​skau@chromium.org
> 
> CQ-DEPEND=CL:972627
> 
> Bug: 827016
> Change-Id: Id35de08fee33106f0122af07eea572757aae9c5f
> Reviewed-on: https://chromium-review.googlesource.com/982273
> Commit-Queue: David Valleau <valleau@chromium.org>
> Reviewed-by: Drew Wilson <atwilson@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547243}

TBR=atwilson@chromium.org,skau@chromium.org,valleau@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 827016
Change-Id: I641993fa4ca9e35901a6c95a9312ec802220eef4
Reviewed-on: https://chromium-review.googlesource.com/990313Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547475}

BUG=b/33693796
TEST=covered by unittest

Change-Id: Ief4d7ff8426ce8c54ad0fbcf34f54bbbd72490cf
Reviewed-on: https://chromium-review.googlesource.com/989849
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547474}

Change-Id: I1506ad5d9ddc3dac74d1d2ccd0e702c1a3191855
Reviewed-on: https://chromium-review.googlesource.com/985108Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547473}

1) Add pe_image_safe project.
2) Rename packed_list_format to shared_defines, and all references.
3) Expose blacklist::DllMatch(), with new wrapper, in preparation for next CL.
4) Adjusted IMEs.cc to use the new centralized pe_image_safe source set.

TBR=grt@chromium.org
Bug=769590
Test=chrome_elf_unittests.exe

Change-Id: Ice1272506237164e97e45d54901f4ec7712b2475
Reviewed-on: https://chromium-review.googlesource.com/957347
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Penny MacNeil <pennymac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547472}

And use that in the XHR code.

Bug: 754493, 712693, 791702
Change-Id: Ic0904558d43131cc2240805eaa794359f6a3f1d7
Reviewed-on: https://chromium-review.googlesource.com/957600
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547471}

Also use the two argument version of UMA_HISTOGRAM_ENUMERATION which
autodeduces the boundary value.

Bug: 742517
Change-Id: I41bb007b16869456baa16b5ab8753c1bd3e565cc
Reviewed-on: https://chromium-review.googlesource.com/989418Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547470}

This CL extends FaceDetectionImplMacTest to also use
FaceDetectionImplMacVision when appropriate.

services_unittests --gtest_filter=*Face* --use-gpu-in-tests

Bug: 799319
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I06c04d9773cac223f5f3612daa6a534a744fa9d8
Reviewed-on: https://chromium-review.googlesource.com/968671
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547469}

Just adapt the context menu code the same way as the Shelf code.

- Added the USE_TOUCHABLE_LAYOUT run type.
- Added the BUBBLE_TOUCHABLE_LEFT anchor type.
- Modified anchor rects.
- Modified ContextMenu builder classes to pass icons.
- Add virtual function to AppContextMenu which allows us to only
  add enabled menu options to the model.
- Move all check items to the end of the context menu.
- Modified tests to test the new context menus.
- Added more assets.

Bug: 793155
Change-Id: I1ac52331b437b13398143e1f6b96a48f64d0262d
Reviewed-on: https://chromium-review.googlesource.com/987551
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547468}

When FinishTailProcessing runs, swap out tail_processing_handlers_
before processing the list because DisableOutputs() can add new items
to it, and reallocate the vector.

Bug: 826232
Change-Id: I61e0c7b7ead40c7abe9807795c28699931402b59
Reviewed-on: https://chromium-review.googlesource.com/988298Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547467}

Bug: 731962
Change-Id: I6a77909f45f14762ec94ced476c66999b02878f7
Reviewed-on: https://chromium-review.googlesource.com/990195Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547466}