GitLab

https://skia.googlesource.com/skia.git/+log/9893f8e15152..95253bd0acff


git log 9893f8e15152..95253bd0acff --date=short --no-merges --format='%ad %ae %s'
2019-06-05 brianosman@google.com Fix SkSL standalone compile errors
2019-06-05 michaelludwig@google.com Combine GrPerspQuad and GrQuad
2019-06-05 egdaniel@google.com Move readSurfacePixels and writePixelSurface into GrSurfaceContext.
2019-06-05 mtklein@google.com Revert "print 1/K floats as fractions"
2019-06-05 robertphillips@google.com Revise GrDataUtils to be more self-contained
2019-06-05 jvanverth@google.com Add GrCFResource::reset() to allow Chrome to transition to sk_cf_obj.
2019-06-05 bsalomon@google.com Add API to invalidate GL texture parameters from GrBackendTexture.


Created with:
  gclient setdep -r src/third_party/skia@95253bd0acff

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Change-Id: I61fa5725388d3e7d9a6cfcab6f5804ec1dc8bcc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645258Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666371}

This is a reland of febfd29f

This change was pulled out due to pre-existing bugs allowing ignored
nodes to be serialized, this caused a new DCHECK to be hit.
For this change, that DCHECK has been removed.

Additional changes in this CL:
* unignored_index_in_parent is now of type size_t.
* ignored nodes now have an unignored_index_in_parent of 0
* calling GetUnignoredIndexInParent on an ignored node is now disallowed

Orignal Change:
https://chromium-review.googlesource.com/c/chromium/src/+/1535171

Revert of original change:
https://chromium-review.googlesource.com/c/chromium/src/+/1610026

Reland:
https://chromium-review.googlesource.com/c/chromium/src/+/1609590

Revert of Reland:
https://chromium-review.googlesource.com/c/chromium/src/+/1620907

Explanation of change:
Today, we have a single concept for ignored elements:
AccessibilityIsIgnored
This is true for elements that are determined to not be worth adding to
the accessibility tree, like:

* an empty div
* a display:none element
* line breaks (br)

However, it is useful for browser-side code to have access to these
elements.

My change allows for us to serialize an ignored node and send it to the
browser-side accessibility tree. (Although this change does not actually
do so).

Nodes that are ignored are marked as such (ax::mojom::State::kIgnored),
and then serialized.

A similar change was attempted a little over a year ago by Dominic
https://chromium-review.googlesource.com/c/chromium/src/+/912136
His change attempted serialize all nodes, even if it is ignored.
That change was never merged and was recently abandoned.

His recommendation was to only serialize *some* of the ignored nodes, to
better scope the change.

To enable only serializing some of the ignored nodes, a new concept/API
was created:
AccessibilityIsIncludedInTree
This does not guarantee a node not ignored, only that is
should be serialized and included in the browser-side accessibility
tree. Subsequent change will add conditions to which
AccessibilityIsIncludedInTree is true, allowing for an ignored node to
be serialized. Some areas continue to care if a node was ignored, and
these areas will continue to call AccessibilityIsIgnored, so the
distinction is useful.

Eventually, the goal is to serialize all nodes and send them to the
browser-side accessibility tree, at this point
AccessibilityIsIncludedInTree will be true for all nodes, and could then
be removed.

AccessibilityIsIgnored will continue to remain the same as it is today.


Original change's description:
> Reland "Refactor to handle ignored nodes that pass into the browser AX tree"
>
>
> This re-lands this CL:
> https://chromium-review.googlesource.com/c/chromium/src/+/1535171
>
> Which was reverted here:
> https://chromium-review.googlesource.com/c/chromium/src/+/1610026
>
> Original Change's description:
> > Refactor to handle ignored nodes that pass into the browser AX tree
> >
> > * Introduces the concept of "in the tree" vs "ignored" in Blink without
> >   changing the actual behavior. No ignored nodes are sent to the browser
> >   accessibility tree.
> > * Adds new function IsIgnoredPassThrough, for use when an object is
> >   ignored, but should be passed through to the browser-side anyways.
> >   This will be used to allow different types of ignored nodes to pass
> >   through, instead of all at once.
> > * Refactors browser-side code to walk only the unignored tree.
> >
> > Bug: 651614
> >
> > Change-Id: Idbd85949a8505f8a03a08e3e002bb893619d6757
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535171
> > Commit-Queue: Jacques Newman <janewman@microsoft.com>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
> > Cr-Commit-Position: refs/heads/master@{#659089}
>
> Change additional to original change:
> The original change caused a crash because GetUnignoredChildCount was
> called on a parent with dangling pointers in its children vector.
> This was previously acceptable as child_count only relied on the
> length of the vector, not its contents.
> This issue has been mitigated by caching the unignored child count,
> similar to how the unignored index in parent is cached.
>
> Bug: 651614
>
> Change-Id: I90b09237862d17848113fb084b9b08b60e12999f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609590
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
> Commit-Queue: Jacques Newman <janewman@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#660987}

Bug: 651614
Change-Id: Icb6bfaf2afe7c28805322541aefe0829f26aed0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626690Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#666370}

Bug: 963446,960795
Change-Id: I3b50117bfae33aa1f36425d156ee780313937035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645383Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666369}

Bug: 862420
Change-Id: Ic2b5b8f08c6399c10e39d495a64543bb497a99cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643422
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666368}

Following bot results are included.
20802 20807 20821 20833 20851 20857 20881 20886 20894

0 lines were removed and 1 lines were deflaked by consecutive
results since 20787.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: Id68fed69a17f37ca6d552c393d8397b5e622e84c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642617Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666367}

TBR=gayane@chromium.org
NOTRY=true

Bug: 971326
Change-Id: Icb560851c066e8671d3f509c088855ad282423ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645207Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666366}

First, we make sure we reorder all tests in test launcher,
we guarantee that "PRE_test" will precede "test" for the delegate.

Test shuffeling was moved before re-ordering test for dependent test

Finally, content test launcher delegate was simplified.
It still has some logic to group dependent together
so they run consecutively in parallel launch.

Bug: 936248
Change-Id: I7d34e45eee1c2c0c88ded8e5cc054327fe27d7b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638139
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666365}

In order to remove the timer to send the fake mouse move event to
update hover for user scroll case, we will send the fake mouse
event as a callback which will be executed when the animation finishes
or cancels, because keyboard scroll does not generate any gesture
events right now.

This CL is working on all the user scrolls, such as keyboard scroll.

Bug: 877132
Change-Id: I29859df6bae983ab982bbec87d9d91d17f11126b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638778
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666364}

SafeBrowsingService::CreateURLLoaderFactoryForIO created a factory directly through NetworkService,
which means that if the network process crashed the interface pointer wouldn't work anymore.
Instead use SafeBrowsingService::GetURLLoaderFactory(), through
CrossThreadSharedURLLoaderFactoryInfo, which correctly handles this case.

Bug: 971274
Change-Id: Ia6915e1e7aa4121130ab34b30587827adb54e96f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645456Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666363}

Adding offsetRects, clientRects and offsetRects into
DOMSnapshot.captureSnapshot using an experimental flags includeDOMRects.

Change-Id: Ie2c0af41c94fc1eeb9a6a371193182791a744719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612105
Commit-Queue: Long Ly <loly@microsoft.com>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666362}

This change adds two new cursors for auto scrolling, one that shows only
vertical directions, and the other that shows only horizontal. (This has
the unfortunate side effect of causing cascading small changes to many
files, sorry!) These new cursors are then used in autoscrolling so that
when a user is on a page that can only scroll vertically, if they middle
click it will then show an autoscroll cursor that reflects the available
directions, i.e. up and down only. Similar results for horizontal
scrolling only pages.

This change caches the directions available to scroll when the middle
mouse button is clicked and uses those to determine which cursors to show
when handling mouse move events. This unfortunately means that if a user
middle clicks somewhere that can only scroll vertically, and later that
changes to being able to scroll horizontally exclusively without user
input, the cursor will still only show vertical directions. However, this
matches what Firefox and non-Chromium-based Edge do right now, so this
seems fine to me. A file up bug to fix this issue should be filed though.

Bug: 11437
Change-Id: I68e083d1e0b9e14071f67f9268e826a40cebd783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638924Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#666361}

Adds a missing ReceiveNextConnectRequest() call to
NamedMessagePortConnector, which fixes an issue which prevented
additional ports from being connected after the first one.

Adds a test which verifies the functionality.

Move InitializeCastPlatformBindings() so that the deprecated bindings
are only evaluated after the Agent-supplied bindings.

Bug: 922718
Change-Id: I5030ebf1f82d9dec4009fb4820f422cd95dfee30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644159
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Auto-Submit: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666360}

Added option to configure code mirrors accessible name then set console
live expressions accessible name to "Live expression editor".
Before it read "Code editor" which is the same as the primary console input.

Screenshot: https://i.imgur.com/GZDwP3F.png
Bug: 963183
Change-Id: Ie3fd3206953c54df31d6abeaeca7e5f7ad0dabee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628224Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: John Emau <johnemau@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#666359}

BUG=937566

Change-Id: If1690d8cfd44b7d92be877f8d596510a78e78497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644156Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666358}

This is a cleanup CL in preparation for adding new variants of the
algorithm for deciding which elements to invert.

Separating out the code for *how* to invert elements from *when* to
invert them should make it easier to adjust the two independently while
making the code easier to follow.

Bug: 963578, 968340
Change-Id: I9a134ea07ef94ee3e46072edfb20bdf2efed5f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639441
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666357}

Migrate the Developer Settings page from deprecated Framework
preferences to the Preferences Support Library.

This is the first fragment migrated that includes a ChromeBasePreference
so some base classes and methods have been duplicated here to support
simultaneous compatibility between Framework and Support Library
Preferences.

Bug: 966244
Change-Id: I2bd8919361207576231f99d799a5a7e95819d81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632557
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666356}

Updates the Android VR test documentation to explicitly list all the
supported values for the --shared-prefs-file argument and add
descriptions of what they do.

TBR=alcooper@chromium.org

Change-Id: I577b3580bf4570c373e7fd13afa014529f43415c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645974Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666355}

Bug: 959097
Change-Id: Ie251657ed6687846ff7284223b3ce541ae958e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643988
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666354}

This reverts commit 26af59f1.

Reason for revert:
cause failure to SplitViewTest.ResizeTwoWindows/2
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12740

Original change's description:
> Use DragEventGenerator for SplitView Resize test
> 
> This also adds extra scenarios.
> * Resizing with overview on the other side.
> * touch event
> 
> I also found the scenario that splitview controller can be
> called recursively during shutdown, which is fixed by the change
> in SplitViewController
> 
> Bug: None
> Change-Id: I293ed17bba4961d338ac0f9a389f42f8f233d4ff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637244
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666091}

TBR=mukai@chromium.org,sky@chromium.org,oshima@chromium.org,xdai@chromium.org

Change-Id: I63a1840ac274e55f4041901820cde8b495faf8f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645162Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666353}

TBR=gayane@chromium.org
NOTRY=true

Bug: 971319
Change-Id: I6437c64264d24a78348983af2a69fc64528ce996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645819Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666352}

This fixes some errors I noticed while doing a refactor. Keeping them to
their own patch will make the refactor more clear:

* Remove an unused include.
* ChromePromptImpl::PromptUser should never be called twice. If this assertion
  is violated, on_prompt_user_ (a OnceCallback) will be null the second time.
  This case was handled incorrectly: the result callback would never be called,
  which is a runtime error in mojo. Better to just DCHECK.
* Add a PromptUser call to NotInstalledExtensionTest, to ensure that
  DisableExtensions returns false because the extension is not installed and not
  just because the user was never prompted.
* Add a missed early return on an invalidated WeakPtr.
* Simplify the MockChromeCleanerProcess setup to reduce repeated code.

R=olivierli

Bug: 969139
Change-Id: I6ad47831d02487309dc35aa5c67d7533178ae386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641994Reviewed-by: proberge <proberge@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#666351}

Bug: 969055
Change-Id: I222d2956dbf82b0da59061464c46e758c2cd93fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639637
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666350}

Adds to SigninManager.isSigninSupported a check for
MobileIdentityConsistency feature to hide sign-in UI surfaces if the
feature is enabled.

Bug: 968140
Change-Id: I39156d4baf852d65117380bf98a983830d61dd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645308
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666349}

3.6 Canary 2 is now available on gLinux.

Tbr: agrieve@chromium.org
Bug: 620034
Change-Id: Id62c9bfb42ad902636cb655266e9abb2333558db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645384Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666348}

This is meant to be a no-op change which allows an IDBRequest to
no longer have an associated callbacks object when the request
response handling is initiated.

It's a no-op because currently HandleResponse() only results in
(maybe) an event being enqueued with no real immediate dispatching
of the event.

A future change will switch event enqueueing to instead immediately
dispatch in some cases, and at that time it will be necessary for
the request to have its callbacks object detached to properly
handle the event.

Bug: 965136
Change-Id: Iaddc0254234b6ba2985f324f21fef2841e8bcf98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639155Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666347}

A gbm_device must be closed using gbm_destroy_device(); this CL
introduces ScopedGbmDevice with a custom deleter that does just
that, and uses it in the place where it's needed now -- I'll also
use it in crrev.com/c/1635929 imminently.

Bug: 970923
Change-Id: I954c1f4bfdf0d6ca8ef91f336eb21fc2d255ee6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643684
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666346}

This CL removes ProfileSyncServiceAutofillTest and all its dependencies
not used elsewhere.

The same functionality for the fully launched USS implementation is now
tested in AutofillProfileSyncBridgeTest.

Bug: 836718
Change-Id: I5b6f9372c1ee7aa17ffe385f5275efbee85a4543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642548Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666345}

This function always returns true, so the result was inclined in
toolbar_egtest.mm. EG2 Tests can not import ios/chrome/browser/ui/util/ui_util.h
(which declares IsRefreshLocationBarEnabled), so the function had to
be removed.

Bug: 884723
Change-Id: I7ab40c5016ca2b17c95d4fd6294df67cdcc55d81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642111Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666344}

This CL hooks up the StartActivation() call with OtaActivatorImpl. With
this CL, the flow is ready to be used by the WebUI dialog.

This CL also adds virtual inheritance for FakeCarrierPortalHandler to
ensure that we avoid the "diamond problem" for multiple inheritance.

Bug: 961084
Change-Id: I79e0e583d6ed3fade8961f6c82241020394945e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629788
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666343}

These includes can not be compiled with EG2 so they should be removed.

Bug: 922813
Change-Id: I60137b39e7b882d8224280ac7e77a8e832652370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639670Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666342}

DataObjectImpl::OnDownloadCompleted() in
os_exchange_data_provider_win.cc will reset the StoredDataInfo object.
And this object has a scoped_refptr to the DragDownloadFile. So
DragDownloadFile could get deleted right after this call.
This CL fixes the issue by not calling any further method after
OnDownloadCompleted.

BUG=968303

Change-Id: I61b99264767e00df33141ed3f9090dfeff554c98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644147Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666341}

BUG=937566

Change-Id: I412c5e383e454e375ba3b10fcec05058b7347422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644319Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666340}

This file is already EG2 compatible.

Bug: 922813
Change-Id: Ib5b072dd7d1a3973017c2ee490c5d7e42dce335d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643239Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666339}

This is the document I wish I could have read rather than all the
implementation. Maybe this will save others time in the future.

Change-Id: I1858808ba4cce584625325fea383a5b2332da395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635414Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666338}

The main purpose here is the refactoring of the almost identical
RegisterAndFetchPolicyBeforeSignIn and isUserManager. This brought some
simplification on the java code, with the removal of the native call to
ShouldLoadPolicyForUser.

Bug: 963400
Change-Id: I828f9a328bc153ebc6325f194fb34206bbe40e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628721
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666337}

Other HasFraction methods as in PhysicalUnit are declared already
constexpr and using it. It breaks GCC build.

Bug: 819294.
Change-Id: I0c4bd9bd206d45cf31f7fa815ce8533718a425cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645222Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#666336}

Enable the features in tests in waterfall. Disable DialMediaRouteProvider
in unrelated tests that fail because of it.

Bug: 956609,956621
Change-Id: I930296900b4f452652785892e73d9860814aff88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620548Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666335}

Add callback supports to the RenderWidgetTargeter
and use the async targetting in drag and drop code
and register a callback to send drag events using
the callback. Note that since drag and drop events
aren't WebInputEvent it is not possible to use
FindTargetAndDispatch function of RenderWidgetTargeter
at this time.


The original CL
https://chromium-review.googlesource.com/c/chromium/src/+/1596840
was reverted due the added test being flaky. This CL is the same
as the original CL expect it has the same test with another
way of checking the logic.

TBR=sadrul@chromium.org

Change-Id: I95ac25a554a2964c3c5a0ebeee97b4d041d74a24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642979Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666334}

WebContents::GetDelegate() can return nullptr when handling a keyboard
event.

BUG=b:64863368
TEST=While browsing a PDF with an ARC Custom Tab, press Ctrl and verify
no crash occurs

Change-Id: I113a41d23f27409d52bcfe313cb4142f7562f905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645816Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666333}

The "configure network" dialog displays a configuration error in some
cases when it should not. This was caused by the fact that we were
inspecting the last_error attribute of NetworkState, even if there is no
current error.

To fix this issue, I removed the NetworkState::GetErrorState() function
and updated clients to simply call the error() function instead.

Bug: 968474
Change-Id: I2d351057ec8b0d2d35a0ea8a46a4515413bec9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642692Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666332}