- 04 Oct, 2019 40 commits
-
-
David Bokan authored
Add a UMA metric to measure the number of Agents[1] per process over time. Roughly speaking, all frames that can potentially script each other synchronously must share an Agent. i.e. they are same site. So a page example.com with subframes foo.external.com and bar.external.com will have 2 agents, one for example.com and one for the subframes. The metric here measures how much time each renderer spends in any given state. That is, a value of N in the 4th bucket means that renderers have spent N seconds having 4 Agents. The purpose of this metric is to analyze the effect of separating memory isolates per-Agent. Therefore, we collect the metric only for WindowAgents since workers already have a separate isolate. We also only consider Documents from ordinary Pages to prevent influencing the metric from poups, overlays, SVG images, and other non core Documents we wouldn't consider isolating. [1] https://html.spec.whatwg.org/multipage/webappapis.html#integration-with-the-javascript-agent-formalism Change-Id: I3ebe8e46b273e53f3107e70b1aace517e0d8b924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830465 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#702749}
-
Eric Willigers authored
In preparation for Minimal UI, we migrate AppRegistrar to using DisplayMode instead of LaunchContainer. Not yet done: Migrate WebApp to use DisplayMode. TBR=amistry@chromium.org TBR=dominickn@chromium.org Bug: 1009909 Change-Id: I6ef945fbc80196960b0ce73506876a89540efa88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835432 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#702748}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/595c588d9706..872d2e9ffe7e Created with: gclient setdep -r src-internal@872d2e9ffe7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Icb4db3767c7134d3e4135626927d5b4cfd1815bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839631Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702747}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 44f1ce3d. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" afc509ca "[WPT/common/security-features] Fix typo" df884b61 "[WPT/referrer-policy] Add worker subresource tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ia492808fdacbefcf6fbd3dc5ba6cf19b8e1252f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839551Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702746}
-
Darren Shen authored
We currently manually manage the lifetime of the engines in engine map. But we can use a unique_ptr instead. It automatically gets released when we remove an engine from the engine map. Bug: 1009903 Change-Id: I93874b0154b949ddceef29695fc000cacfef73cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837443 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#702745}
-
Lei Zhang authored
Change-Id: I3118c919f190e48de8399ac72c0f610f4bc2525d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839016 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#702744}
-
Maksim Sisov authored
The SkiaRenderer uses an image factory that creates anonymous images and native pixmaps. That means a GbmPixmapWayland does not receive an AcceleratedWidget that it will be attached to until a buffer commit request comes. With the implementation we have at the moment, that results in GbmPixmapWayland being a staging buffer without its counterpart created on the browser process side. However, when the SkiaRenderer feature is enabled, we want to create a GbmPixmapWayland with a null widget passed and create a dmabuf based wl_buffer for it. Let's call that buffer an "Anonymous buffer". But that slightly contradicts with the implementation of the GbmPixmapWayland and the WaylandBufferManagerHost classes. The problem is that the GbmPixmapWayland may not send requests to create dmabuf based wl_buffers if a widget is null. The manager simply fires a gpu termination callback if GbmPixmapWayland sends a request to create a wl_buffer for a null widget. To fix the problem, I had to change the implementation a little bit and allow it to create wl_buffers for null widgets. Now, the GbmPixmapWayland always asks the host manager to create wl_buffers regardless of the AcceleratedWidget's id. And to be able to process these requests, a new logic to store these wl_buffers has been added. Previously, the manager host always delegated creation of WaylandBuffers (which is an internal buffer representation) to surfaces. And whenever wl_buffers were created, AttachWlBuffer was called. Now, the manager may create WaylandBuffers by itself if there is no widget passed and it is impossible to know the surface that must own that buffer. When a CommitBuffer request comes, a surface searches for the buffer in its own container and if it is not found, it asks the WaylandBufferManagerHost to search for an anonymous buffer and pass the ownership of that buffer to that surface. Then, the normal flow continues. Bug: 1008364 Change-Id: I5c582381afc3e16b589d53ceb6ba774ac6da8f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837614 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#702743}
-
Lei Zhang authored
This function takes a PrinterType and a separate boolean to indicate the printer is a cloud printer. This was likely written before enum PrinterType gained a |kCloudPrinter| enum value. Now that the |kCloudPrinter| value exists, just use that and get rid of the separate boolean. Change-Id: I14ca569167d49bf273c02e4d24cdaa6c17e9dc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838624 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
dpapad authored
Before this CL, the supported types were only mentioned in comments, and were not programmatically enforced. As a result there were conflicting comments, as well as cases that were a seemingly unsupported type was used (for example 'url' type in chrome://bookmarks). Bug: 1010819 Change-Id: I3f52343220f2db2a3ed302a178efa1c0ca78db99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838975 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702741}
-
Jay Harris authored
This is a prerequisite for adding file handling on Windows, MacOS and Linux. Example: ./chrome --profile-directory=my-profile --app-id=.. -- -- file1 file2 file3 Note: In future, the FileHandlerManager will infer the correct FileHandler for an app based on the files it is given. For now, it just opens the app's launch url. Bug: 938103 Change-Id: Ieaa136d109fc906c9c48a95cdbd194fb0622d3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819286Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#702740}
-
v.paturi authored
CSS filters such as invert, greyscale etc. are not available in DarkModeImageClassifier where the extraction of features happens. So we end up extracting the features on the original image which is not what is seen on the user's screen. Until we have a way to take the css filters into consideration while extracting the features, it's safer to just skip the feature extraction altogether when such filters do exist. Bug: 1007925 Change-Id: I1b082a628709178e64aed488bb4656dd7044386a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824051Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com> Cr-Commit-Position: refs/heads/master@{#702739}
-
Lei Zhang authored
Fix lint errors along the way. Change-Id: If87c1c8c330d191e1ca0d422c4d2bce299b24ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838709Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702738}
-
Lei Zhang authored
Change-Id: Id64281b03e209469b14591849c97ff05feeb148a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838528Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2ae2841e85ac..e65131f1a930 git log 2ae2841e85ac..e65131f1a930 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 saklein@chromium.org BuildsChrome: Call implementation. 2019-10-04 vapier@chromium.org cros_build_lib: run: add encoding/errors options 2019-10-04 jrosenth@chromium.org httplib2: upgrade to upstream and make python3 compatible Created with: gclient setdep -r src/third_party/chromite@e65131f1a930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9b2817e075e6aff3e69cf2c35c21bab40ac04ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702736}
-
Samuel Huang authored
This CL performs a "horizontal" update to IsWebUiHostInDevUiDfm(), so that all WebUI hosts chosen to be in the DevUI DFM become affected by its flow. Specifically (on Android): * Accessing the (chrome://) URLs of these hosts triggers DevUI DFM install and/or load. * These hosts are not accessible unless the DevUI DFM is installed. The updates here are quite mechanical, so it makes sense to do them all at once (at least in draft), thereby reducing churn and edit / review burden. Hereafter, we can focus on moving resources from resources.pak to dev_ui_page_resources.pak. Bug: 927131 Change-Id: I9fc1471e84bb1219eaafad6e751b90cc425a1b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834426 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702735}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I1bf56ef030f33c57361b9b0397f8207bb0d5e4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839236Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702734}
-
Hitoshi Yoshida authored
Before this CL, a default dictionary value {} was not usable for union types that contains a dictionary type, though it is allowed in spec. This CL makes it possible. Bug: 839389, 984949 Change-Id: I4c053a482d5b9623dea665e63ae9ad267555730e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838800Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#702733}
-
Miyoung Shin authored
This change converts VRService mojom interface client in blink to use BrowserInterfaceBroker, and converts VRService{Ptr, Request} in chrome, content and blink to the new Mojo type. Bug: 936482, 955171, 978694 Change-Id: Ib2d982ea3402c570c825e2b55d7aec2c77b2d8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828717 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#702732}
-
Rika Fujimaki authored
Delete unnecessary function definition in ModuleRecordResolverImpl. Change-Id: Ib9b54429487f772565222c6dbb16bd8e905cfe7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839276Reviewed-by:
-
Melissa Zhang authored
This CL moves the GetPickerAction and GetDestinationPlatform function calls out of RecordUma such that ChromeOSAppsNavigationThrottle can call its own GetDestinationPlatform which sets the platform for when a preferred activity is found. BUG=968411 Change-Id: Ia838828ec4d03f1543243827f87601bfa2534c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836293 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#702730}
-
Samuel Huang authored
This CL applies a similar fix as http://crrev.com/c/1807069 (for APK breakage) to unit_tests. In addition, we also include DevUI DFM classes that are in the base module. This change will be needed for tests to work, once the set of chosen DevUI pages are associated en mass with the DevUI DFM. Bug: 927131 Change-Id: I4caa7fba245b77aed3b880846c436a2fc9e99ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835066 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
-
David Staessens authored
This CL adds extra command line options to the video_decode_accelerator_tests to control the format and amount of video frames saved to disk when --output_frames is specified: --output_format: allows switching the file format between png and yuv. --output_limit: allows putting a limit on the number of frames saved to disk. TEST=ran new VDA tests on caroline BUG=962354 Change-Id: Ifc0556986b28309b79ac7df9597154b85f08cc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831728 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#702728}
-
Matt Falkenhagen authored
Bug: 998399 Change-Id: I69c12d797898cd0dbb71d76a90a35b303539f3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838838 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#702727}
-
Xianzhu Wang authored
Let FileInputUploadControl::PaintedOutputHasNoEffectRegardlessOfSize() return false because it always paints the button. Bug: 1009827 Change-Id: Ib74ea880c3b984adf3eee707f8285508e3300b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836659 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702726}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f3c5fefedbf9..94c33f91b3c2 git log f3c5fefedbf9..94c33f91b3c2 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@94c33f91b3c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Id6cff5d3dc7f19147f798f320b4d4b3b32f45177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838544Reviewed-by:
-
Eric Willigers authored
The WebDisplayMode enum is redundant in C++ now that we have blink::mojom::DisplayMode. The following header is no longer needed: third_party/blink/public/common/manifest/web_display_mode.h // TODO(dgozman): instead of this enum, use blink.mojom.DisplayMode directly. WebDisplayMode.java is added to chrome/android/java/..., replacing the WebDisplayMode.java file that was previously generated from the above header. (The mojom-generated Java class DisplayMode is not a direct replacement for the Java annotation type @WebDisplayMode.) The DisplayMode enum constants now following the naming guide: kUndefined kBrowser kMinimalUi kStandalone kFullscreen https://google.github.io/styleguide/cppguide.html#Constant_Names TBR=jochen@chromium.org TBR=reillyg@chromium.org TBR=yusufo@chromium.org Bug: 1009909 Change-Id: Ida01048bd5001e9217601d35a2ef3770d4d7bf54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834804 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2cf50492a3f..35a60f622c58 git log d2cf50492a3f..35a60f622c58 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@35a60f622c58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I49a58d5fbc518a1adec7d6d3d660ec195ea4efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839415Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts UDPSocket from udp_socket.mojom to new Mojo types using PendingRemote, Remote, PendingReceiver, Receiver, and UniqueReceiverSet. Bug: 955171 Change-Id: I344a2808ca8da42a1a5c0cb6166c8916a5159a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831623Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Julie Kim(OoO until 4 Oct) <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#702722}
-
Ankit Kumar 🌪️ authored
Document links may have zoom values defined in the PDF. Currently the zoom values are not taken into account during navigation of document links. This CL adds the zoom value for document links. Tests have been modified to validate the zoom value. Bug: 982176 Change-Id: Ibcd585b20eb2506a1c01066de2548e36da6ffc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811408Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702721} -
Yu-Hsuan Hsu authored
The change is related to CL:1813257. Add histogram information in histograms.xml to make the histogram visible on chromedashboard. BUG=b:141286272 Change-Id: Ic8f94aa183decb6f108954c1249428af6f00d4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837450Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702720}
-
dpapad authored
In Polymer3 relative CSS url()s inside style modules are resolved by default with respect to the main HTML document, which results in incorrect URLs. In Polymer2 these were resolved with respect to the location of the HTML file hosting the style module, but in Polymer3 styles are hosted in JS. Explicitly adding an |assetpath| attribute to auto-generated Polymer3 style modules fixes the issue. Bug: 965770 Test: Use css_icons_css.m.js from a Polymer3 WebUI page. Verify that icons are properly displayed. Change-Id: I12b3e9283bded368976469bdd7ab5e2ef0c79a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838554 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This updates C++ code in the metrics component to use nullptr instead of NULL. This is to align with the chromium C++ styleguide. Bug: 1010369 Test: git cl presubmit --upload Change-Id: Ib4133584972ae6069e469c58798cd1a323b4eeec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835091Reviewed-by:
-
Andrew Luo authored
Change-Id: I7a84805a01edad11df3ba65762aec013bdf2488a Bug: 1010211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832482Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702717}
-
Yoichi Osato authored
TBR=achuith@chromium.org Bug: 1010866 Change-Id: Idb04a7a87cfd1bf71e79e90f2202010954f711ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838793Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#702716}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1f08ab28305d..5549ef0451f9 git log 1f08ab28305d..5549ef0451f9 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 m.maiya@samsung.com Vulkan: Fix content synchronization for textures bound to images 2019-10-03 timvp@google.com Trigger a flush() when the command graph contains too many objects Created with: gclient setdep -r src/third_party/angle@5549ef0451f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I5a3085c3ee848b7f47fcc232a17145550f13b6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839204Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42e79b023ed5..595c588d9706 Created with: gclient setdep -r src-internal@595c588d9706 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie081fa70c99d08b625ad752f8a39763c2dc3d99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839411Reviewed-by:
-
Alexey Baskakov authored
According to go/chrome-bmo design doc sync data model, we should have two copies of app's name and theme_color fields. Rename specifics to sync_data. Rename proto to local_data. Add is_sync_placeholder flag. Add comments. All these fields will be used in WebAppSyncBridge implementation: https://chromium-review.googlesource.com/c/chromium/src/+/1830494 Bug: 860583 Change-Id: Idce95b5fdd4843cf9a8e290fe61293bffb938bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833347 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#702713}
-
Yoichi Osato authored
TBR=bengr@chromium.org Bug: 1010865 Change-Id: I01a9b4390fb0147c95c7f915d4a15d442a0faddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838778Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5407542ba98db5c8ed0d0efaf1362f508eb68561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838387Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702711}
-
Nico Weber authored
Move GOOGLE_CHROME_BUILD into just the cc files, so that the dep on //build:branding_buildflags doesn't have to be a public_deps and to make branding affect internal APIs less. Bug: 961769 Change-Id: I41f0dfc5df304ea34b35d4298e389573a1bd2119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830088Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#702710}
-
