- 13 Dec, 2019 40 commits
-
-
Anand K. Mistry authored
This avoids having multiple stray copies of the password in browser and daemon addressable memory while being transferred over Mojo. On the smbfs side, the password will be read directly into a libpasswordprovider::Password. Bug: 939235 Change-Id: I19e4b401dd388fcf56c02426ee0044ab79d1031f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963594Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#724510}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I7fd2182d5e1933ab7dd282850f0010d0d0c9b26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954996Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#724509}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37fc8b16fc93..928e3835d93d git log 37fc8b16fc93..928e3835d93d --date=short --first-parent --format='%ad %ae %s' 2019-12-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@928e3835d93d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I416b43418b8cd31278bb82917364412ced1c9c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966675Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724508}
-
Alan Cutter authored
This CL disables: - OmniboxViewTest.EnterToSearch - OmniboxViewTest.DesiredTLDWithTemporaryText - OmniboxViewTest.DesiredTLD on TSAN and ASAN bots due to a high number of timeout flakes on the trybots. TBR=tommycli@chromium.org Bug: 1030551 Change-Id: Ie9b0ebfacc2ea3f948e3592902f58d2a7f9f39bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965785Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#724507}
-
Jeonghee Ahn authored
Background: In SpavNav mode, more elements have become focus candidates: https://chromium-review.googlesource.com/c/chromium/src/+/1461355 https://chromium-review.googlesource.com/c/chromium/src/+/1632231 https://chromium-review.googlesource.com/c/chromium/src/+/1859535 These changes were the result of our efforts to avoid unreachable elements. In other words, SpatNav started to consider more elements, with tabIndex<0, as candidates. Problem: Sometimes this caused inconvenience because every "wrapping" element got focused towards the innermost candidate: The user had to press a direction key several times to reach the "real" focusable element, see the bug for more details. Solution: This CL tries to ignore certain extra, inconvenient focus candidates. If an element is recognized as focusable by SpatNav's extended condition (SupportsSpatialNavigationFocus() in element.cc) and it has one or several focusable descendant(s), then we ignore it in favor for its focusable descendant(s). We only ignore ancestor focusables with a non-negative tabIndex. Bug: 982601 Change-Id: I8d98fb2261f205b000e2ab7bae9f801272649784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900792 Commit-Queue: Jeonghee Ahn <jeonghee27.ahn@lge.com> Reviewed-by:
Hugo Holgersson <hugoh@logikbyran.se> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#724506}
-
Nicholas Verne authored
Users can opt to back up their existing container before attempting the upgrade and are prompted to restore if the upgrade fails. Bug: 1024693 Change-Id: If26ae717c47d40ceed74364205a83d98a2e5a1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951272Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#724505}
-
Yu-Hsuan Hsu authored
There are several changes in this CL. 1. Add a histogram for stream effects. (related to CL:1939171) 2. Expand stream config histograms to have the Direction and ClientType suffix. (related to CL:1939172) 3. Extend the expire date of all Cras histograms to next December. BUG=b:145261414 Change-Id: Ibf8fcd84e2305e414bd1892bff1e875edb89be23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958544 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#724504}
-
Alexandre Courbot authored
kV4l2Lib is only used from within PostSandboxInitialization(), so move it there to keep things local. BUG=None TEST=Build succeeds for kevin. Change-Id: If69f1e61c0e131b49b3d02de4838780f387a997e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966795 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#724503}
-
Jinsong Fan authored
For aura and cross-process iframes code path, the visible edges of the selection bound are uninitialized, so GetVisibleRectBetweenBounds() always returned an empty rect. This caused the quick menu or context menu to always be displayed in the top-left corner. The CL fixes it. Bug: 1027843, 1015274 Change-Id: If35210a0428fd51f8c3b44e94dfdb1960cef64a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946054 Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#724502}
-
Alan Cutter authored
This CL disables interactive_ui_tests in autofill_interactive_uitest.cc on Windows. Tests from the following tests suites flakily timeout on the Windows 7 waterfall: - AutofillInteractiveTest - AutofillDynamicFormInteractiveTest TBR=battre@chromium.org Bug: 967588 Change-Id: I2e29e1cb7c8223d1d7cc3951ffc91cbda1be0ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965736Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97a175b7117c..c741d90d63c0 Created with: gclient setdep -r src-internal@c741d90d63c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029823,chromium:1033537,chromium:987646 Tbr: jbudorick@google.com Change-Id: Ifeda6caef9da58026cd299a5bfbf953126a349fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966752Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724500}
-
Tetsui Ohkubo authored
During transition of ARC++ window from minimized to snapped, WorkspaceLayoutManager::OnWindowActivating() might be triggered. For browser windows, it is fine because the transition happens synchronously and the method does nothing, but for ARC++ windows, it happens asynchronously and the method might restore pre-minimize window state while snapping is still in progress. We should clear the pre-minimize state to ensure it does not happen. A Tast test arc.SplitView will be improved to cover this. TEST=manual(Follow the steps in the bug and confirmed it worked) BUG=1031313 Change-Id: Ia6c4c8a9a0746c23dc1c8d0e5716a3007f97c3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963831Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#724499}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b34e896a1257..953ba804a145 git log b34e896a1257..953ba804a145 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 dberris@chromium.org Use all known changes for determining order Created with: gclient setdep -r src/third_party/catapult@953ba804a145 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1031433 Tbr: skyostil@google.com Change-Id: I13a01c0d658ce3f18b8325326024b8f5f90d0d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965861Reviewed-by:
-
Azeem Arshad authored
This CL fixes issue with unnecessary hand pointer appearing on network summary items even when the item is not actionable. This was caused because the row has an "actionable" attribute, that adds a pointer, permanently set on it. Fixed this by making the actionable attribute conditional. Fixed: 1005196 Change-Id: I7fda634e7fcd54c14c909b2a48ecc737b26850fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966090Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#724497}
-
Benjamin Beaudry authored
The following tests were failing when LayoutNG was disabled. - accessibility/listitem-presentation-inherited.html - accessibility/presentation-owned-elements.html - accessibility/role-attribute.html They have been moved automatically into "layout-ng-fragment-item disabled" tests but, according to Koji, they also need to be marked as disabled inside of "disable-layout-ng". Bug: 591099, 982194, 1015100 Change-Id: If08f6b27264064b83959a756d19cffe4f181023b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962646Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#724496}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I317a8e55bd2ad31cbc86b0473a43dce45074a475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966512Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724495}
-
Maggie Chen authored
There are a few crash reports with GPU device id = 0xffff on exit_or_terminate_process() during process teardown. The unsandboxed GPU process is still doing the clean shutdown while the sandbox GPU process had changed to atomics shutdown recently. These crashes are most likely from the unsandboxed GPU process which are used for dx12/vulkan info collection only. Skip the Dx12/Vulkan info collection for software GL implementation (device id = 0xffff) to avoid this crash. Bug: 896565 Change-Id: I0086ebcada8f002562d2b91759e658fab9293550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962640 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#724494}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/977b26570247..f2d6fe62f23f git log 977b26570247..f2d6fe62f23f --date=short --first-parent --format='%ad %ae %s' 2019-12-12 kron@webrtc.org Revert "Reland "Distinguish between send and receive video codecs"" 2019-12-12 kron@webrtc.org Reland "Distinguish between send and receive video codecs" Created with: gclient setdep -r src/third_party/webrtc@f2d6fe62f23f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f00a915b2e5f8456580529515399196360b38c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966408Reviewed-by:
-
Andrey Kosyakov authored
Change-Id: I9777141b5d609c35addfc9e9305062fac170e173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966395Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#724492}
-
Xianzhu Wang authored
The test tests tab grid view containing screenshots of web pages. Previously the web pages were scrollable and the sreenshorts might contain scrollbars, but the existence and opacity of the scrollbars depended on timing. Let the test use a shorter web page which is not scrollable to avoid the flakiness. See https://storage.cloud.google.com/chromium-result-details/7633a0d7f0a2344a68bfd8c195ffd34615863c8a for the change of the golden file. Bug: 1032754 Change-Id: If47d333560d2070574b25a05d0cc39e44d97508b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961290 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#724491}
-
Lijin Shen authored
ChromeDuetLabel will not be supported any more. The wrappers and labels were originally implemented by http://crrev.com/c/1552152. This CL removes these wrappers and labels. Bug: 965556 Change-Id: I0d7a9b3aa46a061dd3c40928a61180725b3dcda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954866Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#724490}
-
Patrick Noland authored
The SRO wasn't triggering in this case because: 1) The type is SEARCH_WHAT_YOU_TYPED, which was excluded 2) There was a (now spurious) assumption that the URL must match exactly The url for equivalent queries can vary due to the aqs (assisted query stats) param being different. The logic has been streamlined and replaced with the following Show the SRO if: 1) The active tab isn't a native page, sad tab, or incognito 2) The suggestion is the first in the list 3) The suggestion URL is "equivalent" to the current page Equivalence means either that the query text is the same (for search what you typed suggestions), or that the urls are the same (for url you typed suggestions). The CL exposes getSearchQueryForUrl to allow the query text comparison. I've also fixed a couple lint issues. Bug: 1027329 Change-Id: Ia1f4d22f23a23f934b98b9e88e65e17480b48418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951329Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#724489}
-
Jon Mann authored
Previously, shift+tab would move focus out of the whole list instead of just moving to the previous element within a row. Bug: 1030825 Change-Id: I11ae0c7c27f308f4de55b7dabf7a3707304e51ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963440 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#724488}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Iddd2034900112615a426942b749f06dacedb97c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964550 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#724487}
-
Demetrios Papadopoulos authored
The rule disallows == in favor of ===, and != in favor of !==, which matches the Google JS styleguide (which Chromium's JS styleguide inherits from). Bug: 720034 Change-Id: I192120525da6458a19e9eeb61e4e63aa598c4589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963350 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#724486}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1521e6b24c19..0678df30b5a5 git log 1521e6b24c19..0678df30b5a5 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms e7b14532d922..5855011aeee5 (1 commits) 2019-12-12 herb@google.com Add filter to SkTHashTable and SkTHashMap 2019-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 7240f337e5d6..e7b14532d922 (1 commits) 2019-12-12 mtklein@google.com use std::make_unique Created with: gclient setdep -r src/third_party/skia@0678df30b5a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I3b18d807962b176ae03a73500e74646805f15415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966407Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0c787d3ac9cf..37fc8b16fc93 git log 0c787d3ac9cf..37fc8b16fc93 --date=short --first-parent --format='%ad %ae %s' 2019-12-12 cjamcl@chromium.org Audits tests: dump settings in state 2019-12-12 cjamcl@chromium.org Audits: fix exporting as HTML. 2019-12-12 brgoddar@microsoft.com DataGrid: Add aria-hidden to header table Created with: gclient setdep -r src/third_party/devtools-frontend/src@37fc8b16fc93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1033368,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia2f72f96d6cd56bf9a0381206bd338a2e693bfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966404Reviewed-by:
-
Kyle Horimoto authored
When no mouse or touchpad is attached, this row is hidden. This fixes a bug which caused this link to show up on tablets with neither. Bug: 1026432 Change-Id: Ic611cad73e88bf86859fbf915c649212e56d6375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962639 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#724483}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a24b354..67c7536f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia99be25e711c240ee0fd33d7228eceb9572bc09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966254Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724482}
-
Jinsuk Kim authored
TabLifecycle is a collection of interface methods that deal with Tab's lifecycle. This is extended by the interface Tab. Bug: 1883270 Change-Id: I94c6174540af1b4319ee9e2d85268fbf512ed35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947867Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#724481}
-
Natalie Chouinard authored
6feb5599 [format] Sort lists based on suffix match c630f1ce Export rustflags in the IDE JSON format e87aa228 Ignore SIGTRAP in child process on macOS fe36c7c1 Create a new target type for Rust procedural macro eb18f84f Delete the default Token assignment opoerator 171ab91c Support for RISC-V 9a9aff09 Remove needless build_settings.h includes. b0400c9e Don't include windows.h in semaphore.h 5649cccd Stop using iostream. de542971 gen.py: Stop writing rule cc, GN has no C code. 47e15b76 Delete some unused code in src/base. 776bbfd9 Add syntax highlighting for string_{join,split} 6e5ba2e7 string_split(): Add tests for edge cases 6ae63300 Add string_join() and string_split() builtins 84843c57 Use git push instead of git cl 45611e33 Update reference.md 93b527c0 Add unit tests for assert() builtin b0e6146a Update documentation on how to configure and build the simple_build example 4872f08f Change args.gn to reference `gn help buildargs` a0a58ab2 Enable -Wall -Wextra compiler warnings on non-Win too. 1ec42e7f [format] Convert invalid whitespace to space when loading for format 5b4af69f Fix problems pointed out by building with clang-cl. 99d23637 win: Only use ICF and LTO if explicitly opted in. 160387be win: Don't use rsp files when linking gn either. 3f6100c9 Move source files into src/, and move tools/gn/misc to the toplevel. 3e42596a win: Don't use rsp files when compiling gn. df79acfb Documentation fix for Rust example 16d0abf5 Handle metadata walk_keys relative to the target directory a3345c9b Better user error detection in assert() d11184e1 Typos. Fix comments. 91420ba0 Fixed typos and clarified generated_file docs. 2020e304 Allow analyze reading from stdin and writing to stdout. 189ddf35 Switch Semaphore to use dispatch_semaphore_t on Mac. 7617b59f Provide separate Rust tools for different output types bbc9dd04 Doc clarification. 6c7fcc3d Add support for building on Haiku. d68b623f Don't report error for non-existent keys in not_needed 546edf82 Don't link Rust libraries and proc macros to C targets 7f603814 Support non-Rust libs and lib_dirs for Rust targets add1bb11 Drop edition variable from Rust support f3c7676f vim: Allow override of default location for gn binary d034be3a Remove Bind and Callback. 572ba24b Remove some base C++ wrappers. bdde2c25 Convert typedef to using. Change-Id: I4ee7a42d64f857df8818413344c8fff030f7626d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963377 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#724480}
-
Meredith Lane authored
This is a reland, the original review can be seen at: https://crrev.com/c/1826397 This change now migrates the existing accessibility code to rely on the attr-associated-elements set via the content attribute or IDL attributes. Followup work to: https://crrev.com/c/1687013, https://crrev.com/c/1781917 Bug: 981423 Change-Id: Ie5cbf514a74e68dfee3074aa9b473dfafd3a81e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911347 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#724479}
-
Gavin Williams authored
-Most dropdowns have an associated text label to explain the dropdown's purpose. To be in line with the overall Settings page a11y strategy, the labels will be marked as aria-hidden so ChromeVox navigation will skip over the label and navigate directly to the dropdown. The "label" attribute on the dropdowns should be used instead for giving aural context for ChromeVox users. -This CL is primarily adding aria-hidden to the labels and in a few places correcting/adding the dropdown label. Bug: 1015899 Change-Id: I21ba756ba5677765bace9279f8f155e8815f16fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933944 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#724478}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6fd4a803. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I383334133c404da19beda6037388843732e423ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965532Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724477}
-
jchen10 authored
Add array length check to be robust. Bug: 1033242 Change-Id: If7a8a0907183df369ebaa55e53411b646607112c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963386Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#724476}
-
Kyle Horimoto authored
At the request of elizabethchiu@, I added the following tweaks: (1) Add a shadow over the button bar when contents are not scrolled to the bottom. When scrolled to the bottom, the shadow should disappear. (2) Adjust the padding around the buttons of the bar. (3) Adjust the spacing between feature descriptions. Large, OOBE: https://screenshot.googleplex.com/0eGWJaoLzO7.png Large, dialog: https://screenshot.googleplex.com/3ad6ACZE2Y4.png Small, portrait, dialog: https://screenshot.googleplex.com/ddHZoBNbgET.png Small, portrait, OOBE: https://screenshot.googleplex.com/W6p1DpAazn7.png Small, landscape, dialog: https://screenshot.googleplex.com/UxhkoJSVGvD.png Small, landscape, OOBE: https://screenshot.googleplex.com/E6XQoWUS16f.png Bug: 1012295 Change-Id: I5efe600a183f4340834b4da9b5a8cad6befbfaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965976 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#724475}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/webusb. Bug: 1001114 Change-Id: I1c8d992d2f55b4e111486f67fa6cc255dee73268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961832Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#724474}
-
Hitoshi Yoshida authored
Names of generating class and its base class are frequently used in template and unique in each context, so this CL adds them in CodeGenContext. Also makes dicitonary use them. Bug: 839389 Change-Id: Ib8ed9b68187f253b044c38a1ff000088decdf81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963834Reviewed-by:
-
Ankit Kumar 🌪️ authored
Return base::Optional<PdfAccessibilityTree::AnnotationInfo> instead of returning the individual elements of AnnotationInfo as out parameters. Bug: 1008775 Change-Id: I8490b735c48d8e5e70eb27c7895001ad98c1dccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958496 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by: -
Renjie Tang authored
Fix the order of parameters in QuicChromiumClientSessionTest to match QuicChromiumClientSession constructor. Change-Id: I35c31a89c49e4c05b0b07aa6002198a97bed4782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966275Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#724471}
-
