- 17 Mar, 2020 40 commits
-
-
Daniel Rubery authored
Due to product decisions, this field should not be included. Bug: 1062298 Change-Id: I46986aec184f61b9af18a6debabd356cbebb9719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107713Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#751127}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Also, ExecutionContextLifecycleObserver has a temporary constructor that takes a Document*. Switch users of that constructor to the standard ExecutionContext* constructor. Bug: 1029822 Change-Id: Id806fd4ba2b0565c9a4865e2293115c7249e1fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101537Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751126}
-
Yue Zhang authored
This reverts commit f8d430ce. Reason for revert: This fix didn't eliminate the crash. Original change's description: > Skip popup Tabstrip update when opening tabs from background > > Currently, we use AnchoredPopupWindow#onRectChanged to force update > popup strip layout when new tabs are added. This could lead to a race > condition where RecyclerView tries to recycle a view that has been > temporarily detached due to the re-layouting process. This is only > reproducible when there is recycling happening, and when tab is added > from background. > > This CL bypasses this crash by disabling the force update for adding > tabs from background. Note that it is already a known issue that strip > is not properly updated when tab is added from background, so this > CL doesn't introduce any UI difference before/after. > > Bug: 1045944, 1050401 > Change-Id: I4d7ba97f53d41042867bea9562ce2e76aade118b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048988 > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741526} TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045944, 1050401 Change-Id: I52434502ea7661361fcac3077869f45e485955be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075224Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751125}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1aa882626c3d..e43a73b009bd git log 1aa882626c3d..e43a73b009bd --date=short --first-parent --format='%ad %ae %s' 2020-03-17 thakis@chromium.org Fix two -Wunreachable-code warnings. Created with: gclient setdep -r src/third_party/openscreen/src@e43a73b009bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:346399 Tbr: jophba@chromium.org Change-Id: I8628d27e3bf5b60aabefc58d00f117c16bce017e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107784Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751124}
-
Nicolás Peña Moreno authored
This CL replaces base::Bind() with BindOnce or BindRepeating in the chrome/renderer/net folder. Two occurrences are in parameters for AddInterface(), which receives a repeating callback and it makes sense to have repeating callbacks there. The other one is for a timer where BindOnce suffices. Bug: 1007641 Change-Id: Id2d3df19c699b881c492a1a3402bb60dcaa7dd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107803 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#751123}
-
Dave Tapuska authored
In preparation for moving compositing into blink move UpdateVisualState into WidgetBase. This callback will eventually be called directly from the LayerTreeView inside blink. Change-Id: I32b6bdc74b778d6a5b60a20f44f6e51036020079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103507Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#751122}
-
Guido Urdaneta authored
This CL moves the command-line switch from CaptureStreamRenderProcessHostTest to its parent, RenderProcessHostTest. Some RenderProcessHostTests use audio and are still flaking. Bug: 986021 Change-Id: Ic1327890183433ef9dd737d7c8d649560e5a981f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107540 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#751121}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80517cb9ee4c..29781ded1b6f git log 80517cb9ee4c..29781ded1b6f --date=short --first-parent --format='%ad %ae %s' 2020-03-17 szuend@chromium.org Make live location update handlers async and properly await {uiLocation} 2020-03-17 aerotwist@chromium.org [global] Remaps self.Bindings.cssWorkspaceBinding Created with: gclient setdep -r src/third_party/devtools-frontend/src@29781ded1b6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016,chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f00a99108fb71ebafa16a2f41422559d79d4778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107783Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f9434816..f1850bf0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If6705d67c2abf1b3f6e46ad14ec2588fa12fb4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106320Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751119}
-
Evan Stade authored
Bug: 1059865 Change-Id: Ic5c31a97233624fdf5848b6cf571fa0e7d120aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097183 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Wei Lee authored
Bug: 1061979 Test: None Change-Id: I2503f40a7f2ee20f2746b2d63dc19b0232bb1ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106701 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#751117}
-
Thomas Lukaszewicz authored
Bug: 1062343 Change-Id: I87307c13437f573a0f984034073691ea4d82eb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107810 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#751116}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 44 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-09-13. TBR=chrome-metrics-team@google.com Change-Id: Ibc156c1e8be51e13a027853fe7bf645cc36b1305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106017 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#751115}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dc6d8e5e. With Chromium commits locally applied on WPT: acbe6d96 "Add timeouts for EventWatchers on CSS animation tests" 6a942cea "[WPT/upgrade-insecure-requests] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1048 and retry the command." 1bb259bc "[WPT/referrer-policy] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 8469 and retry the command." 168319dc "[WPT/mixed-content] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1397 and retry the command." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I2638141fcbd0e96b2e654e5113ed365ed55e398a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106321Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751114}
-
Olivier Yiptong authored
This adds a runtime flag and a DCHECK for gating Font Access functionality. The runtime flag's state is set from the Chromium feature flag's state. Bug: 535764 Change-Id: Ie756de078cd5063e978c5e3faf9248885f5b3efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103859 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#751113}
-
Patrick Noland authored
ActivityTabProvider nulls out the active tab when it's non-interactive, and we receive the onObservingDifferentTab event before entering the tab switcher. This caused us to prematurely set the current tab to null, removing the ability for ToolbarPhone to accurately retrieve state about, e.g. whether the location bar is currently showing. In the linked bug, this manifested by drawing the location bar during the tab switcher entry animation when the location bar wasn't currently being shown. Bug: 1060335 Change-Id: Ib101e4be786f5cad0d2602cb73f7df4620f80af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100112Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#751112}
-
Theodore Olsauskas-Warren authored
As part of the privacy settings redesign a new Cookies settings page has been created. This CL adjusts the ordering and description of each exception list presented on the new page. It also adds the search box to the Cookies page so that exceptions may be filtered. All changes only occur on the new Cookies page, which is only accessible when the privacySettingsRedesign flag is on. Bug: 1061136 Change-Id: I4e2202e9cc1789fd7275847b44ecf95a4c7f949d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102658 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751111}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/469205e1adaf..570330361a17 git log 469205e1adaf..570330361a17 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 kron@webrtc.org Add fallback histograms for VideoDecoderSoftwareFallbackWrapper 2020-03-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4e516821..f71e417d (750566:750950) 2020-03-17 peah@webrtc.org APM: Localize/abstract the usage of AudioFrame Created with: gclient setdep -r src/third_party/webrtc@570330361a17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061376 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iab55faa34568c9986e4085950cd9f49564bd924f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107741Reviewed-by:
-
Ryan Harrison authored
Roll src/third_party/dawn/ 971a6233c..b988e0398 (3 commits) https://dawn.googlesource.com/dawn.git/+log/971a6233c2a4..b988e0398277 $ git log 971a6233c..b988e0398 --date=short --no-merges --format='%ad %ae %s' 2020-03-17 rharrison Add in a default case to unblock shaderc rolls 2020-03-17 natlee LoseForTesting can only be called once 2020-03-17 brandon1.jones Residency 4: Add Facilities For Budgeting Device Memory Roll src/third_party/shaderc/src/ a7657e4fa..95185d920 (2 commits) https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/a7657e4fa2fe..95185d920a0b $ git log a7657e4fa..95185d920 --date=short --no-merges --format='%ad %ae %s' 2020-03-17 rharrison Rolling 4 dependencies (#1002) 2020-03-16 rharrison Add reflection support for storage textures (#1001) Created with: roll-dep src/third_party/dawn src/th Change-Id: I4f3ab6227a65d3b6977993feb11cc93803154682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107570 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#751109}
-
Hailey Wang authored
Used by background tab loading policy to load a PageNode. Bug: 1059341 Change-Id: Ifa11aab18abea4521016a5d9d5c14aff4b8ad88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106016 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#751108}
-
Dan Harrington authored
* Added StreamModel::Update() to accept data from storage or the network. * Added StoreObserver to StreamModel for observing changes that should be made to persistent storage. Currently this only includes DataOperations, but might include more data later (for network fetches). Bug: 1044139 Change-Id: I8179f6f0d5b2c4dbd2347d0d8667a41bc97d09e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106554 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#751107}
-
Victor Fei authored
Added AXObject::IsDetached to check that the ax_object_cache_ is still valid in AXObject::IsARIAControlledByTextboxWithActiveDescendant to fix a crash due to nullptr dereferencing on the ax_object_cache_. The crash happens in the following scenario, when there is a listbox options dropdown where Javascript dynamically remove/add the dropdown option nodes. When Windows Narrator's focus is set on the text content of the option, and we call Javascript function hide(), a crash could occur in some cases due to the following (I was unable to repro this with NVDA): 1. Javascript remove() nodes will trigger AXObject::Detach(), which sets ax_object_cache_ to nullptr. 2. Meanwhile, Windows Narrator's focus remains on the listbox option, and triggers AXNodeObject::OnNativeFocusAction(), which calls AXObject::IsARIAControlledByTextboxWithActiveDescendant() and retrieves nullptr for ax_object_cache_ and we call FocusedObject() on the nullptr cache and causes an exception. <button onclick="hide()">hide dropdown</button> <div role="listbox"> <div role="option" tabindex="1" id="0">option 1</div> <div role="option" tabindex="1" id="1">option 2</div> <div role="option" tabindex="1" id="2">option 3</div> </div> <script> function hide() { document.querySelector('div[role="listbox"]').remove(); } </script> For scenario similar to the example above, I had difficulty to have browsertests/unittests to exercise this scenario. Bug: 1021740 Change-Id: Ib86db0df64c230d341add63faf28a582792fa8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107429 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751106}
-
Xianzhu Wang authored
Previously PaintTimingDetector depended the painter not to paint opacity:0 contents to avoid detect timing of them, which didn't work for composited layers and CompositeAfterPaint where we always paint opacity:0. Bug: 957674 Change-Id: Ie5530f5a4c00d5e350b6dc2d1922f58e3953e7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106341 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#751105}
-
Robert Ogden authored
OnBeforeTunnelRequest and OnTunnelHeadersReceived both drop their H1 qualifiers and are now called during H2 and QUIC CONNECT proxy tunnel setup. Bug: 926427 Change-Id: Ia512f01bc592bfa5ca196d6c2aa0b8b5dcac479b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099294 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
With this CL, the title during the successful IDLE state changes to "Checked Passwords" (not added since it exists for the same context). Also, the IDLE state shows "Check again" only if a check happened before and defaults to "Check Passwords" if there hasn't been a check yet. Without an initial check, we also show a different message and banner and hide icon and subtitle. Screenshots are in the linked bug. Bug: 1062216 Change-Id: I484504fdb37e0043b553813ff51008085d58488f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106087 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#751103}
-
Nicolás Peña Moreno authored
AddInterface() uses base::BindRepeating, so the input object must be a base::BindRepeating, and it seems that it can be called multiple times based on the comment here: https://source.chromium.org/chromium/chromium/src/+/master:chrome/common/sandbox_status_extension_android.mojom;l=11 Similarly, CreateFunctionTemplate() receives a repeating callback, and it is reasonable to allow getAndroidSandboxStatus to be called multiple times. Bug: 1007641 Change-Id: I3103b1e4ca8f5d6064c4b2c74d19cb9aad01fed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107705 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#751102}
-
Andrew Grieve authored
And update docs for the setting. TBR=agrieve # Mechanical rename Bug: 1054892 Change-Id: I7303eb44046f70fae7e6c6a11c7aacc913ef8654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107413 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#751101}
-
John Budorick authored
Both are perilously close to 1h shard execution times. blink_web_tests was already supposed to be running w/ 25 shards but wasn't due to a subtle misconfiguration. Change-Id: If9aff89984380d3a3dafece0b8774d6e494f183f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106884Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751100}
-
Jerome Jiang authored
BUG=1055917 Change-Id: Ic3e12c711c5470a1ebf09dd72df392d85d1226cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106557Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#751099}
-
Jan Wilken Dörrie authored
This change removes IDS_SETTINGS_LEAKED_PASSWORDS_COUNT, which was initially removed in r748277, but then accidentally re-added in r748728. There are no usages of this string, and thus it can safely be removed. Bug: 1047726 Change-Id: Ib765f74ad8a031cb45cbf229c7031e2a7d39682d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107484 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751098}
-
W. James MacLean authored
This test is flaking a lot recently, disabling until a fix is found. TBR=jkrcal@chromium.org Bug: 1021930 Change-Id: I47d5b1ca51686febf5bbd2e712573937d867625c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107685Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#751097}
-
Sergey Ulanov authored
Previously fuchsia-dir was registered as a standard URL scheme only in WebEngine, but not in runners. As result fuchsia-dir:// URLs were not always handled correctly, particularly because GURL::GetOrigin() returns an empty string when called for an URL with a non-standard scheme. When trying to start an app from a custom content directory cast_runner was getting empty string from GetOrigin() and passing that empty string to Frame::SetPermissionState(). As result WebEngine would terminate the Frame. Added RegisterFuchsiaDirScheme() helper that's now used in runners to register fuchsia-dir scheme. This ensures that GURL::GetOrigin() works properly for fuchsia-dir URLs. Bug: 1062120 Change-Id: Ibe28f07e4a6b08cf62526c5f7ee81e2783c6d667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106748 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#751096}
-
Manu Cornet authored
Change-Id: I7b86172efd0c870b3be9242086956b5bc687220d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106654Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751095}
-
John Budorick authored
Shards are liable to time out when running on minis, e.g. https://chromium-swarm.appspot.com/task?id=4b017cb46b89c910 Change-Id: I025c898985dd524fb1d29c7f6ea93efc5c2341a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106461 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/141ac68fa0f7..beefcb9d38c0 git log 141ac68fa0f7..beefcb9d38c0 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 kjlubick@google.com Reland saveLayer can omit the rectangle argument. 2020-03-17 hcm@google.com add m82 release notes 2020-03-17 senorblanco@chromium.org Dawn: embed a staging buffer inside the uniform ring buffer. Created with: gclient setdep -r src/third_party/skia@beefcb9d38c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I88d24aca627cee61cc8d0ebe8f9079eb2e862a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107332Reviewed-by:
-
Kevin Marshall authored
Addresses some post-LGTM feedback items that narrowly missed the initial landing of LegacyMetricsUserEventRecorder. TBR=ddorwin@chromium.org Bug: 1060768 Change-Id: I9f20281b11585439947de89eb71fa15aa6750a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107712Reviewed-by:
-
Rahul Arakeri authored
This CL adds the plumbing to make features::kPercentBasedScrolling accessible to LayerTreeHostImpl via LayerTreeSettings. Bug: 1062163 Change-Id: Ic8676f3c1d76533fcc3639de68ece2763baae711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107153Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751091}
-
Jonah Chin authored
The cause of this bug was the switch to a RecordPaintCanvas() on the CanvasResourceProvider. Previously, a Clear Operation was done directly on the skia canvas in OffscreenCanvas::GetOrCreateResourceProvider(). Now that CanvasResourceProvider::Canvas() returns a RecordPaintCanvas(), a Clear Op is recorded, but not drawn to the backing skia canvas until flush. The context's tracking boolean, |have_recorded_draw_commands_|, was not updated to signal that a flush was needed. This resulted in WritePixels()'s call to FlushRecording() earlying out with no flush, despite the existence of draw operations. By replacing |have_recorded_draw_commands_| with a check of the recorder's actual DisplayItemList, we can avoid juggling the |have_recorded_draw_commands_| boolean and can always correctly determine if a flush is necessary. Bug: 1059121 Change-Id: Ic511229a0cdb0ef3fe48dbd4d760066a0be2d10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099299Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751090}
-
Askar Aitzhan authored
The field is needed to verify that the policy view of DMServer and Chrome OS device is consistent during the ongoing Certificate Provisioning Process. See more: go/built-in-cert-provisioning. Bug: 1045895 Change-Id: Ia1326a6a58720be1e430206882520529a4b16385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100968 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#751089}
-
Pavel Yatsuk authored
This CL extracts methods that InfoBar calls on InfoBarContainer into InfoBar.Container interface. This breaks InfoBar dependency on InfoBarContainer and allows moving InfoBar.java to chrome/browser/ui/messages. BUG=1056346 R=mdjones@chromium.org Change-Id: I1b16b6021979dcdfcff1aa5e48cc9aacf613b02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103140Reviewed-by:
-
