- 08 Jan, 2021 40 commits
-
-
Adam Rice authored
The web test external/wpt/websockets/stream/tentative/backpressure-receive.any.js started failing on Windows 10 with the switch to Python 3. It appears some additional buffering is happening in the OS. As a workaround, split the large message that is supposed to be delayed by backpressure into 16 parts. BUG=1155106 Change-Id: Ifa2b04e4857f3c537721735cec187f610c053d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613853 Commit-Queue: Domenic Denicola <domenic@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841571}
-
Caroline Rising authored
Add a reading list profile pref for whether the first use experience has been shown. Bug: 1109316 Change-Id: I62495a0804910e25c2b3498ed6923362b6b8447d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611445Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#841570}
-
Ken Rockot authored
Bug: 1004256 Change-Id: Iaaf8e601a7f3e400bd7aff5b60e8586e7adb43a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616519Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#841569}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1607b3aa8ccd..942976eacacf 2021-01-08 sergio.garcia.murillo@gmail.com Wire scalability_mode when simulcast is not in use (i.e. streams==1) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6238fcc7a9251700904d5457579ccbde8190e678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841568}
-
Domenic Denicola authored
Fixed: 1148056 Change-Id: Id753248d13cf8332597b0c6592c9d8d9c43407ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615478Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841567}
-
Lijin Shen authored
Bug: 1157681 Change-Id: I109580de27420bafc9a57a4c83bedba18799bac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605417 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#841566}
-
Dave Tapuska authored
Move UnfreezableFrameMsg_DeleteProxy to be a method on the RemoteFrame. This is possible because associated channel messages are not currently frozen. BUG=993189 Change-Id: I9b09706686d4dc1b6bf7f499f1f5f90224380c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527517 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841565}
-
Fredrik Söderqvist authored
MediaValuesInitialViewport was only used by |ViewportStyleResolver::initial_viewport_medium_|, but that in turn is never used. Remove the class and drop the unused ViewportStyleResolver field. Bug: 991610 Change-Id: I51bb5a8f5e967b16d6c1e0f473b76d4bbc76ff28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616562Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#841564}
-
Nick Diego Yamane authored
Factor out common helper test code into WaylandDragDropTest class, clean up and re-use it in both data and window drag controller unit tests. R=msisov@igalia.com, tonikitoo@igalia.com Bug: 1163544 Test: ozone_unittest --gtest_filter='*WaylandDataDragControllerTest.*' Change-Id: I91f34f2f189783472fb8aa20764da305a5cbe793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613684Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#841563}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/070ef598892a..afc78f5e6ae9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie57e77d2ae55c692d5937b336abfb54fdecc8843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618223Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b1f7453a734..f78841938e2d 2021-01-08 tvanderlippe@chromium.org Fix lit_html_data_as_type to handle multiple data setters If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8357ff2b414f7222318b4e9e74dd511ae7571009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617425Reviewed-by:
-
Mark Cogan authored
There are relatively frequent crashes (see bug) originating from GridViewController inducing reentrancy into WebStateList. This happens when a state-mutating method (in this case, ActivateWebStateAt()) is called on WebStateList while it is still handling a different state- mutating method call. The initial method call triggers observer methods, then the observer method (usually very indirectly) calls another state- mutating method. Specifically for this bug, this sequence of events happens: 1) Something causes a new tab to be inserted (there are many ways to do this). 2) The tab insertion is observed by TabGridMediator, which calls the -insertItem:atIndex:selectedItemID: consumer method. 3) The consumer (the GridViewController) eventually calls [UICollectionView performBatchUpdates:completion:]. 4) Roughly 24 stack frames of UIKit calls happen. 5) [UICollectionViewDelegate -shouldSelectItemAtIndexPath:] is called. 6) GridViewController subsequently calls (eventually) [TabGridMediator -selectItemWithID], which calls ActivateWebStateAt(). I don't have repro steps, so I haven't seen a crash with the symbols for the UIKit stack frames in step (4), so I don't know what the collection view is doing to make this happen. The collection view docs say that -shouldSelectItemAtIndexPath: should *only* be called when the user taps on a cell, and never when the cell is programmatically selected. But it looks like that's still what's happening. Absent repro steps, this CL puts two layers of speculative fixes. First, TabGridMediator's selectItemWithID: method adds several early- return possibilities; it will now early-return if the selected item is already selected, and it will early-return if the web state list is locked for mutation. Note that it's unclear what will happen in this case, since the activation event might be triggering the tab being opened. Second, GridViewController sets an 'updating' flag while the collection view batch update is in progress, and doesn't handle cell selection while this flag is set. Either one of these should fix the crash, but since there aren't repro steps, I've added both. Bug: 1134663 Change-Id: Ia838a5da9b763dbe8b82acc69957327d96259261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614432 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#841560}
-
Alexei Svitkine authored
This should speed up using feature / field trial params APIs. Bug: 1163921 Change-Id: Ieacd216cba47c259287b3b392bd00fa7077ac084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615481 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#841559}
-
Sebastien Marchand authored
A lot of the logic in this file dates from the Syzygy days, as we don't use it anymore there's no need to template the target that generates the installer. Change-Id: I810e059b6eb733324096389dca53853f080c672d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613328 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#841558}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/afc78f5e6ae9..11e6cfe60a92 2021-01-08 hjd@google.com Merge "upkeep: Remove redundant return" 2021-01-08 hjd@google.com upkeep: Remove unused using decls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic80e0d8a34e8705e95025ac19fd68a99137d99ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618226Reviewed-by:
-
Clemens Arbesser authored
Bug: b/174305656 Change-Id: I065dc27cee934dd22b9adb4034f2796932a06fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617940 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841556}
-
Gauthier Ambard authored
Add tests to load bad SSL pages and navigate back/forward/proceed. Bug: none Change-Id: I69ca6998a4477515ac63ad201ef7bc6491c8ddeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618138 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#841555}
-
Aaron Leventhal authored
No change in behavior expected, but this is to fix an inconsistency in the code where calls were made using a mismatched BrowserAccessibility and BrowserAccessibilityManager. Bug: None Change-Id: I73cac6b0e901c2685272415fcb28c7542ed6fe34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615201Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841554}
-
Aaron Leventhal authored
File crbug/1164043 for follow-ups. Bug: 1164043,1157731 Change-Id: I285ddb0eec4e21fe0537276b82a352b819395078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616462 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610074312-1e61cca385dcdccbd239aae3d699d6888b006a9e.profdata to chrome-win64-master-1610107094-52dce87c233c024b300dbf806becfa12ff1bc3d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I59b5abdb3d3a1f60280f9d03c78b4e7c39745925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616822Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36b254fb9b13..24cfa1c1796a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC wjmaclean@google.com,fhorschig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: wjmaclean@google.com,fhorschig@google.com Change-Id: I461d1ba1437cea5f2b00ad57e617e315989278da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618224Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841551}
-
Austin Sullivan authored
These changes were originally proposed in this refactor [1], but have been split into another CL. Bug: 1110509 Change-Id: Ifa430ebd8b39eaed9773a2b9ca6e4963f2d40002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604974 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#841550}
-
Dave Tapuska authored
Move the InstanceCrashed notification to the PepperPluginInstanceHost mojo channel. BUG=1157519 Change-Id: Ic93baac43c6b17c28367950336d96eea568344db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616280 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
David Black authored
Addresses two potential issues: - Shelf previews being pixelated due to being larger than thumbnails. - File type placeholders being sized wrong depending on where shown. To accomplish this, this CL: - Makes placeholder logic internal to HoldingSpaceImage - Makes HoldingSpaceImage support returning images up to a max size Another subtle change to call out. The holding space image placeholder image will now be empty until the async bitmap request either succeeds or fails. Since success/failure is very fast, this will reduce flashing of the file type icon. Bug: 1163663 Change-Id: Ib5fe49247294a2e5bf2dc97f71fdf66d654dbef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613811Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#841548}
-
Alexander Timin authored
Rewrite WaitForCondition to call RunLoop::Run only once and avoid relying on an explicit timeout. Combined with crrev.com/c/2616018 this should eliminate timeouts on asan/tsan bots, where the tests are known to take more than the old timeout of 30 seconds. R=eseckler@chromium.org BUG=1157954,1041392 Change-Id: Idb880b64a69b9c5323a683a2764549452345924a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615351 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#841547}
-
Caroline Rising authored
This is a preexisting metric capturing the way the bookmark icon was activated that we want to continue to capture when read later is enabled. Bug: 1163938, 1131547 Change-Id: I0c397d7f534c6c52726978d3a85c9fa2a046a6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616418 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841546}
-
cfredric authored
This makes no behavior change, since the if statement should only be inserted if the `RegisterPnaclComponent` call has also been inserted. However, it makes it clearer that there is no bug related to the missing bracket and an unintentionally un-inserted statement. I.e., a bug of the form: if (condition) # if SOME_FLAG conditional_stmt(); # endif unconditional_stmt(); Note that in the above snippet, if SOME_FLAG is false, then `unconditional_stmt` will unintentionally become conditional. Again, the current code does not exhibit this bug, but at a quick glance, that is not obvious. Change-Id: Ibb41d390ae5be698421266ad494ea03dcb95532f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617462Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#841545}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9f527ffb. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ia15a03e178d534e86b487a4ec50a62e46e9f9aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615345Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841544}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2f51b18065a..f5aed172c693 2021-01-08 westont@google.com [infra] Use Mac10.15.7 and xcode12.3 for all builds. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I33b63993b5db4b063af1534fd90e8ec60bfc483d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616815Reviewed-by:
-
Owen Min authored
SpellCheckEnabled is superset of SpellCheckServiceEnabled. Update the policy doc to make this more clear. Also refers the suggestions from issue 1018157. Bug: 1123562, 1018157 Change-Id: Ib43de56c0e95f6641143d23776049bba602fca19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388156 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#841542}
-
Akihiro Ota authored
This change fixes an issue where giveChromeVoxHint_ was being called several times. This is likely because it's bound to an event listener, which isn't removed until several calls have been queued up. To prevent this, use a variable to track when the hint is given. Fixed: 1162246 Change-Id: I9e9ed3ac5ce83e7011d29b2edc392d019289803a AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613366Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#841541}
-
Brandon Wylie authored
The account check can complete after startup completes, which leaves the ui components out of sync with each other and the current assistant capabilities. Adding an observer to GSAState to monitor for account changes and updating AssistantVoiceSearchService clients accordingly. Bug: 1163196 Change-Id: I02c17425458544cf5afaa9fdd434f661061b0014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611655Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#841540}
-
Austin Sullivan authored
This change was originally proposed in this refactor [1], but has been split into another CL. [1] https://crrev.com/c/2601576 Bug: 1110509 Change-Id: Ifd92321c5136ac3b29a714f24ad39674c866c9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604975 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#841539}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610096386-b7d9ff85a7e5a6b9d422dd8ae3e7ff1b6461dd2b.profdata to chrome-win32-master-1610107094-5d3c24229731decbd402a4499ebb6cac6decdedb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6f57cb94a1ceb1e6ed1955c2af72c63add1a6e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616813Reviewed-by:
-
Colin Blundell authored
Navigation#isKnownProtocol() was added in 89, but I mistakenly added a call to it without guarding by version in NavigationTest.java. That call causes skew tests to break. This CL adds the guard, which necessitates making the inner class from which the method is called not a static class so that it can access the test's activity rule. Bug: 1155275 Change-Id: I14d02fc87bb1a5cbc54f2ea116b01c689e384a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616230Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#841537}
-
Regan Hsu authored
Currently, calling syncer::SyncService::TriggerRefresh() in BrowserTabsModelProvider doesn't guarantee an immediate update. It bypasses some of the potential sources of latency (e.g. for delivering an invalidation), but not others (e.g. backend replication delay). This method of refreshing browser tabs should be replaced when there is a better means. Fixed: 1158480 Change-Id: Id3043a3197cfc8dc88f18fb50c8a3e64ccc09a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618064Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841536}
-
Bartek Nowierski authored
Some tests fail even with PA-Everywhere disabled. Remove these tests so that the bots work on a solid baseline. Bug: 1121427 Change-Id: I5a856ded7c521345a2aba7d3f7e700d1cc3c3293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615733 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#841535}
-
Evan Stade authored
Bug: 1158979 Change-Id: I1383a474580f73b39ccd79e00c4c8ce84fa33ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611789 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841534}
-
Gauthier Ambard authored
This CL change the context menu flag to add another options. This allows to have the following options: - The Web context menu - The System context menu (but still using our implementation) It will be decided later which implementation yields the best results. Bug: 1140387 Change-Id: I92cf9fbb5be8214e295851a9293daba804b0e546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584963 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#841533}
-
Gauthier Ambard authored
This CL adds a new class that could handle using UIContextMenu to display context menu. The new class is reusing the existing JavaScript from the current context menu to find the element on which the long press was done. For now the class isn't connected and isn't displaying anything. Bug: 1140387 Change-Id: I33c2f90445af29712b8680da3f69cdda21dd0367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578958 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#841532}
-
