- 19 Jun, 2020 6 commits
-
-
Mario Bianucci authored
In order to start having the browser process forward ink points to viz for delegated ink trails, add a flag onto the RenderFrameMetadata that lets the browser process know it should start. RenderFrameMetadataObserver will pick it up and ship it over to the browser process, where it will be picked up by RenderWidgetHostViewBase and saved for a future CL, where RWHVEventHandler will use it. Bug: 1052145 Change-Id: I8305292de6289dcec3fb4083666898161ae1dc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240356Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780091}
-
Trent Apted authored
Mostly this is missing nullability modifiers picked up by jscomp_error=lintChecks. Also clean up some white space in closure annotations. This just addresses the release code (test code to be done later after consolidating all the flags better). Bug: 892530 Change-Id: Ibb8c250bf7b5e3950f9bc477bad0fcffc3254bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253258Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#780090}
-
Chris Lu authored
This change will allow for mocking AutofillSaveCardInfoBarDelegateMobile. Bug: 1071914 Change-Id: I1175201dc0b286558211e111bb19a6c6d853856b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250702 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#780089}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib03d852d809386687f2770887a68f74b00c4c1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780088}
-
chrome://internals/query-tilesHesen Zhang authored
- Setup chrome://internals for future merge. - Complete the front end code for chrome://internals/query-tiles. Bug: 1066556 Change-Id: I51529f6e11dd37e15df2b7a3da1864dbbc5da58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247544 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#780087}
-
gogerald authored
This CL fixes the bug in https://chromium-review.googlesource.com/c/chromium/src/+/2243334 Without setting the height to match_parent, it will be unscrollable when its content is short. Screen record before https://drive.google.com/file/d/1CUOz6ErGL2fxkF2pGAC_fGWEcTGy8hrD/view?usp=sharing Screen record after https://drive.google.com/file/d/1CeuBtjQbGRovJC8H0Vk-wY6wpWqmlQJ0/view?usp=sharing Bug: 1093506 Change-Id: Iff9df7ef0050885c02fe55676dbfa2046d6e78a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253143 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780086}
-
- 18 Jun, 2020 34 commits
-
-
Meilin Wang authored
This reverts commit 7e22905c. Reason for revert: fixed the test crashes. Original change's description: > Revert "ambient: container logic refactoring [part 1]." > > This reverts commit 7eab011b. > > Reason for revert: AmbientControllerTest failures > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg?limit=200 > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19204?blamelist=1#blamelist-tab > > Original change's description: > > ambient: container logic refactoring [part 1]. > > > > This CL is splitted from the original CL: > > https://chromium-review.googlesource.com/c/chromium/src/+/2199870 > > with all files changed on ambient/. side. > > > > Bug: b/156531168 > > Test: unittests. > > Change-Id: I4f84277c74c95419ac96e6cfaaa48081c407b243 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248878 > > Commit-Queue: Meilin Wang <meilinw@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#779664} > > Change-Id: Ia9eaa3e0d856c7dabf2526c3566fa35cf415e17c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/156531168 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250602 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779737} Bug: b/156531168 Change-Id: I75b3385ffa72ac9fe5a9d90f2844180231e4fcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252656Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#780085}
-
Christopher Cameron authored
This file has gotten jumbled by keeping diffs small. This does nothing but move code around. TBR=geofflang Bug: 1092155 Change-Id: I6951d61ce1ae96cde61cd879c482bd8a20641f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251160Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#780084}
-
Xianzhu Wang authored
This a reduced version of crrev.com/c/2238519. That CL was reverted because of crbug.com/1094807 (DCHECK failure in cc::PictureLayerImpl::SetUseTransformedRasterization). The failure seems because of cc::PictureLayer::ShouldUseTransformedRasterization() may change after Update() before PushPropertiesTo. This CL removed the main-thread side change about transformed rasterization, but keeps the impl-side changes. > - Turned out that we can't enable LCD text with transformed > rasterization because the latter will cause translucent pixels along the > edges of the layer on which text may draw. This CL partly reverts > crrev.com/c/2229243 which enabled LCD text with transformed > rasterization. > > - When enabling transformed rasterization, we need to not only set > contents_opaque to false, but also need to let RasterSource clear canvas > before drawing because of the translucent pixels at edges. > Bug: 1077071 Change-Id: Ib67d054efb357a75f3c33d98c32cdb4fe5563612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247385Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780083}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c950e05bafcd..304dfa379c54 2020-06-18 brianosman@google.com Remove swizzling-store instructions from SkSL ByteCode 2020-06-18 fmalita@chromium.org [skottie] Add support for unprefixed valign/resizing props 2020-06-18 bsalomon@google.com Use child texture effects in ProcessorRefTest 2020-06-18 johnstiles@google.com Roll gn. 2020-06-18 fmalita@chromium.org [skrive] Start parsing the node hierarchy 2020-06-18 brianosman@google.com Remove swizzling-load instructions from SkSL ByteCode 2020-06-18 brianosman@google.com In SkSLSlide, directly use Viewer's shader error handler 2020-06-18 mtklein@google.com allow fallback to skvm blitter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Icc61f224925aaacf2fa9e43cff384346a3298f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252535Reviewed-by:
-
Philip Rogers authored
This is no longer used. Change-Id: I75aadeb8a4cbf2cd7f928633e03222eb1d3e521f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253118 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780081}
-
Vasiliy Telezhnikov authored
This CL adds Android.WebView.Gfx.HardwareDrawType metric to track what was the reason of current hardware draw in order to see if the draw could be potentially skipped. It tracks three flags: * Did we invalidate this frame * Did renderer submit compositor frame * Did DrawParams from HWUI changed. Change-Id: I28e98a5fe9bbeae5c7adc48d744a50bca7fd4dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246633Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#780080}
-
Anders Hartvoll Ruud authored
Before the dependency-aware MatchedPropertiesCache, we would set a flag HasVariableReferenceFromNonInheritedProperty whenever some non- inherited property referenced a custom property. However, with the dependency-aware MPC enabled, var() references from inherited properties can also incur dependencies. This caused a regression in the CustomPropertiesVarAlias.htm benchmark, since it creates a rule with 2000 var() references that are referenced from other custom property declarations. Since (regular) custom property declarations are _inherited_ properties, they would not be excluded from the cache with the old code, but they are excluded now, since we exceed the dependency limit. To fix this, we only produce a dependency from a var() if it is referenced from a non-inherited property. However, this creates a new problem for the "apply inherited only"-type of cache hit: applying inherited properties mean custom properties (that are not registered as non-inherited) will be applied as well, and this affects any var() references in non-inherited properties. This problem is exactly the same as "apply inherited only" when it affects the font or zoom (which may affect lots of other non-inherited properties). Therefore, this CL changes ::EffectiveZoomOrFontChanged to ::IsUsableAfterApplyInheritedOnly (name inspired by Webkit's similar code), which also takes changes to inherited variables into account. Sidenote: The reason for using CascadeResolver to figure out the current CSSProperty rather than propagating it as an argument is to avoid having multiple sources of truth. If we passed a CSSProperty as a parameter, it would be possible to pass the wrong thing (vs. what is contained by CascadeResolver), and that would be very bad. Bug: 1057072, 1095460 Change-Id: I137fb8ffc69eb2b913c8494ab9b1d1debc8038eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247767 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#780079}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I2f0848de1eeb0b6d165cbd1a8a291595bae42def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248639Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#780078}
-
Fabrice de Gans-Riberi authored
openscreen::cast::Environment now has a default value set to any IPv6 address for the |local_endpoint| argument in the constructor. This cleans up the usage in Cast Streaming. Bug: 1096723 Change-Id: Id5f36a87acfb171d2aaeab7188c0b61ae864fa82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252851 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780077}
-
Yaron Friedman authored
Turns out it's not very accurate at all and often gets misinterpeted as representing user behaviour. Deprecate it and point to PageLoad.Timing2.NavigationToCommit which is more accurate for user behaviour. See also: https://docs.google.com/document/d/1TUvbPhbcuKGPrwx1iqUIisiV9YVWrz_SDTfdEz0_SDM/edit?ts=5ebc27cc# Change-Id: Ic748fa3f3722237b5628353f680a13d704ff5840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198684Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#780076}
-
David Bertoni authored
These tests were disabled many years ago and it's unclear why they weren't enabled when the underlying issue was fixed. There was a CL that purported to do this: https://codereview.chromium.org/9517002 Not sure what happened here, but I don't think it's worth spending more time figuring it out. Note: These were NOT disabled for being flaky. Bug: 116490 Change-Id: I8f200b0f32a10ce1c02959f686e1319e069fd5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252606Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780075}
-
My Nguyen authored
No-Bug: Cleanup Change-Id: Ic4d5c6fe3cd2bf4f67cf168620081b61d95b62a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251520 Commit-Queue: My Nguyen <myy@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#780074}
-
Jimmy Gong authored
- Adjusts the size of the progress bar to align with completion status. Before: https://screenshot.googleplex.com/X7Nk5EoM2Yq After: https://screenshot.googleplex.com/izGd9Kcvwvj Bug: 1053704 Change-Id: I8d11d84596675fb1ea1b44d3c812e665671a7cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252954 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#780073}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592503157-30b63e57baf9882593dc962ba95100f29c6397c5.profdata to chrome-win64-master-1592506745-f793491bcd6225e620fbbb39e10a569b00ffc767.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I09495d97cfc62a3082cd6008607ac71e09739c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252586Reviewed-by:
-
Thomas Guilbert authored
This CL removes the use of base::DictionaryValue in VideoFrameMetadata, and instead uses one base::Optional<> per key. A follow up CL (which will be submitted at the same time) will remove the key-based getters and update all call sites to use the base::Optionals directly. Change-Id: Ic9bce57856a0b7bd01d99acdaa6a5786d7ef36f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231706 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#780071}
-
Shakti Sahu authored
This CL disables tile animations which fixes the crash. We will have a better fix to handle stale animations correctly in M85. Bug: 1096437 Change-Id: I5389707703c587aea0576699217f443ce6852953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252563 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#780070}
-
Jan Krcal authored
This CL removes UMA user actions that have been replaced by a new histogram since M79. Bug: 995757 Change-Id: Iaeae4bd9125f68209a48f8a0c315eefb39b6b2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247729 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#780069}
-
Chris Lu authored
This change adds SaveCardInfobarModalOverlayMediator and SaveCardInfobarModalOverlayCoordinator to manage the SaveCard Overlay Modal UI. Bug: 1071914 Change-Id: I137f38832a56cbf1e0cf934c86c39b1066c08dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246795 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#780068}
-
Omer Katz authored
This CL: * Introduces atomic ObjectStartBitmap * Uses it to get object start of mixins * Removes mixin virtual GetTraceDescriptor method. See for more information: https://docs.google.com/document/d/180i8OnHeZ9pLnaEA0NxDT1UOfrpHKF9ovCRv2X4ET6k/edit?usp=sharing Bug: 986235, 1080701 Change-Id: I1fab84f39c64714b08b8909a39ea0b8367eaf1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247020 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#780067}
-
Chong Gu authored
Bug: 1096611 Change-Id: I8d7b3b2898fded0a805e8c4da784703c7e448180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252685Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#780066}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a6f1fc99. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I97d8021bdc61bcf50b61f7717b02f0f879f52d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252879Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780065}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592495797-0ce2a459124ac0074ced31c25e7b4057cfe18bea.profdata to chrome-win32-master-1592506745-dd4e30b5db51eb72110579247828d44bc4732ba7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I66af096d3d2c0db10e725b8470e6932d5effa934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252533Reviewed-by:
-
Daniel Rubery authored
This CL adds code to fetch the model from the cache (without making a network request) immediately at startup. Since the models have a very long max-age, this should solidly address the high proportion of MODEL_NEVER_FETCHED in SBClientPhishing.ClassifierNotReadyReason. See https://uma.googleplex.com/p/chrome/histograms?sid=20464e66b314d32caf0ef36facc35186 Bug: 1068623 Change-Id: I46c56daa4abb5ac32abf54c1970cb4146e79c22a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250956 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#780063}
-
Anders Hartvoll Ruud authored
A longhand that's part of some shorthand expansion needs manual attention in the code template if that longhand is behind a flag. This CL fixes that by generating shorthand expansions for all possible runtime flag configurations (for relevant flags), and selecting the correct one dynamically. We assume that the flag-protected longhand will appear/disappear "in-place" in the list of longhands. In other words, if some runtime flag were to reorder longhands, manual code will still be needed in the template. Since this CL means we'll generate 2^N expansions for N flags, there's currently a limit of 4 flags per shorthand (which should be generous enough). Bug: 1096015 Fixed: 1094236 Change-Id: I99d321b971ea2b746688829f35a868db7d0f5f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250242 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#780062}
-
Kyle Milka authored
Make ShareSheetCoordinator implement WindowAndroid.ActivityStateObserver this allows it to close the share sheet when switching apps. Bug: 1087463 Change-Id: I6de44ea0e5c02de0c287f84bbbd991f331d2714d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253139Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#780061}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I78d2bd8a5ed30f0d5b13b6ceb35dfb5b85e0fc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252571Reviewed-by:
-
Ahmed Fakhry authored
This is a regression caused by my earlier CL: https://crrev.com/c/2227615. That CL exposed a bug in the ordering between adding a view to the view model, and as a child to ShelfView. The view should be added the model first before adding it as a child to avoid have a wrong view count in the model when updating the visible views. Also, this CL fixes the value of visible_shelf_item_bounds_union_ which was being updated too early while views are animating making it have the wrong bounds. BUG=1095601 TEST=Manually, added a new test. Change-Id: I5bca5a6febe06bfad791e2321727975bd1530d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252931Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#780059}
-
Maggie Chen authored
Majority of the Vulkan crashes on Windows have this driver version. This version was accidentally excluded in the previous CL. Bug: 850881 Change-Id: I0df2ea2e2ba4e5e7ce300e13ece2468f026ddab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253079Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780058}
-
Sorin Jianu authored
Making all App instances singletons appears to have been a mistake. Singletons in Chromium are typically leaky singletons, and thus, destructors for App instance don't run, breaking expectations and creating confusion. This CL makes all the App instances normal ref counted class instances, execept for the Windows COM server, which remains a singleton because of a design quirk: coclass instances created by COM need a way to refer the COM App server class (to talk to the update service, for example). We could not find a way to pass the App instance to coclasses, and so, the need for the singleton. TBR: waffles@chromium.org Bug: 1064498 Change-Id: I2872aa1821fcf27b74f22236483cfc11ea7c3059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252462Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780057}
-
Martin Kreichgauer authored
Builds currently fail because the file doesn't exist in Visual Studio 2017. Bug: 1089996 Change-Id: I1558fc11fda532406baf5b0af998c5e58a774aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252620Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780056}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/477818f5075f..404049010310 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com,atotic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093350,chromium:1096544 Tbr: smcgruer@google.com,atotic@google.com Change-Id: I8b05e21b3ad64730b8c2b8b627e45330d2789f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252532Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780055}
-
Roger Tawa authored
Bug: 1069049 Change-Id: I3ca779e3bbda80abeae89bd035c9159c4dca853c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250513 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780054}
-
Fred Ranking authored
data_source_ should be guaranteed to be release after DataPipeProducer::Cancel() triggered, This ensures that DataPipeProducer destruction eventually leads to teardown of the corresponding SequenceState object. Bug: 1095883 Change-Id: Ibf1d5787a57ae5da9eaa24e25e1e72c1a3a9907c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245987 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#780053}
-
Omer Katz authored
This CL also fixes any unittests that didn't pass the plugin checks. Bug: 986235 Change-Id: Iafff8ad41f76bd7d7957c0b9af435651c1df7591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246176 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
