GitLab

This CL has three components:
  1) The bulk of the logic in OOP HP was refactored into ProfilingTestDriver.
  2) Adds a java instrumentation test, along with a JNI shim that forwards into
  ProfilingTestDriver.
  3) Creates a new apk: chrome_public_apk_for_test that contains the same
  content as chrome_public_apk, as well as native files needed for (2).
  chrome_public_apk_test now targets chrome_public_apk_for_test instead of
  chrome_public_apk.

Other ideas, discarded:
  * Originally, I attempted to make the browser_tests target runnable on
  Android. The primary problem is that native test harness cannot fork
  or spawn processes. This is difficult to solve.

More details on each of the components:
(1) ProfilingTestDriver
  * The TracingController test was migrated to use ProfilingTestDriver, but the
  write-to-file test was left as-is. The latter behavior will likely be phased
  out, but I'll clean that up in a future CL.
  * gtest isn't supported for Android instrumentation tests. ProfilingTestDriver
  has a single function RunTest that returns a 'bool' indicating success. On
  failure, the class uses LOG(ERROR) to print the nature of the error. This will
  cause the error to be printed out on browser_test error. On instrumentation
  test failure, the error will be forwarded to logcat, which is available on all
  infra bot test runs.
(2) Instrumentation test
  * For now, I only added a single test for the "browser" mode. Furthermore, I'm
  only testing the start with command-line path.
(3) New apk
  * libchromefortest is a new shared library that contains all content from
  libchrome, but also contains native sources for the JNI shim.
  * chrome_public_apk_for_test is a new apk that contains all content from
  chrome_public_apk, but uses a single shared library libchromefortest rather
  than libchrome. This also contains java sources for the JNI shim.
  * There is no way to just add a second shared library to chrome_public_apk
  that just contains the native sources from the JNI shim without causing ODR
  issues.
  * chrome_public_test_apk now has apk_under_test = chrome_public_apk_for_test.
  * There is no way to add native JNI sources as a shared library to
  chrome_public_test_apk without causing ODR issues.

Finally, this CL drastically increases the timeout to wait for native
initialization. The previous timeout was 2 *
CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL, which flakily failed for this test.
This suggests that this step/timeout is generally flaky. I increased the timeout
to 20 * CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL.

Bug: 753218
Change-Id: Ic224b7314fff57f1770a4048aa5753f54e040b55
Reviewed-on: https://chromium-review.googlesource.com/770148
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517541}

BUG=696454

Change-Id: I7ea839d6c9135c639b1a8a68843721142d4bf81c
Reviewed-on: https://chromium-review.googlesource.com/776123Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517540}

Repaint overlay visualizes the repaint rectangles in the text results of
repaint tests. This CL brings the feature in the legacy results.html
into the new test expectations page.

Also slightly tweak the handling of keyboard navigation.

Change-Id: I8240e38449287ac899a33a691f0e234e74575ad1
Reviewed-on: https://chromium-review.googlesource.com/776094Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517539}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03c0eed54814..d79c2901f5f8

$ git log 03c0eed54..d79c2901f --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=773489


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I573802b204c6ea717fe5d8ba21ea91d2e7b2616c
Reviewed-on: https://chromium-review.googlesource.com/777387Reviewed-by: src-internal-roller . <src-internal-roller@chromium.org>
Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517538}

Change In-Product Help UI strings (http://go/cs-iph-strings).
Also fix a bug in IPH that caused a NullPointerExcepetion.

Bug: 784561
Change-Id: Icad33dbacc12d8c4d186b119f90c6262ac0cf976
Reviewed-on: https://chromium-review.googlesource.com/769678
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517537}

This change adds a BandwidthEstimator interface and use it in
WebrtcFrameSchedulerSimpler, so we can use different implementations to evaluate
the bandwidth without fully relying on WebRTC.

Currently the implementation is still WebrtcBandwidthEstimator; this change
should have no logic impact.

Bug: chromium:781432
Change-Id: I9f910e2d5e5c441d7f324c549e77e1786e5ed046
Reviewed-on: https://chromium-review.googlesource.com/776009
Commit-Queue: Zijie He <zijiehe@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517536}

Change-Id: I7da84064c8aca5841261833f0a7fa954fbf4f062
Reviewed-on: https://chromium-review.googlesource.com/757643
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517535}

Bug: 613387
Change-Id: I3696db30690ea6bd7de673989e2846ec186bea25
Reviewed-on: https://chromium-review.googlesource.com/775758
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517534}

This prevents the waterfall from retrying failures of media_perftests.

Bug: 785554
Change-Id: I5d2e044a6749c938bae1bfbf567717971623cb77
Reviewed-on: https://chromium-review.googlesource.com/773464
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517533}

Many subclasses of BrowserWithTestWindowTest create a profile manager or
a ScopedTestingLocalState on their own, and this obviates the need for
both.

I came across this because I tried to add a reference to the browser's
profile manager in production code and a unit test started failing.
Rather than adding yet another TestingProfileManager in some local test
class, it's added to the base class.

Bug: none
Change-Id: I91541165044cf58793262cca79efb00a3c9eab29
Reviewed-on: https://chromium-review.googlesource.com/768255
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517532}

TBR=mmoss@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I38515a1b3f3a4056e6fafcf14f6d6e72ca5d3d21
Reviewed-on: https://chromium-review.googlesource.com/776066
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Alex Mineer <amineer@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517531}

We do not support enum splitted into parts in protocol.
It is preparation step before landing improved version of our code
generator which will generate only used types.

R=dgozman@chromium.org

Bug: chromium:778796
Change-Id: I2eceb334b81e59bdb8f4c6ce415f907b7207d0da
Reviewed-on: https://chromium-review.googlesource.com/775663
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517530}

Bug: 771398
Change-Id: Ibe4053be6d8b35e351e71b2e7be28e47ef41d472
Reviewed-on: https://chromium-review.googlesource.com/776406
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517529}

BUG=chromium:786430

Change-Id: I6e7b2878295566a15f482f932d0ba033e38daab2
Reviewed-on: https://chromium-review.googlesource.com/777029
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#517528}

Library loading is the first thing that happens when a renderer starts
navigating to a page. NativeLibraryPreloader is called during loading
and is responsible for majority of the loading time. However, unlike
library loading, preloading doesn't need to know command line of the
child process, and thus can happen earlier.

This CL preloads libraries when a child process is bound, which speeds
up navigation for warmed up renderers.

Bug: 783913
Change-Id: I3bffdc613717bfc61e038a2525cd96c5d0f0c0c3
Reviewed-on: https://chromium-review.googlesource.com/757561
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517527}

https://webrtc.googlesource.com/src.git/+log/12ab00b4d856..c296255c7ee7

$ git log 12ab00b4d..c296255c7 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I0b313642c156c74dfa3ffc639df8a9ea53ec3c1a
Reviewed-on: https://chromium-review.googlesource.com/777222Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517526}

Currently Launcher state transition animation is using layer animation
element of BoundsElement, which will SetBoundsFromAnimation on each
OnProgress. This will generate additional overhead with a whole commit
every frame. This cl converts it to use ThreadedTransformTransition,
which will let compositor optimize and accelerate the animation.

Bug:786209
Test:On Cyan and EVE
Average Smoothness Improved:
Cyan:
1x slow-down-compositing-scale-factor: 88% -> 100%
10x slow-down-compositing-scale-factor: 63% -> 73%

1x slow-down-compositing-scale-factor: 93% -> 99%
5x slow-down-compositing-scale-factor: 46% -> 59%

EVE: 
Change-Id: I960421d89762ff7fcb7c4e230d98137cd3e61170
Reviewed-on: https://chromium-review.googlesource.com/776195
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517525}

Bug: 782848
Change-Id: I9def38ec856a99a20cedf5f3595ee38b0cef2c8e
Reviewed-on: https://chromium-review.googlesource.com/777022Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517524}

Removes the deprecated onReparentingFinished in favor of the new method
onActivityAttachmentChanged.

Updates callers of the old method.

Bug: 
Change-Id: I67920b1caea804281972fbac32f91cd4509c281f
Reviewed-on: https://chromium-review.googlesource.com/775733Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517523}

The goal of an accessibility hit test is to take (x, y) coordinates and
map it to an element in the accessibility tree. When there are iframes,
the hit test first goes to the parent frame, and if the result is an
iframe element, we have to ping back to the browser process and pong to
the child frame's renderer to hit test recursively.

Previously this worked correctly on desktop platforms but didn't work on
Chrome OS, which uses the same renderer accessibility code but doesn't share
the same content/browser/accessibility implementation. Fix it just by moving
that browser-side child frame hit test ping/pong to RenderFrameHostimpl.

Note: this could be more efficient using RWHInputEventRouter, but that
would be a much larger refactoring. Tracking that in bug 785987.

Bug: 770248
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I7bdc15114f1599be5ffd9604db365d64adc0fb5c
Reviewed-on: https://chromium-review.googlesource.com/747202Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517522}

Currently holding on to app_locale but will soon also
gain Address normalization tools.

This is functionality neutral.

Bug: 767931
Test: existing
Change-Id: I2dfbf93b4e6b8b891c0f78b4fcde615dedf37b1e
Reviewed-on: https://chromium-review.googlesource.com/775813
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517521}

https://chromium.googlesource.com/chromium/buildtools.git/+log/9c40f80c9998..461b345a815c

$ git log 9c40f80c9..461b345a8 --date=short --no-merges --format='%ad %ae %s'
2017-11-17 jmadill Add migration code for no_exceptions configs.
2017-11-16 thomasanderson Fix typo: fuschia -> fuchsia
2017-11-16 thomasanderson Always hide libunwind symbols on desktop Linux

Created with:
  roll-dep src/buildtools
TBR=brettw@chromium.org
BUG=727437

Change-Id: I6dd70fd5ae642dd6a861e02913469f65e333bd19
Reviewed-on: https://chromium-review.googlesource.com/777031Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517520}

This paves the way to plug in an AutocompleteController, and associated
UI.  Also, drive URL bar and WebVR toast state via model, as omnibox
will require some of the same data.

BUG=777542
R=vollick

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I29e96b5318e0d90b5530c12166db9fe780dba276
Reviewed-on: https://chromium-review.googlesource.com/772393
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517519}

There is an EarlGrey method that does the same thing.

Bug: 638674
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic4c0d8af6397477a1653367aeddf8b8ff060f70f
Reviewed-on: https://chromium-review.googlesource.com/777385
Commit-Queue: Mike Baxley <baxley@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517518}

NOTE: This CL will land after https://chromium-review.googlesource.com/c/chromium/src/+/769330.

This is to expose MessagePort object in AudioWorkletNode and
AudioWorkletProcessor for the bi-directional communication.

Spec: https://webaudio.github.io/web-audio-api/#instantiation-of-AudioWorkletNode-and-AudioWorkletProcessor

Bug: 774564
Change-Id: I543735fc141460a8c356b52e2d461a82d75422fb
Reviewed-on: https://chromium-review.googlesource.com/747621
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517517}

Document test failures and re-enable passing tests. This brings us to
5200 tests.

Bug: 678687
Change-Id: I800f19093e4e614e69fa6d311d9bb767c9e3e759
Reviewed-on: https://chromium-review.googlesource.com/777546Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517516}

This CL makes ToolbarCoordinator conforms to QRScannerResultLoading and
VoiceSearchControllerDelegate protocols.

Bug: 784911
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4383e36a97304c7e79b22ee8c5de968d19678744
Reviewed-on: https://chromium-review.googlesource.com/774282
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517515}

This CL adds download_objdump.py to make available binutil tools
that dump and analyze binary files. Currently the main user of
these tools is Supersize.

Bug: 723798
Change-Id: I9427f75d81538835ddb431ca7044398126ba9d11
Reviewed-on: https://chromium-review.googlesource.com/766728Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517514}

It is possible that while an input channel is rebound to a new Widget
the old WidgetInputHandler had pending callbacks on it. Since we were
tossing out the mojo pipe we would discard any pending callbacks for it.
Make sure we reset the count and recreate the input router which has
state for pending inputs.

BUG=722928,615090

Change-Id: I34d3ab1af415c97f3ce5ba10ee5c250cf9e30dd1
Reviewed-on: https://chromium-review.googlesource.com/772321Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517513}

Bug: 785185
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7b432dc42efca64870effc7ff819a8036bb649da
Reviewed-on: https://chromium-review.googlesource.com/775792Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517512}

With the OOPIF implementation of webview, the embedder page is not
considered focused when the guest has focus (it does not see any
keyboard input). This means that upon reaching the end of the
<webview>'s content and focusing an element in the embedder,
<paper-icon-button> in this case, the page is first refocused.

This event listener only seemed to expect this to happen once at the
beginning.

This CL prevents the authenticator from focusing the webview if another
element is focused when the page itself is focused.

The alternative would be to call focus only once, when constructing the
Authenticator.

Bug: 781748
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac7020caad90c9e5e617f46bba392caeb09482b0
Reviewed-on: https://chromium-review.googlesource.com/775978
Commit-Queue: Alex Vallee <avallee@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517511}

When there's an uncaught exception from running our test, the test times out
which is annoying to wait for and it doesn't provide any intermediate output.

This executes our test script in an awaited try-catch block so we can print
the error and end the test early.

This updates our unit tests to follow the async IIFE pattern that the rest of
the new tests uses so it plays nicely with our new error-handling code.

R=dgozman@chromium.org,einbinder@chromium.org

Bug: 667560
Change-Id: I2f693c704ef2991a2970fa925e52422d633bc06c
Reviewed-on: https://chromium-review.googlesource.com/773565
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517510}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/8f5568bfc4fd..954710ddd756

$ git log 8f5568bfc..954710ddd --date=short --no-merges --format='%ad %ae %s'
2017-11-15 vtsyrklevich * include/freetype/ftrender.h: Fix `FT_Renderer_RenderFunc' type.
2017-11-14 madigens Use Adobe hinting engine for `light' hinting of both CFF and Type 1.
2017-11-09 yuri_levchenko * CMakeLists.txt: Add `DISABLE_FORCE_DEBUG_PREFIX' option.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

Bug: 785442
Change-Id: Ib465d6300eb54d0d944e082d8b14b45da8f4bc5f
Reviewed-on: https://chromium-review.googlesource.com/775778Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517509}

Bug: 784527
Change-Id: I6f57b53db6f3f898238efa4617e5d8e0bbbfae36
Reviewed-on: https://chromium-review.googlesource.com/776014Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517508}

BUG=783427

Change-Id: Id1a43e33e83c7cfbfa2a86f82adc286e3c2b0c29
Reviewed-on: https://chromium-review.googlesource.com/775995Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517507}

- uncaught error to Cursor::move. Closure should have caught this as a function
  that takes two args; only passed one.

- remove deep equivalent changes in cursor line movement. This causes us to get stuck in various circumstances.

- add AutomationUtil.getLastNode. It computes the last node visited by a predicate. The assumption is that we prefer ancestors that match the predicate. Elsewhere, this is expressed as skipping initial subtree hwne moving forward.

Bug: 784699
Test: existing chromevox_tests.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib9713acf4e749cef31c5f816407df0aa45d5f87e
Reviewed-on: https://chromium-review.googlesource.com/775083Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517506}

SetFocus for non-proxy frames are sent input message over mojo.
RenderFrameProxyHost based messages are still sent via
InputMsg_SetFocus chrome IPC since there is no widget input handler
for these situations.

In order to grab the mojo input message we are required to subclass
the RenderWidgetHostImpl to be able to provide a mock interface.

BUG=722928

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ieb34b0e1948583c433891edb9bfc5618b03952ad
Reviewed-on: https://chromium-review.googlesource.com/762156
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517505}

I did about 800 run on Nexus 5x on Android N and 200 run on Pixel on
Android master, all of them passed, so try to reenable it.

Bug: 767180
Change-Id: Ie373a37271aabb5008ac700ff29779f134e5faea
Reviewed-on: https://chromium-review.googlesource.com/776206Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517504}

BUG=783973

Change-Id: I74cdc80d3cd4187ce0741fa722e2527329347ec5
Reviewed-on: https://chromium-review.googlesource.com/770991Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517503}

The "AutomaticTabDiscarding" field trial has expired. Not having
to read the "AllowMultipleDiscards" param of this field trial will
simplify the TabManager refactor.

Bug: 775644
Change-Id: Idaded6bbc74c8ceb02379d5b7ddf43715b552a6e
Reviewed-on: https://chromium-review.googlesource.com/772090
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517502}